)]}'
{"glanceclient/common/https.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"023cbc6715273ecf5e75aac656c97cda3996d5f1","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        Set up the OpenSSL context."},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        self.context \u003d OpenSSL.SSL.Context(OpenSSL.SSL.SSLv23_METHOD)"},{"line_number":227,"context_line":"        self.context.set_cipher_list(self.CIPHERS)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if self.ssl_compression is False:"},{"line_number":230,"context_line":"            self.context.set_options(0x20000)  # SSL_OP_NO_COMPRESSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_a9e4b63b","line":227,"updated":"2014-09-23 10:51:42.000000000","message":"Should we just use the list of ciphers from urllib3? So we don\u0027t need to maintain our own list?\n\nurllib3.contrib.pyopenssl.DEFAULT_SSL_CIPHER_LIST\n\nhttps://urllib3.readthedocs.org/en/latest/contrib.html\n\nmore specifically, use the urlib3 inside requests package to be in sync with requests being used by other openstack code","commit_id":"9dcf3f16ce1cb7e828ee3d1811bc0ebd44abb106"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"4c0279e4753c16bd367a1c310d5a142058316aab","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        Set up the OpenSSL context."},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        self.context \u003d OpenSSL.SSL.Context(OpenSSL.SSL.SSLv23_METHOD)"},{"line_number":227,"context_line":"        self.context.set_cipher_list(self.CIPHERS)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if self.ssl_compression is False:"},{"line_number":230,"context_line":"            self.context.set_options(0x20000)  # SSL_OP_NO_COMPRESSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_09106200","line":227,"in_reply_to":"da9df570_a9e4b63b","updated":"2014-09-23 10:55:33.000000000","message":"Default list doesn\u0027t look terrible.","commit_id":"9dcf3f16ce1cb7e828ee3d1811bc0ebd44abb106"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"b6f87858b091aee52258632b5c40e090250eeb82","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        Set up the OpenSSL context."},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        self.context \u003d OpenSSL.SSL.Context(OpenSSL.SSL.SSLv23_METHOD)"},{"line_number":227,"context_line":"        self.context.set_cipher_list(self.CIPHERS)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if self.ssl_compression is False:"},{"line_number":230,"context_line":"            self.context.set_options(0x20000)  # SSL_OP_NO_COMPRESSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_e9f31e71","line":227,"in_reply_to":"da9df570_a9e4b63b","updated":"2014-09-23 11:13:41.000000000","message":"Hi Davanum, thanks for your review.\n\n\u003e Should we just use the list of ciphers from urllib3?\n\nWe\u0027d have to add a new dependency on urllib3 just for that one variable.\n\n\u003e use the urlib3 inside requests package to be in sync with requests being used by other openstack code\n\nThere are some concerns about this style of import from a security point of view:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2014-September/046232.html\n\nAlso note that the set of ciphers used by requests is not fixed. It will be potentially different depending on the version of python you are using and whether  ndg-httpsclient and pyasn1 are installed.\n\nFWIW I plan to purge the common/https.py stuff in the medium term, so it is unlikely to be around for too long anyway.\n\nPlease let me know if this addresses your concerns, thanks.","commit_id":"9dcf3f16ce1cb7e828ee3d1811bc0ebd44abb106"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"d9c0511301bc89314198a8e732d5a9b7ff3d8d2f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        Set up the OpenSSL context."},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        self.context \u003d OpenSSL.SSL.Context(OpenSSL.SSL.SSLv23_METHOD)"},{"line_number":227,"context_line":"        self.context.set_cipher_list(self.CIPHERS)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if self.ssl_compression is False:"},{"line_number":230,"context_line":"            self.context.set_options(0x20000)  # SSL_OP_NO_COMPRESSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_0ca06f9e","line":227,"in_reply_to":"da9df570_c90c9945","updated":"2014-09-23 12:22:17.000000000","message":"Cool. Are you ok to remove your \u0027-1\u0027?","commit_id":"9dcf3f16ce1cb7e828ee3d1811bc0ebd44abb106"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6d48971f9aee826e30b78e4738519a75da6d40eb","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        Set up the OpenSSL context."},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        self.context \u003d OpenSSL.SSL.Context(OpenSSL.SSL.SSLv23_METHOD)"},{"line_number":227,"context_line":"        self.context.set_cipher_list(self.CIPHERS)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if self.ssl_compression is False:"},{"line_number":230,"context_line":"            self.context.set_options(0x20000)  # SSL_OP_NO_COMPRESSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_c90c9945","line":227,"in_reply_to":"da9df570_e9f31e71","updated":"2014-09-23 11:59:08.000000000","message":"Stuart, yep. am good. thanks","commit_id":"9dcf3f16ce1cb7e828ee3d1811bc0ebd44abb106"}]}