)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"5f79230c76576c7c8e390e14ef588adaf42e7895","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rakesh H S \u003crh-s@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-03 18:22:22 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"return 130 for keyboard interrupt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when keyboard interrupt is received by glanceclient, the return code as"},{"line_number":10,"context_line":"of now is 1."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da86d52c_af2d6b48","line":7,"updated":"2015-02-03 16:58:14.000000000","message":"Can you capitalize \"R\" here and the \"w\" in \"when\" below.","commit_id":"38c39476e231da9df1a69ce339a382087ae87d49"}],"glanceclient/shell.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"6b99e326eb3ab321988515a6cdc4ee915f10c8f2","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        OpenStackImagesShell().main(map(strutils.safe_decode, sys.argv[1:]))"},{"line_number":699,"context_line":"    except KeyboardInterrupt:"},{"line_number":700,"context_line":"        print(\u0027... terminating glance client\u0027, file\u003dsys.stderr)"},{"line_number":701,"context_line":"        sys.exit(130)"},{"line_number":702,"context_line":"    except Exception as e:"},{"line_number":703,"context_line":"        print(utils.exception_to_str(e), file\u003dsys.stderr)"},{"line_number":704,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_12418539","line":701,"updated":"2015-01-28 15:48:27.000000000","message":"Shouldn\u0027t this be using utils.exit?","commit_id":"7d06f46d610f411ee2e57eff9a24010e909099a3"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"d843f30098781c2fa6d45c8f1c762826e6aeae20","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        OpenStackImagesShell().main(map(strutils.safe_decode, sys.argv[1:]))"},{"line_number":699,"context_line":"    except KeyboardInterrupt:"},{"line_number":700,"context_line":"        print(\u0027... terminating glance client\u0027, file\u003dsys.stderr)"},{"line_number":701,"context_line":"        sys.exit(130)"},{"line_number":702,"context_line":"    except Exception as e:"},{"line_number":703,"context_line":"        print(utils.exception_to_str(e), file\u003dsys.stderr)"},{"line_number":704,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_1737b400","line":701,"in_reply_to":"fa81d914_12418539","updated":"2015-01-28 16:44:45.000000000","message":"I want to pass exit code as 130 (keyboard interrupt). utils.exit does not provide this functionality.","commit_id":"7d06f46d610f411ee2e57eff9a24010e909099a3"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"7798a911a0935a34e55687769e2e77bf4eb87e81","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        OpenStackImagesShell().main(map(strutils.safe_decode, sys.argv[1:]))"},{"line_number":699,"context_line":"    except KeyboardInterrupt:"},{"line_number":700,"context_line":"        print(\u0027... terminating glance client\u0027, file\u003dsys.stderr)"},{"line_number":701,"context_line":"        sys.exit(130)"},{"line_number":702,"context_line":"    except Exception as e:"},{"line_number":703,"context_line":"        print(utils.exception_to_str(e), file\u003dsys.stderr)"},{"line_number":704,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa81d914_1ae35bda","line":701,"in_reply_to":"fa81d914_1737b400","updated":"2015-01-28 16:56:30.000000000","message":"I agree with Ian here. Why not extend utils.exit to take an optional exit code parameter (defaulting to 1)?","commit_id":"7d06f46d610f411ee2e57eff9a24010e909099a3"}],"tests/test_shell.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"004961c3c90ec3e9f7d9d3551fae7827614dac2c","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            mock_glance_shell.side_effect \u003d KeyboardInterrupt()"},{"line_number":232,"context_line":"            openstack_shell.main()"},{"line_number":233,"context_line":"        except SystemExit as ex:"},{"line_number":234,"context_line":"            self.assertEqual(ex.code, 130)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class ShellTestWithKeystoneV3Auth(ShellTest):"},{"line_number":237,"context_line":"    # auth environment to use"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_5e0d6036","line":234,"updated":"2014-10-06 10:05:48.000000000","message":"Order of arguments to assertEqual should be (expected, actual).","commit_id":"f297a40f8c892a87c23b9a28680a186933bae722"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"8d246b0df455e09548b64a32b0590240157b73df","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            mock_glance_shell.side_effect \u003d KeyboardInterrupt()"},{"line_number":232,"context_line":"            openstack_shell.main()"},{"line_number":233,"context_line":"        except SystemExit as ex:"},{"line_number":234,"context_line":"            self.assertEqual(ex.code, 130)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"class ShellTestWithKeystoneV3Auth(ShellTest):"},{"line_number":237,"context_line":"    # auth environment to use"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_3ea41c07","line":234,"in_reply_to":"baa201ad_5e0d6036","updated":"2014-10-06 10:09:21.000000000","message":"Hey, thanks for reviewing, will upload an patch set with the changes.","commit_id":"f297a40f8c892a87c23b9a28680a186933bae722"}]}