)]}'
{"glanceclient/v1/shell.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e4ce8d29c39ec2b01590f9f46a208932d17c712f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":22,"context_line":"    import msvcrt"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from glanceclient.common import utils"},{"line_number":25,"context_line":"import glanceclient.v1.images"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FZ58%3D","line":22,"updated":"2012-09-13 15:13:19.000000000","message":"is this guaranteed to be installed on nt-based systems?","commit_id":"94258cb7adc33433278601f86b2bccadc9833aef"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e4ce8d29c39ec2b01590f9f46a208932d17c712f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if args.file:"},{"line_number":160,"context_line":"            fields[\u0027data\u0027] \u003d open(args.file, \u0027rb\u0027)"},{"line_number":161,"context_line":"        else:"},{"line_number":162,"context_line":"            if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":163,"context_line":"                msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)"},{"line_number":164,"context_line":"            fields[\u0027data\u0027] \u003d sys.stdin"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FZ54%3D","line":162,"updated":"2012-09-13 15:13:19.000000000","message":"Rather than duplicate the logic here, let\u0027s set msvcrt to None on import then here we can just check if msvcrt is not None.","commit_id":"94258cb7adc33433278601f86b2bccadc9833aef"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e4ce8d29c39ec2b01590f9f46a208932d17c712f","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        if args.file:"},{"line_number":233,"context_line":"            fields[\u0027data\u0027] \u003d open(args.file, \u0027rb\u0027)"},{"line_number":234,"context_line":"        else:"},{"line_number":235,"context_line":"            if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":236,"context_line":"                msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)"},{"line_number":237,"context_line":"            fields[\u0027data\u0027] \u003d sys.stdin"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FZ50%3D","line":235,"updated":"2012-09-13 15:13:19.000000000","message":"Same logic de-duplication applies here.","commit_id":"94258cb7adc33433278601f86b2bccadc9833aef"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"92580b7094f2ac61b06ea6d5e46a3f279b841af3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":22,"context_line":"    import msvcrt"},{"line_number":23,"context_line":"else:"},{"line_number":24,"context_line":"    msvcrt \u003d None"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FZ30%3D","line":22,"updated":"2012-09-13 15:45:14.000000000","message":"Do we need to handle ImportError here? I don\u0027t know if msvcrt will be on every nt-based system.","commit_id":"929a5b90c461de02c1abadac07e6dba2c3860ed5"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"cc78f06ed7c01319837b3626a9027c01f6c56c93","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":22,"context_line":"    import msvcrt"},{"line_number":23,"context_line":"else:"},{"line_number":24,"context_line":"    msvcrt \u003d None"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALH%2F%2FZpI%3D","line":22,"updated":"2012-09-13 20:42:30.000000000","message":"Should we handle ImportError?","commit_id":"91896ff51861e8d90bdf0f7c54cab0f2b3e3c277"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"08cdec7a797e30ad20dfaa15405ff58fbf3361e3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":22,"context_line":"    import msvcrt"},{"line_number":23,"context_line":"else:"},{"line_number":24,"context_line":"    msvcrt \u003d None"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALH%2F%2FZTY%3D","line":22,"in_reply_to":"AAAALH%2F%2FZpI%3D","updated":"2012-09-14 12:37:45.000000000","message":"IMO no because it\u0027s available directly in the Python setup, so it cannot be missing on Windows.","commit_id":"91896ff51861e8d90bdf0f7c54cab0f2b3e3c277"}]}