)]}'
{"glanceclient/v1/shell.py":[{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"f9233fb997baf4ee54f64f36c98d0dfb803e9d67","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    if args.properties:"},{"line_number":83,"context_line":"        property_filter_items \u003d [p.split(\u0027\u003d\u0027, 1) for p in args.properties]"},{"line_number":84,"context_line":"        if False in (len(pair) \u003d\u003d 2 for pair in property_filter_items):"},{"line_number":85,"context_line":"            utils.exit(\u0027Argument --property-filter expected properties in the\u0027"},{"line_number":86,"context_line":"                       \u0027 format KEY\u003dVALUE\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_4cc0897c","line":84,"updated":"2014-11-06 19:22:06.000000000","message":"why not use if any(len(pair) !\u003d 2 for pair in property_filter_items)? It seems a more common way to perform this check. You can even make a oneliner :)","commit_id":"277555d551ae8b4267c12ebf54ad6ab0aa208792"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"70bd05957dd8bc730f135bc39675136aa7e71a3f","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    if args.properties:"},{"line_number":83,"context_line":"        property_filter_items \u003d [p.split(\u0027\u003d\u0027, 1) for p in args.properties]"},{"line_number":84,"context_line":"        if False in (len(pair) \u003d\u003d 2 for pair in property_filter_items):"},{"line_number":85,"context_line":"            utils.exit(\u0027Argument --property-filter expected properties in the\u0027"},{"line_number":86,"context_line":"                       \u0027 format KEY\u003dVALUE\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_93a20499","line":84,"in_reply_to":"7a8c0949_4cc0897c","updated":"2014-11-07 21:24:43.000000000","message":"Sounds good. I had totally forgotten about the any() builtin.","commit_id":"277555d551ae8b4267c12ebf54ad6ab0aa208792"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"da6d4d2e7ed5ac787940e43c26d165b1018bd780","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    if args.properties:"},{"line_number":83,"context_line":"        property_filter_items \u003d [p.split(\u0027\u003d\u0027, 1) for p in args.properties]"},{"line_number":84,"context_line":"        if False in (len(pair) \u003d\u003d 2 for pair in property_filter_items):"},{"line_number":85,"context_line":"            utils.exit(\u0027Argument --property-filter expected properties in the\u0027"},{"line_number":86,"context_line":"                       \u0027 format KEY\u003dVALUE\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        filters[\u0027properties\u0027] \u003d dict(property_filter_items)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_4fe31705","line":85,"updated":"2014-10-22 22:43:21.000000000","message":"Nit: How about expects instead of expected?","commit_id":"277555d551ae8b4267c12ebf54ad6ab0aa208792"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"da6105f1bdabb60c7e27456b17046c2b9a81db10","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    if args.properties:"},{"line_number":83,"context_line":"        property_filter_items \u003d [p.split(\u0027\u003d\u0027, 1) for p in args.properties]"},{"line_number":84,"context_line":"        if False in (len(pair) \u003d\u003d 2 for pair in property_filter_items):"},{"line_number":85,"context_line":"            utils.exit(\u0027Argument --property-filter expected properties in the\u0027"},{"line_number":86,"context_line":"                       \u0027 format KEY\u003dVALUE\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        filters[\u0027properties\u0027] \u003d dict(property_filter_items)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_a849cab8","line":85,"in_reply_to":"9aa7fdbe_48985ec0","updated":"2014-10-23 13:56:52.000000000","message":"Well, maybe its a thing to use past-tense. Feel free to ignore my comment.","commit_id":"277555d551ae8b4267c12ebf54ad6ab0aa208792"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"febc196d6080fe60f7eac4040afab9a6404d6d1a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    if args.properties:"},{"line_number":83,"context_line":"        property_filter_items \u003d [p.split(\u0027\u003d\u0027, 1) for p in args.properties]"},{"line_number":84,"context_line":"        if False in (len(pair) \u003d\u003d 2 for pair in property_filter_items):"},{"line_number":85,"context_line":"            utils.exit(\u0027Argument --property-filter expected properties in the\u0027"},{"line_number":86,"context_line":"                       \u0027 format KEY\u003dVALUE\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        filters[\u0027properties\u0027] \u003d dict(property_filter_items)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_48985ec0","line":85,"in_reply_to":"9aa7fdbe_4fe31705","updated":"2014-10-23 13:43:03.000000000","message":"Sure. I was borrowing the phrasing from:\n\n    glance image-list: error: argument --owner: expected one argument\n\nand the other missing argument errors.","commit_id":"277555d551ae8b4267c12ebf54ad6ab0aa208792"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"70bd05957dd8bc730f135bc39675136aa7e71a3f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    if args.properties:"},{"line_number":83,"context_line":"        property_filter_items \u003d [p.split(\u0027\u003d\u0027, 1) for p in args.properties]"},{"line_number":84,"context_line":"        if False in (len(pair) \u003d\u003d 2 for pair in property_filter_items):"},{"line_number":85,"context_line":"            utils.exit(\u0027Argument --property-filter expected properties in the\u0027"},{"line_number":86,"context_line":"                       \u0027 format KEY\u003dVALUE\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        filters[\u0027properties\u0027] \u003d dict(property_filter_items)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f3726848","line":85,"in_reply_to":"9aa7fdbe_70cbbc1e","updated":"2014-11-07 21:24:43.000000000","message":"Good suggestion!","commit_id":"277555d551ae8b4267c12ebf54ad6ab0aa208792"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"310148fb58f5afa9884cb8567ec3c64d1f65eafe","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    if args.properties:"},{"line_number":83,"context_line":"        property_filter_items \u003d [p.split(\u0027\u003d\u0027, 1) for p in args.properties]"},{"line_number":84,"context_line":"        if False in (len(pair) \u003d\u003d 2 for pair in property_filter_items):"},{"line_number":85,"context_line":"            utils.exit(\u0027Argument --property-filter expected properties in the\u0027"},{"line_number":86,"context_line":"                       \u0027 format KEY\u003dVALUE\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        filters[\u0027properties\u0027] \u003d dict(property_filter_items)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_70cbbc1e","line":85,"in_reply_to":"9aa7fdbe_a849cab8","updated":"2014-10-29 15:26:22.000000000","message":"How about the word requires instead of expected?","commit_id":"277555d551ae8b4267c12ebf54ad6ab0aa208792"}]}