)]}'
{"glanceclient/v1/shell.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"39189c262e0cd92f930c6cfd65616a1e59456a8c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONTAINER_FORMATS \u003d [\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027, \u0027bare\u0027, \u0027ovf\u0027]"},{"line_number":33,"context_line":"DISK_FORMATS \u003d [\u0027ami\u0027, \u0027ari\u0027, \u0027aki\u0027, \u0027vhd\u0027, \u0027vmdk\u0027, \u0027raw\u0027,"},{"line_number":34,"context_line":"\u0027qcow2\u0027, \u0027vdi\u0027, \u0027iso\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cNAME\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FMt4%3D","line":34,"updated":"2012-10-05 17:48:39.000000000","message":"Typically you would advance the continued line to line up with the first item of the list. I\u0027d love to see that style followed here.","commit_id":"746134604cd1b22783c8866c6fde00760407d7ed"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"39189c262e0cd92f930c6cfd65616a1e59456a8c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"           help\u003d\u0027Name of image.\u0027)"},{"line_number":187,"context_line":"@utils.arg(\u0027--disk-format\u0027, metavar\u003d\u0027\u003cCONTAINER_FORMAT\u003e\u0027,"},{"line_number":188,"context_line":"           help\u003d\u0027Disk format of image.\\"},{"line_number":189,"context_line":"Acceptable formats: \u0027 + \u0027, \u0027.join(CONTAINER_FORMATS))"},{"line_number":190,"context_line":"@utils.arg(\u0027--container-format\u0027, metavar\u003d\u0027\u003cDISK_FORMAT\u003e\u0027,"},{"line_number":191,"context_line":"           help\u003d\u0027Container format of image.\\"},{"line_number":192,"context_line":"Acceptable formats: \u0027 + \u0027, \u0027.join(DISK_FORMATS))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FMtw%3D","line":189,"updated":"2012-10-05 17:48:39.000000000","message":"Rather than join CONTAINER_FORMATS and DISK_FORMATS every time you want to use it, just define it as the string you want to use as the constant.","commit_id":"746134604cd1b22783c8866c6fde00760407d7ed"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"39189c262e0cd92f930c6cfd65616a1e59456a8c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"Acceptable formats: \u0027 + \u0027, \u0027.join(CONTAINER_FORMATS))"},{"line_number":190,"context_line":"@utils.arg(\u0027--container-format\u0027, metavar\u003d\u0027\u003cDISK_FORMAT\u003e\u0027,"},{"line_number":191,"context_line":"           help\u003d\u0027Container format of image.\\"},{"line_number":192,"context_line":"Acceptable formats: \u0027 + \u0027, \u0027.join(DISK_FORMATS))"},{"line_number":193,"context_line":"@utils.arg(\u0027--owner\u0027, metavar\u003d\u0027\u003cTENANT_ID\u003e\u0027,"},{"line_number":194,"context_line":"           help\u003d\u0027Tenant who should own image.\u0027)"},{"line_number":195,"context_line":"@utils.arg(\u0027--size\u0027, metavar\u003d\u0027\u003cSIZE\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FMto%3D","line":192,"updated":"2012-10-05 17:48:39.000000000","message":"This is a similar style issue as I mentioned above with the list. You should start a continued line directly under the beginning of  whatever object you\u0027re defining above it.","commit_id":"746134604cd1b22783c8866c6fde00760407d7ed"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ea68da9cffa35c04bc50a15b798c906cf980dfff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from glanceclient.v1.legacy_shell import *"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONTAINER_FORMATS \u003d \u0027Acceptable formats: ami, ari, aki, bare, and ovf.\u0027"},{"line_number":33,"context_line":"DISK_FORMATS \u003d \u0027Acceptable formats: ami, ari, aki, vhd, vmdk, raw,\\"},{"line_number":34,"context_line":"                qcow2, vdi, and iso.\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FMeg%3D","line":33,"updated":"2012-10-05 23:27:10.000000000","message":"can you try avoiding the backslash and use quotes instead?\n\nfor example for a statement like:-\nDISK_FORMATS \u003d \u0027I don\u0027t want to use backslash!\u0027 in 2 lines,\n\ntry using -\nDISK_FORMATS \u003d \u0027I don\u0027t want to use \u0027\n               \u0027backslash!\u0027\n\nwe should try to reduce the technical debt here for correction later. For more info refer to the hacking file.","commit_id":"76102395a688886d33e4ecd67eb500297766763e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"a9fbe12ad2a1a23e5a3c820171f787740d60b85a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONTAINER_FORMATS \u003d \u0027Acceptable formats: ami, ari, aki, bare, and ovf.\u0027"},{"line_number":33,"context_line":"DISK_FORMATS \u003d (\u0027Acceptable formats: ami, ari, aki, vhd, vmdk, raw, \u0027"},{"line_number":34,"context_line":"               \u0027qcow2, vdi, and iso.\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@utils.arg(\u0027--name\u0027, metavar\u003d\u0027\u003cNAME\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FMb4%3D","line":34,"updated":"2012-10-06 02:05:54.000000000","message":"think the next line will align with the quote \u0027 and not the bracket (\n\nsome reference: https://github.com/openstack/nova/blob/master/nova/flags.py","commit_id":"e020a57bfb7d84a9af7489c4a01053bf8959cabe"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"1cb477d6501313e228bb86690d836e2acf536088","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           help\u003d\u0027Filter images to those that have this status.\u0027)"},{"line_number":41,"context_line":"@utils.arg(\u0027--container-format\u0027, metavar\u003d\u0027\u003cCONTAINER_FORMAT\u003e\u0027,"},{"line_number":42,"context_line":"           help\u003d\u0027Filter images to those that have this container format. \u0027"},{"line_number":43,"context_line":"           + CONTAINER_FORMATS)"},{"line_number":44,"context_line":"@utils.arg(\u0027--disk-format\u0027, metavar\u003d\u0027\u003cDISK_FORMAT\u003e\u0027,"},{"line_number":45,"context_line":"           help\u003d\u0027Filter images to those that have this disk format. \u0027"},{"line_number":46,"context_line":"           + DISK_FORMATS)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FLvs%3D","line":43,"updated":"2012-10-08 16:49:47.000000000","message":"Line this up under the start of the string.","commit_id":"e020a57bfb7d84a9af7489c4a01053bf8959cabe"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"1cb477d6501313e228bb86690d836e2acf536088","unresolved":false,"context_lines":[{"line_number":43,"context_line":"           + CONTAINER_FORMATS)"},{"line_number":44,"context_line":"@utils.arg(\u0027--disk-format\u0027, metavar\u003d\u0027\u003cDISK_FORMAT\u003e\u0027,"},{"line_number":45,"context_line":"           help\u003d\u0027Filter images to those that have this disk format. \u0027"},{"line_number":46,"context_line":"           + DISK_FORMATS)"},{"line_number":47,"context_line":"@utils.arg(\u0027--size-min\u0027, metavar\u003d\u0027\u003cSIZE\u003e\u0027,"},{"line_number":48,"context_line":"           help\u003d\u0027Filter images to those with a size greater than this.\u0027)"},{"line_number":49,"context_line":"@utils.arg(\u0027--size-max\u0027, metavar\u003d\u0027\u003cSIZE\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FLvo%3D","line":46,"updated":"2012-10-08 16:49:47.000000000","message":"Line this up under the start of the string.","commit_id":"e020a57bfb7d84a9af7489c4a01053bf8959cabe"}]}