)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"9c94f41fb583feaf1c3825f53a639ec141ade1d3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance image delete output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deleting an already deleted image using non-admin user is throwing an"},{"line_number":10,"context_line":"error \"404 Not Found\" which is confusing. Deleting an image that does"},{"line_number":11,"context_line":"not exist throws \"No image with a name or ID of \u0027image-id\u0027 exists.\""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da86d52c_4f8878c6","line":9,"updated":"2015-02-17 10:26:01.000000000","message":"non-admin \u003d\u003e admin","commit_id":"dacbf0d9abaad5a101d6629f2274c95083956f81"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"06fd92ac2f1be1da2e32eb5875546644e7fe0609","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance image delete output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deleting an already deleted image using non-admin user is throwing an"},{"line_number":10,"context_line":"error \"404 Not Found\" which is confusing. Deleting an image that does"},{"line_number":11,"context_line":"not exist throws \"No image with a name or ID of \u0027image-id\u0027 exists.\""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da86d52c_6a128a59","line":9,"in_reply_to":"da86d52c_4f8878c6","updated":"2015-02-17 10:29:00.000000000","message":"Oh god, I\u0027m a brainless zombie today. Fixed, thanks!","commit_id":"dacbf0d9abaad5a101d6629f2274c95083956f81"}],"glanceclient/v1/shell.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f31fcdfed262fc99a0604beedd177d0906a04293","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        except exc.HTTPException as e:"},{"line_number":336,"context_line":"            if args.verbose:"},{"line_number":337,"context_line":"                print(\u0027[Fail]\u0027)"},{"line_number":338,"context_line":"            print(\u0027%s: Unable to delete image %s\u0027 % (e, args_image))"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"@utils.arg(\u0027--image-id\u0027, metavar\u003d\u0027\u003cIMAGE_ID\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_39f09a90","line":338,"updated":"2014-12-12 08:17:27.000000000","message":"Can\u0027t you just capture NotFound here and throw the appropriate error?\n\nWhat happens in v2?","commit_id":"50383f2b2f8f1b6d9b483358d507db411a7b10f7"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f31fcdfed262fc99a0604beedd177d0906a04293","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        except exc.HTTPException as e:"},{"line_number":336,"context_line":"            if args.verbose:"},{"line_number":337,"context_line":"                print(\u0027[Fail]\u0027)"},{"line_number":338,"context_line":"            print(\u0027%s: Unable to delete image %s\u0027 % (e, args_image))"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"@utils.arg(\u0027--image-id\u0027, metavar\u003d\u0027\u003cIMAGE_ID\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_59ed66b6","line":338,"updated":"2014-12-12 08:17:27.000000000","message":"Can\u0027t you just capture NotFound here and throw the appropriate error?\n\nWhat happens in v2?","commit_id":"50383f2b2f8f1b6d9b483358d507db411a7b10f7"},{"author":{"_account_id":12140,"name":"Abhishek Talwar","email":"abhishek.talwar@tcs.com","username":"abhishek.talwar"},"change_message_id":"ae0ece748a9cd517804743d6ca28ea86ecc09290","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        except exc.HTTPException as e:"},{"line_number":336,"context_line":"            if args.verbose:"},{"line_number":337,"context_line":"                print(\u0027[Fail]\u0027)"},{"line_number":338,"context_line":"            print(\u0027%s: Unable to delete image %s\u0027 % (e, args_image))"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"@utils.arg(\u0027--image-id\u0027, metavar\u003d\u0027\u003cIMAGE_ID\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_af10bc59","line":338,"in_reply_to":"3a961159_39f09a90","updated":"2014-12-12 09:48:23.000000000","message":"Hi Flavio,\n\nYes I can surely capture it here only with the appropriate error.\n\nAlso in v2, right now the do_image_delete method is like :\n\ndef do_image_delete(gc, args):\n    \"\"\"Delete specified image.\"\"\"\n    gc.images.delete(args.id)\n\nI can update the same change to v2 in the following way if you approve of it.\n\ndef do_image_delete(gc, args):\n    \"\"\"Delete specified image.\"\"\"\n    image \u003d gc.images.get(args.id)\n    if image and image.status\u003d\u003d \"deleted\":\n    except exc.HTTPNotFound:\n        utils.exit(\u0027No image with a name or ID of \u0027%s\u0027 exists.\u0027 % image.id)\n    gc.images.delete(image.id)","commit_id":"50383f2b2f8f1b6d9b483358d507db411a7b10f7"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"caf0a0cc347b75d2f31e2ff0d2b2335366947658","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    for args_image in args.images:"},{"line_number":323,"context_line":"        image \u003d utils.find_resource(gc.images, args_image)"},{"line_number":324,"context_line":"        if image and image.status \u003d\u003d \"deleted\":"},{"line_number":325,"context_line":"            msg \u003d (\"No image with a name or ID of \u0027%s\u0027 exists.\" % image.id)"},{"line_number":326,"context_line":"            raise exc.NotFound(msg)"},{"line_number":327,"context_line":"        try:"},{"line_number":328,"context_line":"            if args.verbose:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_773f82b4","line":325,"updated":"2014-12-12 13:13:08.000000000","message":"it\u0027s just the image id. the name will never be here.","commit_id":"9603af891bdc5eb690749fe70908b06ca83e1746"},{"author":{"_account_id":12140,"name":"Abhishek Talwar","email":"abhishek.talwar@tcs.com","username":"abhishek.talwar"},"change_message_id":"bb3352e895d9f68c3ff98c9dd4ae234bee57061a","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    for args_image in args.images:"},{"line_number":323,"context_line":"        image \u003d utils.find_resource(gc.images, args_image)"},{"line_number":324,"context_line":"        if image and image.status \u003d\u003d \"deleted\":"},{"line_number":325,"context_line":"            msg \u003d (\"No image with a name or ID of \u0027%s\u0027 exists.\" % image.id)"},{"line_number":326,"context_line":"            raise exc.NotFound(msg)"},{"line_number":327,"context_line":"        try:"},{"line_number":328,"context_line":"            if args.verbose:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_15a9af23","line":325,"in_reply_to":"3a961159_773f82b4","updated":"2014-12-15 05:05:59.000000000","message":"Done","commit_id":"9603af891bdc5eb690749fe70908b06ca83e1746"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4b106a2f6e70bc7f481a67d5eed6831c88427dd8","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        image \u003d utils.find_resource(gc.images, args_image)"},{"line_number":324,"context_line":"        if image and image.status \u003d\u003d \"deleted\":"},{"line_number":325,"context_line":"            msg \u003d (\"No image with a name or ID of \u0027%s\u0027 exists.\" % image.id)"},{"line_number":326,"context_line":"            raise exc.NotFound(msg)"},{"line_number":327,"context_line":"        try:"},{"line_number":328,"context_line":"            if args.verbose:"},{"line_number":329,"context_line":"                print(\u0027Requesting image delete for %s ...\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_d02aa07d","line":326,"updated":"2014-12-16 14:04:25.000000000","message":"What\u0027s the point to raise an exception here? Just utils.exit(msg)","commit_id":"9603af891bdc5eb690749fe70908b06ca83e1746"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"9d27fdc59a7c42265524bd003f6fc07e516456f7","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    for args_image in args.images:"},{"line_number":323,"context_line":"        image \u003d utils.find_resource(gc.images, args_image)"},{"line_number":324,"context_line":"        if image and image.status \u003d\u003d \"deleted\":"},{"line_number":325,"context_line":"            msg \u003d (\"No image with a ID of \u0027%s\u0027 exists.\" % image.id)"},{"line_number":326,"context_line":"            raise exc.NotFound(msg)"},{"line_number":327,"context_line":"        try:"},{"line_number":328,"context_line":"            if args.verbose:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_7fcbb41d","line":325,"updated":"2015-01-08 16:59:39.000000000","message":"You do not need parentheses here.","commit_id":"c06ab1ede085d5005330fd34f4a81c5ee15b42cd"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"9d27fdc59a7c42265524bd003f6fc07e516456f7","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    \"\"\"Delete specified image.\"\"\""},{"line_number":264,"context_line":"    image \u003d gc.images.get(args.id)"},{"line_number":265,"context_line":"    if image and image.status \u003d\u003d \"deleted\":"},{"line_number":266,"context_line":"        msg \u003d (\"No image with a ID of \u0027%s\u0027 exists.\" % image.id)"},{"line_number":267,"context_line":"        raise exc.NotFound(msg)"},{"line_number":268,"context_line":"    gc.images.delete(args.id)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_dfdbc8ea","line":266,"updated":"2015-01-08 16:59:39.000000000","message":"These parentheses are unnecessary.","commit_id":"c06ab1ede085d5005330fd34f4a81c5ee15b42cd"}],"tests/v1/test_shell.py":[{"author":{"_account_id":12814,"name":"Bartosz Fic","email":"bartosz.fic@intel.com","username":"bartosz-fic"},"change_message_id":"d41827967a793a51b4aca7d49a078185e8332e60","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    \u0027id\u0027: \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027,"},{"line_number":197,"context_line":"                    \u0027name\u0027: \u0027imagedeleted\u0027,"},{"line_number":198,"context_line":"                    \u0027deleted\u0027: True,"},{"line_number":199,"context_line":"                    \u0027status\u0027: \u0027deleted\u0027,"},{"line_number":200,"context_line":"                },"},{"line_number":201,"context_line":"            ]},"},{"line_number":202,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_5bfad5bd","line":199,"updated":"2015-02-11 09:04:51.000000000","message":"If I understand properly this test only checks, if deleting image with id \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027 and status: \u0027deleted\u0027 throws an exception.\n\nSo is it really necessary to place below here all of this HEAD GET ?\n\n\u0027/v1/images/detail?limit\u003d20\u0026name\u003d70aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027: {\n    \u0027GET\u0027: (\n        {},\n        {\u0027images\u0027: [\n            {\n                \u0027id\u0027: \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027,\n                \u0027name\u0027: \u0027imagedeleted\u0027,\n                \u0027deleted\u0027: True,\n                \u0027status\u0027: \u0027deleted\u0027,\n            },\n        ]},\n    ),\n}\n\nIs completely sufficient in this case.","commit_id":"a4eda3194e329fa1b0792433f341236dc1724c0e"},{"author":{"_account_id":12814,"name":"Bartosz Fic","email":"bartosz.fic@intel.com","username":"bartosz-fic"},"change_message_id":"bae1c7c8420888305d987da0648597d351627dfe","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    \u0027id\u0027: \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027,"},{"line_number":197,"context_line":"                    \u0027name\u0027: \u0027imagedeleted\u0027,"},{"line_number":198,"context_line":"                    \u0027deleted\u0027: True,"},{"line_number":199,"context_line":"                    \u0027status\u0027: \u0027deleted\u0027,"},{"line_number":200,"context_line":"                },"},{"line_number":201,"context_line":"            ]},"},{"line_number":202,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_66b9b978","line":199,"in_reply_to":"da86d52c_36ea98ac","updated":"2015-02-11 11:51:35.000000000","message":"Hmm weird.. I run this tests including removing this part of code in my virtual env and everything was ok. But even if this resource \u0027/v1/images/70aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027 should be properly called, do we really need all of this HEAD GET x-image-metadefs stuff inside ? \n\nAnd yes, I\u0027ve commented this and tests also are working :)","commit_id":"a4eda3194e329fa1b0792433f341236dc1724c0e"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"f1756f264c636d1c4d29743bc11197d6118889dd","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    \u0027id\u0027: \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027,"},{"line_number":197,"context_line":"                    \u0027name\u0027: \u0027imagedeleted\u0027,"},{"line_number":198,"context_line":"                    \u0027deleted\u0027: True,"},{"line_number":199,"context_line":"                    \u0027status\u0027: \u0027deleted\u0027,"},{"line_number":200,"context_line":"                },"},{"line_number":201,"context_line":"            ]},"},{"line_number":202,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_36ea98ac","line":199,"in_reply_to":"da86d52c_5bfad5bd","updated":"2015-02-11 09:35:35.000000000","message":"Have you downloaded this patch and run the following tests in local environment? If so, you had to notice that your proposed solution fails when the manager.get method is called in the find_resource function. \"\u0027/v1/images/70aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027\" key is necessary to get it working properly (as you can see for all other examples in the file).","commit_id":"a4eda3194e329fa1b0792433f341236dc1724c0e"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"de7887cc0aa674145d581b5b3c1aae46ed86e325","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    \u0027id\u0027: \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027,"},{"line_number":197,"context_line":"                    \u0027name\u0027: \u0027imagedeleted\u0027,"},{"line_number":198,"context_line":"                    \u0027deleted\u0027: True,"},{"line_number":199,"context_line":"                    \u0027status\u0027: \u0027deleted\u0027,"},{"line_number":200,"context_line":"                },"},{"line_number":201,"context_line":"            ]},"},{"line_number":202,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_69b98a78","line":199,"in_reply_to":"da86d52c_66b9b978","updated":"2015-02-11 12:29:11.000000000","message":"We could get rid off the \"GET\" section in \u0027/v1/images/70aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027, because it\u0027s not used in this context (only HEAD is evaluated underneath). I\u0027ve added it here, because rest of the fixtures uses it and wanted to make it consistent.","commit_id":"a4eda3194e329fa1b0792433f341236dc1724c0e"},{"author":{"_account_id":12814,"name":"Bartosz Fic","email":"bartosz.fic@intel.com","username":"bartosz-fic"},"change_message_id":"999ec921c4612d57afffe71749e2e1eea45aab8c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    \u0027id\u0027: \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027,"},{"line_number":197,"context_line":"                    \u0027name\u0027: \u0027imagedeleted\u0027,"},{"line_number":198,"context_line":"                    \u0027deleted\u0027: True,"},{"line_number":199,"context_line":"                    \u0027status\u0027: \u0027deleted\u0027,"},{"line_number":200,"context_line":"                },"},{"line_number":201,"context_line":"            ]},"},{"line_number":202,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_85d51a1d","line":199,"in_reply_to":"da86d52c_69b98a78","updated":"2015-02-16 11:12:25.000000000","message":"Ok, so lets get rid off it.","commit_id":"a4eda3194e329fa1b0792433f341236dc1724c0e"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"de135df8758b50e0a86fca03b7e6787b22deab2d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    \u0027id\u0027: \u002770aa106f-3750-4d7c-a5ce-0a535ac08d0a\u0027,"},{"line_number":197,"context_line":"                    \u0027name\u0027: \u0027imagedeleted\u0027,"},{"line_number":198,"context_line":"                    \u0027deleted\u0027: True,"},{"line_number":199,"context_line":"                    \u0027status\u0027: \u0027deleted\u0027,"},{"line_number":200,"context_line":"                },"},{"line_number":201,"context_line":"            ]},"},{"line_number":202,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_20c37c39","line":199,"in_reply_to":"da86d52c_85d51a1d","updated":"2015-02-16 11:43:16.000000000","message":"Done","commit_id":"a4eda3194e329fa1b0792433f341236dc1724c0e"}],"tests/v2/test_shell_v2.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"20ee60aadaaf0fdb578039cebc0f4ca2732c7125","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            mocked_get.return_value \u003d self._make_args({\u0027status\u0027: \u0027deleted\u0027,"},{"line_number":357,"context_line":"                                                       \u0027id\u0027: \u0027deleted-img\u0027})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            msg \u003d \"No image with an ID of \u0027%s\u0027 exists.\" % \u0027deleted-img\u0027"},{"line_number":360,"context_line":"            self.assert_exits_with_msg(func\u003dtest_shell.do_image_delete,"},{"line_number":361,"context_line":"                                       func_args\u003dargs,"},{"line_number":362,"context_line":"                                       err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_a19de95b","line":359,"updated":"2015-02-06 23:28:40.000000000","message":"Why do string formatting here? I don\u0027t mind it, just curious.","commit_id":"091c33896836bfbbac0463376313d3f3afd552ce"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d7db00eab9e02436f99333f4131ed621776c25c1","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            mocked_get.return_value \u003d self._make_args({\u0027status\u0027: \u0027deleted\u0027,"},{"line_number":357,"context_line":"                                                       \u0027id\u0027: \u0027deleted-img\u0027})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            msg \u003d \"No image with an ID of \u0027%s\u0027 exists.\" % \u0027deleted-img\u0027"},{"line_number":360,"context_line":"            self.assert_exits_with_msg(func\u003dtest_shell.do_image_delete,"},{"line_number":361,"context_line":"                                       func_args\u003dargs,"},{"line_number":362,"context_line":"                                       err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_1922a001","line":359,"in_reply_to":"da86d52c_0395cf87","updated":"2015-02-08 10:13:02.000000000","message":"Lets fix this quickly and then land this patch, it\u0027s a nit but the patch is not high-priority","commit_id":"091c33896836bfbbac0463376313d3f3afd552ce"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"7f8669c23af3ffb5e994ed8e82f8923c8924e2cc","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            mocked_get.return_value \u003d self._make_args({\u0027status\u0027: \u0027deleted\u0027,"},{"line_number":357,"context_line":"                                                       \u0027id\u0027: \u0027deleted-img\u0027})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            msg \u003d \"No image with an ID of \u0027%s\u0027 exists.\" % \u0027deleted-img\u0027"},{"line_number":360,"context_line":"            self.assert_exits_with_msg(func\u003dtest_shell.do_image_delete,"},{"line_number":361,"context_line":"                                       func_args\u003dargs,"},{"line_number":362,"context_line":"                                       err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_0395cf87","line":359,"in_reply_to":"da86d52c_46bb5a75","updated":"2015-02-07 23:51:08.000000000","message":"Looks like automated refactoring. Of course it\u0027ll be better to add a variable for deleted image id and then use it everywhere, but I leave it to the discretion of the author.","commit_id":"091c33896836bfbbac0463376313d3f3afd552ce"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"ef4ac9dfc294928c81f2024fc06f69f9a031599a","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            mocked_get.return_value \u003d self._make_args({\u0027status\u0027: \u0027deleted\u0027,"},{"line_number":357,"context_line":"                                                       \u0027id\u0027: \u0027deleted-img\u0027})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            msg \u003d \"No image with an ID of \u0027%s\u0027 exists.\" % \u0027deleted-img\u0027"},{"line_number":360,"context_line":"            self.assert_exits_with_msg(func\u003dtest_shell.do_image_delete,"},{"line_number":361,"context_line":"                                       func_args\u003dargs,"},{"line_number":362,"context_line":"                                       err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_46bb5a75","line":359,"in_reply_to":"da86d52c_a19de95b","updated":"2015-02-07 16:13:15.000000000","message":"Good question. I wonder if this was meant to be a binding that was replaced with the string literal","commit_id":"091c33896836bfbbac0463376313d3f3afd552ce"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"36f823fc8f5877d3e904b0df45568534463a5a16","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            mocked_get.return_value \u003d self._make_args({\u0027status\u0027: \u0027deleted\u0027,"},{"line_number":357,"context_line":"                                                       \u0027id\u0027: \u0027deleted-img\u0027})"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            msg \u003d \"No image with an ID of \u0027%s\u0027 exists.\" % \u0027deleted-img\u0027"},{"line_number":360,"context_line":"            self.assert_exits_with_msg(func\u003dtest_shell.do_image_delete,"},{"line_number":361,"context_line":"                                       func_args\u003dargs,"},{"line_number":362,"context_line":"                                       err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_f43873d6","line":359,"in_reply_to":"da86d52c_a19de95b","updated":"2015-02-09 07:41:44.000000000","message":"Nice catch Louis! I\u0027ve copied message format from v2/shell.py and replaced image.id with \u0027deleted-img\u0027. I should do it a bit more cleaner like Mike mentioned in the comment :)","commit_id":"091c33896836bfbbac0463376313d3f3afd552ce"}]}