)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"82eaecb86ed06f8c96a8cdd629268804476bab79","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix messy request Id handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds docstring parameter for return_request_id and stops relying **kwargs"},{"line_number":10,"context_line":"for receiving it. Makes the functionality lots more understandable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic7fe42bd1c606b7b4f6f562ac5d042ee50132984"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_6e04887e","line":9,"updated":"2014-12-17 13:57:59.000000000","message":"Nit: missing \u0027on\u0027 before **kwargs.","commit_id":"2d36aed9973bac10191a3ad501e1c0af3ed760e1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"e8b0af8daac8eafac5b442a84ee93dea03f9dd94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d1c32b6_3ca4fd6f","updated":"2023-02-03 20:13:24.000000000","message":"Just rebasing this for the next review party:)","commit_id":"30fdd1f9e508f19d532c4aae84073313b3b91dfc"}],"glanceclient/v1/images.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"c9ee7619bdf361b4f55f33c1883e47d6d399093d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                      images."},{"line_number":164,"context_line":"        :param return_request_id: If an empty list is provided, populate this"},{"line_number":165,"context_line":"                              list with the request ID value from the header"},{"line_number":166,"context_line":"                              x-openstack-request-id"},{"line_number":167,"context_line":"        :rtype: list of :class:`Image`"},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        absolute_limit \u003d kwargs.get(\u0027limit\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_cba2ce4a","side":"PARENT","line":166,"updated":"2014-12-17 13:19:52.000000000","message":"Why not reuse this documentation? It is a little more verbose, but conveys more information about the parameter.","commit_id":"0cdc947bf998c7f00a23c11bf1be4bc5929b7803"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"c9ee7619bdf361b4f55f33c1883e47d6d399093d","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return body"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def list(self, return_request_id\u003dNone):"},{"line_number":153,"context_line":"        \"\"\"Get a list of images."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        :param page_size: number of items to request in each paginated request"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6b955ae3","line":152,"updated":"2014-12-17 13:19:52.000000000","message":"This should be kept as **kwargs, since the other arguments rely on it.","commit_id":"2d36aed9973bac10191a3ad501e1c0af3ed760e1"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"82eaecb86ed06f8c96a8cdd629268804476bab79","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return body"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def list(self, return_request_id\u003dNone):"},{"line_number":153,"context_line":"        \"\"\"Get a list of images."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        :param page_size: number of items to request in each paginated request"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6edd6814","line":152,"in_reply_to":"3a961159_6b955ae3","updated":"2014-12-17 13:57:59.000000000","message":"+1","commit_id":"2d36aed9973bac10191a3ad501e1c0af3ed760e1"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"dfcfa8ca35e2605b91c37d0f00630f3e19a30705","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SORT_KEY_VALUES \u003d (\u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":40,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"OS_REQ_ID_HDR \u003d \u0027x-openstack-request-id\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class Image(base.Resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_801c80c2","side":"PARENT","line":42,"updated":"2015-10-14 12:52:58.000000000","message":"Could you please explain why we need to get rid of named constant here?\nI think it is good to have this constant defined in one place instead of \"spreading\" the hard-coded constant through functions.","commit_id":"3bd28bf5620513faedd446617e23b25077751051"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"509dc46d1f6d2fe3ed8c515785a31731941a9b90","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SORT_KEY_VALUES \u003d (\u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":40,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"OS_REQ_ID_HDR \u003d \u0027x-openstack-request-id\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class Image(base.Resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_97e1249d","side":"PARENT","line":42,"in_reply_to":"5a2ca52d_6c07db1c","updated":"2015-10-14 14:16:27.000000000","message":"I am sorry but I am tend to disagree. \n1) Unfortunately there is no 100% guarantee that this code will be changed one day. IMO it always can happen with the code and best approach to this is to be prepared for changed. One day somebody can introduce new openstack request id header.\n2) Not using named constants is not convention IMO. It is just bad practice and we should refactor the code one day to change these hard-coded constants. Named constant in theory should provide some abstraction instead of concentrating on value (and understanding why do we need this constant, what does it mean and so on). So it allows not to bother at value at all which is pretty good and readable. \nPerhaps, the constant name is not good that\u0027s why you consider it as not readable.\nSorry to sound like a holly war guy:), but I think the point does worth it:)","commit_id":"3bd28bf5620513faedd446617e23b25077751051"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9ecec784164bc48b5369cd2f5dd1b8dfc9f17615","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SORT_KEY_VALUES \u003d (\u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":40,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"OS_REQ_ID_HDR \u003d \u0027x-openstack-request-id\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class Image(base.Resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_b05e8a74","side":"PARENT","line":42,"in_reply_to":"5a2ca52d_72ba5625","updated":"2015-10-15 06:39:27.000000000","message":"I\u0027m happy either way here, tbh. IMHO, this variable should either go away or be made private. Lets remember that glanceclient is not just a CLI and this is the library that we\u0027re talking about. This means someone could just change the value of this \"constant\".\n\nSo, again, either we make it private or we remove it. Either are good with me. I\u0027ll let someone else, with a stronger opinion, to chime in.\n\nThat said, I\u0027m not in favor of creating a gazillion of global constants in a \"constants.py\" module. My point is that we already have this one an making it private or removing it is fine by me.","commit_id":"3bd28bf5620513faedd446617e23b25077751051"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"abb3c8cc958be975c3b88eb0335222d66fd87851","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SORT_KEY_VALUES \u003d (\u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":40,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"OS_REQ_ID_HDR \u003d \u0027x-openstack-request-id\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class Image(base.Resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_6c07db1c","side":"PARENT","line":42,"in_reply_to":"5a2ca52d_801c80c2","updated":"2015-10-14 14:01:30.000000000","message":"Due to the stability drive on OpenStack APIs the header key will not change. Being consistent we do not use named constants for our paths nor other header keys either. Utilizing the value that will stay constant is just way more descriptive and reader friendly than all caps name which tries to mimic the value.","commit_id":"3bd28bf5620513faedd446617e23b25077751051"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6ec89457fa4e6a33a59060acb6c265711c7693ed","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SORT_KEY_VALUES \u003d (\u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":40,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"OS_REQ_ID_HDR \u003d \u0027x-openstack-request-id\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class Image(base.Resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_72ba5625","side":"PARENT","line":42,"in_reply_to":"5a2ca52d_97e1249d","updated":"2015-10-14 14:23:36.000000000","message":"No war, I\u0027m happy to agree to disagree, that sed line to change the header name will not change regardless if it\u0027s in multiple constants through the project files or written open into the code so it has nothing to do with future proofing. Just readability and consistency, which of I\u0027m huge fan.","commit_id":"3bd28bf5620513faedd446617e23b25077751051"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"68246a210a36787c58ade36683f38fddba7b3bca","unresolved":false,"context_lines":[{"line_number":39,"context_line":"SORT_KEY_VALUES \u003d (\u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"},{"line_number":40,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"OS_REQ_ID_HDR \u003d \u0027x-openstack-request-id\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class Image(base.Resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_4a6f3e92","side":"PARENT","line":42,"in_reply_to":"5a2ca52d_b05e8a74","updated":"2015-10-15 07:57:45.000000000","message":"Removing making the code not supportable. Instead of gazillion constants we have much more literals that need to be supported every time it changes.\nI think this direction is not so right.","commit_id":"3bd28bf5620513faedd446617e23b25077751051"}]}