)]}'
{"glanceclient/common/http.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"7956dd62cffbe18151c836edd16e1f49978db316","unresolved":false,"context_lines":[{"line_number":31,"context_line":"except ImportError:"},{"line_number":32,"context_line":"    import simplejson as json"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from oslo.utils import encodeutils"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Python 2.5 compat fix"},{"line_number":37,"context_line":"if not hasattr(parse, \u0027parse_qsl\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_31241f5f","line":34,"updated":"2015-01-07 20:19:14.000000000","message":"This import should go before the other imports","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"12b6a5a512626be5598b609756c0dae5b9ce9ed3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"except ImportError:"},{"line_number":32,"context_line":"    import simplejson as json"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from oslo.utils import encodeutils"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Python 2.5 compat fix"},{"line_number":37,"context_line":"if not hasattr(parse, \u0027parse_qsl\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_ec571958","line":34,"in_reply_to":"3a961159_31241f5f","updated":"2015-01-08 00:45:04.000000000","message":"Done","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"780923c618d402a7d0dd44efd9bdd2974f976aac","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    import cgi"},{"line_number":37,"context_line":"    parse.parse_qsl \u003d cgi.parse_qsl"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from oslo.utils import encodeutils"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from glanceclient.common import https"},{"line_number":42,"context_line":"from glanceclient.common.utils import safe_header"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_5bf45354","line":39,"updated":"2015-01-08 13:30:50.000000000","message":"Due to [0] I prefer to use oslo_utils in the whole change.\n\n[0] https://github.com/openstack/oslo.utils/blob/master/oslo/utils/__init__.py#L19","commit_id":"a2602f1d6282c96db10701b4702196e06d1b433d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"835787c20357f7f6273ce94008db716883455b0a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    import cgi"},{"line_number":37,"context_line":"    parse.parse_qsl \u003d cgi.parse_qsl"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from oslo.utils import encodeutils"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from glanceclient.common import https"},{"line_number":42,"context_line":"from glanceclient.common.utils import safe_header"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_be5525c3","line":39,"in_reply_to":"3a961159_5bf45354","updated":"2015-01-08 13:51:32.000000000","message":"I\u0027m sorry, my bad here! I would like to do it for next oslo.utils release.","commit_id":"a2602f1d6282c96db10701b4702196e06d1b433d"}],"glanceclient/common/https.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"7956dd62cffbe18151c836edd16e1f49978db316","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        from eventlet.green.OpenSSL.SSL import GreenConnection as Connection"},{"line_number":38,"context_line":"        from eventlet.greenio import GreenSocket"},{"line_number":39,"context_line":"        # TODO(mclaren): A getsockopt workaround: see \u0027getsockopt\u0027 doc string"},{"line_number":40,"context_line":"        GreenSocket.getsockopt \u003d utils.getsockopt"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        raise ImportError"},{"line_number":43,"context_line":"except ImportError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_b1c56f5d","line":40,"updated":"2015-01-07 20:19:14.000000000","message":"What about this lonely code?","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0b0562831956b07381a00eafd36b46a726296475","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        from eventlet.green.OpenSSL.SSL import GreenConnection as Connection"},{"line_number":38,"context_line":"        from eventlet.greenio import GreenSocket"},{"line_number":39,"context_line":"        # TODO(mclaren): A getsockopt workaround: see \u0027getsockopt\u0027 doc string"},{"line_number":40,"context_line":"        GreenSocket.getsockopt \u003d utils.getsockopt"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        raise ImportError"},{"line_number":43,"context_line":"except ImportError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_cf788f91","line":40,"in_reply_to":"3a961159_8c4695a5","updated":"2015-01-08 01:00:50.000000000","message":"Done","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"12b6a5a512626be5598b609756c0dae5b9ce9ed3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        from eventlet.green.OpenSSL.SSL import GreenConnection as Connection"},{"line_number":38,"context_line":"        from eventlet.greenio import GreenSocket"},{"line_number":39,"context_line":"        # TODO(mclaren): A getsockopt workaround: see \u0027getsockopt\u0027 doc string"},{"line_number":40,"context_line":"        GreenSocket.getsockopt \u003d utils.getsockopt"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        raise ImportError"},{"line_number":43,"context_line":"except ImportError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8c4695a5","line":40,"in_reply_to":"3a961159_b1c56f5d","updated":"2015-01-08 00:45:04.000000000","message":"Good catch! I still have to address this","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"}],"glanceclient/common/utils.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"7956dd62cffbe18151c836edd16e1f49978db316","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    msvcrt \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import prettytable"},{"line_number":35,"context_line":"from oslo.utils import encodeutils"},{"line_number":36,"context_line":"from oslo.utils import strutils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from glanceclient import exc"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_51136b64","line":35,"updated":"2015-01-07 20:19:14.000000000","message":"This one should be before prettytable","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"12b6a5a512626be5598b609756c0dae5b9ce9ed3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    msvcrt \u003d None"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import prettytable"},{"line_number":35,"context_line":"from oslo.utils import encodeutils"},{"line_number":36,"context_line":"from oslo.utils import strutils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from glanceclient import exc"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_0cd2a5d0","line":35,"in_reply_to":"3a961159_51136b64","updated":"2015-01-08 00:45:04.000000000","message":"Done","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"7956dd62cffbe18151c836edd16e1f49978db316","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import prettytable"},{"line_number":35,"context_line":"from oslo.utils import encodeutils"},{"line_number":36,"context_line":"from oslo.utils import strutils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from glanceclient import exc"},{"line_number":39,"context_line":"from glanceclient.openstack.common import importutils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_710dc73d","line":36,"updated":"2015-01-07 20:19:14.000000000","message":"and this one too","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"12b6a5a512626be5598b609756c0dae5b9ce9ed3","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"import prettytable"},{"line_number":35,"context_line":"from oslo.utils import encodeutils"},{"line_number":36,"context_line":"from oslo.utils import strutils"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from glanceclient import exc"},{"line_number":39,"context_line":"from glanceclient.openstack.common import importutils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2cdcc1e3","line":36,"in_reply_to":"3a961159_710dc73d","updated":"2015-01-08 00:45:04.000000000","message":"Done","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"}],"glanceclient/openstack/common/apiclient/base.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"14790fc25dc799896d9fd1e37b08bcb64ce1f4ad","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from glanceclient.openstack.common.apiclient import exceptions"},{"line_number":33,"context_line":"#FIXME remove this when syncing"},{"line_number":34,"context_line":"from oslo.utils import strutils"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def getid(obj):"},{"line_number":37,"context_line":"    \"\"\"Return id if argument is a Resource."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_d56bbcb6","line":35,"updated":"2015-01-08 02:32:05.000000000","message":"You need an extra space here.","commit_id":"02d3a043b49af78f2bc3ff6312e52dd252d90d87"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"83f742dd7ac407495f61adba0bd0f62d8d0addd3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from glanceclient.openstack.common.apiclient import exceptions"},{"line_number":33,"context_line":"#FIXME remove this when syncing"},{"line_number":34,"context_line":"from oslo.utils import strutils"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def getid(obj):"},{"line_number":37,"context_line":"    \"\"\"Return id if argument is a Resource."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_e108f792","line":35,"in_reply_to":"3a961159_d56bbcb6","updated":"2015-01-08 09:40:46.000000000","message":"You may rebase on https://review.openstack.org/#/c/145715/","commit_id":"02d3a043b49af78f2bc3ff6312e52dd252d90d87"}],"glanceclient/v2/images.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"7956dd62cffbe18151c836edd16e1f49978db316","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"from six.moves.urllib import parse"},{"line_number":19,"context_line":"from oslo.utils import encodeutils"},{"line_number":20,"context_line":"import warlock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glanceclient.common import utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_d443c93c","line":19,"updated":"2015-01-07 20:19:14.000000000","message":"this should be a line after warlock","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"12b6a5a512626be5598b609756c0dae5b9ce9ed3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"from six.moves.urllib import parse"},{"line_number":19,"context_line":"from oslo.utils import encodeutils"},{"line_number":20,"context_line":"import warlock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glanceclient.common import utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_4cd74dbf","line":19,"in_reply_to":"3a961159_d443c93c","updated":"2015-01-08 00:45:04.000000000","message":"Done","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"}],"glanceclient/v2/metadefs.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"7956dd62cffbe18151c836edd16e1f49978db316","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":"from six.moves.urllib import parse"},{"line_number":18,"context_line":"from oslo.utils import encodeutils"},{"line_number":19,"context_line":"import warlock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from glanceclient.common import utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_346c0dd0","line":18,"updated":"2015-01-07 20:19:14.000000000","message":"this one too","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"12b6a5a512626be5598b609756c0dae5b9ce9ed3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":"from six.moves.urllib import parse"},{"line_number":18,"context_line":"from oslo.utils import encodeutils"},{"line_number":19,"context_line":"import warlock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from glanceclient.common import utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_6ce249a1","line":18,"in_reply_to":"3a961159_346c0dd0","updated":"2015-01-08 00:45:04.000000000","message":"Done","commit_id":"4855e4f64e3e695e6c17510c162340095a6be5fe"}],"glanceclient/v2/tasks.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"f7f95728c0b84565f40eb59df7aa58dddf439e32","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"from oslo.utils import encodeutils"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"import warlock"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_55b7d7f4","line":16,"updated":"2015-01-27 03:57:01.000000000","message":"nit: prefer to add a blank before this line","commit_id":"66dffbc521918eb910764bf81d76f01086bc9d3b"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"2a5719c211272be93636926e0209ee06ddea825e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"from oslo.utils import encodeutils"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"import warlock"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa81d914_ca1f63b6","line":16,"in_reply_to":"1a930d6b_55b7d7f4","updated":"2015-01-27 18:46:43.000000000","message":"Done","commit_id":"66dffbc521918eb910764bf81d76f01086bc9d3b"}],"openstack-common.conf":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"f7f95728c0b84565f40eb59df7aa58dddf439e32","unresolved":false,"context_lines":[{"line_number":4,"context_line":"module\u003dapiclient"},{"line_number":5,"context_line":"module\u003dgettextutils"},{"line_number":6,"context_line":"module\u003dimportutils"},{"line_number":7,"context_line":"module\u003duuidutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base module to hold the copy of openstack.common"},{"line_number":10,"context_line":"base\u003dglanceclient"}],"source_content_type":"text/plain","patch_set":12,"id":"1a930d6b_957a1f22","line":7,"updated":"2015-01-27 03:57:01.000000000","message":"I think this change is unrelated.\n\nIn anyway, we\u0027d use https://github.com/openstack/oslo.utils/blob/master/oslo_utils/uuidutils.py instead of oslo-inc one.","commit_id":"66dffbc521918eb910764bf81d76f01086bc9d3b"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"2a5719c211272be93636926e0209ee06ddea825e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"module\u003dapiclient"},{"line_number":5,"context_line":"module\u003dgettextutils"},{"line_number":6,"context_line":"module\u003dimportutils"},{"line_number":7,"context_line":"module\u003duuidutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base module to hold the copy of openstack.common"},{"line_number":10,"context_line":"base\u003dglanceclient"}],"source_content_type":"text/plain","patch_set":12,"id":"fa81d914_eaeee7b3","line":7,"in_reply_to":"1a930d6b_957a1f22","updated":"2015-01-27 18:46:43.000000000","message":"This was part of my continued failure to rebase. Thanks for spotting it!","commit_id":"66dffbc521918eb910764bf81d76f01086bc9d3b"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"28b66f0f830adcd74f908d77fd1fd63d04bc6167","unresolved":false,"context_lines":[{"line_number":4,"context_line":"module\u003dapiclient"},{"line_number":5,"context_line":"module\u003dgettextutils"},{"line_number":6,"context_line":"module\u003dimportutils"},{"line_number":7,"context_line":"module\u003duuidutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base module to hold the copy of openstack.common"},{"line_number":10,"context_line":"base\u003dglanceclient"}],"source_content_type":"text/plain","patch_set":12,"id":"da86d52c_47f181cc","line":7,"in_reply_to":"da86d52c_e558bafc","updated":"2015-02-02 11:24:29.000000000","message":"Thanks! Review here: https://review.openstack.org/#/c/152087/","commit_id":"66dffbc521918eb910764bf81d76f01086bc9d3b"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"5892160ca7fecaa2da16460c4ec21311c1a331a8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"module\u003dapiclient"},{"line_number":5,"context_line":"module\u003dgettextutils"},{"line_number":6,"context_line":"module\u003dimportutils"},{"line_number":7,"context_line":"module\u003duuidutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base module to hold the copy of openstack.common"},{"line_number":10,"context_line":"base\u003dglanceclient"}],"source_content_type":"text/plain","patch_set":12,"id":"da86d52c_e558bafc","line":7,"in_reply_to":"fa81d914_eaeee7b3","updated":"2015-02-02 04:25:06.000000000","message":"Your latest PS still has this problem..I approved first to let it go, then you can push up a patch to fix it, due to I think it\u0027s easier than rebase. Thanks.","commit_id":"66dffbc521918eb910764bf81d76f01086bc9d3b"}]}