)]}'
{"glanceclient/v2/images.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"64602efa645bd5d58c2fef775866ecdd14e1dc0b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"                if limit:"},{"line_number":67,"context_line":"                    limit -\u003d 1"},{"line_number":68,"context_line":"                    if limit \u003c\u003d 0:"},{"line_number":69,"context_line":"                        raise StopIteration"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"            # NOTE(zhiyan); Reset validation function."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_7d1f48b7","line":68,"updated":"2015-01-27 13:44:31.000000000","message":"This is a bit funky. Why not write:\n\n    if limit:\n        if limit \u003c 0:\n            raise StopIteration\n\ninstead?","commit_id":"906069d958400baad6d095955f5b1c41f54c794d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0e922e88ac2bbfed74f374da07c21083963bcef2","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"                if limit:"},{"line_number":67,"context_line":"                    limit -\u003d 1"},{"line_number":68,"context_line":"                    if limit \u003c\u003d 0:"},{"line_number":69,"context_line":"                        raise StopIteration"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"            # NOTE(zhiyan); Reset validation function."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_bd4d309c","line":68,"in_reply_to":"1a930d6b_7d1f48b7","updated":"2015-01-27 13:47:47.000000000","message":"Users don\u0027t start counting from 0, which means in a case where `limit\u003d1` your proposal would return 2 images. :/\n\nI\u0027m assuming you forgot to add `limit -\u003d 1` in your example. Otherwise, I\u0027m lost :P","commit_id":"906069d958400baad6d095955f5b1c41f54c794d"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"e11b672d576778d12ed796c665ec4b55debcc8ed","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"                if limit:"},{"line_number":67,"context_line":"                    limit -\u003d 1"},{"line_number":68,"context_line":"                    if limit \u003c\u003d 0:"},{"line_number":69,"context_line":"                        raise StopIteration"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"            # NOTE(zhiyan); Reset validation function."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_187f3267","line":68,"in_reply_to":"1a930d6b_bd4d309c","updated":"2015-01-27 13:52:29.000000000","message":"Durr. I\u0027m a fool and didn\u0027t get the point of the deincrement. It makes sense now.","commit_id":"906069d958400baad6d095955f5b1c41f54c794d"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d655678b32974eaf2acc3c5e0917703f09061f57","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        empty_fun \u003d lambda *args, **kwargs: None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        limit \u003d kwargs.get(\u0027limit\u0027)"},{"line_number":50,"context_line":"        page_size \u003d kwargs.get(\u0027page_size\u0027, DEFAULT_PAGE_SIZE)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        def paginate(url, limit\u003dNone):"},{"line_number":53,"context_line":"            resp, body \u003d self.http_client.get(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_79058e0f","line":50,"updated":"2015-01-27 17:56:07.000000000","message":"So I think it\u0027s important to point something out. Previously if \n\n    kwargs.get(\u0027page_size\u0027)\n\nwas None then we would use the DEFAULT_PAGE_SIZE. Now, if the user passes\n\n    page_size\u003dNone\n\nthen page_size is None because the default is only used when page_size isn\u0027t passed. Do we care about that case? This is technically breaking previous (possibly intentional, but likely unintentional) expectations of behaviour.","commit_id":"473ec96a4bb1372a084f6b63a07d5451379b6df2"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"be32b5c1a139e8c91e311e36f3ad2ea48464e328","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        empty_fun \u003d lambda *args, **kwargs: None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        limit \u003d kwargs.get(\u0027limit\u0027)"},{"line_number":50,"context_line":"        page_size \u003d kwargs.get(\u0027page_size\u0027, DEFAULT_PAGE_SIZE)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        def paginate(url, limit\u003dNone):"},{"line_number":53,"context_line":"            resp, body \u003d self.http_client.get(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_996ddace","line":50,"in_reply_to":"1a930d6b_79058e0f","updated":"2015-01-27 17:58:00.000000000","message":"I probably should have included this in my first set of comments, but we could maintain the old behaviour with\n\n    page_size \u003d kwargs.get(\u0027page_size\u0027) or DEFAULT_PAGE_SIZE\n\nWhich will also likely prevent a user from passing 0 (which is a different case that was previously handled coincidentally)","commit_id":"473ec96a4bb1372a084f6b63a07d5451379b6df2"}],"tests/v2/test_images.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"64602efa645bd5d58c2fef775866ecdd14e1dc0b","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        # NOTE(bcwaldon):cast to list since the controller returns a generator"},{"line_number":425,"context_line":"        images \u003d list(self.controller.list(limit\u003d1, page_size\u003d1))"},{"line_number":426,"context_line":"        self.assertEqual(\u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027, images[0].id)"},{"line_number":427,"context_line":"        self.assertEqual(\u0027image-1\u0027, images[0].name)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def test_list_images_visibility_public(self):"},{"line_number":430,"context_line":"        filters \u003d {\u0027filters\u0027: {\u0027visibility\u0027: \u0027public\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_fde7b8a9","line":427,"updated":"2015-01-27 13:44:31.000000000","message":"Shouldn\u0027t this also test that the length of images is 1?","commit_id":"906069d958400baad6d095955f5b1c41f54c794d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0e922e88ac2bbfed74f374da07c21083963bcef2","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        # NOTE(bcwaldon):cast to list since the controller returns a generator"},{"line_number":425,"context_line":"        images \u003d list(self.controller.list(limit\u003d1, page_size\u003d1))"},{"line_number":426,"context_line":"        self.assertEqual(\u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027, images[0].id)"},{"line_number":427,"context_line":"        self.assertEqual(\u0027image-1\u0027, images[0].name)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def test_list_images_visibility_public(self):"},{"line_number":430,"context_line":"        filters \u003d {\u0027filters\u0027: {\u0027visibility\u0027: \u0027public\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_dd375cfd","line":427,"in_reply_to":"1a930d6b_fde7b8a9","updated":"2015-01-27 13:47:47.000000000","message":"good point.","commit_id":"906069d958400baad6d095955f5b1c41f54c794d"}]}