)]}'
{"glanceclient/common/utils.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"0932fc0d9326312321462615bba344048fe8c01a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                      (md5sum, checksum))"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"def make_size_human_readable(size):"},{"line_number":174,"context_line":"    suffix \u003d [\u0027B\u0027, \u0027kB\u0027, \u0027MB\u0027, \u0027GB\u0027, \u0027TB\u0027, \u0027PB\u0027, \u0027EB\u0027, \u0027ZB\u0027]"},{"line_number":175,"context_line":"    base \u003d 1024.0"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F%2FUU%3D","line":173,"updated":"2012-11-12 18:30:30.000000000","message":"Would you mind adding some unit tests to ensure this function continues to work?","commit_id":"c127d942d353833f5c7d5f5acf75ff34b2459a00"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"0932fc0d9326312321462615bba344048fe8c01a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        index \u003d index + 1"},{"line_number":180,"context_line":"        size \u003d size / base"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    return \"%.3f %s\" % (size, suffix[index])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F%2FUM%3D","line":182,"updated":"2012-11-12 18:30:30.000000000","message":"Is it common to have a space between the size and the suffix? The output of \u0027ls -lh\u0027 doesn\u0027t seem to insert a space in its file-size output.","commit_id":"c127d942d353833f5c7d5f5acf75ff34b2459a00"}],"glanceclient/v1/shell.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"0932fc0d9326312321462615bba344048fe8c01a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"@utils.arg(\u0027--page-size\u0027, metavar\u003d\u0027\u003cSIZE\u003e\u0027, default\u003dNone, type\u003dint,"},{"line_number":56,"context_line":"           help\u003d\u0027Number of images to request in each paginated request.\u0027)"},{"line_number":57,"context_line":"@utils.arg(\u0027--human-readable\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":58,"context_line":"           help\u003d\u0027print size in a human readable format\u0027)"},{"line_number":59,"context_line":"def do_image_list(gc, args):"},{"line_number":60,"context_line":"    \"\"\"List images you can access.\"\"\""},{"line_number":61,"context_line":"    filter_keys \u003d [\u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F%2FUY%3D","line":58,"updated":"2012-11-12 18:30:30.000000000","message":"I think we can clean up this help text a little bit:\n\n  Print image size in a human-friendly format.","commit_id":"c127d942d353833f5c7d5f5acf75ff34b2459a00"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"0932fc0d9326312321462615bba344048fe8c01a","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    if args.human_readable:"},{"line_number":78,"context_line":"        tmp \u003d list()"},{"line_number":79,"context_line":"        for image in images:"},{"line_number":80,"context_line":"            setattr(image, \u0027size\u0027, utils.make_size_human_readable("},{"line_number":81,"context_line":"                                      image._info[\u0027size\u0027]"},{"line_number":82,"context_line":"                                   ))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F%2FUc%3D","line":79,"updated":"2012-11-12 18:30:30.000000000","message":"Rather than have to manually iterate through the list of images and deal with the append/reassignment at the end, what do you think about this:\n\n  if args.human_readable:\n      def convert_size(image):\n          image.size \u003d utils.make_size_human_readable(image.size)\n          return image\n      \n      images \u003d (convert_size(image) for image in images)\n\nThis uses a generator to map the image size on the fly.","commit_id":"c127d942d353833f5c7d5f5acf75ff34b2459a00"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"0932fc0d9326312321462615bba344048fe8c01a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if args.human_readable:"},{"line_number":78,"context_line":"        tmp \u003d list()"},{"line_number":79,"context_line":"        for image in images:"},{"line_number":80,"context_line":"            setattr(image, \u0027size\u0027, utils.make_size_human_readable("},{"line_number":81,"context_line":"                                      image._info[\u0027size\u0027]"},{"line_number":82,"context_line":"                                   ))"},{"line_number":83,"context_line":"            tmp.append(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F%2FU8%3D","line":80,"updated":"2012-11-12 18:30:30.000000000","message":"This would be cleaner if you split it into two statements:\n\n  size \u003d utils.make_size_human_readable(image._info[\u0027size\u0027])\n  setattr(image, \u0027size\u0027, size)\n\nAdditionally, is there a reason you aren\u0027t using dot-access to get and set the \u0027size\u0027 attribute?","commit_id":"c127d942d353833f5c7d5f5acf75ff34b2459a00"}],"tests/test_utils.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"7f7c21139f95e9690e12d11c4e38797453f1038a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        data \u003d \u0027\u0027.join([f for f in utils.integrity_iter(fixture, checksum)])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_make_size_human_readable(self):"},{"line_number":48,"context_line":"        self.assertEqual(\"1024.000kB\", utils.make_size_human_readable(1048576))"},{"line_number":49,"context_line":"        self.assertEqual(\"1.375GB\", utils.make_size_human_readable(1476395008))"},{"line_number":50,"context_line":"        self.assertEqual(\"9.309MB\", utils.make_size_human_readable(9761280))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F5Vo%3D","line":48,"updated":"2012-11-16 17:48:58.000000000","message":"This should assert \u00271024kB\u0027 now that you are using %g","commit_id":"4baa03949ea87ef97d778b9fbafbbc536afefbcb"}]}