)]}'
{"glanceclient/v2/image_members.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1ea0a70f72e0770c17532836ccf26f26f481634b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from glanceclient.v2 import schemas"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"MEMBER_STATUS_VALUES \u003d (\u0027Accepted\u0027, \u0027Rejected\u0027, \u0027Pending\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class Controller(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_a40dc092","line":22,"updated":"2015-03-05 12:07:33.000000000","message":"During the specification http://docs.openstack.org/developer/glance/glanceapi.html#image-membership-changes-in-version-2-0 it must be \n\nMEMBER_STATUS_VALUES \u003d (\u0027accepted\u0027, \u0027rejected\u0027, \u0027pending\u0027)","commit_id":"7ce4679985097b52bda121db2d9e9e6655cb44bb"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4482f4f5a3b4bca636aee63a41b24365ee85ecf6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"@utils.arg(\u0027member_id\u0027, metavar\u003d\u0027\u003cMEMBER_ID\u003e\u0027,"},{"line_number":184,"context_line":"           help\u003d\u0027Tenant to update.\u0027)"},{"line_number":185,"context_line":"@utils.arg(\u0027member_status\u0027, metavar\u003d\u0027\u003cMEMBER_STATUS\u003e\u0027,"},{"line_number":186,"context_line":"           help\u003d\u0027Updated status of member.\u0027"},{"line_number":187,"context_line":"                \u0027 Valid Values: Pending, Accepted, Rejected\u0027)"},{"line_number":188,"context_line":"def do_member_update(gc, args):"},{"line_number":189,"context_line":"    \"\"\"Update the status of a member for a given image.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_3f466dc0","line":186,"updated":"2015-03-04 14:36:18.000000000","message":"I would recommend to add \u0027choices\u0027 param here, like\n\nchoices \u003d (\u0027pending\u0027, \u0027accepted\u0027, \u0027rejected\u0027)\n\nor\n\nchoices \u003d glanceclient.v2.image_members.MEMBER_STATUS_VALUES\nwith adding this tuple in that file.\n\nAnd after that you don\u0027t have to expand the help string - the message will appear automatically when someone makes a mistake.","commit_id":"f02ccb943bb9061c4e79814b30b63680299227cf"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"98fd79f5242d0806e06a68b9b606d1e688ee13c0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"@utils.arg(\u0027member_id\u0027, metavar\u003d\u0027\u003cMEMBER_ID\u003e\u0027,"},{"line_number":184,"context_line":"           help\u003d\u0027Tenant to update.\u0027)"},{"line_number":185,"context_line":"@utils.arg(\u0027member_status\u0027, metavar\u003d\u0027\u003cMEMBER_STATUS\u003e\u0027,"},{"line_number":186,"context_line":"           help\u003d\u0027Updated status of member.\u0027"},{"line_number":187,"context_line":"                \u0027 Valid Values: Pending, Accepted, Rejected\u0027)"},{"line_number":188,"context_line":"def do_member_update(gc, args):"},{"line_number":189,"context_line":"    \"\"\"Update the status of a member for a given image.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_df01d13a","line":186,"in_reply_to":"9a80dd14_3f466dc0","updated":"2015-03-04 14:38:33.000000000","message":"Do we have that here? mmh, I thought we didn\u0027t. Did you double check this?","commit_id":"f02ccb943bb9061c4e79814b30b63680299227cf"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"1bf4333ced031beec06f4ddb5bff18cf7798a194","unresolved":false,"context_lines":[{"line_number":183,"context_line":"@utils.arg(\u0027member_id\u0027, metavar\u003d\u0027\u003cMEMBER_ID\u003e\u0027,"},{"line_number":184,"context_line":"           help\u003d\u0027Tenant to update.\u0027)"},{"line_number":185,"context_line":"@utils.arg(\u0027member_status\u0027, metavar\u003d\u0027\u003cMEMBER_STATUS\u003e\u0027,"},{"line_number":186,"context_line":"           help\u003d\u0027Updated status of member.\u0027"},{"line_number":187,"context_line":"                \u0027 Valid Values: Pending, Accepted, Rejected\u0027)"},{"line_number":188,"context_line":"def do_member_update(gc, args):"},{"line_number":189,"context_line":"    \"\"\"Update the status of a member for a given image.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_42eeeaed","line":186,"in_reply_to":"9a80dd14_df01d13a","updated":"2015-03-04 14:59:00.000000000","message":"Of course we have it - I did that in sorting here https://review.openstack.org/#/c/148688/6/glanceclient/v2/shell.py and everything was fine.\n\nFor example, for a wrong sort key I get output:\n\n\"glance image-list: error: argument --sort-key: invalid choice: u\u0027foo\u0027 (choose from \u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027, \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)\"","commit_id":"f02ccb943bb9061c4e79814b30b63680299227cf"}]}