)]}'
{"id":"openstack%2Fpython-glanceclient~157516","triplet_id":"openstack%2Fpython-glanceclient~master~I16a7b02f2b10e506e91719712cf34ef0aea1afc0","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1423939","hashtags":[],"change_id":"I16a7b02f2b10e506e91719712cf34ef0aea1afc0","subject":"Fix leaking sockets after v1 list operation","status":"MERGED","created":"2015-02-19 20:22:15.000000000","updated":"2015-03-11 15:02:24.000000000","submitted":"2015-03-11 15:02:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":38,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d36b61c13a1363f458537ae9110c1b176652154d","_number":157516,"virtual_id_number":157516,"owner":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-03-04 20:13:22.000000000","_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"date":"2015-03-05 19:46:36.000000000","_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2015-03-11 15:02:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"value":2,"date":"2015-03-11 14:09:21.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":2,"date":"2015-03-05 14:16:34.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":1,"date":"2015-03-06 21:07:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":1,"date":"2015-03-05 03:18:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"value":1,"date":"2015-03-11 14:09:21.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-20 11:44:52.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2015-03-02 17:33:41.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2015-03-05 03:18:33.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-03-05 14:16:34.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2015-03-05 19:46:36.000000000","updated_by":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"reviewer":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"state":"REVIEWER"},{"updated":"2015-03-11 14:09:21.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2015-03-11 15:02:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4f8dd78d7a0464066ceab81689a3deb8e51e9a23","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-02-19 20:22:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dab855f389103cf8ee21d83d27cfb8507e06b0f2","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-02-19 21:22:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1088433d32036838e244cc669c5b9e336655162d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-19 21:23:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/16/157516/1/check/gate-python-glanceclient-python26/ebdec38/ : SUCCESS in 2m 07s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/16/157516/1/check/gate-python-glanceclient-pep8/0223639/ : SUCCESS in 1m 17s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/16/157516/1/check/gate-python-glanceclient-docs/9535c39//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-glanceclient-python27 http://logs.openstack.org/16/157516/1/check/gate-python-glanceclient-python27/4484c07/ : SUCCESS in 1m 35s\n- gate-python-glanceclient-python34 http://logs.openstack.org/16/157516/1/check/gate-python-glanceclient-python34/d620530/ : SUCCESS in 3m 18s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/16/157516/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/e0ff3fa/ : SUCCESS in 43m 21s\n- gate-python-glanceclient-pypy http://logs.openstack.org/16/157516/1/check/gate-python-glanceclient-pypy/3ca2ff9/ : SUCCESS in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/16/157516/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/c6d5bcf/ : SUCCESS in 52m 59s","accounts_in_message":[],"_revision_number":1},{"id":"35a868b946b8d409ef19bc943f19dbf335d737c3","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-02-20 11:14:22.000000000","message":"Patch Set 1:\n\nMinor comment on the paperwork side...\n\nShould this have a separate bug to 1423165?","accounts_in_message":[],"_revision_number":1},{"id":"2325e8540405d79fb8e79010086365615f4a37fd","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-02-20 11:44:42.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nThanks Louis. Some minor comments.","accounts_in_message":[],"_revision_number":1},{"id":"9483f0511d334e75356ec31eb03b25e682e02b68","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-02-20 11:44:52.000000000","message":"Patch Set 1: Code-Review-1\n\n(7 comments)\n\nI think you have logic error on determining if we have more images coming or not\n\nOtherwise pretty minor things.","accounts_in_message":[],"_revision_number":1},{"id":"98432e5b34fa5c7f6259140d2af4932293823d09","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-02-20 11:53:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1eade4a9ab2716816ee0bc3dcb7397b2ee86f721","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-02-20 15:24:56.000000000","message":"Patch Set 1:\n\n(10 comments)\n\nThanks for the feedback! Comments inline.","accounts_in_message":[],"_revision_number":1},{"id":"d7c4ab7970146e383521c9917dc6cb8814bf3b77","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-02-20 15:25:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ffcb1cc10156bc39bc97b0116e1bbcfad4c020db","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-02-20 15:26:09.000000000","message":"Patch Set 2: Workflow-1\n\nWIP while I work on the owner filter test.","accounts_in_message":[],"_revision_number":2},{"id":"94315e822e5c6a1fdbe22876b307ebbc20299cc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-20 16:51:03.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/16/157516/2/check/gate-python-glanceclient-python26/23ad1eb/ : SUCCESS in 1m 11s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/16/157516/2/check/gate-python-glanceclient-pep8/f617503/ : SUCCESS in 1m 24s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/16/157516/2/check/gate-python-glanceclient-docs/7a24ef0//doc/build/html/ : SUCCESS in 1m 24s\n- gate-python-glanceclient-python27 http://logs.openstack.org/16/157516/2/check/gate-python-glanceclient-python27/f377035/ : SUCCESS in 1m 53s\n- gate-python-glanceclient-python34 http://logs.openstack.org/16/157516/2/check/gate-python-glanceclient-python34/2f000ed/ : FAILURE in 2m 51s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/16/157516/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/46378a2/ : SUCCESS in 40m 40s\n- gate-python-glanceclient-pypy http://logs.openstack.org/16/157516/2/check/gate-python-glanceclient-pypy/9308688/ : SUCCESS in 1m 57s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/16/157516/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/78221cd/ : SUCCESS in 59m 40s","accounts_in_message":[],"_revision_number":2},{"id":"d70a0d72c2be454e45029d0932c28d4ce3c61183","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-02-20 17:48:47.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"229a546cd7ae393bb8a975b087dbc35c4e77fa29","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-20 18:49:57.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/16/157516/3/check/gate-python-glanceclient-python26/d4b6d9e/ : SUCCESS in 1m 28s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/16/157516/3/check/gate-python-glanceclient-pep8/0ce979f/ : SUCCESS in 1m 24s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/16/157516/3/check/gate-python-glanceclient-docs/6b6269a//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-python27 http://logs.openstack.org/16/157516/3/check/gate-python-glanceclient-python27/e21a0d9/ : SUCCESS in 1m 02s\n- gate-python-glanceclient-python34 http://logs.openstack.org/16/157516/3/check/gate-python-glanceclient-python34/62ce277/ : FAILURE in 3m 06s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/16/157516/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/276a088/ : SUCCESS in 36m 15s\n- gate-python-glanceclient-pypy http://logs.openstack.org/16/157516/3/check/gate-python-glanceclient-pypy/7eb0c87/ : SUCCESS in 1m 42s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/16/157516/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/b190555/ : SUCCESS in 1h 01m 06s","accounts_in_message":[],"_revision_number":3},{"id":"2d23d6c21b6c53144a6e5ef595a1b9f7922993c6","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-02-27 21:48:43.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"138a47b08781190ba898a6a4436ec48f140581e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-28 00:20:54.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/16/157516/4/check/gate-python-glanceclient-python26/4f23fe2/ : SUCCESS in 1m 21s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/16/157516/4/check/gate-python-glanceclient-pep8/b5a8cc4/ : SUCCESS in 1m 11s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/16/157516/4/check/gate-python-glanceclient-docs/21bc357//doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-glanceclient-python27 http://logs.openstack.org/16/157516/4/check/gate-python-glanceclient-python27/4ee7a06/ : SUCCESS in 1m 27s\n- gate-python-glanceclient-python34 http://logs.openstack.org/16/157516/4/check/gate-python-glanceclient-python34/56cae7c/ : SUCCESS in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/16/157516/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/bce35c8/ : SUCCESS in 50m 50s\n- gate-python-glanceclient-pypy http://logs.openstack.org/16/157516/4/check/gate-python-glanceclient-pypy/5146dec/ : SUCCESS in 1m 52s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/16/157516/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient/d050e3e/ : SUCCESS in 1h 06m 42s","accounts_in_message":[],"_revision_number":4},{"id":"90185b0ef0ba7d38357c13ad0842c4c001ac0b59","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2015-03-02 17:33:41.000000000","message":"Patch Set 4: Code-Review+2\n\nLogic looks good","accounts_in_message":[],"_revision_number":4},{"id":"10a3010760711f210062e51b1df07f1b0c478e59","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-03-02 18:01:03.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)\n\nNeed to double check the filtering logic.","accounts_in_message":[],"_revision_number":4},{"id":"5cfb17786bc00f92521d7d322b6fa6e95e18b00a","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-03-02 22:54:20.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"cca768fc37d1ed8e69c896aed1589bc9225bd105","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-03-03 22:24:10.000000000","message":"Patch Set 4: Workflow-1","accounts_in_message":[],"_revision_number":4},{"id":"fea2961cde09073bea844886753ab8d381c4b591","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-03-04 20:08:09.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"f612b46b2a34b380a06052737006602932dd8b86","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-03-04 20:12:09.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"58676291b16bee27c200142016ba8c1310a6a1df","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-03-04 20:13:22.000000000","message":"Patch Set 5:\n\nThe last patchset is probably a bit clunky, but hopefully works.","accounts_in_message":[],"_revision_number":5},{"id":"9971ec190eeb5e7cdfee53bb063dbd1239bc4787","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-03-05 03:18:33.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)\n\nIt may be \"clunky\" but it looks good to me. I didn\u0027t have the chance to spin up a devstack and test the filtering bug that Stuart caught though","accounts_in_message":[],"_revision_number":5},{"id":"b52fa95e9365ae90cfe877955cf0e7188a6fc578","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-05 03:39:29.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/16/157516/5/check/gate-python-glanceclient-python26/56bb8a0/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/16/157516/5/check/gate-python-glanceclient-pep8/bf64457/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/16/157516/5/check/gate-python-glanceclient-docs/576ed09//doc/build/html/ : SUCCESS in 59s\n- gate-python-glanceclient-python27 http://logs.openstack.org/16/157516/5/check/gate-python-glanceclient-python27/75cebd2/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-python34 http://logs.openstack.org/16/157516/5/check/gate-python-glanceclient-python34/76820ef/ : SUCCESS in 2m 12s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/16/157516/5/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/e74888f/ : SUCCESS in 39m 27s\n- gate-python-glanceclient-pypy http://logs.openstack.org/16/157516/5/check/gate-python-glanceclient-pypy/e54e8fe/ : SUCCESS in 1m 32s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/16/157516/5/check/gate-tempest-dsvm-neutron-src-python-glanceclient/a1ea443/ : SUCCESS in 57m 04s","accounts_in_message":[],"_revision_number":5},{"id":"d0320ee648ac399fdd7a26b8d8a61ae88a8152fa","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-03-05 14:16:34.000000000","message":"Patch Set 5: Code-Review+2\n\nThanks Louis.\n\nI wasn\u0027t able to spot any gaps here.\n\nI think the new code is easier to follow than the original.","accounts_in_message":[],"_revision_number":5},{"id":"bb62ee0715ccf76aeb611e1f94743389d83ce028","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-03-05 16:30:55.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"c0d0b4b6007005da37088f36a71324addbb8e943","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2015-03-05 19:46:36.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"43ff64123c7a0076f77e920c68cce75993ff0993","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-03-05 20:56:33.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"03bf854704e47119f002d50a4e6358880d74ec37","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2015-03-06 21:07:56.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"d439b2ee495e93c3331ab56a421f42b133620d4a","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-03-11 14:09:21.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"bc34e35c9dc12ad41eaab1fd11dda26f61011074","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 14:09:37.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"a15fc7a3f8f1733e2c1ba4b44a9a89608f064259","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 15:02:22.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/16/157516/5/gate/gate-python-glanceclient-python26/55bad8e/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/16/157516/5/gate/gate-python-glanceclient-docs/744c039//doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/16/157516/5/gate/gate-python-glanceclient-pep8/93805a9/ : SUCCESS in 57s\n- gate-python-glanceclient-python27 http://logs.openstack.org/16/157516/5/gate/gate-python-glanceclient-python27/3e369e5/ : SUCCESS in 1m 02s\n- gate-python-glanceclient-python34 http://logs.openstack.org/16/157516/5/gate/gate-python-glanceclient-python34/a80d1ba/ : SUCCESS in 2m 26s\n- gate-python-glanceclient-pypy http://logs.openstack.org/16/157516/5/gate/gate-python-glanceclient-pypy/e64b1eb/ : SUCCESS in 1m 25s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/16/157516/5/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/e319402/ : SUCCESS in 52m 40s","accounts_in_message":[],"_revision_number":5},{"id":"141dabcf810eaed87b345bc941db8e620c5dd3fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 15:02:24.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"f98ab688eff8fff4bdb5f650da3516715d62f232","revisions":{"a0b3663e734d9deea52de2fb3486bc343026b5d8":{"kind":"REWORK","_number":1,"created":"2015-02-19 20:22:15.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/16/157516/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/16/157516/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/1"}}},"commit":{"parents":[{"commit":"a3eaafefbdcec0231db33c44cca718526f9c96cc","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3eaafefbdcec0231db33c44cca718526f9c96cc"}]}],"author":{"name":"Louis Taylor","email":"kragniz@gmail.com","date":"2015-02-19 18:39:20.000000000","tz":0},"committer":{"name":"Louis Taylor","email":"kragniz@gmail.com","date":"2015-02-19 20:22:10.000000000","tz":0},"subject":"Fix leaking sockets after v1 list operation","message":"Fix leaking sockets after v1 list operation\n\nSince the move to using the requests library, v1 list operations keep the\nconnection open to the glance server. This is normally closed by the garbage\ncollector if it is not explicitly closed, however the paginate function used by\nthe list method had a circular reference preventing it from ever being\ncollected.\n\nThis is problematic, since it causes long running nova processes to run out of\nfile descriptors for new connections.\n\nThis patch makes paginate() non-recursive, which allows the connection to be\nfreed.\n\nChange-Id: I16a7b02f2b10e506e91719712cf34ef0aea1afc0\nPartial-Bug: 1423165\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a0b3663e734d9deea52de2fb3486bc343026b5d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a0b3663e734d9deea52de2fb3486bc343026b5d8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a3eaafefbdcec0231db33c44cca718526f9c96cc","is_merged_in_target_branch":true,"change_id":"I06268c3e638716366c38181cb6364a2fce7bafee","change_number":149977,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/master"},"526234e23a7abee0270c1b566bd3f6565af7cc69":{"kind":"REWORK","_number":2,"created":"2015-02-20 15:25:01.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/16/157516/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/16/157516/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/2"}}},"commit":{"parents":[{"commit":"a3eaafefbdcec0231db33c44cca718526f9c96cc","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3eaafefbdcec0231db33c44cca718526f9c96cc"}]}],"author":{"name":"Louis Taylor","email":"kragniz@gmail.com","date":"2015-02-19 18:39:20.000000000","tz":0},"committer":{"name":"Louis Taylor","email":"kragniz@gmail.com","date":"2015-02-20 15:05:36.000000000","tz":0},"subject":"Fix leaking sockets after v1 list operation","message":"Fix leaking sockets after v1 list operation\n\nSince the move to using the requests library, v1 list operations keep\nthe connection open to the glance server. This is normally closed by the\ngarbage collector if it is not explicitly closed, however the paginate\nfunction used by the list method had a circular reference preventing it\nfrom ever being collected during the lifecycle of a service consuming\nglanceclient.\n\nThis is problematic, since it causes long running nova processes to run\nout of file descriptors for new connections.\n\nThis patch makes paginate() non-recursive, which allows the connection\nto be freed.\n\nChange-Id: I16a7b02f2b10e506e91719712cf34ef0aea1afc0\nCloses-Bug: 1423939\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/526234e23a7abee0270c1b566bd3f6565af7cc69"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/526234e23a7abee0270c1b566bd3f6565af7cc69"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a3eaafefbdcec0231db33c44cca718526f9c96cc","is_merged_in_target_branch":true,"change_id":"I06268c3e638716366c38181cb6364a2fce7bafee","change_number":149977,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/master"},"8b6f0b2b7633f75088464160c801da5ff167e89d":{"kind":"REWORK","_number":3,"created":"2015-02-20 17:48:47.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/16/157516/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/16/157516/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/3"}}},"commit":{"parents":[{"commit":"a3eaafefbdcec0231db33c44cca718526f9c96cc","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3eaafefbdcec0231db33c44cca718526f9c96cc"}]}],"author":{"name":"Louis Taylor","email":"kragniz@gmail.com","date":"2015-02-19 18:39:20.000000000","tz":0},"committer":{"name":"Louis Taylor","email":"kragniz@gmail.com","date":"2015-02-20 17:48:29.000000000","tz":0},"subject":"Fix leaking sockets after v1 list operation","message":"Fix leaking sockets after v1 list operation\n\nSince the move to using the requests library, v1 list operations keep\nthe connection open to the glance server. This is normally closed by the\ngarbage collector if it is not explicitly closed, however the paginate\nfunction used by the list method had a circular reference preventing it\nfrom ever being collected during the lifecycle of a service consuming\nglanceclient.\n\nThis is problematic, since it causes long running nova processes to run\nout of file descriptors for new connections.\n\nThis patch makes paginate() non-recursive, which allows the connection\nto be freed.\n\nChange-Id: I16a7b02f2b10e506e91719712cf34ef0aea1afc0\nCloses-Bug: 1423939\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8b6f0b2b7633f75088464160c801da5ff167e89d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8b6f0b2b7633f75088464160c801da5ff167e89d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a3eaafefbdcec0231db33c44cca718526f9c96cc","is_merged_in_target_branch":true,"change_id":"I06268c3e638716366c38181cb6364a2fce7bafee","change_number":149977,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/master"},"b36bfb23ce7c27d36e14c50ee837d37c1d909e3a":{"kind":"REWORK","_number":4,"created":"2015-02-27 21:48:43.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/16/157516/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/16/157516/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/4"}}},"commit":{"parents":[{"commit":"db0179f5c4fa02515b1706e74da545bc1eeb6b54","subject":"Merge \"Register our own ConnectionPool without globals\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/db0179f5c4fa02515b1706e74da545bc1eeb6b54"}]}],"author":{"name":"Louis Taylor","email":"kragniz@gmail.com","date":"2015-02-19 18:39:20.000000000","tz":0},"committer":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-02-27 21:48:31.000000000","tz":0},"subject":"Fix leaking sockets after v1 list operation","message":"Fix leaking sockets after v1 list operation\n\nSince the move to using the requests library, v1 list operations keep\nthe connection open to the glance server. This is normally closed by the\ngarbage collector if it is not explicitly closed, however the paginate\nfunction used by the list method had a circular reference preventing it\nfrom ever being collected during the lifecycle of a service consuming\nglanceclient.\n\nThis is problematic, since it causes long running nova processes to run\nout of file descriptors for new connections.\n\nThis patch makes paginate() non-recursive, which allows the connection\nto be freed.\n\nChange-Id: I16a7b02f2b10e506e91719712cf34ef0aea1afc0\nCloses-Bug: 1423939\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b36bfb23ce7c27d36e14c50ee837d37c1d909e3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b36bfb23ce7c27d36e14c50ee837d37c1d909e3a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"db0179f5c4fa02515b1706e74da545bc1eeb6b54","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"f98ab688eff8fff4bdb5f650da3516715d62f232":{"kind":"REWORK","_number":5,"created":"2015-03-04 20:08:09.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/16/157516/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/16/157516/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/16/157516/5"}}},"commit":{"parents":[{"commit":"db0179f5c4fa02515b1706e74da545bc1eeb6b54","subject":"Merge \"Register our own ConnectionPool without globals\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/db0179f5c4fa02515b1706e74da545bc1eeb6b54"}]}],"author":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-02-19 18:39:20.000000000","tz":0},"committer":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-03-04 20:07:53.000000000","tz":0},"subject":"Fix leaking sockets after v1 list operation","message":"Fix leaking sockets after v1 list operation\n\nSince the move to using the requests library, v1 list operations keep\nthe connection open to the glance server. This is normally closed by the\ngarbage collector if it is not explicitly closed, however the paginate\nfunction used by the list method had a circular reference preventing it\nfrom ever being collected during the lifecycle of a service consuming\nglanceclient.\n\nThis is problematic, since it causes long running nova processes to run\nout of file descriptors for new connections.\n\nThis patch makes paginate() non-recursive, which allows the connection\nto be freed.\n\nChange-Id: I16a7b02f2b10e506e91719712cf34ef0aea1afc0\nCloses-Bug: 1423939\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f98ab688eff8fff4bdb5f650da3516715d62f232"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f98ab688eff8fff4bdb5f650da3516715d62f232"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"db0179f5c4fa02515b1706e74da545bc1eeb6b54","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}