)]}'
{"id":"openstack%2Fpython-glanceclient~161839","triplet_id":"openstack%2Fpython-glanceclient~master~Iaa7a421e8c1acafb7b23bb3f55e50b9d2a9d030a","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1428797","hashtags":[],"change_id":"Iaa7a421e8c1acafb7b23bb3f55e50b9d2a9d030a","subject":"Fix leaking sockets after v2 list operation","status":"MERGED","created":"2015-03-05 18:59:20.000000000","updated":"2015-03-06 22:37:28.000000000","submitted":"2015-03-06 22:37:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4b3a0bd79b8acd769543613a587d86683adc955a","_number":161839,"virtual_id_number":161839,"owner":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":2,"date":"2015-03-06 22:37:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"recommended":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"all":[{"value":1,"date":"2015-03-06 21:36:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-03-06 11:34:46.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":2,"date":"2015-03-06 21:39:35.000000000","_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":1,"date":"2015-03-06 21:39:35.000000000","_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-06 11:34:46.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2015-03-06 21:36:59.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-03-06 21:39:35.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2015-03-06 22:37:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5061f511091a7ffd9f99e6e8795e5878ed47da9f","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2015-03-05 18:59:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf998220487be951255f146a538b6842b673a0d3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-05 20:07:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/39/161839/1/check/gate-python-glanceclient-python26/923b69e/ : SUCCESS in 1m 19s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/39/161839/1/check/gate-python-glanceclient-pep8/5027f05/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/39/161839/1/check/gate-python-glanceclient-docs/5732f47//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-glanceclient-python27 http://logs.openstack.org/39/161839/1/check/gate-python-glanceclient-python27/05a243a/ : SUCCESS in 1m 27s\n- gate-python-glanceclient-python34 http://logs.openstack.org/39/161839/1/check/gate-python-glanceclient-python34/531fb6b/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/39/161839/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/f4b97ef/ : SUCCESS in 37m 55s\n- gate-python-glanceclient-pypy http://logs.openstack.org/39/161839/1/check/gate-python-glanceclient-pypy/9e0ac27/ : SUCCESS in 2m 32s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/39/161839/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/b4087ab/ : SUCCESS in 58m 44s","accounts_in_message":[],"_revision_number":1},{"id":"0cc5c4c1ab9d5edfd87a8917ff08d3790a2d385f","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-03-06 11:34:46.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Louis.\n\nThis matches the current behaviour, minus the socket leak.\n\nThe current behaviour is buggy:\n\n https://bugs.launchpad.net/python-glanceclient/+bug/1429088\n\nwe can address that in another patch set.","accounts_in_message":[],"_revision_number":1},{"id":"e53cf97259aa1f54f9df59f8d16f505dbb2f0e6f","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-03-06 21:36:59.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ae83c0c3f48da144a9065196d106b8b275cb19ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-06 21:39:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5c21c3acac374a9b911e0d326045584fb4444c6b","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2015-03-06 21:39:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"63dfa78ca7ea23a6b673ef50ff97cba0540abe0f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-06 22:37:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/39/161839/1/gate/gate-python-glanceclient-python26/4d6dc65/ : SUCCESS in 1m 14s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/39/161839/1/gate/gate-python-glanceclient-docs/52e3f92//doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/39/161839/1/gate/gate-python-glanceclient-pep8/cad1063/ : SUCCESS in 59s\n- gate-python-glanceclient-python27 http://logs.openstack.org/39/161839/1/gate/gate-python-glanceclient-python27/38358e8/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-python34 http://logs.openstack.org/39/161839/1/gate/gate-python-glanceclient-python34/87116bf/ : SUCCESS in 2m 28s\n- gate-python-glanceclient-pypy http://logs.openstack.org/39/161839/1/gate/gate-python-glanceclient-pypy/04c7d2f/ : SUCCESS in 2m 21s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/39/161839/1/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/7a093fd/ : SUCCESS in 55m 30s","accounts_in_message":[],"_revision_number":1},{"id":"67c2f49faa18ce09d75c170a9ddb142fc5075779","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-06 22:37:28.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0ab5a78d78249199cc25420fe80a2f8598022184","revisions":{"0ab5a78d78249199cc25420fe80a2f8598022184":{"kind":"REWORK","_number":1,"created":"2015-03-05 18:59:20.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/39/161839/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/39/161839/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/39/161839/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/39/161839/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/39/161839/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/39/161839/1"}}},"commit":{"parents":[{"commit":"59eec058bca34645c81697537e6dfc3fa2a359b1","subject":"Merge \"removed excessive call to os.path.exists\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/59eec058bca34645c81697537e6dfc3fa2a359b1"}]}],"author":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-03-05 18:53:54.000000000","tz":0},"committer":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2015-03-05 18:53:54.000000000","tz":0},"subject":"Fix leaking sockets after v2 list operation","message":"Fix leaking sockets after v2 list operation\n\nThis fixes the same problem with leaking file descriptors after the port\nto requests I16a7b02f2b10e506e91719712cf34ef0aea1afc0 does, but for the\nv2 api client.\n\nThe paginate function in the list method has been refactored from a\nrecursive generator to a non-recursive generator, which avoids issues\nwith garbage collection holding the socket open.\n\nChange-Id: Iaa7a421e8c1acafb7b23bb3f55e50b9d2a9d030a\nCloses-Bug: #1428797\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0ab5a78d78249199cc25420fe80a2f8598022184"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0ab5a78d78249199cc25420fe80a2f8598022184"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}