)]}'
{"id":"openstack%2Fpython-glanceclient~163584","triplet_id":"openstack%2Fpython-glanceclient~master~I5914fa9cfef190a028b374005adbf3a804b1b677","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1309272","hashtags":[],"change_id":"I5914fa9cfef190a028b374005adbf3a804b1b677","subject":"Require disk and container format on image-create","status":"MERGED","created":"2015-03-11 19:36:51.000000000","updated":"2015-08-14 09:48:58.000000000","submitted":"2015-08-14 09:48:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f7ed0901cf60ab7618dfa0fc234cbb82aec67d63","_number":163584,"virtual_id_number":163584,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2015-08-14 09:48:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"date":"2015-08-14 08:08:35.000000000","_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":2,"date":"2015-08-14 08:00:54.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":1,"date":"2015-08-14 08:00:54.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-11 19:58:06.000000000","updated_by":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"reviewer":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"state":"REVIEWER"},{"updated":"2015-05-22 18:55:54.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-05-27 00:01:01.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2015-07-03 19:21:35.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2015-08-13 23:10:47.000000000","updated_by":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"reviewer":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"state":"REVIEWER"},{"updated":"2015-08-14 08:00:54.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2015-08-14 09:48:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ed59ae0e5a955f03f2a1419d4f5effd8af66e8eb","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-11 19:36:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e1d4bb1dd65bd25f63530dbeff92e1ec86040e93","author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"date":"2015-03-11 19:58:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI have some suggestions. Is there a reason why set container format wasn\u0027t just set to \u0027bare\u0027?","accounts_in_message":[],"_revision_number":1},{"id":"09cc606840fbf93b49f834cad4bfb7a0372cb708","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-11 20:15:04.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nI wasn\u0027t sure that setting a default, and it being bare, was the right choice since I haven\u0027t been working on OpenStack long enough to judge it.\n\nAnyway, if you want me to set a default I\u0027ll gladly create another patch for that. :)\nBut now in this one, because here we don\u0027t change the command line behavior, we just accelerate the error response. Instead of waiting to send the image data to the endpoint and wait for the error response we give an immediate error response.\n\nThank you for the review. :)","accounts_in_message":[],"_revision_number":1},{"id":"e2ebc37996ca36be434c0055eab98a5e14af6087","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 22:19:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/1/check/gate-python-glanceclient-python26/0d741ad/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/1/check/gate-python-glanceclient-pep8/a237682/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/1/check/gate-python-glanceclient-docs/ee8bb61//doc/build/html/ : SUCCESS in 53s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/1/check/gate-python-glanceclient-python27/95707c8/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/1/check/gate-python-glanceclient-python34/2a1db8a/ : SUCCESS in 2m 47s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/84/163584/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/0fc5321/ : SUCCESS in 47m 01s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/1/check/gate-python-glanceclient-pypy/0d225ab/ : SUCCESS in 1m 50s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/bc24931/ : SUCCESS in 55m 13s","accounts_in_message":[],"_revision_number":1},{"id":"b71bd9a0d1d981766fb0474f1e325e0c8fdea193","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-03-11 22:52:35.000000000","message":"Patch Set 1: Code-Review-2\n\nNeither Image API version (1 or 2) does not need any fields what so ever to create an image:\n\nubuntu@devstack-01:~$ glance --os-image-api-version 1 image-create\n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n| checksum         | None                                 |\n| container_format | None                                 |\n| created_at       | 2015-03-11T22:44:41                  |\n| deleted          | False                                |\n| deleted_at       | None                                 |\n| disk_format      | None                                 |\n| id               | 679c5270-dd4f-45dc-ad8e-7668215aa6b5 |\n| is_public        | False                                |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | None                                 |\n| owner            | f96a6e291fc24afda2dc226a01579381     |\n| protected        | False                                |\n| size             | 0                                    |\n| status           | queued                               |\n| updated_at       | 2015-03-11T22:44:41                  |\n| virtual_size     | None                                 |\n+------------------+--------------------------------------+\nubuntu@devstack-01:~$ glance --os-image-api-version 2 image-create\n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n| checksum         | None                                 |\n| container_format | None                                 |\n| created_at       | 2015-03-11T22:44:59Z                 |\n| disk_format      | None                                 |\n| id               | 9bf1936a-c1ea-4ca8-9599-8fa75930fe55 |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | None                                 |\n| owner            | f96a6e291fc24afda2dc226a01579381     |\n| protected        | False                                |\n| size             | None                                 |\n| status           | queued                               |\n| tags             | []                                   |\n| updated_at       | 2015-03-11T22:44:59Z                 |\n| virtual_size     | None                                 |\n| visibility       | private                              |\n+------------------+--------------------------------------+\nubuntu@devstack-01:~$\n\nThus such should not be enforced either.\n\nI do see the point on the issue, this is just not right way to fix it. We will need quite a lot more logic if we want to ensure that the data has not been provided to glance before the needed properties have been set.","accounts_in_message":[],"_revision_number":1},{"id":"ffa87c41d00a37f8d59675578c50a5d932e7df3a","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-12 08:47:51.000000000","message":"Patch Set 1:\n\nErno, I agree in half of what you said.\nLooking at the API documentation for v1 (http://developer.openstack.org/api-ref-image-v1.html#images-v1) disk_format and container_format are not optional on the request, and as such they should be enforced in glanceclient for v1. Right?\n\nAs for v2 I really can\u0027t tell (http://developer.openstack.org/api-ref-image-v2.html#images-v2), because documentation is not clear on all request parameters (according to it it doesn\u0027t even allow disk_format and container_format). But I think we could enforce the presence of those 2 arguments if locations or file are present. Don\u0027t you agree?\n\nBy the way Cindy, given a second thought, I\u0027ll be changing those default empty lists to tuples to resolves the issue of having mutable default arguments.","accounts_in_message":[],"_revision_number":1},{"id":"19cdae39f2ffb9c11320d4a06ff29ef1d2612826","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-03-12 09:21:13.000000000","message":"Patch Set 1:\n\nHi Gorka,\n\nThe image creation can be done in multiple steps and those required properties are required when the transition to active is happening (as in when the image data gets provided to glance). If we want to ensure those needed parameters being there, we would need to check if there is location, copy-from or the actual data provided and those properties not. If we do this we need also to check on image update that those properties are provided or exists on the image already before we start uploading the data, set the location or copy-from, but only in those cases. Image create and update does not require them unless the data provided so we cannot just go and mark bunch of options required, as that\u0027s not the case and we would break established behavior really badly if we did that.\n\nAs said before, making the calls fail early does not quite a bit more logic. If you\u0027re up for implementing it, I\u0027m up for reviewing the code. :)","accounts_in_message":[],"_revision_number":1},{"id":"e164d1ef21bdb0966aeab650c79abc11648ce737","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-03-12 09:22:34.000000000","message":"Patch Set 1:\n\nsorry, \"does need quite a bit more logic\"","accounts_in_message":[],"_revision_number":1},{"id":"2410e849d169945d44bfb200c625a761a6a2e2ec","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-12 16:20:30.000000000","message":"Patch Set 1:\n\nErno, that\u0027s an offer I can\u0027t refuse. :)\nI\u0027ll change the logic here for creation and submit another patch for the update command.\nJust to be sure, image creation from v1 does not require disk-format and container-format and the documentation is wrong, right?","accounts_in_message":[],"_revision_number":1},{"id":"e9a37602efb34d8fd288b09592c17aa81f6cdf1b","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-13 18:15:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ee9ae4a58684d902299a7c20b239b0d1f049cbca","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-13 18:18:08.000000000","message":"Patch Set 2:\n\nErno, I have changed the patch so that disk-format and container-format fields are only required on creation if --file, --location, --locations or --copy-from are supplied.\n\nThis should fix the issue with the creation command and the update will come in another patch.","accounts_in_message":[],"_revision_number":2},{"id":"edb2241eda9f631df19f1fbbcf0dcf4e9bca8994","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-13 22:43:36.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/2/check/gate-python-glanceclient-python26/a3ccac3/ : FAILURE in 1m 15s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/2/check/gate-python-glanceclient-pep8/8d65f8f/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/2/check/gate-python-glanceclient-docs/5836215//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/2/check/gate-python-glanceclient-python27/4d69c90/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/2/check/gate-python-glanceclient-python34/f06ecd4/ : SUCCESS in 2m 36s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/84/163584/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/77a6e47/ : SUCCESS in 41m 58s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/2/check/gate-python-glanceclient-pypy/51bf00d/ : SUCCESS in 1m 31s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/ecb0b3d/ : SUCCESS in 53m 32s","accounts_in_message":[],"_revision_number":2},{"id":"eeaf7660245bc5698b8cf865319c6e4647048964","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-15 12:43:54.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"723353ca65cfbb4722b19ee2dee1f1b0651ff5e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-15 14:50:13.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/3/check/gate-python-glanceclient-python26/fadafa2/ : SUCCESS in 1m 17s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/3/check/gate-python-glanceclient-pep8/9ae6246/ : SUCCESS in 1m 22s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/3/check/gate-python-glanceclient-docs/347052b//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/3/check/gate-python-glanceclient-python27/e398ce0/ : SUCCESS in 1m 33s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/3/check/gate-python-glanceclient-python34/3263a44/ : SUCCESS in 3m 07s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/84/163584/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/10656a2/ : SUCCESS in 39m 28s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/3/check/gate-python-glanceclient-pypy/161cd5d/ : SUCCESS in 1m 39s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/dfdbfe5/ : SUCCESS in 59m 37s","accounts_in_message":[],"_revision_number":3},{"id":"1b90e800575063992cecd566f2549bf5cf9c2f03","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-15 15:50:10.000000000","message":"Patch Set 3:\n\nThis last patch set fixes issue with Python 2.6 that doesn\u0027t like set comprehension :(","accounts_in_message":[],"_revision_number":3},{"id":"8b0d695e66ec95143b07357a3242d31379dfa326","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-03-16 10:19:14.000000000","message":"Patch Set 3: Code-Review-1\n\nHow about when the data is provided through stdin?","accounts_in_message":[],"_revision_number":3},{"id":"cdef5683757149aac60d1d26bbb59dcfb4007f28","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-16 16:35:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4482f565effd0d8bee19b9c6550c0c8dca357dc6","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-16 16:36:25.000000000","message":"Patch Set 4:\n\nErno, Thanks! I didn\u0027t realize that was a possibility.\nI have taken it into account now.","accounts_in_message":[],"_revision_number":4},{"id":"e01793c8f280ad437bbaa31ab909ce0cb5e8b838","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-16 18:08:23.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/4/check/gate-python-glanceclient-python26/16fd3f3/ : SUCCESS in 1m 31s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/4/check/gate-python-glanceclient-pep8/8614cc6/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/4/check/gate-python-glanceclient-docs/dade4d4//doc/build/html/ : SUCCESS in 1m 21s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/4/check/gate-python-glanceclient-python27/8284692/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/4/check/gate-python-glanceclient-python34/8d39b2b/ : FAILURE in 2m 55s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/84/163584/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/fb8fab5/ : SUCCESS in 40m 38s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/4/check/gate-python-glanceclient-pypy/0766e17/ : SUCCESS in 2m 13s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient/0342c17/ : SUCCESS in 54m 01s","accounts_in_message":[],"_revision_number":4},{"id":"165592fe324a03cc96110aa52199843d1a37f3ea","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-16 19:32:35.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"590dcac5d1408166a226cbfac6d7f0f0c2f208e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-16 20:58:49.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/5/check/gate-python-glanceclient-python26/c182bf9/ : SUCCESS in 1m 25s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/5/check/gate-python-glanceclient-pep8/1c22e8f/ : SUCCESS in 1m 30s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/5/check/gate-python-glanceclient-docs/a8d34be//doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/5/check/gate-python-glanceclient-python27/fa15a1a/ : SUCCESS in 1m 36s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/5/check/gate-python-glanceclient-python34/d5fe2c6/ : SUCCESS in 2m 49s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/84/163584/5/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/0203ac3/ : SUCCESS in 39m 07s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/5/check/gate-python-glanceclient-pypy/9bc9c49/ : SUCCESS in 2m 35s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/5/check/gate-tempest-dsvm-neutron-src-python-glanceclient/63d7b7b/ : SUCCESS in 59m 11s","accounts_in_message":[],"_revision_number":5},{"id":"79923aef30fa3c2206e9f602ceaa18c034612e5e","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2015-04-13 00:03:28.000000000","message":"Patch Set 5: Code-Review-1\n\nI can\u0027t reproduce this issue with latest glance client, can you try again?","accounts_in_message":[],"_revision_number":5},{"id":"df6e0a40038a7083b5855e580e3b37f125083aaa","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-13 09:29:47.000000000","message":"Patch Set 5:\n\nI tried again and the issue is still there.\nMaybe in your case you are seeing a quick enough response because your image is relatively small or connection to your storage backend is fast.\nIf you try it with a big enough file you\u0027ll see an increase in the delay. In any case if you check TCP traffic when you execute the command you\u0027ll see that you are actually sending the whole file even though you already know the call will fail.","accounts_in_message":[],"_revision_number":5},{"id":"644d48f80721823d5c280fe7d8bb051d3a030176","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-28 16:34:48.000000000","message":"Patch Set 5: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":5},{"id":"398f176dd61fd67de13b5bc6e5340f00300c5b6f","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-28 17:35:59.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"70e2b9eb58dce4c8a717f8db8ceffa6e91a9078d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-28 18:35:03.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/6/check/gate-python-glanceclient-python26/cfc9c75/ : SUCCESS in 1m 15s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/6/check/gate-python-glanceclient-pep8/e2cfc5d/ : SUCCESS in 1m 27s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/6/check/gate-python-glanceclient-docs/6fa62c6//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/6/check/gate-python-glanceclient-python27/8b38564/ : SUCCESS in 1m 35s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/6/check/gate-python-glanceclient-python34/a03bf07/ : SUCCESS in 3m 35s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/6/check/gate-python-glanceclient-pypy/9896cd3/ : SUCCESS in 1m 39s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/6/check/gate-tempest-dsvm-neutron-src-python-glanceclient/90baa98/ : SUCCESS in 53m 47s","accounts_in_message":[],"_revision_number":6},{"id":"97c10885feda220e8d29e85017ae3340ed452807","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-05-17 23:18:59.000000000","message":"Patch Set 6: Code-Review-1\n\n(2 comments)\n\nThis is a really good change. I just have a couple nits but then I\u0027m strongly a +2.","accounts_in_message":[],"_revision_number":6},{"id":"520d03c3a21e17295a27afa636488ac69bced528","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-21 15:43:02.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"d15e5c54384b9bd4bfc82f0a30d92b95debba3d9","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-21 15:43:21.000000000","message":"Patch Set 6:\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"775307a3787c204ee03f66ea1ae87d24cce037c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-21 16:36:08.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-python26/1ae5193/ : SUCCESS in 1m 29s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-pep8/c71b6f6/ : SUCCESS in 1m 43s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/7/check/gate-python-glanceclient-docs/43ab02e//doc/build/html/ : SUCCESS in 1m 46s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-python27/fcaaf96/ : SUCCESS in 1m 39s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-python34/2a57c8d/ : SUCCESS in 1m 54s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-pypy/021fb81/ : SUCCESS in 1m 52s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/7/check/gate-tempest-dsvm-neutron-src-python-glanceclient/c5fbc35/ : SUCCESS in 53m 00s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/84/163584/7/check/check-glanceclient-dsvm-functional/7575058/ : FAILURE in 14m 54s","accounts_in_message":[],"_revision_number":7},{"id":"d30619eb61b7af11ecf2bdc42c212d3e81e086c6","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-05-22 18:55:53.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"578abc4c26df37837eac41a8090971262dbccbc3","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-05-22 18:55:54.000000000","message":"Patch Set 7: Code-Review+1\n\n(1 comment)\n\nOne last nit. I also need to spin up a devstack instance to test this before I give it a +2.\n\nCheers,\nIan","accounts_in_message":[],"_revision_number":7},{"id":"004fd60ddcd2575e1800d68b96a6b26f4d5db4e6","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-25 11:56:44.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"0cdca1cb2ae04ff09c66660afccedcc699eff35d","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-26 07:24:43.000000000","message":"Patch Set 7:\n\nrecheck","accounts_in_message":[],"_revision_number":7},{"id":"9c4f15f749061cc9942562c38d8096e3ebe3e36a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-26 08:05:46.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-python26/ecd4327/ : SUCCESS in 1m 35s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-pep8/b6ff164/ : SUCCESS in 1m 43s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/7/check/gate-python-glanceclient-docs/b2b7844//doc/build/html/ : SUCCESS in 1m 50s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-python27/cb842eb/ : SUCCESS in 2m 05s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-python34/fc8d34e/ : SUCCESS in 2m 00s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/7/check/gate-python-glanceclient-pypy/a44e8ce/ : SUCCESS in 1m 53s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/7/check/gate-tempest-dsvm-neutron-src-python-glanceclient/9dc1b3d/ : SUCCESS in 40m 56s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/84/163584/7/check/check-glanceclient-dsvm-functional/a55693a/ : SUCCESS in 20m 06s","accounts_in_message":[],"_revision_number":7},{"id":"94a06dcb29402ffe3a104b68fe2efd9b351b5221","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-05-27 00:01:01.000000000","message":"Patch Set 7: Code-Review+1\n\nI\u0027m ok to take it in as it is now, but if Ian want\u0027s that lambda changed to function I\u0027m fine with that as well.","accounts_in_message":[],"_revision_number":7},{"id":"82f6d1c601d4c96ec470099657a8bfdaa82ea802","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-06-19 21:25:37.000000000","message":"Patch Set 7: Code-Review+2\n\nI\u0027m fine with this. Ian, your call.","accounts_in_message":[],"_revision_number":7},{"id":"6f72d9be5b8e07a839ea07439ea182ed6ab00910","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-07-03 19:21:35.000000000","message":"Patch Set 7: Code-Review+1\n\nBtw, I fixed it on the server side, so without disk-format or container-format, but with file provided, Glance returns 400 response with adequate message and doesn\u0027t create an instance in db. https://review.openstack.org/#/c/181130/","accounts_in_message":[],"_revision_number":7},{"id":"e522a4511d9f4d313bc2b4b1857a24d24cfae594","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2015-07-05 22:10:15.000000000","message":"Patch Set 7: Code-Review-1\n\nGorka, can you try again based on Make\u0027s patch? IMHO, if it\u0027s handled on server side, then it\u0027s not really necessary to duplicate the work on client side.","accounts_in_message":[],"_revision_number":7},{"id":"fbd4271a3f4269039bfa292e386d3247cb07c30c","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-07-29 11:39:38.000000000","message":"Patch Set 7:\n\nSorry for the delay, I actually tested this weeks ago but for some reason didn\u0027t post a reply. :-(\n\nYes, that prevents the client from sending the whole image before getting an error and the server will not create the image entry in the DB, but one could argue, why even send the request in the first place?\n\nMy reasoning for this patch is that, regardless of the server protection (which is a must have) and will prevent the situation with any request (even from other scripts), our client should be smart enough to avoid even making the request to the server when he already knows it\u0027s going to fail.","accounts_in_message":[],"_revision_number":7},{"id":"4e03404b7416d52a125f4a68f19159cb8974512c","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-07-29 11:40:53.000000000","message":"Patch Set 7:\n\nAnd if the client has this protection, even older clouds without that server fix can benefit from it, since it\u0027s a lot easier for cloud users to update the clients than update the whole deployment.","accounts_in_message":[],"_revision_number":7},{"id":"34121a3f15ea6e7dd33b63ce9feb51acc589d279","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2015-08-13 23:10:47.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nThanks for the explanation, that makes sense for me. Thanks.","accounts_in_message":[],"_revision_number":7},{"id":"4629509f6040cb090a0df57035b0b594f09451e6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-13 23:10:52.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"28a9100bcb53f0ca41bef1d39e1b184405dc1a95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 00:08:13.000000000","message":"Patch Set 7: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/7/gate/gate-python-glanceclient-python26/f10a6e3/ : SUCCESS in 1m 47s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/7/gate/gate-python-glanceclient-docs/1bfc91f//doc/build/html/ : SUCCESS in 1m 39s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/7/gate/gate-python-glanceclient-pep8/9bc27f3/ : FAILURE in 2m 21s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/7/gate/gate-python-glanceclient-python27/95038f8/ : SUCCESS in 2m 34s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/7/gate/gate-python-glanceclient-python34/9b4b331/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/7/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/d444f2f/ : FAILURE in 56m 48s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/84/163584/7/gate/gate-glanceclient-dsvm-functional/fc0464f/ : SUCCESS in 21m 35s","accounts_in_message":[],"_revision_number":7},{"id":"1d28b688cc322e463508e3dd5388507794eb5252","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-08-14 08:00:28.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"14d3b74d435711530c256cef95ee39a520437187","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-08-14 08:00:54.000000000","message":"Patch Set 8: Code-Review+2 Workflow+1\n\nI just fixed the pep8 issue, re-approving as per previous approval","accounts_in_message":[],"_revision_number":8},{"id":"fdc992a26bc8035a6aa3eda0e72d50b169e4fa93","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-08-14 08:08:35.000000000","message":"Patch Set 8:\n\nThanks Flavio!","accounts_in_message":[],"_revision_number":8},{"id":"ada451b98cc4d55737d93a23112f38660344c328","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 08:52:45.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/8/check/gate-python-glanceclient-python26/aeed238/ : SUCCESS in 1m 54s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/8/check/gate-python-glanceclient-pep8/bd45388/ : SUCCESS in 1m 47s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/8/check/gate-python-glanceclient-docs/b2e430d//doc/build/html/ : SUCCESS in 1m 36s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/8/check/gate-python-glanceclient-python27/55f87d7/ : SUCCESS in 1m 48s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/8/check/gate-python-glanceclient-python34/8b545bf/ : SUCCESS in 2m 24s\n- gate-python-glanceclient-pypy http://logs.openstack.org/84/163584/8/check/gate-python-glanceclient-pypy/576622e/ : FAILURE in 1m 27s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/8/check/gate-tempest-dsvm-neutron-src-python-glanceclient/2720ca2/ : SUCCESS in 52m 09s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/84/163584/8/check/gate-glanceclient-dsvm-functional/605410d/ : SUCCESS in 22m 28s","accounts_in_message":[],"_revision_number":8},{"id":"2a82db095c3f81ad50532380d158ceb3715537bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 08:52:50.000000000","message":"Patch Set 8: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"c5b199f2bd29fd29e00a6fd3628b05cee1dc18aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 09:48:57.000000000","message":"Patch Set 8: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/84/163584/8/gate/gate-python-glanceclient-python26/6211bb8/ : SUCCESS in 1m 52s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/84/163584/8/gate/gate-python-glanceclient-docs/bf77812//doc/build/html/ : SUCCESS in 1m 50s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/84/163584/8/gate/gate-python-glanceclient-pep8/18e7e2c/ : SUCCESS in 1m 36s\n- gate-python-glanceclient-python27 http://logs.openstack.org/84/163584/8/gate/gate-python-glanceclient-python27/319c6f5/ : SUCCESS in 2m 41s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/163584/8/gate/gate-python-glanceclient-python34/931facd/ : SUCCESS in 2m 27s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/163584/8/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/222bca5/ : SUCCESS in 55m 55s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/84/163584/8/gate/gate-glanceclient-dsvm-functional/538e5c1/ : SUCCESS in 22m 30s","accounts_in_message":[],"_revision_number":8},{"id":"3cafa77e2c32a6076ed05b3b23797e939d5a5aa9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 09:48:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"8d118ccedc7e0544ec21e1fbb7f1b8b3a4f03715","revisions":{"b1797f979138639514bdc10f5117661317a36918":{"kind":"REWORK","_number":1,"created":"2015-03-11 19:36:51.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/84/163584/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/1"}}},"commit":{"parents":[{"commit":"23c8d1818aceaff55e50043ee5b8e1f445f9996e","subject":"Merge \"v2: read limit for list from --limit in shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/23c8d1818aceaff55e50043ee5b8e1f445f9996e"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-10 15:26:13.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-11 19:35:40.000000000","tz":60},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create, which means that the POST\nrequest is made with the whole image and error is reported by Glance\nAPI.\n\nThis post enforces presence of those arguments so we can get the error\nquicker and also avoid sending unnecessary data over the network.\n\nThere were 2 implementations options here:\n\n1) Breaking change in glanceclient command line making disk-format and\ncontainer-format positional arguments instead of optional arguments.\n\n2) Make them required options.\n\nRequired options are considered bad form, as options are expected to be\noptional, but in this case I believe the benefits of maintaining the same\ncommand line as before outweighs the bad form issue.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b1797f979138639514bdc10f5117661317a36918"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b1797f979138639514bdc10f5117661317a36918"}]},"branch":"refs/heads/master"},"dc379e93f8b91807e58cfa09c006147e707360af":{"kind":"REWORK","_number":2,"created":"2015-03-13 18:15:27.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/84/163584/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/2"}}},"commit":{"parents":[{"commit":"cc4c402f099304e2657347a5e33745de884157c3","subject":"Merge \"Fix leaking sockets after v1 list operation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cc4c402f099304e2657347a5e33745de884157c3"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 16:47:09.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 18:14:40.000000000","tz":60},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create when providing image data\n(with --file, --location, --locations, --copy-from), which means that\nthe POST request is made with the whole image and error is reported by\nGlance API.\n\nThis post enforces presence of those arguments when image data is\nprovided so we can get the error quicker and avoid sending unnecessary\ndata over the network.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dc379e93f8b91807e58cfa09c006147e707360af"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dc379e93f8b91807e58cfa09c006147e707360af"}]},"branch":"refs/heads/master"},"c90f6a49c5ab2b8f917c49f1006abea566ae3584":{"kind":"REWORK","_number":3,"created":"2015-03-15 12:43:54.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/84/163584/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/3"}}},"commit":{"parents":[{"commit":"cc4c402f099304e2657347a5e33745de884157c3","subject":"Merge \"Fix leaking sockets after v1 list operation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cc4c402f099304e2657347a5e33745de884157c3"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 16:47:09.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-15 12:43:16.000000000","tz":60},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create when providing image data\n(with --file, --location, --locations, --copy-from), which means that\nthe POST request is made with the whole image and error is reported by\nGlance API.\n\nThis post enforces presence of those arguments when image data is\nprovided so we can get the error quicker and avoid sending unnecessary\ndata over the network.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c90f6a49c5ab2b8f917c49f1006abea566ae3584"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c90f6a49c5ab2b8f917c49f1006abea566ae3584"}]},"branch":"refs/heads/master"},"d630dcaa31c7db55f06b63e3f65fcbf87aa96e40":{"kind":"REWORK","_number":4,"created":"2015-03-16 16:35:21.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/84/163584/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/4"}}},"commit":{"parents":[{"commit":"cc4c402f099304e2657347a5e33745de884157c3","subject":"Merge \"Fix leaking sockets after v1 list operation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cc4c402f099304e2657347a5e33745de884157c3"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 16:47:09.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-16 16:35:04.000000000","tz":60},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create when providing image data\n(with --file, --location, --locations, --copy-from), which means that\nthe POST request is made with the whole image and error is reported by\nGlance API.\n\nThis post enforces presence of those arguments when image data is\nprovided so we can get the error quicker and avoid sending unnecessary\ndata over the network.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d630dcaa31c7db55f06b63e3f65fcbf87aa96e40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d630dcaa31c7db55f06b63e3f65fcbf87aa96e40"}]},"branch":"refs/heads/master"},"9efc48443646115d9a5c17aeaee8cc9ebf5a2443":{"kind":"REWORK","_number":5,"created":"2015-03-16 19:32:35.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/84/163584/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/5"}}},"commit":{"parents":[{"commit":"cc4c402f099304e2657347a5e33745de884157c3","subject":"Merge \"Fix leaking sockets after v1 list operation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cc4c402f099304e2657347a5e33745de884157c3"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 16:47:09.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-16 19:32:22.000000000","tz":60},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create when providing image data\n(with --file, --location, --locations, --copy-from), which means that\nthe POST request is made with the whole image and error is reported by\nGlance API.\n\nThis post enforces presence of those arguments when image data is\nprovided so we can get the error quicker and avoid sending unnecessary\ndata over the network.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9efc48443646115d9a5c17aeaee8cc9ebf5a2443"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9efc48443646115d9a5c17aeaee8cc9ebf5a2443"}]},"branch":"refs/heads/master"},"e3dd86d8fc2aea6457a0df6efa021a046aa4a985":{"kind":"REWORK","_number":6,"created":"2015-04-28 17:35:59.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/84/163584/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/6"}}},"commit":{"parents":[{"commit":"d4d7fdc35422b0da1c08e68ab36f31071678105f","subject":"Merge \"Move unit tests to standard directory\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d4d7fdc35422b0da1c08e68ab36f31071678105f"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 16:47:09.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-04-28 17:35:18.000000000","tz":120},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create when providing image data\n(with --file, --location, --copy-from), which means that the POST\nrequest is made with the whole image and error is reported by Glance\nAPI.\n\nThis post enforces presence of those arguments when image data is\nprovided so we can get the error quicker and avoid sending unnecessary\ndata over the network.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e3dd86d8fc2aea6457a0df6efa021a046aa4a985"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e3dd86d8fc2aea6457a0df6efa021a046aa4a985"}]},"branch":"refs/heads/master"},"cb026ebbbe69d5d5c661c57398991d52981e38b1":{"kind":"REWORK","_number":7,"created":"2015-05-21 15:43:02.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/84/163584/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/7"}}},"commit":{"parents":[{"commit":"d4d7fdc35422b0da1c08e68ab36f31071678105f","subject":"Merge \"Move unit tests to standard directory\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d4d7fdc35422b0da1c08e68ab36f31071678105f"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 16:47:09.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-05-21 15:42:56.000000000","tz":120},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create when providing image data\n(with --file, --location, --copy-from), which means that the POST\nrequest is made with the whole image and error is reported by Glance\nAPI.\n\nThis post enforces presence of those arguments when image data is\nprovided so we can get the error quicker and avoid sending unnecessary\ndata over the network.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cb026ebbbe69d5d5c661c57398991d52981e38b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cb026ebbbe69d5d5c661c57398991d52981e38b1"}]},"branch":"refs/heads/master"},"8d118ccedc7e0544ec21e1fbb7f1b8b3a4f03715":{"kind":"REWORK","_number":8,"created":"2015-08-14 08:00:28.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/84/163584/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/163584/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/163584/8"}}},"commit":{"parents":[{"commit":"13af69039671d842167cb66e25b0dfbd1ce89724","subject":"Merge \"Use API v2 as default\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/13af69039671d842167cb66e25b0dfbd1ce89724"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-13 16:47:09.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2015-08-14 07:59:17.000000000","tz":120},"subject":"Require disk and container format on image-create","message":"Require disk and container format on image-create\n\nCurrently glanceclient doesn\u0027t enforce disk-format or container-format\npresence in the command line on image-create when providing image data\n(with --file, --location, --copy-from), which means that the POST\nrequest is made with the whole image and error is reported by Glance\nAPI.\n\nThis post enforces presence of those arguments when image data is\nprovided so we can get the error quicker and avoid sending unnecessary\ndata over the network.\n\nChange-Id: I5914fa9cfef190a028b374005adbf3a804b1b677\nCloses-Bug: #1309272\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8d118ccedc7e0544ec21e1fbb7f1b8b3a4f03715"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8d118ccedc7e0544ec21e1fbb7f1b8b3a4f03715"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}