)]}'
{"glanceclient/tests/unit/v2/test_tasks.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"38a1780facc6085c87cbe260854cf8b337772b13","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            {},"},{"line_number":177,"context_line":"            {\u0027tasks\u0027: ["},{"line_number":178,"context_line":"                {"},{"line_number":179,"context_line":"                    \u0027id\u0027: \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027,"},{"line_number":180,"context_line":"                    \u0027type\u0027: \u0027import\u0027,"},{"line_number":181,"context_line":"                    \u0027status\u0027: \u0027pending\u0027,"},{"line_number":182,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_f9a03ca1","line":179,"updated":"2015-05-17 23:19:02.000000000","message":"Should we turn these IDs into global constants?","commit_id":"3a29efe0942eeb30796a67a0865e810e0f4edf13"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"575f97384cce1b913ff6b218122ebd3355c7bbe9","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            {},"},{"line_number":177,"context_line":"            {\u0027tasks\u0027: ["},{"line_number":178,"context_line":"                {"},{"line_number":179,"context_line":"                    \u0027id\u0027: \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027,"},{"line_number":180,"context_line":"                    \u0027type\u0027: \u0027import\u0027,"},{"line_number":181,"context_line":"                    \u0027status\u0027: \u0027pending\u0027,"},{"line_number":182,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_a3bde669","line":179,"in_reply_to":"7a016987_f9a03ca1","updated":"2015-05-18 11:28:59.000000000","message":"Can\u0027t agree more with you Ian! I\u0027ve had to update other occurrences to make the file consistent.","commit_id":"3a29efe0942eeb30796a67a0865e810e0f4edf13"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"38a1780facc6085c87cbe260854cf8b337772b13","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        self.assertEqual(b\"ni\\xc3\\xb1o\", filters[\"owner\"])"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def test_list_tasks_with_marker(self):"},{"line_number":317,"context_line":"        marker \u003d \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027"},{"line_number":318,"context_line":"        tasks \u003d list(self.controller.list(marker\u003dmarker, page_size\u003d1))"},{"line_number":319,"context_line":"        self.assertEqual(1, len(tasks))"},{"line_number":320,"context_line":"        self.assertEqual(\u00276f99bf80-2ee6-47cf-acfe-1f1fabb7e810\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_d99b4071","line":317,"updated":"2015-05-17 23:19:02.000000000","message":"Especially, since we\u0027re using them here, I\u0027d rather these be constants than strings that are copied and pasted around as necessary.","commit_id":"3a29efe0942eeb30796a67a0865e810e0f4edf13"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"acc6b3ccec9e59bc1d24ef278e8848860ef2d029","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.assertRaises(ValueError,"},{"line_number":336,"context_line":"                          list,"},{"line_number":337,"context_line":"                          self.controller.list(sort_key\u003dsort_key))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def test_list_tasks_with_desc_sort_dir(self):"},{"line_number":340,"context_line":"        task_id \u003d _PENDING_ID"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_546f0ac5","line":337,"updated":"2015-05-18 12:51:04.000000000","message":"Nit: self.controller.list(sort_key\u003d\u0027invalid\u0027) saves one line","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"756fac82dd32178bcb41ee0872a1c9e9b1adb3f6","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.assertRaises(ValueError,"},{"line_number":336,"context_line":"                          list,"},{"line_number":337,"context_line":"                          self.controller.list(sort_key\u003dsort_key))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def test_list_tasks_with_desc_sort_dir(self):"},{"line_number":340,"context_line":"        task_id \u003d _PENDING_ID"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_d091b4f2","line":337,"in_reply_to":"7a016987_546f0ac5","updated":"2015-05-19 09:30:33.000000000","message":"Done","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"acc6b3ccec9e59bc1d24ef278e8848860ef2d029","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        task_id \u003d _PENDING_ID"},{"line_number":341,"context_line":"        sort_key \u003d \u0027id\u0027"},{"line_number":342,"context_line":"        sort_dir \u003d \u0027desc\u0027"},{"line_number":343,"context_line":"        tasks \u003d list(self.controller.list(sort_key\u003dsort_key,"},{"line_number":344,"context_line":"                                          sort_dir\u003dsort_dir))"},{"line_number":345,"context_line":"        self.assertEqual(2, len(tasks))"},{"line_number":346,"context_line":"        self.assertEqual(task_id, tasks[1].id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_b4307ee9","line":343,"updated":"2015-05-18 12:51:04.000000000","message":"Nit: I\u0027d omit predeclaration of sort_key and sort_dir and use the values directly, as long as they are not needed anywhere else.\n\nself.controller.list(sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027desc\u0027)","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"756fac82dd32178bcb41ee0872a1c9e9b1adb3f6","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        task_id \u003d _PENDING_ID"},{"line_number":341,"context_line":"        sort_key \u003d \u0027id\u0027"},{"line_number":342,"context_line":"        sort_dir \u003d \u0027desc\u0027"},{"line_number":343,"context_line":"        tasks \u003d list(self.controller.list(sort_key\u003dsort_key,"},{"line_number":344,"context_line":"                                          sort_dir\u003dsort_dir))"},{"line_number":345,"context_line":"        self.assertEqual(2, len(tasks))"},{"line_number":346,"context_line":"        self.assertEqual(task_id, tasks[1].id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_904c5c9f","line":343,"in_reply_to":"7a016987_b4307ee9","updated":"2015-05-19 09:30:33.000000000","message":"Good catch! Done :)","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"acc6b3ccec9e59bc1d24ef278e8848860ef2d029","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        sort_key \u003d \u0027id\u0027"},{"line_number":351,"context_line":"        sort_dir \u003d \u0027asc\u0027"},{"line_number":352,"context_line":"        tasks \u003d list(self.controller.list(sort_key\u003dsort_key,"},{"line_number":353,"context_line":"                                          sort_dir\u003dsort_dir))"},{"line_number":354,"context_line":"        self.assertEqual(2, len(tasks))"},{"line_number":355,"context_line":"        self.assertEqual(task_id, tasks[0].id)"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_340dae37","line":353,"updated":"2015-05-18 12:51:04.000000000","message":"Nit: Same thing here\n\nself.controller.list(sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027)","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"756fac82dd32178bcb41ee0872a1c9e9b1adb3f6","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        sort_key \u003d \u0027id\u0027"},{"line_number":351,"context_line":"        sort_dir \u003d \u0027asc\u0027"},{"line_number":352,"context_line":"        tasks \u003d list(self.controller.list(sort_key\u003dsort_key,"},{"line_number":353,"context_line":"                                          sort_dir\u003dsort_dir))"},{"line_number":354,"context_line":"        self.assertEqual(2, len(tasks))"},{"line_number":355,"context_line":"        self.assertEqual(task_id, tasks[0].id)"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_b08e38ce","line":353,"in_reply_to":"7a016987_340dae37","updated":"2015-05-19 09:30:33.000000000","message":"Done","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"acc6b3ccec9e59bc1d24ef278e8848860ef2d029","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        self.assertEqual(task_id, tasks[0].id)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_list_tasks_with_invalid_sort_dir(self):"},{"line_number":358,"context_line":"        sort_dir \u003d \u0027invalid\u0027"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        self.assertRaises(ValueError,"},{"line_number":361,"context_line":"                          list,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_54214a9e","line":358,"updated":"2015-05-18 12:51:04.000000000","message":"Nit: And here","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"756fac82dd32178bcb41ee0872a1c9e9b1adb3f6","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        self.assertEqual(task_id, tasks[0].id)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_list_tasks_with_invalid_sort_dir(self):"},{"line_number":358,"context_line":"        sort_dir \u003d \u0027invalid\u0027"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        self.assertRaises(ValueError,"},{"line_number":361,"context_line":"                          list,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_90be9c63","line":358,"in_reply_to":"7a016987_54214a9e","updated":"2015-05-19 09:30:33.000000000","message":"Done","commit_id":"7de7f2f8b9f7d1b222e67bb0e08e8b34192f29ff"}]}