)]}'
{"id":"openstack%2Fpython-glanceclient~165770","triplet_id":"openstack%2Fpython-glanceclient~master~I9871ee42b1b4572b7e5de9fc912d96ae6996b875","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1434040","hashtags":[],"change_id":"I9871ee42b1b4572b7e5de9fc912d96ae6996b875","subject":"Integrity check for images with checksum \u003d \"None\"","status":"ABANDONED","created":"2015-03-19 10:53:22.000000000","updated":"2015-11-23 11:02:22.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f5e34d5f10f0be7e9150d181ff67f555b40bf445","_number":165770,"virtual_id_number":165770,"owner":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":-1,"date":"2015-04-09 16:01:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"date":"2015-04-09 15:02:15.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"date":"2015-04-09 14:47:16.000000000","_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},{"date":"2015-06-01 11:45:36.000000000","_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"disliked":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"all":[{"value":-1,"date":"2015-05-17 23:19:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-10-16 08:01:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":-2,"date":"2015-04-14 10:29:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"date":"2015-06-17 15:26:30.000000000","_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},{"_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},{"_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-19 11:03:41.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2015-04-02 15:18:56.000000000","updated_by":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"reviewer":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"state":"REVIEWER"},{"updated":"2015-04-05 17:37:37.000000000","updated_by":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"reviewer":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"state":"REVIEWER"},{"updated":"2015-04-09 15:02:15.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2015-04-09 16:01:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-05-17 23:19:03.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-06-01 11:45:36.000000000","updated_by":{"_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},"reviewer":{"_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},"state":"REVIEWER"},{"updated":"2015-06-17 15:26:30.000000000","updated_by":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"reviewer":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"state":"REVIEWER"},{"updated":"2015-10-16 08:01:26.000000000","updated_by":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"reviewer":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"state":"REVIEWER"}],"messages":[{"id":"f17ea94d2534883dd4d317001353f45146b92ae8","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-03-19 10:53:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d022f98858d301c2dad3096f5f63c76760f9d0da","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2015-03-19 11:03:41.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Ruediger,\n\nHave you reported any bug for this in launchpad?\nIf yes then add closes-bug tag in commit message else report this issue in launchpad and add the tag in commit message.\n\nIt will help to track what bugs were fixed in the release.","accounts_in_message":[],"_revision_number":1},{"id":"1e61e79d3000c3eef396117ce5a7f22ea3c58f38","author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"date":"2015-03-19 11:15:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e5ed7bdaabda8a199e2904db277ad13faea0cd85","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-03-19 11:43:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b6e26ca40478057b02e8f0427b2a08697ea498ce","author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"date":"2015-03-19 12:17:53.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)\n\nLooks good, but room for improvement - see in-line comments.","accounts_in_message":[],"_revision_number":2},{"id":"3cd6bd4e7887639c564a2ae5834aef9fb6d51555","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-19 13:37:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/70/165770/2/check/gate-python-glanceclient-python26/cad88d0/ : SUCCESS in 1m 38s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/70/165770/2/check/gate-python-glanceclient-pep8/c5ecb8d/ : SUCCESS in 1m 05s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/70/165770/2/check/gate-python-glanceclient-docs/bd39cb8//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-python27 http://logs.openstack.org/70/165770/2/check/gate-python-glanceclient-python27/3dd92e2/ : SUCCESS in 1m 17s\n- gate-python-glanceclient-python34 http://logs.openstack.org/70/165770/2/check/gate-python-glanceclient-python34/565623f/ : SUCCESS in 2m 33s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/70/165770/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/cb17a7a/ : SUCCESS in 46m 41s\n- gate-python-glanceclient-pypy http://logs.openstack.org/70/165770/2/check/gate-python-glanceclient-pypy/82e831e/ : SUCCESS in 3m 09s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/70/165770/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/834dc92/ : SUCCESS in 49m 30s","accounts_in_message":[],"_revision_number":2},{"id":"2678901f4ed1ed55835db47c2c95a5021e5a7a85","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-03-19 15:42:23.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cb1148f7f99fbd81a980e81c003d670b4e1603e2","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2015-04-02 02:57:41.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nPlease adjust the commit message to fit expected line length.","accounts_in_message":[],"_revision_number":2},{"id":"dba6e72060e8ca07698b6ac29d64f87315f3a81f","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-04-02 06:00:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ef60af64a773a6d1489522b30d9f9d31fcae58fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-02 07:00:48.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/70/165770/3/check/gate-python-glanceclient-python26/9ab351a/ : SUCCESS in 1m 14s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/70/165770/3/check/gate-python-glanceclient-pep8/584b346/ : SUCCESS in 1m 25s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/70/165770/3/check/gate-python-glanceclient-docs/c43fd68//doc/build/html/ : SUCCESS in 1m 19s\n- gate-python-glanceclient-python27 http://logs.openstack.org/70/165770/3/check/gate-python-glanceclient-python27/1725eee/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-python34 http://logs.openstack.org/70/165770/3/check/gate-python-glanceclient-python34/45bd0be/ : SUCCESS in 3m 02s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/70/165770/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/cd2a75f/ : SUCCESS in 54m 30s\n- gate-python-glanceclient-pypy http://logs.openstack.org/70/165770/3/check/gate-python-glanceclient-pypy/98843dd/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/70/165770/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/ef0194a/ : SUCCESS in 59m 53s","accounts_in_message":[],"_revision_number":3},{"id":"2dc8e4d60d911f933a3e6e3d7ce16774d7cedc01","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2015-04-02 15:18:56.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"83b90e8338ff37aaed36a71f1e7d1691f8edceea","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-04-02 16:39:56.000000000","message":"Patch Set 3: Code-Review-1\n\nWhy bother calculating a checksum if we\u0027re not going to use it?\n\nIn  glanceclient/v2/images.py and glanceclient/v1/images.py we use logic of this form:\n\n      if do_checksum and checksum is not None:\n            body \u003d utils.integrity_iter(body, checksum)\n\nis the issue here that checksum is the string \u0027None\u0027 rather than the pythonic None?\nIf so we should update both images.py to check for \u0027None\u0027 also. This saves computing the checksum.","accounts_in_message":[],"_revision_number":3},{"id":"3c822b0c65735fcda08a0dad98c4edd8a890965d","author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"date":"2015-04-05 17:37:37.000000000","message":"Patch Set 3: Code-Review-1\n\nAgree with Stuart\u0027s suggestion to fix the test in the callers.","accounts_in_message":[],"_revision_number":3},{"id":"798de119e416cb8c593cce2faa93ffd197c6f625","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-04-09 14:31:12.000000000","message":"Patch Set 3:\n\nOK, I just tested this change\n\nif md5sum !\u003d checksum and checksum is not None:\n\nand the integrity check fails again.","accounts_in_message":[],"_revision_number":3},{"id":"d71dc158b6d816aaa744b247c5e54e108e806f9c","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-04-09 14:44:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0b358b862b2b285b271a46d663b0299863f1b84e","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-04-09 14:47:16.000000000","message":"Patch Set 4:\n\nThats a better place to fix it. Thanks Stuart\n\nOK, now I am checking for the string before we calculate the checksum.","accounts_in_message":[],"_revision_number":4},{"id":"9c73ebe7270624e034d8b56cf4708290ffe67b02","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-04-09 15:02:15.000000000","message":"Patch Set 4:\n\nThanks Ruediger.\n\nWould it be possible to add unit tests for this (something similar to the existing test_data_with_wrong_checksum)?\n\n(If not let me know and I\u0027ll create them for you.)","accounts_in_message":[],"_revision_number":4},{"id":"189259500a0473b6c70eac1fea2db17975b2e986","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-09 16:01:27.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-python26/b712b65/ : SUCCESS in 1m 22s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-pep8/65fc713/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/70/165770/4/check/gate-python-glanceclient-docs/b583aab//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-python27 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-python27/6dc424e/ : SUCCESS in 1m 19s\n- gate-python-glanceclient-python34 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-python34/7e94cca/ : SUCCESS in 2m 46s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/70/165770/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/caf4dc6/ : FAILURE in 15m 24s\n- gate-python-glanceclient-pypy http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-pypy/25e245e/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/70/165770/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient/ef4f66f/ : SUCCESS in 52m 45s","accounts_in_message":[],"_revision_number":4},{"id":"e51822028f3f6e14997d22e0789f1e4c4cbc222f","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-04-09 19:01:42.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"5e165b5d0608e3a58056b63eca3a1f30d931f9b1","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-04-09 19:17:11.000000000","message":"Patch Set 4:\n\nStuart if you could write the test that would be great.","accounts_in_message":[],"_revision_number":4},{"id":"e133f744a66fce99174d9999b3c5507a2fa9832a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-09 20:07:11.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-python26/86897bb/ : SUCCESS in 1m 23s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-pep8/649c2b0/ : SUCCESS in 1m 23s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/70/165770/4/check/gate-python-glanceclient-docs/d1f3fe4//doc/build/html/ : SUCCESS in 1m 30s\n- gate-python-glanceclient-python27 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-python27/9f0d082/ : SUCCESS in 1m 38s\n- gate-python-glanceclient-python34 http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-python34/cd9b0d6/ : SUCCESS in 3m 14s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-juno http://logs.openstack.org/70/165770/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient-juno/12a879e/ : FAILURE in 13m 54s\n- gate-python-glanceclient-pypy http://logs.openstack.org/70/165770/4/check/gate-python-glanceclient-pypy/7632abd/ : SUCCESS in 2m 04s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/70/165770/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient/d9396ab/ : SUCCESS in 49m 29s","accounts_in_message":[],"_revision_number":4},{"id":"34032b93e54b1979ce2b2f7a941c64ca6f4936cb","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-04-10 09:33:04.000000000","message":"Patch Set 4: Code-Review-1\n\n-1 based on the need for test cases.\n\nBut also, I haven\u0027t been able to reproduce this in devstack. I want to be absolutely sure that this isn\u0027t a quirk in the way cinder is using the glance client. I\u0027ll update the bug report.","accounts_in_message":[],"_revision_number":4},{"id":"9347dbaab0777ab639a8c3ee6696a1ded68ada53","author":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"date":"2015-04-10 10:08:45.000000000","message":"Patch Set 4:\n\nI think the root cause for this bug is somewhere in cinder.\nThe checksum should never be the string \"None\", right? \nEither it is a checksum value or None (undefined).\n\nHowever it might be a good idea to have an additional check here as well.","accounts_in_message":[],"_revision_number":4},{"id":"55b67b18c01437b7da3236d40195e23fb9feb4e4","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-04-14 10:29:01.000000000","message":"Patch Set 4: Code-Review-2\n\nI\u0027m going to mark this with \u0027do not merge\u0027 for now.\n\nI haven\u0027t been able to reproduce the issue with the latest code base.\n\nI think it\u0027s a small bit simpler/cleaner if the download checksum semantics are \u0027always verify the checksum if it is present\u0027.","accounts_in_message":[],"_revision_number":4},{"id":"46cdad1cfdedb6b7e519f76b8e9c5bdbafbe35ca","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-05-17 23:19:03.000000000","message":"Patch Set 4: Code-Review-1\n\nI don\u0027t have access to it at the moment, but is cinder doing something like\n\n    checksum \u003d str(image.checksum)\n\nIf so, note that \n\n    str(None) \u003d\u003d \u0027None\u0027\n\nWhich means that could be how cinder is seeing this problem. That said, Stuart\u0027s sluething skills are legendary and if he can\u0027t reproduce this, I\u0027m not certain it\u0027s a patch we still need.","accounts_in_message":[],"_revision_number":4},{"id":"0065b964c93f4db7c1051e812b08be79939701b5","author":{"_account_id":16619,"name":"Alvar Vilu","email":"alvar.vilu@gmail.com","username":"Alvar"},"date":"2015-06-01 11:45:36.000000000","message":"Patch Set 4:\n\nThat fix works.\nInstalled environment is ubuntu 14.04 with multible glance backends and witout that fix it did not work.","accounts_in_message":[],"_revision_number":4},{"id":"92f3f8c881d1ba4f75faee698d501c59e13e9164","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-10-16 08:01:26.000000000","message":"Patch Set 4: Code-Review-1\n\nThis patch has been -1ed because it has not been updated in\n\u003e\u003d2months. The patch also has either a -1/-2 from a core reviewer or a\n-1 from Jenkins.\n\nPlease, update/rebase the patch if the lack of updates was actually a\nlack of reviews or if you think the patch is still relevant.\n\n**NOTE: This will be abandoned if no update is done in 1 week.**\n\nIf this action does not seem accurate, please, ping flaper87 on IRC\nand he will gladly revert it. Sorry for the inconvenience and we look\nforward to have more contributions from you.","accounts_in_message":[],"_revision_number":4},{"id":"9c1e63cd034b3389fbdc43349fe1dcbfcf962d9e","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-11-23 11:02:22.000000000","message":"Patch Set 4:\n\nThis patch was marked to be abanadoned \u003e\u003d7days ago.\n\nIt is now being abandoned because there was no update, feedback nor rebase in the aforementioned period. If this is a mistake, please, contact members of the glance team[0] and they\u0027ll promptly correct the error.\n\nThanks for your contribution. The Glance team looks forward to new contributions from you.","accounts_in_message":[],"_revision_number":4},{"id":"28f96d2913cd202834feab9e64bf161d28d423db","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-11-23 11:02:22.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2b3150969a95d50c37ce25d86c63476dffc66779","revisions":{"47071284f7af695c56ccbcf3fcd75f8b97956954":{"kind":"REWORK","_number":1,"created":"2015-03-19 10:53:22.000000000","uploader":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"ref":"refs/changes/70/165770/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/165770/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/1"}}},"commit":{"parents":[{"commit":"3a69231f4f1fea29735f120fd1c50cf104c37ff4","subject":"Merge \"Updated help for v2 member-update api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3a69231f4f1fea29735f120fd1c50cf104c37ff4"}]}],"author":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-03-19 10:52:00.000000000","tz":60},"committer":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-03-19 10:53:20.000000000","tz":60},"subject":"Integrity check for images with checksum \u003d \"None\"","message":"Integrity check for images with checksum \u003d \"None\"\n\nImages on \"External sources\" have checksum \u003d \"None\" in the glance db.\nThese images could be uploaded for example with:\nglance image-create --name test-image --location\u003dhttp://some.location.com/image.raw ...\n\nTrying to start an instance with \"boot from image (creates volume)\"\nfails with \"Checksum was xxxxxx expected None\"\n\nThis change will fix this error.\n\nChange-Id: I9871ee42b1b4572b7e5de9fc912d96ae6996b875\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/47071284f7af695c56ccbcf3fcd75f8b97956954"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/47071284f7af695c56ccbcf3fcd75f8b97956954"}]},"branch":"refs/heads/master"},"be916006409a74e601bd0180868cfe2ffbc8343d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-03-19 11:43:03.000000000","uploader":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"ref":"refs/changes/70/165770/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/165770/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/2"}}},"commit":{"parents":[{"commit":"3a69231f4f1fea29735f120fd1c50cf104c37ff4","subject":"Merge \"Updated help for v2 member-update api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3a69231f4f1fea29735f120fd1c50cf104c37ff4"}]}],"author":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-03-19 10:52:00.000000000","tz":60},"committer":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-03-19 11:42:31.000000000","tz":60},"subject":"Integrity check for images with checksum \u003d \"None\"","message":"Integrity check for images with checksum \u003d \"None\"\n\nImages on \"External sources\" have checksum \u003d \"None\" in the glance db.\nThese images could be uploaded for example with:\nglance image-create --name test-image --location\u003dhttp://some.location.com/image.raw ...\n\nTrying to start an instance with \"boot from image (creates volume)\"\nfails with \"Checksum was xxxxxx expected None\"\n\nThis change will fix this error.\n\nCloses-Bug: 1434040\nChange-Id: I9871ee42b1b4572b7e5de9fc912d96ae6996b875\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/be916006409a74e601bd0180868cfe2ffbc8343d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/be916006409a74e601bd0180868cfe2ffbc8343d"}]},"branch":"refs/heads/master"},"c27593ec93f44698868b73f5702232ba4cac54b0":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-04-02 06:00:44.000000000","uploader":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"ref":"refs/changes/70/165770/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/165770/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/3"}}},"commit":{"parents":[{"commit":"3a69231f4f1fea29735f120fd1c50cf104c37ff4","subject":"Merge \"Updated help for v2 member-update api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3a69231f4f1fea29735f120fd1c50cf104c37ff4"}]}],"author":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-03-19 10:52:00.000000000","tz":60},"committer":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-04-02 06:00:03.000000000","tz":120},"subject":"Integrity check for images with checksum \u003d \"None\"","message":"Integrity check for images with checksum \u003d \"None\"\n\nImages on \"External sources\" have checksum \u003d \"None\" in the glance db.\nThese images could be uploaded for example with:\nglance image-create --name test-image\n               --location\u003dhttp://some.location.com/image.raw ...\n\nTrying to start an instance with \"boot from image (creates volume)\"\nfails with \"Checksum was xxxxxx expected None\"\n\nThis change will fix this error.\n\nCloses-Bug: 1434040\nChange-Id: I9871ee42b1b4572b7e5de9fc912d96ae6996b875\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c27593ec93f44698868b73f5702232ba4cac54b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c27593ec93f44698868b73f5702232ba4cac54b0"}]},"branch":"refs/heads/master"},"2b3150969a95d50c37ce25d86c63476dffc66779":{"kind":"REWORK","_number":4,"created":"2015-04-09 14:44:36.000000000","uploader":{"_account_id":9657,"name":"Ruediger Rissmann","email":"ruediger@rissmann.ch","username":"ruediger.rissmann"},"ref":"refs/changes/70/165770/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/165770/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/165770/4"}}},"commit":{"parents":[{"commit":"3a69231f4f1fea29735f120fd1c50cf104c37ff4","subject":"Merge \"Updated help for v2 member-update api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3a69231f4f1fea29735f120fd1c50cf104c37ff4"}]}],"author":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-03-19 10:52:00.000000000","tz":60},"committer":{"name":"Ruediger Rissmann","email":"ruediger.rissmann@switch.ch","date":"2015-04-09 14:44:19.000000000","tz":120},"subject":"Integrity check for images with checksum \u003d \"None\"","message":"Integrity check for images with checksum \u003d \"None\"\n\nImages on \"External sources\" have checksum \u003d \"None\" in the glance db.\nThese images could be uploaded for example with:\nglance image-create --name test-image\n               --location\u003dhttp://some.location.com/image.raw ...\n\nTrying to start an instance with \"boot from image (creates volume)\"\nfails with \"Checksum was xxxxxx expected None\"\n\nThis change will fix this error.\n\nCloses-Bug: 1434040\nChange-Id: I9871ee42b1b4572b7e5de9fc912d96ae6996b875\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2b3150969a95d50c37ce25d86c63476dffc66779"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2b3150969a95d50c37ce25d86c63476dffc66779"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}