)]}'
{"glanceclient/v2/schemas.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"44bee101cacac1ac01a3c37a9bbd305e314b00eb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        return self._check_property(property_name, False)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _check_property(self, property_name, allow_non_base):"},{"line_number":108,"context_line":"        for prop in self.properties:"},{"line_number":109,"context_line":"            if property_name \u003d\u003d prop.name:"},{"line_number":110,"context_line":"                return prop.is_base or allow_non_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_ac3be5ea","line":107,"updated":"2015-03-27 15:16:22.000000000","message":"1. self is not used, so can be used as static method.\n\n2. allow_non_base \u003e\u003e is_core_property\u003dFalse","commit_id":"62b91e2c63385e7dee92b4fac8ed6ee40016fefc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e76be4702f35fe527f420915d09d44b1baf75e28","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        return self._check_property(property_name, False)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _check_property(self, property_name, allow_non_base):"},{"line_number":108,"context_line":"        for prop in self.properties:"},{"line_number":109,"context_line":"            if property_name \u003d\u003d prop.name:"},{"line_number":110,"context_line":"                return prop.is_base or allow_non_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_efe9df1b","line":107,"in_reply_to":"fa963961_ac3be5ea","updated":"2015-03-27 15:20:18.000000000","message":"sorry, first comment is invalid","commit_id":"62b91e2c63385e7dee92b4fac8ed6ee40016fefc"}],"tests/v2/test_schemas.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"0ccbcc37adf35614e5372d59e87c8fe9d106caa8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_property_is_base(self):"},{"line_number":105,"context_line":"        raw_schema \u003d {\u0027name\u0027: \u0027Country\u0027,"},{"line_number":106,"context_line":"                      \u0027properties\u0027:"},{"line_number":107,"context_line":"                          {\u0027size\u0027: {},"},{"line_number":108,"context_line":"                           \u0027population\u0027: {\u0027is_base\u0027: False}}}"},{"line_number":109,"context_line":"        schema \u003d schemas.Schema(raw_schema)"},{"line_number":110,"context_line":"        self.assertTrue(schema.is_base_property(\u0027size\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_75424040","line":107,"updated":"2015-03-27 16:01:33.000000000","message":"pep8 issue here :(","commit_id":"9b1f15267cf86b50946a13bb87d378fb63148e5d"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"42e988931407da53e86321aec841a5d8cebb71a0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_property_is_base(self):"},{"line_number":105,"context_line":"        raw_schema \u003d {\u0027name\u0027: \u0027Country\u0027,"},{"line_number":106,"context_line":"                      \u0027properties\u0027:"},{"line_number":107,"context_line":"                          {\u0027size\u0027: {},"},{"line_number":108,"context_line":"                           \u0027population\u0027: {\u0027is_base\u0027: False}}}"},{"line_number":109,"context_line":"        schema \u003d schemas.Schema(raw_schema)"},{"line_number":110,"context_line":"        self.assertTrue(schema.is_base_property(\u0027size\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_35ba7824","line":107,"in_reply_to":"fa963961_75424040","updated":"2015-03-27 16:04:01.000000000","message":"Thanks, fixed.","commit_id":"9b1f15267cf86b50946a13bb87d378fb63148e5d"}]}