)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"40b0073068cba49a855ce16c127251874c2001eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add task-upload command for uploading images in v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are several complicated steps involved with uploading an image"},{"line_number":10,"context_line":"successfully in the glance v2 API. Provide an all-in-one command that"},{"line_number":11,"context_line":"does these steps, with an optional \"--poll\" options modeled after the"},{"line_number":12,"context_line":"nova --poll options which will poll the task status and ultimately print"},{"line_number":13,"context_line":"the image dict."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aaa499b_e773257f","line":10,"updated":"2015-04-14 10:12:45.000000000","message":"Hi Monty,\n\n \"There are several complicated steps involved with uploading an image successfully in the glance v2 API.\"\n\nI don\u0027t fully understand this. The semantics for image upload are pretty much the same for v2 as v1:\n\nv1:\n $ glance --os-image-api-version 1 image-create --file /some/path --disk-format raw --container-format bare\n\nv2:\n $ glance --os-image-api-version 2 image-create --file /some/path --disk-format raw --container-format bare\n\nAre we really talking about \u0027image import\u0027?","commit_id":"4a913731dc62cb698d630615d98c4d064068f93e"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"40b0073068cba49a855ce16c127251874c2001eb","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change adds python-swiftclient as a hard dependency, because even"},{"line_number":16,"context_line":"if a user does not want to use the task-upload command, swiftclient _IS_"},{"line_number":17,"context_line":"a hard dependency for anyone who wants to upload an image with v2."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifd2fb913284a56684a4ed3611f743e5ad0645137"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aaa499b_478c1935","line":17,"updated":"2015-04-14 10:12:45.000000000","message":"\u0027swiftclient _IS_ a hard dependency for anyone who wants to upload an image with v2.\u0027\n\nCan you clarify? Again I don\u0027t see why v2 is different from v1 for regular image upload, so I\u0027m not sure why swiftclient would be a dependency. (Again, are  we really talking about \u0027image import\u0027 here?)\n\nThe difference between import and upload is that:\n\nupload: comes from a trusted source (eg a nova snapshot, or someone who has been assigned the image upload role -- eg someone that up uploads partner images, or maybe the openstack infra team), and the bits go straight to the Glance api. No check is run on the image before it is marked active.\n\nimport: when a unprivileged user wants to import an image into, eg a public cloud, and the deployer wants to automatically run some in-house script (for validity or security reasons) against the bits before marking the image as active.","commit_id":"4a913731dc62cb698d630615d98c4d064068f93e"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"40b0073068cba49a855ce16c127251874c2001eb","unresolved":false,"context_lines":[{"line_number":841,"context_line":"           help\u003d\u0027Show upload progress bar.\u0027)"},{"line_number":842,"context_line":"@utils.arg(\u0027--poll\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":843,"context_line":"           help\u003d\u0027Poll for task completion.\u0027)"},{"line_number":844,"context_line":"def do_task_upload(gc, args):"},{"line_number":845,"context_line":"    \"\"\"Create a new image upload task.\"\"\""},{"line_number":846,"context_line":"    schema \u003d gc.schemas.get(\"image\")"},{"line_number":847,"context_line":"    _args \u003d [(x[0].replace(\u0027-\u0027, \u0027_\u0027), x[1]) for x in vars(args).items()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_471c1977","line":844,"updated":"2015-04-14 10:12:45.000000000","message":"upload-\u003eimport?","commit_id":"4a913731dc62cb698d630615d98c4d064068f93e"}]}