)]}'
{"glanceclient/shell.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"f7f04954afd4637099ec1d4746da08ef585d92cc","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        if not os.path.exists(homedir):"},{"line_number":559,"context_line":"            try:"},{"line_number":560,"context_line":"                os.makedirs(homedir)"},{"line_number":561,"context_line":"            except Exception:"},{"line_number":562,"context_line":"                # This avoids glanceclient to crash if it can\u0027t write to"},{"line_number":563,"context_line":"                # ~/.glanceclient, which may happen on some env (for me,"},{"line_number":564,"context_line":"                # it happens in Jenkins, as Glanceclient can\u0027t write to"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a0c5dc1_b0e6bee6","line":561,"updated":"2015-05-12 03:31:59.000000000","message":"Shouldn\u0027t this be more specific, such as an OSError?","commit_id":"6d75e0e38cbd990878faecc8bf9484fd55023428"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"85b167dde0e32dc97b3e89b3e149ef3b4dd5add7","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        if not os.path.exists(homedir):"},{"line_number":559,"context_line":"            try:"},{"line_number":560,"context_line":"                os.makedirs(homedir)"},{"line_number":561,"context_line":"            except Exception:"},{"line_number":562,"context_line":"                # This avoids glanceclient to crash if it can\u0027t write to"},{"line_number":563,"context_line":"                # ~/.glanceclient, which may happen on some env (for me,"},{"line_number":564,"context_line":"                # it happens in Jenkins, as Glanceclient can\u0027t write to"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_40db321c","line":561,"in_reply_to":"9a0c5dc1_b0e6bee6","updated":"2015-05-14 04:12:46.000000000","message":"It would be better to Log.warning()/print an appropriate message here.","commit_id":"6d75e0e38cbd990878faecc8bf9484fd55023428"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"85b167dde0e32dc97b3e89b3e149ef3b4dd5add7","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                # ~/.glanceclient, which may happen on some env (for me,"},{"line_number":564,"context_line":"                # it happens in Jenkins, as Glanceclient can\u0027t write to"},{"line_number":565,"context_line":"                # /var/lib/jenkins)."},{"line_number":566,"context_line":"                pass"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        resources \u003d [\u0027image\u0027, \u0027metadefs/namespace\u0027, \u0027metadefs/resource_type\u0027]"},{"line_number":569,"context_line":"        schema_file_paths \u003d [homedir + os.sep + x + \u0027_schema.json\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_e008de93","line":566,"updated":"2015-05-14 04:12:46.000000000","message":"Instead of pass, just return from this method. If there is an exception creating homedir, then there is no need to continue with the rest of this method. The latter part of this method tries to create 3 files in homedir. Although exceptions thrown during creation of those files are swallowed, it is still wasted work.","commit_id":"6d75e0e38cbd990878faecc8bf9484fd55023428"}]}