)]}'
{"glanceclient/common/http.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"554ebcf0f33a6dbf908c3f7ca45a1eb544c19c86","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if self.auth_token:"},{"line_number":68,"context_line":"            self.session.headers[\"X-Auth-Token\"] \u003d \\"},{"line_number":69,"context_line":"                encodeutils.safe_encode(self.auth_token)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.timeout \u003d float(kwargs.get(\u0027timeout\u0027, 600))"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_b66f84c4","line":69,"updated":"2015-04-24 12:42:37.000000000","message":"We are trying to avoid \\ for long lines. Can you wrap it with parentheses or something like:\n\n self.session.headers[\"X-Auth-Token\"] \u003d encodeutils.safe_encode(\n    self.auth_token)","commit_id":"557f5c0758a4d396d8d47ef90c87866af6e49d3f"}],"glanceclient/common/utils.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"c05e89d2cf3a8a2132cda75ae01433843c13741f","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"def safe_header(name, value):"},{"line_number":422,"context_line":"    if name in SENSITIVE_HEADERS:"},{"line_number":423,"context_line":"        h \u003d hashlib.sha1(value)"},{"line_number":424,"context_line":"        d \u003d h.hexdigest()"},{"line_number":425,"context_line":"        return name, \"{SHA1}%s\" % d"},{"line_number":426,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ad32947_df783792","line":423,"updated":"2015-04-27 14:28:00.000000000","message":"On Python 3 you have to encode the value before you pass it to this function:\n\n    ~ python3.4\n    Python 3.4.2 (default, Oct  8 2014, 19:29:52)\n    [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.51)] on darwin\n    Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n    \u003e\u003e\u003e import hashlib\n    \u003e\u003e\u003e hashlib.sha1(\u0027foobarbogus\u0027)\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    TypeError: Unicode-objects must be encoded before hashing","commit_id":"c2e257538429b3e095c687bf4d2046f1966d68f0"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"52a1f7a55de2fe7dd6266a4035eaab9234ff246b","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"def safe_header(name, value):"},{"line_number":422,"context_line":"    if name in SENSITIVE_HEADERS:"},{"line_number":423,"context_line":"        h \u003d hashlib.sha1(value)"},{"line_number":424,"context_line":"        d \u003d h.hexdigest()"},{"line_number":425,"context_line":"        return name, \"{SHA1}%s\" % d"},{"line_number":426,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ad32947_0a8f8b24","line":423,"in_reply_to":"7ad32947_df783792","updated":"2015-04-27 14:54:03.000000000","message":"Isn\u0027t the encodeutils.safe_encode() call doing that for us? That\u0027s what I see here.","commit_id":"c2e257538429b3e095c687bf4d2046f1966d68f0"}]}