)]}'
{"id":"openstack%2Fpython-glanceclient~185223","triplet_id":"openstack%2Fpython-glanceclient~master~Ibf348d2e04494fa3e7802758add1fd740d62f2a1","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1307412","hashtags":[],"change_id":"Ibf348d2e04494fa3e7802758add1fd740d62f2a1","subject":"Check updated properties are actually updated in V2","status":"ABANDONED","created":"2015-05-23 10:22:49.000000000","updated":"2015-11-23 11:03:06.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"621b2bfc81f8980c4ff6f50cb7fa9fb0f82fd2d9","_number":185223,"virtual_id_number":185223,"owner":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":1,"date":"2015-06-24 22:42:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":1,"date":"2015-06-24 21:55:17.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":1,"date":"2015-06-26 15:08:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-10-16 08:00:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":1,"date":"2015-06-26 08:45:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},{"value":-1,"date":"2015-06-26 17:38:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"value":2,"date":"2015-06-25 12:12:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":-1,"date":"2015-07-15 23:29:00.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"date":"2015-05-23 10:24:33.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-23 10:24:33.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2015-06-24 21:55:17.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-06-24 22:42:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-06-26 08:45:23.000000000","updated_by":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"reviewer":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"state":"REVIEWER"},{"updated":"2015-06-26 15:08:45.000000000","updated_by":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"reviewer":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"state":"REVIEWER"},{"updated":"2015-06-26 17:38:12.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2015-10-16 08:00:53.000000000","updated_by":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"reviewer":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"state":"REVIEWER"}],"messages":[{"id":"195e2c811ca4f2f745ce228b386897b284e15ff9","author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"date":"2015-05-23 10:22:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8f9aa8b8b114d7a23b0c1ac3eef2e253072733f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-23 11:14:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-python26/883c5d7/ : SUCCESS in 1m 24s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-pep8/987a0a2/ : SUCCESS in 1m 35s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/23/185223/1/check/gate-python-glanceclient-docs/1951b63//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-glanceclient-python27 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-python27/878b7fa/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-python34 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-python34/eab0a21/ : SUCCESS in 2m 02s\n- gate-python-glanceclient-pypy http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-pypy/067b268/ : SUCCESS in 1m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/23/185223/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/c0757d2/ : SUCCESS in 52m 01s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/23/185223/1/check/check-glanceclient-dsvm-functional/b0ae77b/ : FAILURE in 18m 53s","accounts_in_message":[],"_revision_number":1},{"id":"b587c348da9109d7fa790207878cf3cadfb7cba6","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-05-26 22:53:43.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nRecheck","accounts_in_message":[],"_revision_number":1},{"id":"4b2db75c7a1b08fd2eb634fed712aa638d252322","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-24 21:54:53.000000000","message":"Patch Set 1: -Code-Review\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"39b182c9a52e68dfa6667613d69ede68bc974e85","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-24 21:55:17.000000000","message":"Patch Set 1: Code-Review+1\n\nForgot that gertty wipes out my vote","accounts_in_message":[],"_revision_number":1},{"id":"994c16b57830586427c30d900478e93e6b2d1b13","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-24 22:42:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-python26/868ccc0/ : SUCCESS in 1m 41s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-pep8/1ce2b6d/ : SUCCESS in 1m 34s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/23/185223/1/check/gate-python-glanceclient-docs/1e8177a//doc/build/html/ : SUCCESS in 1m 54s\n- gate-python-glanceclient-python27 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-python27/0ac9d95/ : SUCCESS in 1m 58s\n- gate-python-glanceclient-python34 http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-python34/b75f0fa/ : SUCCESS in 2m 21s\n- gate-python-glanceclient-pypy http://logs.openstack.org/23/185223/1/check/gate-python-glanceclient-pypy/bbd2788/ : FAILURE in 2m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/23/185223/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/3a1b812/ : SUCCESS in 44m 12s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/23/185223/1/check/check-glanceclient-dsvm-functional/e50bd26/ : SUCCESS in 18m 55s","accounts_in_message":[],"_revision_number":1},{"id":"fc4c7d14362f2deb6d1956d9fe99b616ee442f33","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-06-25 12:12:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7d850085d4ba72bd3387a363bb622832a2c421be","author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"date":"2015-06-26 08:45:23.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5652c56cd8b52c4e043737ab60f9f3f0ebcef801","author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"date":"2015-06-26 15:08:45.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a121a04cd17365a9ad9eee5ca2cb39660616376e","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-06-26 17:38:12.000000000","message":"Patch Set 1: Code-Review-1\n\nHi, it\u0027s a good enhancement, but I\u0027m going to ask you to add a unit test on it.\n\ndef test_update_prop_with_the_same_value(self):\n\n    image_id \u003d \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027\n\n    params \u003d {\u0027name\u0027: \u0027image-1\u0027}\n\n    self.assertRaises(exc.HTTPBadRequest,\n\n                      self.controller.update, image_id, **params)","accounts_in_message":[],"_revision_number":1},{"id":"4c9bc7a9b16f3b9de092b2a8e9967d269781506c","author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"date":"2015-07-06 14:13:25.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"b93716a88076ca66631363a872787750901010ed","author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"date":"2015-07-15 23:29:00.000000000","message":"Patch Set 1: -Code-Review Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"0bb2696e63c5fef6941b521e8714375afde6417b","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-10-16 08:00:53.000000000","message":"Patch Set 1: Code-Review-1\n\nThis patch has been -1ed because it has not been updated in\n\u003e\u003d2months. The patch also has either a -1/-2 from a core reviewer or a\n-1 from Jenkins.\n\nPlease, update/rebase the patch if the lack of updates was actually a\nlack of reviews or if you think the patch is still relevant.\n\n**NOTE: This will be abandoned if no update is done in 1 week.**\n\nIf this action does not seem accurate, please, ping flaper87 on IRC\nand he will gladly revert it. Sorry for the inconvenience and we look\nforward to have more contributions from you.","accounts_in_message":[],"_revision_number":1},{"id":"eb46065a5e837bd493746d19b106ce5ca1b39415","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-11-23 11:03:06.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"29e4a89d18366eb59166b3919338a852509473b1","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-11-23 11:03:06.000000000","message":"Patch Set 1:\n\nThis patch was marked to be abanadoned \u003e\u003d7days ago.\n\nIt is now being abandoned because there was no update, feedback nor rebase in the aforementioned period. If this is a mistake, please, contact members of the glance team[0] and they\u0027ll promptly correct the error.\n\nThanks for your contribution. The Glance team looks forward to new contributions from you.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"30907679ec3d7feb37e5672a4b71bb29cd12515c","revisions":{"30907679ec3d7feb37e5672a4b71bb29cd12515c":{"kind":"REWORK","_number":1,"created":"2015-05-23 10:22:49.000000000","uploader":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"ref":"refs/changes/23/185223/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/23/185223/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/23/185223/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/23/185223/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/23/185223/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/23/185223/1"}}},"commit":{"parents":[{"commit":"e180dbf12cc597c95be363fc309e4f526538373b","subject":"Merge \"Add release notes for 0.18.0\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e180dbf12cc597c95be363fc309e4f526538373b"}]}],"author":{"name":"Cindy Pallares","email":"cindy.pallaresq@gmail.com","date":"2014-06-11 15:18:55.000000000","tz":0},"committer":{"name":"Cindy Pallares","email":"cindy.pallaresq@gmail.com","date":"2015-05-23 10:22:38.000000000","tz":-300},"subject":"Check updated properties are actually updated in V2","message":"Check updated properties are actually updated in V2\n\nWhen an image is being updated, V2 doesn\u0027t check if a parameter\nis actually being updated. It would be good to catch this\nbefore the client sends it to the server.\n\nChange-Id: Ibf348d2e04494fa3e7802758add1fd740d62f2a1\nFixes-bug: #1307412\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/30907679ec3d7feb37e5672a4b71bb29cd12515c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/30907679ec3d7feb37e5672a4b71bb29cd12515c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}