)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"52bdb114a3c54c7f6ee56b1db4276ba8e9be5461","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The check used to verify if there are any properties to remove in the V2"},{"line_number":10,"context_line":"image-update command will always execute even if there are no properties to"},{"line_number":11,"context_line":"remove due to the fact that it checks if remove_prop is not None, when it is"},{"line_number":12,"context_line":"actually a list and not a None value."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia36e945b880de3514c73073a392bdb7dde13cf84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa32b979_4ca375b2","line":12,"updated":"2015-06-24 22:54:15.000000000","message":"Could you file a bug for this? Thanks","commit_id":"0dbab418069cbb5a908760abbd1ec3d1c69d9041"}],"glanceclient/v2/images.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"51388dc32321542855f1e5506193740237033e37","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            except warlock.InvalidOperation as e:"},{"line_number":251,"context_line":"                raise TypeError(utils.exception_to_str(e))"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if remove_props:"},{"line_number":254,"context_line":"            cur_props \u003d image.keys()"},{"line_number":255,"context_line":"            new_props \u003d kwargs.keys()"},{"line_number":256,"context_line":"            #NOTE(esheffield): Only remove props that currently exist on the"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f8ff4fa8","line":253,"updated":"2015-05-26 22:59:28.000000000","message":"Can you add a comment about this? Something along the lines of \"We always pass in a value that is not None when using this from the command-line. In that case we always execute this logic which we don\u0027t want to do.\" (Assuming I have that even remotely correct.)","commit_id":"b662dc70674dbf3d2fbb5169138d46c6a99d97fd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8396938c1bdf114c9dee531fc234d332ea82e176","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            except warlock.InvalidOperation as e:"},{"line_number":251,"context_line":"                raise TypeError(utils.exception_to_str(e))"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if remove_props:"},{"line_number":254,"context_line":"            #NOTE(cpallares): Checking for None is unnecesary since we always"},{"line_number":255,"context_line":"            # pass a value from the cli."},{"line_number":256,"context_line":"            cur_props \u003d image.keys()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_c16f3ac2","line":253,"updated":"2015-06-11 09:16:40.000000000","message":"you could probably change this and check if it is an instance of set,list,tuple (not sure if `.difference` will be happy with any of those types or just `set`)","commit_id":"ec5ed90cf3fc950f1939a1b1c7eb719fb6f51f3d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8c967f623b91d053b971196c70de2adb1f196ef4","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            except warlock.InvalidOperation as e:"},{"line_number":251,"context_line":"                raise TypeError(utils.exception_to_str(e))"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if isinstance(remove_props, (list, tuple)):"},{"line_number":254,"context_line":"            cur_props \u003d image.keys()"},{"line_number":255,"context_line":"            new_props \u003d kwargs.keys()"},{"line_number":256,"context_line":"            #NOTE(esheffield): Only remove props that currently exist on the"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a41bdd9_319e8107","line":253,"updated":"2015-07-15 23:52:57.000000000","message":"I believe that \u0027isinstance\u0027 is not necessary here. We just can write \n\nif remove_props:\n\nand it will reject all empty lists from cli and None from other places. And also it looks much better :)","commit_id":"e8fc77c4aac5710c62feabe924249901d11c277a"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"36e0bfcf70afd5d867ad7b1132a70d87265b7d7b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            except warlock.InvalidOperation as e:"},{"line_number":251,"context_line":"                raise TypeError(utils.exception_to_str(e))"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if remove_props:"},{"line_number":254,"context_line":"            cur_props \u003d image.keys()"},{"line_number":255,"context_line":"            new_props \u003d kwargs.keys()"},{"line_number":256,"context_line":"            #NOTE(esheffield): Only remove props that currently exist on the"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_930084ac","line":253,"updated":"2015-09-14 07:00:36.000000000","message":"FWIW, the real bug here is that the caller is passing in an empty value. I think this is fine for now.","commit_id":"0869196ca2c3e7d62ce5d5ee1714f4a531ed6c3b"}]}