)]}'
{"id":"openstack%2Fpython-glanceclient~189344","triplet_id":"openstack%2Fpython-glanceclient~master~I7e7761fc91b0d6da03939374eeedd809534f6edf","project":"openstack/python-glanceclient","branch":"master","topic":"bp/remove-custom-client-ssl-handling","hashtags":[],"change_id":"I7e7761fc91b0d6da03939374eeedd809534f6edf","subject":"Remove custom SSL compression handling","status":"MERGED","created":"2015-06-08 15:40:37.000000000","updated":"2015-08-26 17:35:46.000000000","submitted":"2015-08-26 17:35:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"533dd499156fb563975e7d4ff8695cc5bf8b711f","_number":189344,"virtual_id_number":189344,"owner":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2015-08-26 17:35:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"all":[{"value":2,"date":"2015-08-26 16:14:08.000000000","_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":2,"date":"2015-08-26 16:12:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"all":[{"value":1,"date":"2015-08-26 16:14:08.000000000","_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-17 15:26:07.000000000","updated_by":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"reviewer":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"state":"REVIEWER"},{"updated":"2015-08-26 16:12:48.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2015-08-26 16:14:08.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-08-26 17:35:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"44cf8200d0ba4524bfa0414722831777eb746f6a","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-08 15:40:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"525f46ba70a3ad3f7d70c8eeb295ade6d72102f3","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-08 15:42:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c26836c4e952bab925c604d5cf0507a913f9a800","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-08 15:46:12.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)\n\nA couple nits, but I\u0027m not sure they\u0027re worthy of a -1.","accounts_in_message":[],"_revision_number":2},{"id":"f0a5b041f4b997d55f7556d8ccc27d9221cffa9e","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-08 15:58:31.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cf58dc01f9fa37757b573888184dbbd45c47b43c","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-08 16:24:11.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"fa41609b3271ca1c1dc0aea42aa15aaeb3800131","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-08 17:00:14.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/3/check/gate-python-glanceclient-python26/c7e8156/ : SUCCESS in 2m 04s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/3/check/gate-python-glanceclient-pep8/53d2850/ : SUCCESS in 1m 35s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/3/check/gate-python-glanceclient-docs/57fa70c//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/3/check/gate-python-glanceclient-python27/7fa00b0/ : SUCCESS in 1m 32s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/3/check/gate-python-glanceclient-python34/96acea1/ : FAILURE in 1m 44s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/3/check/gate-python-glanceclient-pypy/4fa0797/ : SUCCESS in 2m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/6f98b9d/ : SUCCESS in 51m 47s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/3/check/check-glanceclient-dsvm-functional/e77a398/ : SUCCESS in 16m 42s","accounts_in_message":[],"_revision_number":3},{"id":"0a3c7bc72f0ee05d701ff19ea8b65b2e625c9b1b","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-09 12:25:55.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2ddaa7efd952a5128a874657f064c77e90aaae27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-09 13:42:51.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/4/check/gate-python-glanceclient-python26/43e93bc/ : SUCCESS in 2m 33s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/4/check/gate-python-glanceclient-pep8/d3ed84e/ : FAILURE in 1m 33s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/4/check/gate-python-glanceclient-docs/510f0c2//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/4/check/gate-python-glanceclient-python27/244930a/ : SUCCESS in 1m 56s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/4/check/gate-python-glanceclient-python34/f6ae874/ : SUCCESS in 2m 01s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/4/check/gate-python-glanceclient-pypy/e25261c/ : SUCCESS in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient/60760bd/ : SUCCESS in 1h 14m 03s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/4/check/check-glanceclient-dsvm-functional/7ce8459/ : FAILURE in 15m 22s","accounts_in_message":[],"_revision_number":4},{"id":"fa671fcf04d36f0dd9e8c346ba8a8df8bdba2a8c","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-09 13:49:24.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"f346025a812d583bb27db9d3e3c7193b736edf32","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-09 13:50:16.000000000","message":"Patch Set 5: Code-Review+2\n\nRound and round we go. Will it pass gating? Nobody knows.","accounts_in_message":[],"_revision_number":5},{"id":"23f546939c2b17d102f4aa7a896e54efab1d2d1a","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-09 13:51:36.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"6b0b7098ba953e462a9e7e5ecc57364d1602b651","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-09 13:53:06.000000000","message":"Patch Set 5:\n\nWhich emoticon is best suited for \u0027hanging my head in shame on pep8 failure?\u0027 :-)","accounts_in_message":[],"_revision_number":5},{"id":"40cb15f47ec3fa7effbf4c7a88fc3b9e9aaae602","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-09 15:17:13.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/5/check/gate-python-glanceclient-python26/1b88b23/ : SUCCESS in 1m 35s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/5/check/gate-python-glanceclient-pep8/4dba523/ : SUCCESS in 1m 18s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/5/check/gate-python-glanceclient-docs/86af9a2//doc/build/html/ : SUCCESS in 1m 30s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/5/check/gate-python-glanceclient-python27/a3d5b7c/ : SUCCESS in 1m 08s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/5/check/gate-python-glanceclient-python34/c12cd1c/ : SUCCESS in 1m 31s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/5/check/gate-python-glanceclient-pypy/00ae1c9/ : SUCCESS in 2m 27s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/5/check/gate-tempest-dsvm-neutron-src-python-glanceclient/95f643c/ : SUCCESS in 57m 19s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/5/check/check-glanceclient-dsvm-functional/b177787/ : SUCCESS in 21m 03s","accounts_in_message":[],"_revision_number":5},{"id":"e53bd638d9183ed277b243c7d936bf20d1adbe62","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-16 09:30:10.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"9a3bd4efe5bb51cb7da41e4254117971d29c5eea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-16 10:20:25.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/6/check/gate-python-glanceclient-python26/3812fc4/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/6/check/gate-python-glanceclient-pep8/8a3576b/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/6/check/gate-python-glanceclient-docs/6300bfb//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/6/check/gate-python-glanceclient-python27/21d0321/ : SUCCESS in 1m 06s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/6/check/gate-python-glanceclient-python34/81ed246/ : SUCCESS in 1m 37s\n- gate-python-glanceclient-requirements http://logs.openstack.org/44/189344/6/check/gate-python-glanceclient-requirements/5edbc23/ : SUCCESS in 24s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/6/check/gate-python-glanceclient-pypy/60b5fdb/ : SUCCESS in 1m 36s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/6/check/gate-tempest-dsvm-neutron-src-python-glanceclient/de812e3/ : SUCCESS in 50m 08s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/6/check/check-glanceclient-dsvm-functional/e6de438/ : SUCCESS in 15m 37s","accounts_in_message":[],"_revision_number":6},{"id":"1104313a5a46b7b6ba2508112fa0639d91b93587","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-17 21:12:42.000000000","message":"Patch Set 6: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"a1002973c6c66585f7537226b057d57484c3aed2","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-18 16:15:17.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"fdda171443cc6e759b9b3ea11770136caaa37d5b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-18 17:37:45.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/7/check/gate-python-glanceclient-python26/4db7ef8/ : SUCCESS in 1m 11s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/7/check/gate-python-glanceclient-pep8/af0ca9a/ : SUCCESS in 1m 37s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/7/check/gate-python-glanceclient-docs/0dbf7d2//doc/build/html/ : SUCCESS in 1m 45s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/7/check/gate-python-glanceclient-python27/f4606e4/ : SUCCESS in 1m 58s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/7/check/gate-python-glanceclient-python34/a380501/ : SUCCESS in 2m 22s\n- gate-python-glanceclient-requirements http://logs.openstack.org/44/189344/7/check/gate-python-glanceclient-requirements/8273ca7/ : SUCCESS in 26s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/7/check/gate-python-glanceclient-pypy/0b1cdfd/ : FAILURE in 2m 36s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/7/check/gate-tempest-dsvm-neutron-src-python-glanceclient/85e5b71/ : SUCCESS in 59m 31s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/7/check/check-glanceclient-dsvm-functional/7a4cb10/ : SUCCESS in 19m 24s","accounts_in_message":[],"_revision_number":7},{"id":"3fab99a995b16556f83b47f9ec78053ea01d9462","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-18 19:58:55.000000000","message":"Patch Set 7: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":7},{"id":"107ca3c786521ef6fc76e96a01ad477693db51b4","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-03 01:23:02.000000000","message":"Patch Set 7: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":7},{"id":"b2186f188fd8963b47275c58347faa91166eb5e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-03 01:23:10.000000000","message":"Patch Set 7:\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":7},{"id":"48a5e1ebd28b78b10821307490b240916e4c7500","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-08 22:02:24.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"7003e41b6281c8a9f9b8cf04c9424614727451dc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-08 23:03:16.000000000","message":"Patch Set 8: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/8/check/gate-python-glanceclient-python26/03cc11e/ : FAILURE in 1m 15s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/8/check/gate-python-glanceclient-pep8/7e67c89/ : SUCCESS in 1m 01s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/8/check/gate-python-glanceclient-docs/566da9f//doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/8/check/gate-python-glanceclient-python27/5d348f1/ : FAILURE in 1m 13s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/8/check/gate-python-glanceclient-python34/881ec32/ : SUCCESS in 1m 29s\n- gate-python-glanceclient-requirements http://logs.openstack.org/44/189344/8/check/gate-python-glanceclient-requirements/d295bf4/ : SUCCESS in 29s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/8/check/gate-python-glanceclient-pypy/2daa1cc/ : FAILURE in 1m 44s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/8/check/gate-tempest-dsvm-neutron-src-python-glanceclient/df44a63/ : SUCCESS in 51m 31s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/8/check/check-glanceclient-dsvm-functional/bf8266d/ : SUCCESS in 20m 38s","accounts_in_message":[],"_revision_number":8},{"id":"bc8d0c53778732bc78989a1a2704c20b8d6ead44","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-13 15:10:51.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"14c231c1cb15fcf5ea3e383e4cb8891d132559e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-13 21:56:50.000000000","message":"Patch Set 9: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/9/check/gate-python-glanceclient-python26/e993282/ : FAILURE in 1m 01s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/9/check/gate-python-glanceclient-pep8/cec452f/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/9/check/gate-python-glanceclient-docs/adfe1aa//doc/build/html/ : SUCCESS in 1m 49s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/9/check/gate-python-glanceclient-python27/3a382b8/ : FAILURE in 1m 56s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/9/check/gate-python-glanceclient-python34/fc9cc48/ : SUCCESS in 2m 46s\n- gate-python-glanceclient-requirements http://logs.openstack.org/44/189344/9/check/gate-python-glanceclient-requirements/a624c71/ : SUCCESS in 34s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/9/check/gate-python-glanceclient-pypy/438a4b5/ : FAILURE in 3m 22s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/9/check/gate-tempest-dsvm-neutron-src-python-glanceclient/bb65474/ : SUCCESS in 1h 09m 11s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/9/check/check-glanceclient-dsvm-functional/a4f7b4c/ : SUCCESS in 23m 23s","accounts_in_message":[],"_revision_number":9},{"id":"354d0d2aa72d3f73ba0d99657dce0806ca9a631c","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-07-15 20:49:14.000000000","message":"Patch Set 9:\n\nrecheck","accounts_in_message":[],"_revision_number":9},{"id":"07eddb8493f3ecc9a60abc78766083951f3ebb59","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-15 20:49:20.000000000","message":"Patch Set 9:\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":9},{"id":"632db237a1434adabd68f08494fa48e18306e549","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-08-26 10:12:59.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"06b7101a5992fb570a1cc548c01ec4a1cd48bcb8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-26 11:29:00.000000000","message":"Patch Set 10: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/10/check/gate-python-glanceclient-python26/b70ac84/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/10/check/gate-python-glanceclient-pep8/5904638/ : SUCCESS in 57s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/10/check/gate-python-glanceclient-docs/9f37e30//doc/build/html/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/10/check/gate-python-glanceclient-python27/d086772/ : SUCCESS in 1m 33s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/10/check/gate-python-glanceclient-python34/de2beb5/ : SUCCESS in 1m 39s\n- gate-python-glanceclient-requirements http://logs.openstack.org/44/189344/10/check/gate-python-glanceclient-requirements/03e9e75/ : SUCCESS in 28s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/10/check/gate-python-glanceclient-pypy/149e3a4/ : FAILURE in 2m 10s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/10/check/gate-tempest-dsvm-neutron-src-python-glanceclient/4921317/ : SUCCESS in 1h 09m 27s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/10/check/gate-glanceclient-dsvm-functional/7c591d1/ : FAILURE in 25m 34s","accounts_in_message":[],"_revision_number":10},{"id":"f922fa51b088f743f4ceae06e992a2eb3b6bd696","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-08-26 12:28:01.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"10212ef811e578249656c3cb0ca32b2a8435beda","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-26 14:05:32.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/11/check/gate-python-glanceclient-python26/178d7da/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/11/check/gate-python-glanceclient-pep8/61af268/ : SUCCESS in 1m 02s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/11/check/gate-python-glanceclient-docs/1bff54d//doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/11/check/gate-python-glanceclient-python27/49a094f/ : SUCCESS in 1m 26s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/11/check/gate-python-glanceclient-python34/15276dd/ : SUCCESS in 1m 51s\n- gate-python-glanceclient-requirements http://logs.openstack.org/44/189344/11/check/gate-python-glanceclient-requirements/680291f/ : SUCCESS in 25s\n- gate-python-glanceclient-pypy http://logs.openstack.org/44/189344/11/check/gate-python-glanceclient-pypy/1ca56c0/ : FAILURE in 2m 04s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/11/check/gate-tempest-dsvm-neutron-src-python-glanceclient/7c9b66f/ : SUCCESS in 1h 07m 03s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/11/check/gate-glanceclient-dsvm-functional/0fa9fc6/ : SUCCESS in 26m 16s","accounts_in_message":[],"_revision_number":11},{"id":"e0420f11a3229da19d9890a369b7b320870ebac3","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-08-26 16:12:48.000000000","message":"Patch Set 11: Code-Review+2\n\nI\u0027d really like to see this land.","accounts_in_message":[],"_revision_number":11},{"id":"ee266134f293e851bc8c06322a842dc93b0f8ff2","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-08-26 16:14:08.000000000","message":"Patch Set 11: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":11},{"id":"9735f4d50d5f9295dc5f70981337d24f3dc9ae92","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-26 16:15:33.000000000","message":"Patch Set 11: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":11},{"id":"15cda1ce5fb4e79093c9a7a7f82a4129a6686ebf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-26 17:35:44.000000000","message":"Patch Set 11: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/44/189344/11/gate/gate-python-glanceclient-python26/d396fef/ : SUCCESS in 1m 06s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/44/189344/11/gate/gate-python-glanceclient-docs/4062c72//doc/build/html/ : SUCCESS in 3m 34s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/44/189344/11/gate/gate-python-glanceclient-pep8/ed930b2/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-python27 http://logs.openstack.org/44/189344/11/gate/gate-python-glanceclient-python27/c52b3ea/ : SUCCESS in 3m 07s\n- gate-python-glanceclient-python34 http://logs.openstack.org/44/189344/11/gate/gate-python-glanceclient-python34/89bb865/ : SUCCESS in 2m 34s\n- gate-python-glanceclient-requirements http://logs.openstack.org/44/189344/11/gate/gate-python-glanceclient-requirements/2ba6739/ : SUCCESS in 2m 13s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/44/189344/11/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/db73562/ : SUCCESS in 1h 09m 44s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/44/189344/11/gate/gate-glanceclient-dsvm-functional/eba1b60/ : SUCCESS in 25m 02s","accounts_in_message":[],"_revision_number":11},{"id":"d84c0c9db6566cd436a1df229d210a6c1e6b5499","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-26 17:35:46.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"618637a5bd545d8271d9349b08a8e4ab2841d086","revisions":{"98bd79796be55ae6024f905b89c44d87d80bf57c":{"kind":"REWORK","_number":1,"created":"2015-06-08 15:40:37.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/1"}}},"commit":{"parents":[{"commit":"d80c70e58abdc4260600ceadc81a49802d7878d6","subject":"Merge \"Improve import related error handling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d80c70e58abdc4260600ceadc81a49802d7878d6"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 15:40:31.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: https://blueprints.launchpad.net/python-glanceclient/+spec/remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/98bd79796be55ae6024f905b89c44d87d80bf57c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/98bd79796be55ae6024f905b89c44d87d80bf57c"}]},"branch":"refs/heads/master"},"1a7be09264fe75175cec22dffe9586366317d088":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-06-08 15:42:57.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/2"}}},"commit":{"parents":[{"commit":"d80c70e58abdc4260600ceadc81a49802d7878d6","subject":"Merge \"Improve import related error handling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d80c70e58abdc4260600ceadc81a49802d7878d6"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 15:41:52.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: https://blueprints.launchpad.net/python-glanceclient/+spec/remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1a7be09264fe75175cec22dffe9586366317d088"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1a7be09264fe75175cec22dffe9586366317d088"}]},"branch":"refs/heads/master"},"8210bd8bced28c0879e2427057d816cc52a192c0":{"kind":"REWORK","_number":3,"created":"2015-06-08 15:58:31.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/3"}}},"commit":{"parents":[{"commit":"d80c70e58abdc4260600ceadc81a49802d7878d6","subject":"Merge \"Improve import related error handling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d80c70e58abdc4260600ceadc81a49802d7878d6"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 15:58:18.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8210bd8bced28c0879e2427057d816cc52a192c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8210bd8bced28c0879e2427057d816cc52a192c0"}]},"branch":"refs/heads/master"},"187c7f7a8c210e3a8f4a5682802b65f966d4a87c":{"kind":"REWORK","_number":4,"created":"2015-06-09 12:25:55.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/4"}}},"commit":{"parents":[{"commit":"d80c70e58abdc4260600ceadc81a49802d7878d6","subject":"Merge \"Improve import related error handling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d80c70e58abdc4260600ceadc81a49802d7878d6"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-09 12:25:29.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/187c7f7a8c210e3a8f4a5682802b65f966d4a87c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/187c7f7a8c210e3a8f4a5682802b65f966d4a87c"}]},"branch":"refs/heads/master"},"64132d59d768b313471eefc14de024d512b48952":{"kind":"REWORK","_number":5,"created":"2015-06-09 13:49:24.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/5"}}},"commit":{"parents":[{"commit":"d80c70e58abdc4260600ceadc81a49802d7878d6","subject":"Merge \"Improve import related error handling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d80c70e58abdc4260600ceadc81a49802d7878d6"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-09 13:48:36.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/64132d59d768b313471eefc14de024d512b48952"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/64132d59d768b313471eefc14de024d512b48952"}]},"branch":"refs/heads/master"},"b2fa2d8266cd3935f96f5a1266292c7067714f3c":{"kind":"REWORK","_number":6,"created":"2015-06-16 09:30:10.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/6"}}},"commit":{"parents":[{"commit":"0d22e821f9df4247e16a115f8b486d9bdd68eea1","subject":"Merge \"Add parameter \u0027changes-since\u0027 for image-list of v1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0d22e821f9df4247e16a115f8b486d9bdd68eea1"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-16 09:28:03.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b2fa2d8266cd3935f96f5a1266292c7067714f3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b2fa2d8266cd3935f96f5a1266292c7067714f3c"}]},"branch":"refs/heads/master"},"9a571efe8e2d711688d2ad0974db59ffe410547b":{"kind":"REWORK","_number":7,"created":"2015-06-18 16:15:17.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/7"}}},"commit":{"parents":[{"commit":"0d22e821f9df4247e16a115f8b486d9bdd68eea1","subject":"Merge \"Add parameter \u0027changes-since\u0027 for image-list of v1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0d22e821f9df4247e16a115f8b486d9bdd68eea1"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-18 16:12:55.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9a571efe8e2d711688d2ad0974db59ffe410547b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9a571efe8e2d711688d2ad0974db59ffe410547b"}]},"branch":"refs/heads/master"},"42b8d9c422ed45ec559eef64b18495ca2c877f91":{"kind":"REWORK","_number":8,"created":"2015-07-08 22:02:24.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/44/189344/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/8"}}},"commit":{"parents":[{"commit":"731cc77d4aef732250ebb41df3c8b24beef5957c","subject":"Merge \"Do not fall back to namespaced oslo.i18n\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/731cc77d4aef732250ebb41df3c8b24beef5957c"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Ian Cordasco","email":"graffatcolmingov@gmail.com","date":"2015-07-08 22:02:17.000000000","tz":-300},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/42b8d9c422ed45ec559eef64b18495ca2c877f91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/42b8d9c422ed45ec559eef64b18495ca2c877f91"}]},"branch":"refs/heads/master"},"7d7e6edaf8340d3d5e0920a510cd2a7772cfaf0d":{"kind":"TRIVIAL_REBASE","_number":9,"created":"2015-07-13 15:10:51.000000000","uploader":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"ref":"refs/changes/44/189344/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/9"}}},"commit":{"parents":[{"commit":"e976032a95962d6f6c750a7812ffda155492bc73","subject":"Remove usage of assert_called_once on Mock objects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e976032a95962d6f6c750a7812ffda155492bc73"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Ian Cordasco","email":"graffatcolmingov@gmail.com","date":"2015-07-13 15:06:50.000000000","tz":-300},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7d7e6edaf8340d3d5e0920a510cd2a7772cfaf0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7d7e6edaf8340d3d5e0920a510cd2a7772cfaf0d"}]},"branch":"refs/heads/master"},"8e2ca8f0743164608c3e7de90f9171b9ad26f151":{"kind":"REWORK","_number":10,"created":"2015-08-26 10:12:59.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/10"}}},"commit":{"parents":[{"commit":"17375a422c44641dd459bbde9473e126d874ab82","subject":"Merge \"V2: Do not validate image schema when listing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/17375a422c44641dd459bbde9473e126d874ab82"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-08-26 09:57:04.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8e2ca8f0743164608c3e7de90f9171b9ad26f151"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8e2ca8f0743164608c3e7de90f9171b9ad26f151"}]},"branch":"refs/heads/master"},"618637a5bd545d8271d9349b08a8e4ab2841d086":{"kind":"REWORK","_number":11,"created":"2015-08-26 12:28:01.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/44/189344/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/44/189344/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/44/189344/11"}}},"commit":{"parents":[{"commit":"17375a422c44641dd459bbde9473e126d874ab82","subject":"Merge \"V2: Do not validate image schema when listing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/17375a422c44641dd459bbde9473e126d874ab82"}]}],"author":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-08 14:49:52.000000000","tz":0},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-08-26 12:26:21.000000000","tz":0},"subject":"Remove custom SSL compression handling","message":"Remove custom SSL compression handling\n\nCustom SSL handling was introduced because disabling SSL layer compression\nprovided an approximately five fold performance increase in some\ncases. Without SSL layer compression disabled the image transfer would be\nCPU bound -- with the CPU performing the DEFLATE algorithm.  This would\ntypically limit image transfers to \u003c 20 MB/s. When --no-ssl-compression\nwas specified the client would not negotiate any compression algorithm\nduring the SSL handshake with the server which would remove the CPU\nbottleneck and transfers could approach wire speed.\n\nIn order to support \u0027--no-ssl-compression\u0027 two totally separate code\npaths exist depending on whether this is True or False.  When SSL\ncompression is disabled, rather than using the standard \u0027requests\u0027\nlibrary, we enter some custom code based on pyopenssl and httplib in\norder to disable compression.\n\nThis patch/spec proposes removing the custom code because:\n\n* It is a burden to maintain\n\n Eg adding new code such as keystone session support is more complicated\n\n* It can introduce additional failure modes\n\n We have seen some bugs related to the \u0027custom\u0027 certificate checking\n\n* Newer Operating Systems disable SSL for us.\n\n Eg. While Debian 7 defaulted to compression \u0027on\u0027, Debian 8 has compression\n \u0027off\u0027. This makes both servers and client less likely to have compression\n enabled.\n\n* Newer combinations of \u0027requests\u0027 and \u0027python\u0027 do this for us\n\n Requests disables compression when backed by a version of python which\n supports it (\u003e\u003d 2.7.9). This makes clients more likely to disable\n compression out-of-the-box.\n\n* It is (in principle) possible to do this on older versions too\n\n If pyopenssl, ndg-httpsclient and pyasn1 are installed on older\n operating system/python combinations, the requests library should\n disable SSL compression on the client side.\n\n* Systems that have SSL compression enabled may be vulnerable to the CRIME\n(https://web.nvd.nist.gov/view/vuln/detail?vulnId\u003dCVE-2012-4929) attack.\nInstallations which are security conscious should be running the Glance\nserver with SSL disabled.\n\nFull Spec: https://review.openstack.org/#/c/187674\nBlueprint: remove-custom-client-ssl-handling\n\nChange-Id: I7e7761fc91b0d6da03939374eeedd809534f6edf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/618637a5bd545d8271d9349b08a8e4ab2841d086"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/618637a5bd545d8271d9349b08a8e4ab2841d086"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
