)]}'
{"id":"openstack%2Fpython-glanceclient~190359","triplet_id":"openstack%2Fpython-glanceclient~master~Ibe9990e8c337c117a978b1cd8ec388c4bc6d3b4b","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1461678","hashtags":[],"change_id":"Ibe9990e8c337c117a978b1cd8ec388c4bc6d3b4b","subject":"Close iterables at the end of iteration","status":"MERGED","created":"2015-06-10 21:23:12.000000000","updated":"2015-06-16 19:06:40.000000000","submitted":"2015-06-16 19:01:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"571b9ca1fd16ddc4d1ae20df37266d626bc9cf5d","_number":190359,"virtual_id_number":190359,"owner":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2015-06-16 19:01:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"date":"2015-06-16 19:06:40.000000000","post_submit":true,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"all":[{"value":2,"date":"2015-06-13 20:39:47.000000000","_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":1,"date":"2015-06-11 18:27:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":2,"date":"2015-06-16 18:05:15.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":1,"date":"2015-06-16 18:05:15.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-11 00:34:54.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2015-06-11 16:29:17.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2015-06-11 18:27:10.000000000","updated_by":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"reviewer":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"state":"REVIEWER"},{"updated":"2015-06-13 20:39:47.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2015-06-16 18:05:15.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2015-06-16 19:01:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1b2126a627c6d589a155da60773551edcd209608","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2015-06-10 21:23:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a023a97947c86dd2f5a97b6285a135f11ee50fd7","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-10 21:29:56.000000000","message":"Patch Set 1: Code-Review+1\n\nThis is based off of the discussion on the mailing list, yes?","accounts_in_message":[],"_revision_number":1},{"id":"dca0c0545ed4763d891b812e36fb12794daab6d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-10 22:18:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/59/190359/1/check/gate-python-glanceclient-python26/a05eba2/ : SUCCESS in 1m 57s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/59/190359/1/check/gate-python-glanceclient-pep8/5bca078/ : SUCCESS in 1m 58s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/59/190359/1/check/gate-python-glanceclient-docs/b63cc94//doc/build/html/ : SUCCESS in 1m 52s\n- gate-python-glanceclient-python27 http://logs.openstack.org/59/190359/1/check/gate-python-glanceclient-python27/1dde228/ : SUCCESS in 2m 07s\n- gate-python-glanceclient-python34 http://logs.openstack.org/59/190359/1/check/gate-python-glanceclient-python34/59ae1d5/ : SUCCESS in 3m 09s\n- gate-python-glanceclient-pypy http://logs.openstack.org/59/190359/1/check/gate-python-glanceclient-pypy/95f3b00/ : SUCCESS in 3m 24s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/59/190359/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/d4d3995/ : SUCCESS in 44m 24s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/59/190359/1/check/check-glanceclient-dsvm-functional/5b6ad4c/ : SUCCESS in 17m 25s","accounts_in_message":[],"_revision_number":1},{"id":"0c37a2605e10a947628d62d503e8bb5dd00c7ad9","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-06-11 00:34:54.000000000","message":"Patch Set 1:\n\nWould something like http://paste.openstack.org/show/282579/ also work? Up to u guys I guess...","accounts_in_message":[],"_revision_number":1},{"id":"18bb5315f422560c35d670c3eff3567ff2e29e59","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2015-06-11 06:21:17.000000000","message":"Patch Set 1:\n\nYes, we discovered in IRC that of the theories we had, the one about a hung socket was right.\n\nAnd this looks like the culprit.\n\nIt needs tests, and Chris is going to do that once its validated in the lab.\n\n@harlowja - no, because that requires all callers to DTRT.\n\nWe can either expose that this is a file-like object, and ask all callers to close it, which is an API break, or we can make exiting the iterator ensure its cleaned up, which this patch attempts.","accounts_in_message":[],"_revision_number":1},{"id":"3bdf4220b8f3ddede731d3c422302f2c6cde9fc1","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-06-11 06:52:23.000000000","message":"Patch Set 1: Code-Review-1\n\nSo it turns out that this patch doesn\u0027t actually help the original problem.  The issue is that the exception occurs while writing out the data, not while getting the next chunk of data from glance.  Because of this we never hit the \"finally\" clause.\n\nWhat did help is what I\u0027ve proposed in https://review.openstack.org/#/c/188179/","accounts_in_message":[],"_revision_number":1},{"id":"34fb66c9c026c407497db1eaa9c8e43d95e89b94","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2015-06-11 06:55:21.000000000","message":"Patch Set 1:\n\nAh - so, yes, thats where the exception occurs. What you may not know is that an exception is raised in any generators like this when the generator is gc\u0027d before its completely iterated; which is why this code is a strict improvement IMO.\n\nBut - if we\u0027re not managing to trigger gc of the generator at all, we\u0027re not going to trigger the early exception, and your del approach works there, though it is of course non-obvious to folk that haven\u0027t dealt with leaking references in exceptions before.\n\nWhat would make it more explicit is the use of a context manager(e.g. contextlib.closing as harlowja suggested) in the place in nova where its used... but we need to expose a close attribute to do that.","accounts_in_message":[],"_revision_number":1},{"id":"e920f7cb44dd76d70144b4df3eabd8325621d56e","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-06-11 07:14:25.000000000","message":"Patch Set 1:\n\nOkay, so I dug into things a bit more closely, and it turns out that I messed up the tests earlier.  After careful retest it looks like this does indeed fix the issue.","accounts_in_message":[],"_revision_number":1},{"id":"25c998b6ed2f9652a0a7312606dc36b1f1d5068a","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-06-11 07:14:51.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"4b46f2572f28f00c5878957e9f522781079e04e7","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-11 09:25:37.000000000","message":"Patch Set 1: Code-Review+1\n\nThis is the fix for this discussion?\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-June/066057.html\n\n(If so, I\u0027ll add a bug + link to it in the commit message, then +2).\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"b5e31f940f1f90aab44e9d851ad11001eb612326","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-06-11 15:04:30.000000000","message":"Patch Set 1:\n\nYes, that\u0027s the right discussion.  It\u0027s bug #1461678.\n\nWe were planning on adding some sort of unit test, but I\u0027ve been pulled off onto another issue so if someone wants to run with this that\u0027d be great.","accounts_in_message":[],"_revision_number":1},{"id":"3f009a3f8e56549d2708af1bd34cf316f51b41f4","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-11 15:22:03.000000000","message":"Patch Set 1:\n\n\u003e We were planning on adding some sort of unit test\n\nI\u0027ll see if I can do that","accounts_in_message":[],"_revision_number":1},{"id":"678f091a130c7fa568c15ab9bf861c53d884161b","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-11 16:01:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d9c341184c96bd1c0eedb669e6a82e36f47c82d2","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-06-11 16:17:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3dd819043c0e19ea8722398977fa0ee831e09aca","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-11 16:29:17.000000000","message":"Patch Set 2: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bb8104c287cefa47482198f37c4dc4c8bfb1233f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-11 17:21:28.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/59/190359/2/check/gate-python-glanceclient-python26/4b89738/ : SUCCESS in 1m 33s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/59/190359/2/check/gate-python-glanceclient-pep8/9fa11ff/ : SUCCESS in 1m 50s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/59/190359/2/check/gate-python-glanceclient-docs/82512bd//doc/build/html/ : SUCCESS in 2m 03s\n- gate-python-glanceclient-python27 http://logs.openstack.org/59/190359/2/check/gate-python-glanceclient-python27/40e622f/ : SUCCESS in 1m 49s\n- gate-python-glanceclient-python34 http://logs.openstack.org/59/190359/2/check/gate-python-glanceclient-python34/b31e8ff/ : FAILURE in 2m 17s\n- gate-python-glanceclient-pypy http://logs.openstack.org/59/190359/2/check/gate-python-glanceclient-pypy/b7ef6c7/ : SUCCESS in 2m 16s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/59/190359/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/cecd94c/ : SUCCESS in 1h 04m 26s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/59/190359/2/check/check-glanceclient-dsvm-functional/4d8fc0b/ : SUCCESS in 20m 23s","accounts_in_message":[],"_revision_number":2},{"id":"5129d9cef4fe9f5a0469f2a12dc46932fc27d76b","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-06-11 18:12:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"21115955396fe6182d86f3a5cbc22f0beb46279b","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-06-11 18:27:10.000000000","message":"Patch Set 3: Code-Review+1\n\nLooks good, thanks for this to both of you.","accounts_in_message":[],"_revision_number":3},{"id":"753ae3eed233b3ae1fcd52b6dbea912a5a2307bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-11 19:13:26.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/59/190359/3/check/gate-python-glanceclient-python26/d49d155/ : SUCCESS in 1m 40s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/59/190359/3/check/gate-python-glanceclient-pep8/0d446df/ : SUCCESS in 1m 34s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/59/190359/3/check/gate-python-glanceclient-docs/a557c58//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-glanceclient-python27 http://logs.openstack.org/59/190359/3/check/gate-python-glanceclient-python27/5e8fee8/ : SUCCESS in 1m 46s\n- gate-python-glanceclient-python34 http://logs.openstack.org/59/190359/3/check/gate-python-glanceclient-python34/de41698/ : SUCCESS in 2m 13s\n- gate-python-glanceclient-pypy http://logs.openstack.org/59/190359/3/check/gate-python-glanceclient-pypy/ca9bb77/ : FAILURE in 2m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/59/190359/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/7a32336/ : SUCCESS in 52m 05s\n- check-glanceclient-dsvm-functional http://logs.openstack.org/59/190359/3/check/check-glanceclient-dsvm-functional/2016ac5/ : SUCCESS in 15m 19s","accounts_in_message":[],"_revision_number":3},{"id":"38967f6e9914e454ac736ecbf9a8f6e59b03eebf","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2015-06-13 20:39:47.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks for figuring out a test Stuart and to Chris and lifeless for testing and developing this patch.","accounts_in_message":[],"_revision_number":3},{"id":"b9910b49aca25c064d3ef0dea7a0bdc68bbdd616","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-06-16 18:05:15.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nCool test :)","accounts_in_message":[],"_revision_number":3},{"id":"ad14e43f44f250d70b9179bfcf9f4cf7c7158687","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-16 18:05:20.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"27c495915e821867b47fe75069f02338333d4ec1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-16 19:01:18.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/59/190359/3/gate/gate-python-glanceclient-python26/4a54ab0/ : SUCCESS in 1m 36s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/59/190359/3/gate/gate-python-glanceclient-docs/d907c72//doc/build/html/ : SUCCESS in 2m 03s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/59/190359/3/gate/gate-python-glanceclient-pep8/a9c9d11/ : SUCCESS in 1m 41s\n- gate-python-glanceclient-python27 http://logs.openstack.org/59/190359/3/gate/gate-python-glanceclient-python27/3c35861/ : SUCCESS in 2m 02s\n- gate-python-glanceclient-python34 http://logs.openstack.org/59/190359/3/gate/gate-python-glanceclient-python34/26f62c0/ : SUCCESS in 2m 37s\n- gate-python-glanceclient-pypy http://logs.openstack.org/59/190359/3/gate/gate-python-glanceclient-pypy/d5c4607/ : FAILURE in 2m 37s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/59/190359/3/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/a92af13/ : SUCCESS in 52m 55s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/59/190359/3/gate/gate-glanceclient-dsvm-functional/e9588b1/ : SUCCESS in 18m 44s","accounts_in_message":[],"_revision_number":3},{"id":"83d338eaed229faa673b8f7dc1ed1f611537710f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-16 19:01:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"08ce6ad7a7fb73be406cfd8e3bdda190702eb460","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2015-06-16 19:06:40.000000000","message":"Patch Set 3:\n\nThanks Stuart!","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"43621dc1ac626f7ce3322cee8b7908a93af20f26","revisions":{"953790bd27e4d7abd1da30837d6fdf34dafd862a":{"kind":"REWORK","_number":1,"created":"2015-06-10 21:23:12.000000000","uploader":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"ref":"refs/changes/59/190359/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/59/190359/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/1"}}},"commit":{"parents":[{"commit":"db6420b44779411d6d1f238f6b887f83f1988986","subject":"Add release notes for 0.19.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/db6420b44779411d6d1f238f6b887f83f1988986"}]}],"author":{"name":"Robert Collins","email":"rbtcollins@hp.com","date":"2015-06-10 21:21:53.000000000","tz":720},"committer":{"name":"Robert Collins","email":"rbtcollins@hp.com","date":"2015-06-10 21:23:09.000000000","tz":720},"subject":"Close iterables at the end of iteration.","message":"Close iterables at the end of iteration.\n\nThis fixes a bug where if iteration is interrupted, we\u0027re stuck until\nthe iterable is gc\u0027d, which can be a very long time (e.g. if the\niterable is held in an exception stack frame).\n\nChange-Id: Ibe9990e8c337c117a978b1cd8ec388c4bc6d3b4b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/953790bd27e4d7abd1da30837d6fdf34dafd862a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/953790bd27e4d7abd1da30837d6fdf34dafd862a"}]},"branch":"refs/heads/master"},"4a3a4ae653ecd661149d00e45af97914caa70056":{"kind":"REWORK","_number":2,"created":"2015-06-11 16:01:09.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/59/190359/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/59/190359/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/2"}}},"commit":{"parents":[{"commit":"db6420b44779411d6d1f238f6b887f83f1988986","subject":"Add release notes for 0.19.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/db6420b44779411d6d1f238f6b887f83f1988986"}]}],"author":{"name":"Robert Collins","email":"rbtcollins@hp.com","date":"2015-06-10 21:21:53.000000000","tz":720},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-11 15:57:53.000000000","tz":0},"subject":"Close iterables at the end of iteration","message":"Close iterables at the end of iteration\n\nThis fixes a bug where if iteration is interrupted, we\u0027re stuck until\nthe iterable is garbage collected, which can be a very long time (e.g. if\nthe iterable is held in an exception stack frame).\n\nCo-authored-by: Stuart McLaren \u003cstuart.mclaren@hp.com\u003e\n\nChange-Id: Ibe9990e8c337c117a978b1cd8ec388c4bc6d3b4b\nCloses-bug: 1461678\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4a3a4ae653ecd661149d00e45af97914caa70056"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4a3a4ae653ecd661149d00e45af97914caa70056"}]},"branch":"refs/heads/master"},"43621dc1ac626f7ce3322cee8b7908a93af20f26":{"kind":"REWORK","_number":3,"created":"2015-06-11 18:12:46.000000000","uploader":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"ref":"refs/changes/59/190359/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/59/190359/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/59/190359/3"}}},"commit":{"parents":[{"commit":"db6420b44779411d6d1f238f6b887f83f1988986","subject":"Add release notes for 0.19.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/db6420b44779411d6d1f238f6b887f83f1988986"}]}],"author":{"name":"Robert Collins","email":"rbtcollins@hp.com","date":"2015-06-10 21:21:53.000000000","tz":720},"committer":{"name":"Stuart McLaren","email":"stuart.mclaren@hp.com","date":"2015-06-11 18:11:39.000000000","tz":0},"subject":"Close iterables at the end of iteration","message":"Close iterables at the end of iteration\n\nThis fixes a bug where if iteration is interrupted, we\u0027re stuck until\nthe iterable is garbage collected, which can be a very long time (e.g. if\nthe iterable is held in an exception stack frame).\n\nCo-authored-by: Stuart McLaren \u003cstuart.mclaren@hp.com\u003e\n\nChange-Id: Ibe9990e8c337c117a978b1cd8ec388c4bc6d3b4b\nCloses-bug: 1461678\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/43621dc1ac626f7ce3322cee8b7908a93af20f26"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/43621dc1ac626f7ce3322cee8b7908a93af20f26"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}