)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"cf9c50d4a3a60ca4b8d47077bba32776c8794595","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use API v2 as default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now we have claimed v2 is the current API version of Glance, so we"},{"line_number":10,"context_line":"should Glance client as well to be consistent with Glance server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I09c9e409d149e2d797785591183e06c13229b7f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_9f38333f","line":10,"updated":"2015-06-22 22:08:57.000000000","message":"Suggest changing \"should Glance client\" to \"should change the Glance client\"","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ab683ae2bf25675469e24107075fe105f4d8b983","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use API v2 as default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now we have claimed v2 is the current API version of Glance, so we"},{"line_number":10,"context_line":"should Glance client as well to be consistent with Glance server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I09c9e409d149e2d797785591183e06c13229b7f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_7fb68f8b","line":10,"in_reply_to":"fa32b979_9f38333f","updated":"2015-06-23 01:42:22.000000000","message":"Done","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"cf9c50d4a3a60ca4b8d47077bba32776c8794595","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now we have claimed v2 is the current API version of Glance, so we"},{"line_number":10,"context_line":"should Glance client as well to be consistent with Glance server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I09c9e409d149e2d797785591183e06c13229b7f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_9f0fd387","line":11,"updated":"2015-06-22 22:08:57.000000000","message":"This should probably specify Doc impact, as the documentation currently indicates --os-image-api-version defaults to 1.\n\nhttp://docs.openstack.org/cli-reference/content/glanceclient_commands.html","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ab683ae2bf25675469e24107075fe105f4d8b983","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now we have claimed v2 is the current API version of Glance, so we"},{"line_number":10,"context_line":"should Glance client as well to be consistent with Glance server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I09c9e409d149e2d797785591183e06c13229b7f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_bf63b719","line":11,"in_reply_to":"fa32b979_9f0fd387","updated":"2015-06-23 01:42:22.000000000","message":"Nice catch.","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"}],"glanceclient/shell.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"479798c1d2374a306d4231b875e6a269c9add36c","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        parser.add_argument(\u0027--os-image-api-version\u0027,"},{"line_number":264,"context_line":"                            default\u003dutils.env(\u0027OS_IMAGE_API_VERSION\u0027,"},{"line_number":265,"context_line":"                                              default\u003dNone),"},{"line_number":266,"context_line":"                            help\u003d\u0027Defaults to env[OS_IMAGE_API_VERSION] or 1.\u0027)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        parser.add_argument(\u0027--os_image_api_version\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_3ece9e2d","line":265,"updated":"2015-06-23 17:01:33.000000000","message":"+1","commit_id":"bdfd80e0a686bcafee55f900a35eabfef82569cf"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b59a089f96179ad6c365dcd3f8892272be560ced","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        parser.add_argument(\u0027--os-image-api-version\u0027,"},{"line_number":264,"context_line":"                            default\u003dutils.env(\u0027OS_IMAGE_API_VERSION\u0027,"},{"line_number":265,"context_line":"                                              default\u003dNone),"},{"line_number":266,"context_line":"                            help\u003d\u0027Defaults to env[OS_IMAGE_API_VERSION] or 1.\u0027)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        parser.add_argument(\u0027--os_image_api_version\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_f51b851a","line":265,"updated":"2015-06-23 11:52:38.000000000","message":"IMO here 1 \u003e\u003e 2","commit_id":"bdfd80e0a686bcafee55f900a35eabfef82569cf"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b26a99d92e2e467373d262375803df872fdaa969","unresolved":false,"context_lines":[{"line_number":568,"context_line":"            hash_host \u003d hashlib.sha1(options.os_auth_url.encode(\u0027utf-8\u0027))"},{"line_number":569,"context_line":"            path_prefix +\u003d hash_host.hexdigest() + os.sep"},{"line_number":570,"context_line":"        resources \u003d [\u0027image\u0027, \u0027metadefs/namespace\u0027, \u0027metadefs/resource_type\u0027]"},{"line_number":571,"context_line":"        schema_file_paths \u003d [path_prefix + x + \u0027_schema.json\u0027"},{"line_number":572,"context_line":"                             for x in [\u0027image\u0027, \u0027namespace\u0027, \u0027resource_type\u0027]]"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        client \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_5e7562c8","line":571,"updated":"2015-07-09 07:38:34.000000000","message":"Could you please use `os.path.join` here instead of appending os.spe in L566 and concatenating the strings here?\n\nSame in L569","commit_id":"adbf41a85956afdfdfd908535d6c73807ade211c"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b26a99d92e2e467373d262375803df872fdaa969","unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        if api_version \u003d\u003d 2:"},{"line_number":626,"context_line":"            switch_version \u003d self._cache_schemas(options)"},{"line_number":627,"context_line":"            if switch_version:"},{"line_number":628,"context_line":"                api_version \u003d 1"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_de1df273","line":627,"updated":"2015-07-09 07:38:34.000000000","message":"Can we print a warning here saying that the client is falling back to v1 and that this behavior  will be removed in future versions?","commit_id":"adbf41a85956afdfdfd908535d6c73807ade211c"}],"glanceclient/tests/unit/test_shell.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"cf9c50d4a3a60ca4b8d47077bba32776c8794595","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            # test no authentication is required if both token and endpoint url"},{"line_number":210,"context_line":"            # are specified"},{"line_number":211,"context_line":"            args \u003d (\u0027--os-auth-token mytoken \u0027"},{"line_number":212,"context_line":"                    \u0027--os-image-url https://image:1234/v2 \u0027"},{"line_number":213,"context_line":"                    \u0027--os-image-api-version 2 image-list\u0027)"},{"line_number":214,"context_line":"            glance_shell \u003d openstack_shell.OpenStackImagesShell()"},{"line_number":215,"context_line":"            glance_shell.main(args.split())"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_bf609736","line":212,"updated":"2015-06-22 22:08:57.000000000","message":"Should this be changed to specify no version, as 2 will be the default?","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ab683ae2bf25675469e24107075fe105f4d8b983","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            # test no authentication is required if both token and endpoint url"},{"line_number":210,"context_line":"            # are specified"},{"line_number":211,"context_line":"            args \u003d (\u0027--os-auth-token mytoken \u0027"},{"line_number":212,"context_line":"                    \u0027--os-image-url https://image:1234/v2 \u0027"},{"line_number":213,"context_line":"                    \u0027--os-image-api-version 2 image-list\u0027)"},{"line_number":214,"context_line":"            glance_shell \u003d openstack_shell.OpenStackImagesShell()"},{"line_number":215,"context_line":"            glance_shell.main(args.split())"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_8a26af66","line":212,"in_reply_to":"fa32b979_bf609736","updated":"2015-06-23 01:42:22.000000000","message":"I would like to keep it to make it explicit.","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"cf9c50d4a3a60ca4b8d47077bba32776c8794595","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    def test_auth_plugin_invocation_with_v2(self,"},{"line_number":244,"context_line":"                                            v2_client,"},{"line_number":245,"context_line":"                                            cache_schemas):"},{"line_number":246,"context_line":"        args \u003d \u0027--os-image-api-version 2 image-list\u0027"},{"line_number":247,"context_line":"        glance_shell \u003d openstack_shell.OpenStackImagesShell()"},{"line_number":248,"context_line":"        glance_shell.main(args.split())"},{"line_number":249,"context_line":"        self._assert_auth_plugin_args()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_1f1c23c0","line":246,"updated":"2015-06-22 22:08:57.000000000","message":"Should this be changed to specify no version, as 2 will be the default?","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"cf9c50d4a3a60ca4b8d47077bba32776c8794595","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    @mock.patch.object(openstack_shell.OpenStackImagesShell, \u0027_cache_schemas\u0027)"},{"line_number":262,"context_line":"    def test_auth_plugin_invocation_with_unversioned_auth_url_with_v2("},{"line_number":263,"context_line":"            self, v2_client, cache_schemas):"},{"line_number":264,"context_line":"        args \u003d (\u0027--os-auth-url %s --os-image-api-version 2 \u0027"},{"line_number":265,"context_line":"                \u0027image-list\u0027) % DEFAULT_UNVERSIONED_AUTH_URL"},{"line_number":266,"context_line":"        glance_shell \u003d openstack_shell.OpenStackImagesShell()"},{"line_number":267,"context_line":"        glance_shell.main(args.split())"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_df7c7bed","line":264,"updated":"2015-06-22 22:08:57.000000000","message":"Same question as above.","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"cf9c50d4a3a60ca4b8d47077bba32776c8794595","unresolved":false,"context_lines":[{"line_number":443,"context_line":"    @mock.patch(\u0027glanceclient.v2.client.Client\u0027)"},{"line_number":444,"context_line":"    @mock.patch.object(openstack_shell.OpenStackImagesShell, \u0027_cache_schemas\u0027)"},{"line_number":445,"context_line":"    def test_auth_plugin_invocation_with_v2(self, v2_client, cache_schemas):"},{"line_number":446,"context_line":"        args \u003d \u0027--os-image-api-version 2 image-list\u0027"},{"line_number":447,"context_line":"        glance_shell \u003d openstack_shell.OpenStackImagesShell()"},{"line_number":448,"context_line":"        glance_shell.main(args.split())"},{"line_number":449,"context_line":"        self._assert_auth_plugin_args()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_9f86f3d9","line":446,"updated":"2015-06-22 22:08:57.000000000","message":"Same question as above.","commit_id":"b02b3c0970bbd8eda696b748268f00068a441f5d"}]}