)]}'
{"tests/v2/test_images.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"cb7bf44d0d7158d6b8c7c613ff97a5e156ffb292","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_delete_image(self):"},{"line_number":133,"context_line":"        image \u003d self.controller.delete(\u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027)"},{"line_number":134,"context_line":"        self.assertEqual(image.id, \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_data_without_checksum(self):"},{"line_number":137,"context_line":"        body \u003d self.controller.data(\u00275cc4bebc-db27-11e1-a1eb-080027cbe205\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FWhU%3D","line":134,"updated":"2013-01-25 22:50:15.000000000","message":"maybe you can assert that you can no longer access the image?\nlike the image get on this image returns not found?","commit_id":"db09fb43f481bbc57ca40cd66bdc8f324970225b"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"f217806aa365e65eb1a02f2db081c6503069b058","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_delete_image(self):"},{"line_number":133,"context_line":"        image \u003d self.controller.delete(\u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027)"},{"line_number":134,"context_line":"        self.assertEqual(image.id, \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_data_without_checksum(self):"},{"line_number":137,"context_line":"        body \u003d self.controller.data(\u00275cc4bebc-db27-11e1-a1eb-080027cbe205\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FWgI%3D","line":134,"in_reply_to":"AAAAM3%2F%2FWhU%3D","updated":"2013-01-28 16:09:23.000000000","message":"Sounds like a good approach. I will try that.\nThanks Iccha.","commit_id":"db09fb43f481bbc57ca40cd66bdc8f324970225b"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"86b296dc77712883d96cfebf3e73eed630b492b2","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertEqual(image.name, \u0027image-1\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_delete_image(self):"},{"line_number":141,"context_line":"        image \u003d self.controller.delete(\u002787b634c1-f893-33c9-28a9-e5673c99239a\u0027)"},{"line_number":142,"context_line":"        self.assertEqual(None, image)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_data_without_checksum(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FVN8%3D","line":141,"updated":"2013-01-28 18:28:29.000000000","message":"can u assert that you can no longer get the image? so that we can know that the image has been deleted?","commit_id":"439a4b5d9abde30408daad146c44c1870c4a8474"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"2b44aa2d86ad3c4b87d2a9e4e7cbbece8ed0c7ef","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertEqual(image.name, \u0027image-1\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_delete_image(self):"},{"line_number":141,"context_line":"        image \u003d self.controller.delete(\u002787b634c1-f893-33c9-28a9-e5673c99239a\u0027)"},{"line_number":142,"context_line":"        self.assertEqual(None, image)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_data_without_checksum(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FVJA%3D","line":141,"in_reply_to":"AAAAM3%2F%2FVJ0%3D","updated":"2013-01-28 19:14:16.000000000","message":"makes sense. I get your point. I will download patch and check it on my server and will approve it then. Looks good otherwise.","commit_id":"439a4b5d9abde30408daad146c44c1870c4a8474"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"946f8516f6fd18d5c81454b3a7098802bf22a434","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertEqual(image.name, \u0027image-1\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_delete_image(self):"},{"line_number":141,"context_line":"        image \u003d self.controller.delete(\u002787b634c1-f893-33c9-28a9-e5673c99239a\u0027)"},{"line_number":142,"context_line":"        self.assertEqual(None, image)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_data_without_checksum(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FVJ0%3D","line":141,"in_reply_to":"AAAAM3%2F%2FVN8%3D","updated":"2013-01-28 19:05:16.000000000","message":"Well since the returned object is None, None has no attributes.\n\nI think I would have to write a new fixture for the get after the delete and then I feel I would just be testing my ability to write fixtures.\n\nI have tried looking at other OpenStack code to see how other tests are written that assert anything beside assertEqual but I couldn\u0027t find much.","commit_id":"439a4b5d9abde30408daad146c44c1870c4a8474"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"88e7ba042ed10d6ad267cf087d57bbcb6c85c301","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_delete_image(self):"},{"line_number":141,"context_line":"        image \u003d self.controller.delete(\u002787b634c1-f893-33c9-28a9-e5673c99239a\u0027)"},{"line_number":142,"context_line":"        self.assertEqual(None, image)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_data_without_checksum(self):"},{"line_number":145,"context_line":"        body \u003d self.controller.data(\u00275cc4bebc-db27-11e1-a1eb-080027cbe205\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUw8%3D","line":142,"updated":"2013-01-28 23:10:26.000000000","message":"What you can do is something similar to the v1 tests. self.api.calls should be equal to [(\u0027DELETE\u0027, \u0027/v2/images/87b634c1-f893-33c9-28a9-e5673c99239a\u0027, {}, None)] after the delete is called.","commit_id":"439a4b5d9abde30408daad146c44c1870c4a8474"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"74a197ef249cb8623900126ff1934ba6aeb29899","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_delete_image(self):"},{"line_number":141,"context_line":"        image \u003d self.controller.delete(\u002787b634c1-f893-33c9-28a9-e5673c99239a\u0027)"},{"line_number":142,"context_line":"        self.assertEqual(None, image)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_data_without_checksum(self):"},{"line_number":145,"context_line":"        body \u003d self.controller.data(\u00275cc4bebc-db27-11e1-a1eb-080027cbe205\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FUuw%3D","line":142,"in_reply_to":"AAAAM3%2F%2FUw8%3D","updated":"2013-01-28 23:31:17.000000000","message":"Thanks Alex, I will take a look at implementing what you suggest.","commit_id":"439a4b5d9abde30408daad146c44c1870c4a8474"}]}
