)]}'
{"id":"openstack%2Fpython-glanceclient~205385","triplet_id":"openstack%2Fpython-glanceclient~master~I0489e180f577e1a33193dd1b6da6d4d524d61283","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1420809","hashtags":[],"change_id":"I0489e180f577e1a33193dd1b6da6d4d524d61283","subject":"Made name and disk-format mandatory in CLI","status":"ABANDONED","created":"2015-07-24 06:01:33.000000000","updated":"2015-11-23 11:03:01.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2d73b00e0a355e709f572b6aa84958b049754ed6","_number":205385,"virtual_id_number":205385,"owner":{"_account_id":17371,"name":"vaibhav","email":"vaibhav.j1@tcs.com","username":"vaibworld"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2015-07-24 07:23:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-07-24 06:01:39.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"disliked":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":-1,"date":"2015-10-16 08:00:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":-1,"date":"2015-07-24 08:39:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":-2,"date":"2015-07-24 18:44:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-24 06:01:39.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2015-07-24 07:23:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-07-24 08:39:22.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2015-07-24 18:44:41.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2015-10-16 08:00:44.000000000","updated_by":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"reviewer":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"state":"REVIEWER"}],"messages":[{"id":"e9dc62f69b80b5afec26af63cd22e84b5848c24c","author":{"_account_id":17371,"name":"vaibhav","email":"vaibhav.j1@tcs.com","username":"vaibworld"},"date":"2015-07-24 06:01:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48cb4cfc07c7ab1f7d6f3c40f7e0fb31b006dde3","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2015-07-24 06:01:39.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"831bd3ce5ae3c5f5bac7645a44391b6bce31b625","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-24 07:23:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/85/205385/1/check/gate-python-glanceclient-python26/4f858a0/ : SUCCESS in 1m 38s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/85/205385/1/check/gate-python-glanceclient-pep8/97f3dc1/ : FAILURE in 1m 56s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/85/205385/1/check/gate-python-glanceclient-docs/e9fe7ec//doc/build/html/ : SUCCESS in 2m 31s\n- gate-python-glanceclient-python27 http://logs.openstack.org/85/205385/1/check/gate-python-glanceclient-python27/a272c23/ : SUCCESS in 1m 58s\n- gate-python-glanceclient-python34 http://logs.openstack.org/85/205385/1/check/gate-python-glanceclient-python34/9e6486a/ : FAILURE in 2m 29s\n- gate-python-glanceclient-pypy http://logs.openstack.org/85/205385/1/check/gate-python-glanceclient-pypy/5115710/ : FAILURE in 2m 36s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/85/205385/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/a90d64b/ : SUCCESS in 1h 04m 06s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/85/205385/1/check/gate-glanceclient-dsvm-functional/1ec5791/ : SUCCESS in 23m 14s","accounts_in_message":[],"_revision_number":1},{"id":"721d542d625a66bcee707ff6df2157d596a1788b","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2015-07-24 08:39:22.000000000","message":"Patch Set 1: Code-Review-1\n\nWe can create an image without data or locations. This kind of image\u0027s status will be queued. Obviously it can\u0027t be use directly. see: https://github.com/openstack/glance/blob/master/glance/api/v1/images.py#L850\nSo name or disk_format is not necessary in this situation.","accounts_in_message":[],"_revision_number":1},{"id":"40fe7a5c13dfda2f7b5a65e2e665f3fb30d4d18a","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-07-24 18:44:41.000000000","message":"Patch Set 1: Code-Review-2\n\nThanks for working on this, but I have to reject your commit for two reasons:\n\n1. There is an official api v1, where it\u0027s stated that these parameters are optional, and client must fully support this api. If some third-party tools impose restrictions on api, it doesn\u0027t mean that and the client should too.\n\n2. Many other services use cli for a long time, and changing it will break backward compatibility, which is strictly prohibited.","accounts_in_message":[],"_revision_number":1},{"id":"2502fd12211b592c37c608475d1151869d0383cd","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-10-16 08:00:44.000000000","message":"Patch Set 1: Code-Review-1\n\nThis patch has been -1ed because it has not been updated in\n\u003e\u003d2months. The patch also has either a -1/-2 from a core reviewer or a\n-1 from Jenkins.\n\nPlease, update/rebase the patch if the lack of updates was actually a\nlack of reviews or if you think the patch is still relevant.\n\n**NOTE: This will be abandoned if no update is done in 1 week.**\n\nIf this action does not seem accurate, please, ping flaper87 on IRC\nand he will gladly revert it. Sorry for the inconvenience and we look\nforward to have more contributions from you.","accounts_in_message":[],"_revision_number":1},{"id":"0a69c56a14451802a3f8f9e79d5c1949513e00bd","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-11-23 11:03:01.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"c097706c51306e1455d478edacc78696c68faae1","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2015-11-23 11:03:01.000000000","message":"Patch Set 1:\n\nThis patch was marked to be abanadoned \u003e\u003d7days ago.\n\nIt is now being abandoned because there was no update, feedback nor rebase in the aforementioned period. If this is a mistake, please, contact members of the glance team[0] and they\u0027ll promptly correct the error.\n\nThanks for your contribution. The Glance team looks forward to new contributions from you.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"92cf09502b544f5e77f10a69de7c58c71510c338","revisions":{"92cf09502b544f5e77f10a69de7c58c71510c338":{"kind":"REWORK","_number":1,"created":"2015-07-24 06:01:33.000000000","uploader":{"_account_id":17371,"name":"vaibhav","email":"vaibhav.j1@tcs.com","username":"vaibworld"},"ref":"refs/changes/85/205385/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/85/205385/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/85/205385/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/85/205385/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/85/205385/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/85/205385/1"}}},"commit":{"parents":[{"commit":"d9d586942bf3f78ba174eb5832f60d80a7c839ca","subject":"Extend unittests coverage for v2 tasks module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d9d586942bf3f78ba174eb5832f60d80a7c839ca"}]}],"author":{"name":"vaibworld","email":"vaibhav.j1@tcs.com","date":"2015-07-23 04:58:29.000000000","tz":330},"committer":{"name":"vaibworld","email":"vaibhav.j1@tcs.com","date":"2015-07-23 05:01:04.000000000","tz":330},"subject":"Made name and disk-format mandatory in CLI","message":"Made name and disk-format mandatory in CLI\n\nfor glance image creation name and\ndisk-format made mandatory in cli as in horizon.\n\nChange-Id: I0489e180f577e1a33193dd1b6da6d4d524d61283\nCloses-Bug: 1420809\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/92cf09502b544f5e77f10a69de7c58c71510c338"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/92cf09502b544f5e77f10a69de7c58c71510c338"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}