)]}'
{"id":"openstack%2Fpython-glanceclient~209051","triplet_id":"openstack%2Fpython-glanceclient~master~Ie2f3e2c2f71835e6415036f5cfb22c20843b9f57","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1481341","hashtags":[],"change_id":"Ie2f3e2c2f71835e6415036f5cfb22c20843b9f57","subject":"Allows upload to fail early when missing formats","status":"ABANDONED","created":"2015-08-04 13:08:05.000000000","updated":"2015-11-10 16:11:46.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3d10f0fa68100dc6b7bca253c64794ff9004657b","_number":209051,"virtual_id_number":209051,"owner":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-08-05 18:20:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"value":-2,"date":"2015-09-16 08:29:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-05 18:20:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-09-16 08:29:06.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"}],"messages":[{"id":"d0317ca85e857d74392509ed2b4135255ed2a11f","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-08-04 13:08:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ce81194a432172c3aae6b0682240644d3243ffd8","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-08-04 13:08:54.000000000","message":"Patch Set 1: Workflow-1\n\nNeed to add some tests.","accounts_in_message":[],"_revision_number":1},{"id":"197f425a5da5f590973433c6a7f77add6a9a2f5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-04 15:45:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/51/209051/1/check/gate-python-glanceclient-python26/1444943/ : SUCCESS in 2m 08s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/51/209051/1/check/gate-python-glanceclient-pep8/93ebbfa/ : SUCCESS in 1m 26s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/51/209051/1/check/gate-python-glanceclient-docs/c67c158//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-glanceclient-python27 http://logs.openstack.org/51/209051/1/check/gate-python-glanceclient-python27/693a592/ : SUCCESS in 1m 28s\n- gate-python-glanceclient-python34 http://logs.openstack.org/51/209051/1/check/gate-python-glanceclient-python34/e21e567/ : SUCCESS in 2m 49s\n- gate-python-glanceclient-pypy http://logs.openstack.org/51/209051/1/check/gate-python-glanceclient-pypy/3e544ae/ : FAILURE in 1m 40s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/51/209051/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/238aa51/ : SUCCESS in 58m 39s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/51/209051/1/check/gate-glanceclient-dsvm-functional/7428cc7/ : SUCCESS in 21m 26s","accounts_in_message":[],"_revision_number":1},{"id":"6ec58c6debade945b1fe7692362a4d2e2212c847","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-08-05 13:25:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2487c5feb93d036033788450eee8246fde652501","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-05 15:12:46.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/51/209051/2/check/gate-python-glanceclient-python26/d0afb99/ : SUCCESS in 2m 07s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/51/209051/2/check/gate-python-glanceclient-pep8/5191680/ : FAILURE in 1m 31s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/51/209051/2/check/gate-python-glanceclient-docs/4c10f09//doc/build/html/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-python27 http://logs.openstack.org/51/209051/2/check/gate-python-glanceclient-python27/111a71a/ : SUCCESS in 2m 03s\n- gate-python-glanceclient-python34 http://logs.openstack.org/51/209051/2/check/gate-python-glanceclient-python34/ae805b5/ : SUCCESS in 1m 57s\n- gate-python-glanceclient-pypy http://logs.openstack.org/51/209051/2/check/gate-python-glanceclient-pypy/b6fbe4c/ : FAILURE in 1m 50s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/51/209051/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/b2bbcdb/ : SUCCESS in 56m 21s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/51/209051/2/check/gate-glanceclient-dsvm-functional/d0796d4/ : SUCCESS in 27m 32s","accounts_in_message":[],"_revision_number":2},{"id":"8158066ea840b760067386dbc5e90ee53d615a16","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-08-05 16:07:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8eacaad12a4abefc9a972b70755228a16ffdd314","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-05 18:20:30.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/51/209051/3/check/gate-python-glanceclient-python26/2c3af02/ : SUCCESS in 1m 37s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/51/209051/3/check/gate-python-glanceclient-pep8/1bcd529/ : SUCCESS in 1m 41s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/51/209051/3/check/gate-python-glanceclient-docs/583a874//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-glanceclient-python27 http://logs.openstack.org/51/209051/3/check/gate-python-glanceclient-python27/70501bd/ : SUCCESS in 2m 01s\n- gate-python-glanceclient-python34 http://logs.openstack.org/51/209051/3/check/gate-python-glanceclient-python34/d02d17e/ : SUCCESS in 3m 06s\n- gate-python-glanceclient-pypy http://logs.openstack.org/51/209051/3/check/gate-python-glanceclient-pypy/3d2ce74/ : FAILURE in 1m 52s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/51/209051/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/361f159/ : SUCCESS in 55m 47s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/51/209051/3/check/gate-glanceclient-dsvm-functional/6c9c6a6/ : SUCCESS in 20m 30s","accounts_in_message":[],"_revision_number":3},{"id":"f62c934703606059c81318116bcde44810138f87","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-16 08:29:06.000000000","message":"Patch Set 3: Code-Review-2\n\nI really think these checks belong to the server and a proper 400 error should be returned.\n\nIf images are being created on the server when these fields are missing, then we should fix the API rather than the client","accounts_in_message":[],"_revision_number":3},{"id":"44d1b3a76c64bf0aabda9473cd1a000bf9136fda","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-11-10 16:11:46.000000000","message":"Abandoned\n\nAbandoning due to -2 from a core.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"dfd732c415a445997005ed1317b2817d82b571d6","revisions":{"c30e3398011362c68ec3553d8b76e140e205c8a3":{"kind":"REWORK","_number":1,"created":"2015-08-04 13:08:05.000000000","uploader":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"ref":"refs/changes/51/209051/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/51/209051/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/1"}}},"commit":{"parents":[{"commit":"099b49a66a8f1097632bd338d7f9747de11af9f4","subject":"Merge \"Account for dictionary order in test_shell.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/099b49a66a8f1097632bd338d7f9747de11af9f4"}]}],"author":{"name":"Niall Bunting","email":"niall.bunting@hp.com","date":"2015-08-04 12:55:07.000000000","tz":0},"committer":{"name":"Niall Bunting","email":"niall.bunting@hp.com","date":"2015-08-04 13:06:27.000000000","tz":0},"subject":"Allows upload to fail early when missing formats","message":"Allows upload to fail early when missing formats\n\nThis checks that if a file argument is included in a\nimage create and disk and container format are missing\nthen it will throw an exception. Failing early will stop\nthe creation of images that fale to have there image data\nuploaded, meaning the command will fail it a way that\nwould be more expected from operators.\n\nChange-Id: Ie2f3e2c2f71835e6415036f5cfb22c20843b9f57\nCloses-Bug: 1481341\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c30e3398011362c68ec3553d8b76e140e205c8a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c30e3398011362c68ec3553d8b76e140e205c8a3"}]},"branch":"refs/heads/master"},"76afb6f8bd4e4350b44ef25eeb89cbd6b2b82980":{"kind":"REWORK","_number":2,"created":"2015-08-05 13:25:16.000000000","uploader":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"ref":"refs/changes/51/209051/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/51/209051/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/2"}}},"commit":{"parents":[{"commit":"099b49a66a8f1097632bd338d7f9747de11af9f4","subject":"Merge \"Account for dictionary order in test_shell.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/099b49a66a8f1097632bd338d7f9747de11af9f4"}]}],"author":{"name":"Niall Bunting","email":"niall.bunting@hp.com","date":"2015-08-04 12:55:07.000000000","tz":0},"committer":{"name":"Niall Bunting","email":"niall.bunting@hp.com","date":"2015-08-05 13:22:35.000000000","tz":0},"subject":"Allows upload to fail early when missing formats","message":"Allows upload to fail early when missing formats\n\nThis checks that if a file argument is included in a\nimage create and disk and container format are missing\nthen it will throw an exception. Failing early will stop\nthe creation of images that fale to have there image data\nuploaded, meaning the command will fail it a way that\nwould be more expected from operators.\n\nChange-Id: Ie2f3e2c2f71835e6415036f5cfb22c20843b9f57\nCloses-Bug: 1481341\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/76afb6f8bd4e4350b44ef25eeb89cbd6b2b82980"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/76afb6f8bd4e4350b44ef25eeb89cbd6b2b82980"}]},"branch":"refs/heads/master"},"dfd732c415a445997005ed1317b2817d82b571d6":{"kind":"REWORK","_number":3,"created":"2015-08-05 16:07:17.000000000","uploader":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"ref":"refs/changes/51/209051/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/51/209051/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/51/209051/3"}}},"commit":{"parents":[{"commit":"099b49a66a8f1097632bd338d7f9747de11af9f4","subject":"Merge \"Account for dictionary order in test_shell.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/099b49a66a8f1097632bd338d7f9747de11af9f4"}]}],"author":{"name":"Niall Bunting","email":"niall.bunting@hp.com","date":"2015-08-04 12:55:07.000000000","tz":0},"committer":{"name":"Niall Bunting","email":"niall.bunting@hp.com","date":"2015-08-05 16:05:19.000000000","tz":0},"subject":"Allows upload to fail early when missing formats","message":"Allows upload to fail early when missing formats\n\nThis checks that if a file argument is included in a\nimage create and disk and container format are missing\nthen it will throw an exception. Failing early will stop\nthe creation of images that fale to have there image data\nuploaded, meaning the command will fail it a way that\nwould be more expected from operators.\n\nChange-Id: Ie2f3e2c2f71835e6415036f5cfb22c20843b9f57\nCloses-Bug: 1481341\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dfd732c415a445997005ed1317b2817d82b571d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dfd732c415a445997005ed1317b2817d82b571d6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}