)]}'
{"glanceclient/shell.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"cd68401b453268b80dba98d5d2cca1171bcd19ce","unresolved":false,"context_lines":[{"line_number":619,"context_line":"                   \"Supported values are %s\" % SUPPORTED_VERSIONS)"},{"line_number":620,"context_line":"            utils.exit(msg\u003dmsg)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        if not options.os_image_api_version and api_version \u003d\u003d 2:"},{"line_number":623,"context_line":"            switch_version \u003d True"},{"line_number":624,"context_line":"            client \u003d self._get_versioned_client(\u00272\u0027, options,"},{"line_number":625,"context_line":"                                                force_auth\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_64e5bca6","line":622,"updated":"2015-09-02 15:41:57.000000000","message":"The logic looks good here.\n\n(Wonder if some of this could be tidied into a function?)","commit_id":"2861312bf894403517679f8fef612fa4230e087e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a0ebc75e21a0733090b07e2e8967a748a9f318b1","unresolved":false,"context_lines":[{"line_number":619,"context_line":"                   \"Supported values are %s\" % SUPPORTED_VERSIONS)"},{"line_number":620,"context_line":"            utils.exit(msg\u003dmsg)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        if not options.os_image_api_version and api_version \u003d\u003d 2:"},{"line_number":623,"context_line":"            switch_version \u003d True"},{"line_number":624,"context_line":"            client \u003d self._get_versioned_client(\u00272\u0027, options,"},{"line_number":625,"context_line":"                                                force_auth\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_aa6716b6","line":622,"in_reply_to":"da20952f_64e5bca6","updated":"2015-09-02 17:52:56.000000000","message":"Yes but I\u0027m doing that as part of another re-factor in a patch I haven\u0027t pushed.","commit_id":"2861312bf894403517679f8fef612fa4230e087e"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"65951905efa72ed25711cc3555954cfac36fa192","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            resp, body \u003d client.http_client.get(\u0027/versions\u0027)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"            for version in body[\u0027versions\u0027]:"},{"line_number":630,"context_line":"                if version[\u0027id\u0027].startswith(\u00272\u0027):"},{"line_number":631,"context_line":"                    # NOTE(flaper87): We know v2 is enabled in the server,"},{"line_number":632,"context_line":"                    # which means we should be able to get the schemas and"},{"line_number":633,"context_line":"                    # move on."}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_64037cb9","line":630,"updated":"2015-09-02 15:31:51.000000000","message":"changing \u00272\u0027 to \u0027v2\u0027 I think works","commit_id":"2861312bf894403517679f8fef612fa4230e087e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a0ebc75e21a0733090b07e2e8967a748a9f318b1","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            resp, body \u003d client.http_client.get(\u0027/versions\u0027)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"            for version in body[\u0027versions\u0027]:"},{"line_number":630,"context_line":"                if version[\u0027id\u0027].startswith(\u00272\u0027):"},{"line_number":631,"context_line":"                    # NOTE(flaper87): We know v2 is enabled in the server,"},{"line_number":632,"context_line":"                    # which means we should be able to get the schemas and"},{"line_number":633,"context_line":"                    # move on."}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6a081eda","line":630,"in_reply_to":"da20952f_64037cb9","updated":"2015-09-02 17:52:56.000000000","message":"Oh, very good catch","commit_id":"2861312bf894403517679f8fef612fa4230e087e"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"cd68401b453268b80dba98d5d2cca1171bcd19ce","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                    # NOTE(flaper87): We know v2 is enabled in the server,"},{"line_number":632,"context_line":"                    # which means we should be able to get the schemas and"},{"line_number":633,"context_line":"                    # move on."},{"line_number":634,"context_line":"                    switch_version \u003d self._cache_schemas(options, client)"},{"line_number":635,"context_line":"                    break"},{"line_number":636,"context_line":"            else:"},{"line_number":637,"context_line":"                switch_version \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_248fc424","line":634,"updated":"2015-09-02 15:41:57.000000000","message":"Do we still need to couple switch_version to _cache_schemas?\n\nAt this point we know v2 is supported. Why do we want to switch if caching schemas fails?","commit_id":"2861312bf894403517679f8fef612fa4230e087e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a0ebc75e21a0733090b07e2e8967a748a9f318b1","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                    # NOTE(flaper87): We know v2 is enabled in the server,"},{"line_number":632,"context_line":"                    # which means we should be able to get the schemas and"},{"line_number":633,"context_line":"                    # move on."},{"line_number":634,"context_line":"                    switch_version \u003d self._cache_schemas(options, client)"},{"line_number":635,"context_line":"                    break"},{"line_number":636,"context_line":"            else:"},{"line_number":637,"context_line":"                switch_version \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_aaecf6f3","line":634,"in_reply_to":"da20952f_248fc424","updated":"2015-09-02 17:52:56.000000000","message":"I just didn\u0027t want to change the current behavior w.r.t schemas, Just trying to reduce the number of changes to make the patch backportable in case we need to.\n\nI believe we could skip the fallback if schemas fail.","commit_id":"2861312bf894403517679f8fef612fa4230e087e"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"113028ec2e30d21f7d41da36fffc34413949708b","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                    # NOTE(flaper87): We know v2 is enabled in the server,"},{"line_number":632,"context_line":"                    # which means we should be able to get the schemas and"},{"line_number":633,"context_line":"                    # move on."},{"line_number":634,"context_line":"                    switch_version \u003d self._cache_schemas(options, client)"},{"line_number":635,"context_line":"                    break"},{"line_number":636,"context_line":"            else:"},{"line_number":637,"context_line":"                switch_version \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_49ac2835","line":634,"updated":"2015-09-03 10:39:38.000000000","message":"\u003e I believe we could skip the fallback if schemas fail.\n\nI think this makes sense. I think we could decouple the schema cache and the fallback logic.","commit_id":"6222e012ba775b318bcca97bda29a06b39ffb91c"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"113028ec2e30d21f7d41da36fffc34413949708b","unresolved":false,"context_lines":[{"line_number":634,"context_line":"                    switch_version \u003d self._cache_schemas(options, client)"},{"line_number":635,"context_line":"                    break"},{"line_number":636,"context_line":"            else:"},{"line_number":637,"context_line":"                switch_version \u003d True"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"            if switch_version:"},{"line_number":640,"context_line":"                print(\u0027WARNING: The client is falling back to v1 because\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_2973f481","line":637,"updated":"2015-09-03 10:39:38.000000000","message":"Do we need this else statement? (switch_version is already True)","commit_id":"6222e012ba775b318bcca97bda29a06b39ffb91c"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"db93d91765bb77f824145372e78baf91f7002acc","unresolved":false,"context_lines":[{"line_number":634,"context_line":"                    switch_version \u003d self._cache_schemas(options, client)"},{"line_number":635,"context_line":"                    break"},{"line_number":636,"context_line":"            else:"},{"line_number":637,"context_line":"                switch_version \u003d True"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"            if switch_version:"},{"line_number":640,"context_line":"                print(\u0027WARNING: The client is falling back to v1 because\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_38b6c5f9","line":637,"in_reply_to":"da20952f_2973f481","updated":"2015-09-03 20:14:49.000000000","message":"we don\u0027t, this was from a previous version of the patch.","commit_id":"6222e012ba775b318bcca97bda29a06b39ffb91c"}]}