)]}'
{"glanceclient/common/utils.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"5ed0da21dd84d351686c4a7fce281f397dab13e6","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"def safe_header(name, value):"},{"line_number":453,"context_line":"    if name in SENSITIVE_HEADERS and value is not None:"},{"line_number":454,"context_line":"        v \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":455,"context_line":"        h \u003d hashlib.sha1(v)"},{"line_number":456,"context_line":"        d \u003d h.hexdigest()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_76ab9275","line":453,"updated":"2015-09-07 12:03:06.000000000","message":"just one tiny optimization nit:\n\nCould you first check for nulless and then check if it\u0027s in the list?","commit_id":"251c809ea20eaff58d4a0d3d654578a2686b3327"}],"glanceclient/tests/unit/test_utils.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"f164b7c9a782a31fc3166d646b969e30c7664262","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        for sensitive_header in utils.SENSITIVE_HEADERS:"},{"line_number":188,"context_line":"            (name, value) \u003d utils.safe_header(sensitive_header, \u0027somestring\u0027)"},{"line_number":189,"context_line":"            self.assertEqual(sensitive_header, name)"},{"line_number":190,"context_line":"            self.assertEqual(True, value.startswith(\"{SHA1}\"))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"            (name, value) \u003d utils.safe_header(sensitive_header, None)"},{"line_number":193,"context_line":"            self.assertEqual(sensitive_header, name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_5b046a16","line":190,"updated":"2015-09-07 17:47:45.000000000","message":"assertTrue(value.startswith(\"{SHA1}\")) looks better here","commit_id":"fcdd8367cf8739f5c465b4903aa717d7b277760e"}]}