)]}'
{"id":"openstack%2Fpython-glanceclient~219660","triplet_id":"openstack%2Fpython-glanceclient~master~I56944a382fd546eba0a6dd6d6b1cecf83b1dc106","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1491311","hashtags":[],"change_id":"I56944a382fd546eba0a6dd6d6b1cecf83b1dc106","subject":"check for None value in utils.safe_header","status":"MERGED","created":"2015-09-02 11:55:29.000000000","updated":"2015-09-08 08:23:48.000000000","submitted":"2015-09-08 08:23:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"abf3d04f318ed79cf26052b6c9f4d69b5533d6f0","_number":219660,"virtual_id_number":219660,"owner":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-09-08 08:23:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-09-07 23:44:49.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"value":2,"date":"2015-09-08 07:24:58.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"value":1,"date":"2015-09-08 07:24:58.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-07 23:44:49.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2015-09-08 07:24:58.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2015-09-08 08:23:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4b2631a8a1ce33c9031d8845c3b118943647be2c","author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"date":"2015-09-02 11:55:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ab7b1d4191be26be172f973fa707fb03cc23c54","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-02 12:52:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/60/219660/1/check/gate-python-glanceclient-python26/76c1755/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/60/219660/1/check/gate-python-glanceclient-pep8/de9582f/ : SUCCESS in 58s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/60/219660/1/check/gate-python-glanceclient-docs/ae50e33//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-glanceclient-python27 http://logs.openstack.org/60/219660/1/check/gate-python-glanceclient-python27/f43c450/ : SUCCESS in 1m 11s\n- gate-python-glanceclient-python34 http://logs.openstack.org/60/219660/1/check/gate-python-glanceclient-python34/227e55e/ : SUCCESS in 1m 43s\n- gate-python-glanceclient-pypy http://logs.openstack.org/60/219660/1/check/gate-python-glanceclient-pypy/342a5e7/ : FAILURE in 1m 39s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/60/219660/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/08e4e66/ : SUCCESS in 52m 44s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/60/219660/1/check/gate-glanceclient-dsvm-functional/64997a6/ : SUCCESS in 20m 39s","accounts_in_message":[],"_revision_number":1},{"id":"5ed0da21dd84d351686c4a7fce281f397dab13e6","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-07 12:03:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nlooks good, just one nit","accounts_in_message":[],"_revision_number":1},{"id":"e7e2bbacafd01c94d239d98ca2fac8a1fd4c9851","author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"date":"2015-09-07 12:10:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"25cad911e0c9085dc5a24be2b7387652930d7177","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-07 13:23:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/60/219660/2/check/gate-python-glanceclient-python26/dc0e785/ : SUCCESS in 1m 01s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/60/219660/2/check/gate-python-glanceclient-pep8/ec7dc32/ : SUCCESS in 56s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/60/219660/2/check/gate-python-glanceclient-docs/c5f675d//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-python27 http://logs.openstack.org/60/219660/2/check/gate-python-glanceclient-python27/7f8ac36/ : SUCCESS in 1m 10s\n- gate-python-glanceclient-python34 http://logs.openstack.org/60/219660/2/check/gate-python-glanceclient-python34/13d963a/ : SUCCESS in 1m 48s\n- gate-python-glanceclient-pypy http://logs.openstack.org/60/219660/2/check/gate-python-glanceclient-pypy/2f4de2d/ : FAILURE in 2m 25s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/60/219660/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/7132dcd/ : SUCCESS in 1h 11m 47s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/60/219660/2/check/gate-glanceclient-dsvm-functional/7d2c630/ : SUCCESS in 20m 03s","accounts_in_message":[],"_revision_number":2},{"id":"f164b7c9a782a31fc3166d646b969e30c7664262","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-09-07 17:47:45.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nJust another nit :) I will +2 after amendment.","accounts_in_message":[],"_revision_number":2},{"id":"f47a10d4a7e961d7c8bbffdc8786bbbd5180fb47","author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"date":"2015-09-07 21:24:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3f11ba6f141b8bd12114f1fee28d5e80c4111f57","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-07 22:43:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/60/219660/3/check/gate-python-glanceclient-python26/495bb2d/ : SUCCESS in 1m 08s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/60/219660/3/check/gate-python-glanceclient-pep8/2a4994a/ : SUCCESS in 46s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/60/219660/3/check/gate-python-glanceclient-docs/a11facb//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-glanceclient-python27 http://logs.openstack.org/60/219660/3/check/gate-python-glanceclient-python27/7fc5908/ : SUCCESS in 1m 00s\n- gate-python-glanceclient-python34 http://logs.openstack.org/60/219660/3/check/gate-python-glanceclient-python34/dfa8d74/ : SUCCESS in 1m 25s\n- gate-python-glanceclient-pypy http://logs.openstack.org/60/219660/3/check/gate-python-glanceclient-pypy/e7f3fc4/ : FAILURE in 1m 56s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/60/219660/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/8fd92b3/ : SUCCESS in 1h 18m 08s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/60/219660/3/check/gate-glanceclient-dsvm-functional/8a078b7/ : SUCCESS in 19m 45s","accounts_in_message":[],"_revision_number":3},{"id":"a290f9855bc462a7d0e434a7c230bc162f357c4c","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-09-07 23:44:49.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0ff65786a90ea163ff30d81c9790807eb91ac847","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-08 07:24:58.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"5b5a2f5ead49fba2f62a65669319a4e9ea8f2af1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 07:25:03.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"f0cd93a9e455f73b7a5126396b98f3988bb79d18","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 08:23:47.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/60/219660/3/gate/gate-python-glanceclient-python26/9aa05b5/ : SUCCESS in 1m 08s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/60/219660/3/gate/gate-python-glanceclient-docs/e363378//doc/build/html/ : SUCCESS in 1m 50s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/60/219660/3/gate/gate-python-glanceclient-pep8/b35e620/ : SUCCESS in 1m 02s\n- gate-python-glanceclient-python27 http://logs.openstack.org/60/219660/3/gate/gate-python-glanceclient-python27/70ff6db/ : SUCCESS in 1m 46s\n- gate-python-glanceclient-python34 http://logs.openstack.org/60/219660/3/gate/gate-python-glanceclient-python34/b09a617/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/60/219660/3/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/6ebf01c/ : SUCCESS in 58m 43s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/60/219660/3/gate/gate-glanceclient-dsvm-functional/1b47ffd/ : SUCCESS in 34m 47s","accounts_in_message":[],"_revision_number":3},{"id":"bbdde8844463d3ca58b095bda7f442826ff9b41f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 08:23:48.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"75ec9033c2c29dfd72238dd20ecfb4d35ce95cee","revisions":{"251c809ea20eaff58d4a0d3d654578a2686b3327":{"kind":"REWORK","_number":1,"created":"2015-09-02 11:55:29.000000000","uploader":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"ref":"refs/changes/60/219660/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/60/219660/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/1"}}},"commit":{"parents":[{"commit":"1e2274aef011c143ef0ae421b45755babaff3652","subject":"Password should be prompted once","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1e2274aef011c143ef0ae421b45755babaff3652"}]}],"author":{"name":"David Edery","email":"david.edery@alcatel-lucent.com","date":"2015-09-02 11:50:47.000000000","tz":180},"committer":{"name":"David Edery","email":"david.edery@alcatel-lucent.com","date":"2015-09-02 11:55:32.000000000","tz":180},"subject":"check for None value in utils.safe_header","message":"check for None value in utils.safe_header\n\nIn case that a sensetive header (that should be obscured by its SHA1\nhash) is None, the safe_header throws an exception which fails the\ncalling process and by that may harm the functionality.\n\nChange-Id: I56944a382fd546eba0a6dd6d6b1cecf83b1dc106\nCloses-Bug: #1491311\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/251c809ea20eaff58d4a0d3d654578a2686b3327"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/251c809ea20eaff58d4a0d3d654578a2686b3327"}]},"branch":"refs/heads/master"},"fcdd8367cf8739f5c465b4903aa717d7b277760e":{"kind":"REWORK","_number":2,"created":"2015-09-07 12:10:49.000000000","uploader":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"ref":"refs/changes/60/219660/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/60/219660/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/2"}}},"commit":{"parents":[{"commit":"1e2274aef011c143ef0ae421b45755babaff3652","subject":"Password should be prompted once","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1e2274aef011c143ef0ae421b45755babaff3652"}]}],"author":{"name":"David Edery","email":"david.edery@alcatel-lucent.com","date":"2015-09-02 11:50:47.000000000","tz":180},"committer":{"name":"David Edery","email":"david.edery@alcatel-lucent.com","date":"2015-09-07 12:10:26.000000000","tz":180},"subject":"check for None value in utils.safe_header","message":"check for None value in utils.safe_header\n\nIn case that a sensetive header (that should be obscured by its SHA1\nhash) is None, the safe_header throws an exception which fails the\ncalling process and by that may harm the functionality.\n\nChange-Id: I56944a382fd546eba0a6dd6d6b1cecf83b1dc106\nCloses-Bug: #1491311\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fcdd8367cf8739f5c465b4903aa717d7b277760e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fcdd8367cf8739f5c465b4903aa717d7b277760e"}]},"branch":"refs/heads/master"},"75ec9033c2c29dfd72238dd20ecfb4d35ce95cee":{"kind":"REWORK","_number":3,"created":"2015-09-07 21:24:52.000000000","uploader":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"ref":"refs/changes/60/219660/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/60/219660/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/60/219660/3"}}},"commit":{"parents":[{"commit":"1e2274aef011c143ef0ae421b45755babaff3652","subject":"Password should be prompted once","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1e2274aef011c143ef0ae421b45755babaff3652"}]}],"author":{"name":"David Edery","email":"david.edery@alcatel-lucent.com","date":"2015-09-02 11:50:47.000000000","tz":180},"committer":{"name":"David Edery","email":"david.edery@alcatel-lucent.com","date":"2015-09-07 21:24:36.000000000","tz":180},"subject":"check for None value in utils.safe_header","message":"check for None value in utils.safe_header\n\nIn case that a sensetive header (that should be obscured by its SHA1\nhash) is None, the safe_header throws an exception which fails the\ncalling process and by that may harm the functionality.\n\nChange-Id: I56944a382fd546eba0a6dd6d6b1cecf83b1dc106\nCloses-Bug: #1491311\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/75ec9033c2c29dfd72238dd20ecfb4d35ce95cee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/75ec9033c2c29dfd72238dd20ecfb4d35ce95cee"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}