)]}'
{"glanceclient/shell.py":[{"author":{"_account_id":16421,"name":"Edmund Rhudy","email":"erhudy@bloomberg.net","username":"erhudy"},"change_message_id":"6eb712ac9147c677bce6a21fa31162358e7a0f73","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        client \u003d self._get_versioned_client(api_version, args)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if getattr(args.func, \u0027backwards\u0027, None) is not None:"},{"line_number":700,"context_line":"            for compatable in args.func.backwards:"},{"line_number":701,"context_line":"                compatable_underscore \u003d compatable[0][2:].replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":702,"context_line":"                if getattr(args, compatable_underscore, None) is not None:"},{"line_number":703,"context_line":"                    print(\u0027WARNING: %s is deprecated.\u0027 % compatable[0],"}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_a4e84b7c","line":700,"updated":"2015-09-11 20:31:40.000000000","message":"Nit: this (and other instances elsewhere, both in this file and another) should be \"compatible\" instead of \"compatable\".","commit_id":"2670d03e6bcc11a3911131d4d6043e97d52a9c35"}],"glanceclient/tests/unit/v2/test_shell_v2.py":[{"author":{"_account_id":16421,"name":"Edmund Rhudy","email":"erhudy@bloomberg.net","username":"erhudy"},"change_message_id":"6eb712ac9147c677bce6a21fa31162358e7a0f73","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                filters\u003dexp_img_filters)"},{"line_number":297,"context_line":"            utils.print_list.assert_called_once_with({}, [\u0027ID\u0027, \u0027Name\u0027])"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def test_backwards_compatable_with_v1_image_list(self):"},{"line_number":300,"context_line":"        input \u003d {"},{"line_number":301,"context_line":"            \u0027limit\u0027: None,"},{"line_number":302,"context_line":"            \u0027page_size\u0027: 18,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_a7992d6f","line":299,"updated":"2015-09-11 20:31:40.000000000","message":"Is the intention here to test invoking the v2 version of the API with v1 flags, or vice versa, or issue both sets of flags simultaneously?","commit_id":"2670d03e6bcc11a3911131d4d6043e97d52a9c35"},{"author":{"_account_id":16421,"name":"Edmund Rhudy","email":"erhudy@bloomberg.net","username":"erhudy"},"change_message_id":"6eb712ac9147c677bce6a21fa31162358e7a0f73","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                \u0027visibility\u0027: True,"},{"line_number":329,"context_line":"                \u0027checksum\u0027: \u0027fake_checksum\u0027,"},{"line_number":330,"context_line":"                \u0027tag\u0027: \u0027fake tag\u0027,"},{"line_number":331,"context_line":"                \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":332,"context_line":"                \u0027owner\u0027: \u0027test\u0027,"},{"line_number":333,"context_line":"                \u0027status\u0027: \u0027queued\u0027"},{"line_number":334,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":14,"id":"da20952f_e7be45d3","line":331,"updated":"2015-09-11 20:31:40.000000000","message":"The visibility key is set twice in this list.","commit_id":"2670d03e6bcc11a3911131d4d6043e97d52a9c35"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"f5ec583900bf00f191cd2d05abcdd4651f84701b","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                \u0027visibility\u0027: True,"},{"line_number":329,"context_line":"                \u0027checksum\u0027: \u0027fake_checksum\u0027,"},{"line_number":330,"context_line":"                \u0027tag\u0027: \u0027fake tag\u0027,"},{"line_number":331,"context_line":"                \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":332,"context_line":"                \u0027owner\u0027: \u0027test\u0027,"},{"line_number":333,"context_line":"                \u0027status\u0027: \u0027queued\u0027"},{"line_number":334,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_b1aa5d6f","line":331,"in_reply_to":"da20952f_e7be45d3","updated":"2015-09-14 09:49:35.000000000","message":"This is because the visibility key, will now exist. Where as in the list before it does not.","commit_id":"2670d03e6bcc11a3911131d4d6043e97d52a9c35"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"b6cf4b9356d8c7c851c466e981057a71275b0057","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"\"\"Update an existing image.\"\"\""},{"line_number":122,"context_line":"    # For backwards compatablity"},{"line_number":123,"context_line":"    is_public \u003d str(getattr(args, \u0027is_public\u0027, None)).lower()"},{"line_number":124,"context_line":"    if is_public.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":125,"context_line":"        args.visibility \u003d \u0027public\u0027"},{"line_number":126,"context_line":"    if is_public \u003d\u003d \u0027false\u0027:"},{"line_number":127,"context_line":"        args.visibility \u003d \u0027private\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_eabe6eff","line":124,"updated":"2015-09-09 17:57:14.000000000","message":"Do we need lower two() times?","commit_id":"5315ce80fd21974e8fcef6fe84b5c0624597ae1d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"b6cf4b9356d8c7c851c466e981057a71275b0057","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # For backwards compatablity"},{"line_number":123,"context_line":"    is_public \u003d str(getattr(args, \u0027is_public\u0027, None)).lower()"},{"line_number":124,"context_line":"    if is_public.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":125,"context_line":"        args.visibility \u003d \u0027public\u0027"},{"line_number":126,"context_line":"    if is_public \u003d\u003d \u0027false\u0027:"},{"line_number":127,"context_line":"        args.visibility \u003d \u0027private\u0027"},{"line_number":128,"context_line":"    is_protected \u003d str(getattr(args, \u0027is_protected\u0027, None)).lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_4dfe9406","line":125,"updated":"2015-09-09 17:57:14.000000000","message":"I don\u0027t see visibility listed under args? Where does it get set?","commit_id":"5315ce80fd21974e8fcef6fe84b5c0624597ae1d"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"855835d467b953a92b13220e597980c59dc5046f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # For backwards compatablity"},{"line_number":123,"context_line":"    is_public \u003d str(getattr(args, \u0027is_public\u0027, None)).lower()"},{"line_number":124,"context_line":"    if is_public.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":125,"context_line":"        args.visibility \u003d \u0027public\u0027"},{"line_number":126,"context_line":"    if is_public \u003d\u003d \u0027false\u0027:"},{"line_number":127,"context_line":"        args.visibility \u003d \u0027private\u0027"},{"line_number":128,"context_line":"    is_protected \u003d str(getattr(args, \u0027is_protected\u0027, None)).lower()"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_720eba33","line":125,"in_reply_to":"da20952f_4dfe9406","updated":"2015-09-10 10:41:21.000000000","message":"I think it comes from the schema_args decorator.","commit_id":"5315ce80fd21974e8fcef6fe84b5c0624597ae1d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"b6cf4b9356d8c7c851c466e981057a71275b0057","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    if is_public \u003d\u003d \u0027false\u0027:"},{"line_number":127,"context_line":"        args.visibility \u003d \u0027private\u0027"},{"line_number":128,"context_line":"    is_protected \u003d str(getattr(args, \u0027is_protected\u0027, None)).lower()"},{"line_number":129,"context_line":"    if is_protected.lower() \u003d\u003d \u0027true\u0027:"},{"line_number":130,"context_line":"        args.protected \u003d True"},{"line_number":131,"context_line":"    if is_protected \u003d\u003d \u0027false\u0027:"},{"line_number":132,"context_line":"        args.protected \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_8a4d72c6","line":129,"updated":"2015-09-09 17:57:14.000000000","message":"do we need lower() twice?","commit_id":"5315ce80fd21974e8fcef6fe84b5c0624597ae1d"}]}