)]}'
{"id":"openstack%2Fpython-glanceclient~221234","triplet_id":"openstack%2Fpython-glanceclient~master~I8bd64cca7f1b7abdbabf4c09e3dbbcb4044e51b4","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1492887","hashtags":[],"change_id":"I8bd64cca7f1b7abdbabf4c09e3dbbcb4044e51b4","subject":"Updates default --sort behaviour","status":"MERGED","created":"2015-09-08 10:13:58.000000000","updated":"2015-09-12 14:35:55.000000000","submitted":"2015-09-10 11:52:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"929935fd31b91c36c8272f8dbe8ed420c74bcd26","_number":221234,"virtual_id_number":221234,"owner":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-09-09 12:49:37.000000000","_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2015-09-10 11:52:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"date":"2015-09-09 15:35:43.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"value":2,"date":"2015-09-10 09:13:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-09-10 09:07:38.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":2,"date":"2015-09-10 10:42:47.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":1,"date":"2015-09-10 10:42:47.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-09 12:20:27.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2015-09-10 09:07:38.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2015-09-10 09:13:20.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2015-09-10 10:42:47.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2015-09-10 11:52:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"af2b447aa1a68ab130099b4ea07dcb20653b95a6","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-09-08 10:13:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6721420d0307a705cb559e8aefd4c27c3b0415ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 11:44:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/34/221234/1/check/gate-python-glanceclient-python26/f083245/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/34/221234/1/check/gate-python-glanceclient-pep8/00da951/ : SUCCESS in 49s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/34/221234/1/check/gate-python-glanceclient-docs/735bdd1//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-glanceclient-python27 http://logs.openstack.org/34/221234/1/check/gate-python-glanceclient-python27/7c675f0/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-python34 http://logs.openstack.org/34/221234/1/check/gate-python-glanceclient-python34/ae7654e/ : SUCCESS in 2m 44s\n- gate-python-glanceclient-pypy http://logs.openstack.org/34/221234/1/check/gate-python-glanceclient-pypy/aceb0a3/ : FAILURE in 2m 16s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/34/221234/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/b05504b/ : SUCCESS in 1h 30m 12s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/34/221234/1/check/gate-glanceclient-dsvm-functional/bf8be82/ : SUCCESS in 23m 52s","accounts_in_message":[],"_revision_number":1},{"id":"79b2e65b4d74abde37cd858330c09c47a4835211","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-09-08 15:35:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5be1264f4b2d2340e8c582035ed73038a64199f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-08 17:30:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/34/221234/2/check/gate-python-glanceclient-python26/3a40f92/ : SUCCESS in 4m 48s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/34/221234/2/check/gate-python-glanceclient-pep8/56b2a21/ : SUCCESS in 50s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/34/221234/2/check/gate-python-glanceclient-docs/b7689d7//doc/build/html/ : SUCCESS in 1m 26s\n- gate-python-glanceclient-python27 http://logs.openstack.org/34/221234/2/check/gate-python-glanceclient-python27/3712994/ : SUCCESS in 1m 17s\n- gate-python-glanceclient-python34 http://logs.openstack.org/34/221234/2/check/gate-python-glanceclient-python34/843cc27/ : SUCCESS in 1m 51s\n- gate-python-glanceclient-pypy http://logs.openstack.org/34/221234/2/check/gate-python-glanceclient-pypy/c0f557c/ : FAILURE in 2m 25s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/34/221234/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/d48553c/ : SUCCESS in 1h 30m 56s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/34/221234/2/check/gate-glanceclient-dsvm-functional/efaf903/ : SUCCESS in 22m 23s","accounts_in_message":[],"_revision_number":2},{"id":"016305e6eb1805a4cf1082babd35ea232b0b767e","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-09-09 11:33:42.000000000","message":"Patch Set 2: Code-Review-1\n\nThis patch will change the default behaviour of glance image-list from sorting alphabetically to reverse alphabetically.\n\nie this:\n\n $ glance image-list\n +--------------------------------------+------+\n | ID                                   | Name |\n +--------------------------------------+------+\n | cb8341e9-1e8b-47e2-8ed5-e9c11fcc3511 | a    |\n | c4cfdc0e-2fee-41b8-ac98-7813e31adfe9 | z    |\n +--------------------------------------+------+\n\nwill become:\n\n $ glance image-list\n +--------------------------------------+------+\n | ID                                   | Name |\n +--------------------------------------+------+\n | c4cfdc0e-2fee-41b8-ac98-7813e31adfe9 | z    |\n | cb8341e9-1e8b-47e2-8ed5-e9c11fcc3511 | a    |\n +--------------------------------------+------+\n\nWe need to think about this a little.\n\n(I\u0027m not sure it\u0027s consistent with other services\u0027 behaviour for example.)\n\nOur behaviour doesn\u0027t seem to be overly consistent, eg see the discussion here:\n\nhttps://bugs.launchpad.net/python-glanceclient/+bug/1489941\n\n\nI\u0027m wondering if this may be something we need to fix in the server rather than the client?\n\nThe request \"http://glance:9292/v2/images?limit\u003d20\u0026sort\u003dname:asc\" should return the same whether or not you are running the v2 registry. (This is the case for the equivalent v1 request.)","accounts_in_message":[],"_revision_number":2},{"id":"3398e086b58ff56817f36c48c7e674580962d31a","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-09-09 12:20:27.000000000","message":"Patch Set 2: Code-Review-1\n\nHi, --sort was added in Kilo and not acceptable for Juno and previous versions.\nhttps://github.com/openstack/requirements/blob/stable/juno/global-requirements.txt#L112\n\nI think you should use stable/juno client to save backward compatibility. https://github.com/openstack/python-glanceclient/tree/stable/juno/glanceclient","accounts_in_message":[],"_revision_number":2},{"id":"9b12b9fe2df88e1c93ca1a4047b0f8af33527fbd","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-09-09 12:45:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ab80e8483a1898bb3533467deb2305fa396e0f88","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-09-09 12:49:37.000000000","message":"Patch Set 3:\n\nHi Stuart,\n\nThank you for your kind comments.\n\nI agree it is bad form to break existing behaviour. In this case, could you review the patch set 3? Instead of removing --sort, we set --sort-key and --sort-dir instead.\n\nThis has the benefit of keeping existing behaviour, as well fixing the issue of a user using v1.0.0 against a Juno registry and getting a blank list.","accounts_in_message":[],"_revision_number":3},{"id":"87cdcd3ddf70ce9edb2fe8389c0f674e9af00f90","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-09-09 12:55:05.000000000","message":"Patch Set 3:\n\nHi Mike,\n\nI agree with you that a user should not be using --sort and expecting it to work, since it is a Kilo feature.\n\nWhat I am concerned about is unwary user installing the latest glanceclient from a pip install, running `glance image-list`, and getting a blank list (which is how I ran into this bug in the first place).\n\nWould you be open to accepting the newest patch? This prevents the abovementioned scenario from occurring, yet keeps existing behaviour.","accounts_in_message":[],"_revision_number":3},{"id":"b62cf77d507a4413b765264bce9753ef83383dac","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-09-09 13:42:09.000000000","message":"Patch Set 3: Code-Review+1\n\n@Mike\n\nThanks for the additional info.\n\nIf I understand things correctly, a v2 juno server which has been configured with the registry will return an empty listing with the latest client. A v2 kilo server will work with \u0027sort\u003dname:asc\u0027.\n\nImage listing is such a fundamental operation that we really need it to work against a juno server I think.\n\nThis patch matches the default v1 behaviour, so I think it makes sense.\n\n+1 for now, just need to think about whether this perturbs anything else.","accounts_in_message":[],"_revision_number":3},{"id":"04c1c657e667e0796fa44e69b5073fddd6113aee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-09 13:45:37.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/34/221234/3/check/gate-python-glanceclient-python26/455b27d/ : SUCCESS in 2m 54s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/34/221234/3/check/gate-python-glanceclient-pep8/c103ee7/ : SUCCESS in 2m 38s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/34/221234/3/check/gate-python-glanceclient-docs/ee191d4//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-python27 http://logs.openstack.org/34/221234/3/check/gate-python-glanceclient-python27/7bbfa17/ : SUCCESS in 1m 14s\n- gate-python-glanceclient-python34 http://logs.openstack.org/34/221234/3/check/gate-python-glanceclient-python34/5cc1122/ : SUCCESS in 1m 42s\n- gate-python-glanceclient-pypy http://logs.openstack.org/34/221234/3/check/gate-python-glanceclient-pypy/00e8542/ : FAILURE in 2m 04s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/34/221234/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/1b6ecf1/ : SUCCESS in 52m 23s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/34/221234/3/check/gate-glanceclient-dsvm-functional/e49c01c/ : SUCCESS in 19m 09s","accounts_in_message":[],"_revision_number":3},{"id":"723b936370e8abd35a6540848c12fbf562af14b0","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-09 15:35:43.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"31f270de726e161e40a10d42fb465e70204a6c9e","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-09-10 01:27:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b8bf5e931a16462bda319e6af2faf7b2b208fb5a","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-09-10 09:07:38.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)\n\nOk, this will change the default v2 list from having this:\n\n?sort\u003dname:asc\n\nto this:\n\n?sort_key\u003dname\u0026sort_key\u003dasc\n\nThey are equivalent, but the new version will work against all v2 servers (including juno v2 servers with the registry configured).\n\nIf any additional sort parameters are supplied the behaviour will be the same as before.\n\nSeems like an important fix.","accounts_in_message":[],"_revision_number":3},{"id":"91f5581442a376177d1cdcac5682453d8d291455","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-09-10 09:13:20.000000000","message":"Patch Set 3: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":3},{"id":"adba6cf75e332fc2380ed4d0981134836872b16b","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-10 10:42:47.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"dc6ed8d69bd8e6c5ca74f090e2749985d27f3685","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 10:42:53.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"c42515898be93d8b1ea8e82e028d366c593eda2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 11:52:07.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/34/221234/3/gate/gate-python-glanceclient-python26/8d5fcab/ : SUCCESS in 1m 56s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/34/221234/3/gate/gate-python-glanceclient-docs/c38f2dc//doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/34/221234/3/gate/gate-python-glanceclient-pep8/f6141e4/ : SUCCESS in 56s\n- gate-python-glanceclient-python27 http://logs.openstack.org/34/221234/3/gate/gate-python-glanceclient-python27/717b344/ : SUCCESS in 2m 12s\n- gate-python-glanceclient-python34 http://logs.openstack.org/34/221234/3/gate/gate-python-glanceclient-python34/4ac7aad/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/34/221234/3/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/a432523/ : SUCCESS in 1h 08m 08s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/34/221234/3/gate/gate-glanceclient-dsvm-functional/067835c/ : SUCCESS in 31m 41s","accounts_in_message":[],"_revision_number":3},{"id":"c93300403c258f8a1d3b171febdd8e4de0f93858","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 11:52:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"ba9200b57127510b2abfd5b35472468f0854f2d1","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-09-12 14:35:55.000000000","message":"Patch Set 3:\n\nThanks Stuart, Mike, Flavio for your guidance and acceptance of the patch!","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c8c8964ddd5a49de6eb4794fba68ab4ec0400b08","revisions":{"c5613e252e1d46044a4423b8384f96cc9c36a3b8":{"kind":"REWORK","_number":1,"created":"2015-09-08 10:13:58.000000000","uploader":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"ref":"refs/changes/34/221234/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/34/221234/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/1"}}},"commit":{"parents":[{"commit":"aa4cd9dc4bba0334a0ee7db6e86ef313721c32f4","subject":"Merge \"check for None value in utils.safe_header\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/aa4cd9dc4bba0334a0ee7db6e86ef313721c32f4"}]}],"author":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-09-08 10:04:11.000000000","tz":600},"committer":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-09-08 10:04:11.000000000","tz":600},"subject":"Remove default sort for image_list","message":"Remove default sort for image_list\n\nWhen querying against a Juno glance-registry, we found that having the\nsort filter defaulting to \u0027name:asc\" results in querying the registry\nwith additional SQL parameters like the following:\n\nWHERE image_properties_2.name \u003d :name_1 AND image_properties_2.value \u003d\n:value_1\n\nThis results in a blank list being returned.\n\nChange-Id: I8bd64cca7f1b7abdbabf4c09e3dbbcb4044e51b4\nCloses-bug: #1492887\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c5613e252e1d46044a4423b8384f96cc9c36a3b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c5613e252e1d46044a4423b8384f96cc9c36a3b8"}]},"branch":"refs/heads/master"},"f6728669a01869f5026d7e79929ed28a13f4065b":{"kind":"REWORK","_number":2,"created":"2015-09-08 15:35:28.000000000","uploader":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"ref":"refs/changes/34/221234/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/34/221234/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/2"}}},"commit":{"parents":[{"commit":"aa4cd9dc4bba0334a0ee7db6e86ef313721c32f4","subject":"Merge \"check for None value in utils.safe_header\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/aa4cd9dc4bba0334a0ee7db6e86ef313721c32f4"}]}],"author":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-09-08 10:04:11.000000000","tz":600},"committer":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-09-08 15:33:57.000000000","tz":600},"subject":"Remove default --sort for `glance image-list`","message":"Remove default --sort for `glance image-list`\n\nWhen querying against a Juno glance-registry, we found that having the\n--sort option defaulting to \u0027name:asc\" results in querying the registry\nwith additional SQL parameters like the following:\n\nWHERE image_properties_2.name \u003d :name_1 AND image_properties_2.value \u003d\n:value_1\n\nas a result of handling the newer \u0027sort\u0027 filter. This results in a\nblank list being returned as the output of glance image-list.\n\nThis patch removes the default --sort when neither --sort-key nor\n--sort-dir are specified, so as to maintain backwards compatibility\nwith Juno glance-registry.\n\nChange-Id: I8bd64cca7f1b7abdbabf4c09e3dbbcb4044e51b4\nCloses-bug: #1492887\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f6728669a01869f5026d7e79929ed28a13f4065b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f6728669a01869f5026d7e79929ed28a13f4065b"}]},"branch":"refs/heads/master"},"c8c8964ddd5a49de6eb4794fba68ab4ec0400b08":{"kind":"REWORK","_number":3,"created":"2015-09-09 12:45:21.000000000","uploader":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"ref":"refs/changes/34/221234/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/34/221234/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/34/221234/3"}}},"commit":{"parents":[{"commit":"aa4cd9dc4bba0334a0ee7db6e86ef313721c32f4","subject":"Merge \"check for None value in utils.safe_header\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/aa4cd9dc4bba0334a0ee7db6e86ef313721c32f4"}]}],"author":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-09-08 10:04:11.000000000","tz":600},"committer":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-09-09 12:44:08.000000000","tz":600},"subject":"Updates default --sort behaviour","message":"Updates default --sort behaviour\n\nWhen querying against a Juno glance-registry, we found that having the\n--sort option defaulting to \u0027name:asc\" results in querying the registry\nwith additional SQL parameters like the following:\n\nWHERE image_properties_2.name \u003d :name_1 AND image_properties_2.value \u003d\n:value_1\n\nas a result of handling the newer \u0027sort\u0027 filter. This results in a\nblank list being returned as the output of glance image-list.\n\nThis patch sets the --sort-key and --sort-dir instead of --sort when\nneither --sort-key nor --sort-dir are specified, so as to maintain\nbackwards compatibility with Juno glance-registry.\n\nChange-Id: I8bd64cca7f1b7abdbabf4c09e3dbbcb4044e51b4\nCloses-bug: #1492887\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c8c8964ddd5a49de6eb4794fba68ab4ec0400b08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c8c8964ddd5a49de6eb4794fba68ab4ec0400b08"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}