)]}'
{"id":"openstack%2Fpython-glanceclient~223675","triplet_id":"openstack%2Fpython-glanceclient~master~I28fd51a4cbef40fc7c90999fe8121611c7f89f21","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1496024","hashtags":[],"change_id":"I28fd51a4cbef40fc7c90999fe8121611c7f89f21","subject":"Remove self from image-create/image-update","status":"MERGED","created":"2015-09-15 16:21:39.000000000","updated":"2015-11-23 18:18:20.000000000","submitted":"2015-11-23 18:18:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0772f09e7e4bc4a906747a864d2c707a152fe30c","_number":223675,"virtual_id_number":223675,"owner":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2015-11-23 18:18:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"date":"2015-09-30 10:27:44.000000000","_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"recommended":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"all":[{"value":1,"date":"2015-10-12 13:22:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-09-30 15:48:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":2,"date":"2015-11-23 17:09:24.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":1,"date":"2015-09-30 11:01:02.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"value":2,"date":"2015-11-19 17:40:38.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"all":[{"value":0,"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":1,"date":"2015-11-23 17:09:24.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"value":0,"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-23 18:57:53.000000000","updated_by":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"reviewer":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"state":"REVIEWER"},{"updated":"2015-09-28 20:34:59.000000000","updated_by":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"reviewer":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"state":"REVIEWER"},{"updated":"2015-09-28 21:37:06.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2015-09-30 11:01:02.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2015-09-30 15:48:29.000000000","updated_by":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"reviewer":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"state":"REVIEWER"},{"updated":"2015-10-12 13:22:19.000000000","updated_by":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"reviewer":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"state":"REVIEWER"},{"updated":"2015-11-19 17:40:38.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2015-11-23 17:09:24.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2015-11-23 18:18:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0c05356709e2ba1db70fb7b6d94ea3a7d6d6608f","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-09-15 16:21:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b3043092bc318d7acd71edbd9ba7b44a922b5396","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-15 17:34:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/75/223675/1/check/gate-python-glanceclient-python26/3ce145a/ : SUCCESS in 2m 04s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/75/223675/1/check/gate-python-glanceclient-pep8/a1ad059/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/75/223675/1/check/gate-python-glanceclient-docs/9052412//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-glanceclient-python27 http://logs.openstack.org/75/223675/1/check/gate-python-glanceclient-python27/aa33b9c/ : SUCCESS in 1m 21s\n- gate-python-glanceclient-python34 http://logs.openstack.org/75/223675/1/check/gate-python-glanceclient-python34/a4cca20/ : SUCCESS in 1m 46s\n- gate-python-glanceclient-pypy http://logs.openstack.org/75/223675/1/check/gate-python-glanceclient-pypy/514918d/ : FAILURE in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/75/223675/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/b57a887/ : SUCCESS in 1h 00m 37s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/75/223675/1/check/gate-glanceclient-dsvm-functional/11a2183/ : SUCCESS in 23m 18s","accounts_in_message":[],"_revision_number":1},{"id":"90224738711f4efaed75018bc3e47b5f8ccf0932","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-15 20:00:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"12972e8208e4ba97534bc5b2e4d2f9dc77ffdd6e","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2015-09-16 15:13:17.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"955081aba6727500697654c5490e12d03caaf9cf","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-09-16 15:30:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\n\u0027image-update\u0027 supports --owner but image-create can\u0027t (even for admins) because the v2 server only supports changing it.\n\nWe could consider a server change to allow setting the owner on image create.","accounts_in_message":[],"_revision_number":1},{"id":"828995284ca0f5a4710b15eb6d76be3f58c38c19","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2015-09-18 10:48:36.000000000","message":"Patch Set 1: Code-Review-1\n\nJust for double check, I tried to pass the tests your implemented on master and it worked correctly. So it seems that tests do not test the fix.\nHonestly, I am not even sure we need a tests for such fixes because we have a review system for such cases.","accounts_in_message":[],"_revision_number":1},{"id":"9da564a75a6af5fb9e16f7926340943d86e9f14a","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2015-09-18 10:49:19.000000000","message":"Patch Set 1:\n\nAlso, I found that image-update has --self (READ_ONLY) parameter. Would it be reasonable to fix it too?","accounts_in_message":[],"_revision_number":1},{"id":"b324fcd31662fee711331e7353b64d118f55a12d","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-09-18 12:27:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8b514c5cc1e7bef0c646343fe4e464790728a685","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2015-09-18 12:28:34.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"afaeebf15e805e6f76dd755c0ebf1afd4ca7676a","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-09-18 12:29:49.000000000","message":"Patch Set 2:\n\n@Kairat Thanks! I always assumed that basically everything needed a test. I was mistaken in that case it seems.","accounts_in_message":[],"_revision_number":2},{"id":"ad282a0e8a465ccdb8d5147f4b5eef2b080d71a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-18 13:22:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/75/223675/2/check/gate-python-glanceclient-python26/38342ba/ : SUCCESS in 1m 19s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/75/223675/2/check/gate-python-glanceclient-pep8/d4160bb/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/75/223675/2/check/gate-python-glanceclient-docs/05ed213//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-python27 http://logs.openstack.org/75/223675/2/check/gate-python-glanceclient-python27/0be270a/ : SUCCESS in 1m 11s\n- gate-python-glanceclient-python34 http://logs.openstack.org/75/223675/2/check/gate-python-glanceclient-python34/ad50d26/ : SUCCESS in 1m 42s\n- gate-python-glanceclient-pypy http://logs.openstack.org/75/223675/2/check/gate-python-glanceclient-pypy/83aaa4d/ : FAILURE in 3m 30s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/75/223675/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/0630bda/ : SUCCESS in 54m 39s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/75/223675/2/check/gate-glanceclient-dsvm-functional/d208c55/ : SUCCESS in 26m 39s","accounts_in_message":[],"_revision_number":2},{"id":"fd6cdaba92ebaaedfb604534134754077e719d35","author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"date":"2015-09-28 15:59:42.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5ce1e8966b1c72d9499b01dd9f02caf53a2ad740","author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"date":"2015-09-28 20:34:59.000000000","message":"Patch Set 2: Code-Review+1\n\nCool","accounts_in_message":[],"_revision_number":2},{"id":"70928d1aaf9d5fad758b4aeb5249f0de4d218916","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-09-28 21:37:06.000000000","message":"Patch Set 2: Code-Review-1\n\nBased on our API documentation https://bugs.launchpad.net/glance/+bug/1499368 is valid bug which renders this bug \u0026 fix invalid for the case of owner.","accounts_in_message":[],"_revision_number":2},{"id":"7d439259fa58b2732a260db57f327f30c9b28a7e","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-29 06:28:29.000000000","message":"Patch Set 2: Code-Review-1\n\nWhat happened with the tests ? :D","accounts_in_message":[],"_revision_number":2},{"id":"2c11e15adf1d94d181caf2869afe5554718beab1","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-09-29 09:50:31.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3f2d737672691b17e341e4ac5671367b43f661ad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-29 11:01:53.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/75/223675/3/check/gate-python-glanceclient-python26/25a93b4/ : SUCCESS in 1m 01s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/75/223675/3/check/gate-python-glanceclient-pep8/6ea10c2/ : SUCCESS in 1m 08s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/75/223675/3/check/gate-python-glanceclient-docs/82314e2//doc/build/html/ : SUCCESS in 55s\n- gate-python-glanceclient-python27 http://logs.openstack.org/75/223675/3/check/gate-python-glanceclient-python27/6d40a29/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-python34 http://logs.openstack.org/75/223675/3/check/gate-python-glanceclient-python34/8a88939/ : SUCCESS in 1m 39s\n- gate-python-glanceclient-pypy http://logs.openstack.org/75/223675/3/check/gate-python-glanceclient-pypy/44f8093/ : FAILURE in 2m 39s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/75/223675/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/e65a372/ : SUCCESS in 1h 11m 14s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/75/223675/3/check/gate-glanceclient-dsvm-functional/494e77d/ : SUCCESS in 20m 33s","accounts_in_message":[],"_revision_number":3},{"id":"78445f53052cad59590fd90411fef5574fc91fef","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2015-09-30 00:34:17.000000000","message":"Patch Set 3: Code-Review-1\n\nOk, I just double checked the tests on master and they are still not failing on master:) So you have two options: try to insist that tests are not needed or fix the tests.","accounts_in_message":[],"_revision_number":3},{"id":"4e6f6c425fa94e70fe391f6bd1921ee2c2865a96","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-09-30 10:20:02.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"85739caf69c788867767eb60eb08af3d497a6efc","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2015-09-30 10:27:44.000000000","message":"Patch Set 4:\n\nI had a look at improving the tests, however as the command is always going to fail I see why the current tests pass.\n\nFor a change like this though I\u0027m not sure we actually need a test, as if someone removes self from the ignored values that should be picked up in a review.","accounts_in_message":[],"_revision_number":4},{"id":"07a891724cc03f40720f94dd68df144bdf003b5b","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2015-09-30 11:01:02.000000000","message":"Patch Set 4: Code-Review+1\n\nI think this is ok without unit test","accounts_in_message":[],"_revision_number":4},{"id":"368becccba88d809f99fe6506e27958623c4daed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-30 11:26:49.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/75/223675/4/check/gate-python-glanceclient-python26/9943a23/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/75/223675/4/check/gate-python-glanceclient-pep8/74f861e/ : SUCCESS in 39s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/75/223675/4/check/gate-python-glanceclient-docs/cad81f0//doc/build/html/ : SUCCESS in 45s\n- gate-python-glanceclient-python27 http://logs.openstack.org/75/223675/4/check/gate-python-glanceclient-python27/3d263b8/ : SUCCESS in 1m 08s\n- gate-python-glanceclient-python34 http://logs.openstack.org/75/223675/4/check/gate-python-glanceclient-python34/7be92db/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-pypy http://logs.openstack.org/75/223675/4/check/gate-python-glanceclient-pypy/ee03346/ : FAILURE in 2m 00s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/75/223675/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient/a164ea6/ : SUCCESS in 1h 06m 40s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/75/223675/4/check/gate-glanceclient-dsvm-functional/aa5e741/ : SUCCESS in 23m 18s","accounts_in_message":[],"_revision_number":4},{"id":"11054e7413cc9b25e3080d256e2c15fbc079a38b","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2015-09-30 15:48:29.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"2207aae78ae84ab230ae75bc8feb71c81fd8b508","author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"date":"2015-10-12 13:22:19.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"ee557ec0c2999f07f90a226e480b12bb0b3ee3ed","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-11-19 17:40:38.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d52141a465ca28961d2d755d9385eaa96d9c2825","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-11-23 17:09:24.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"60279a3e5368eb5ae1c2bcead7f623cf64ee51e6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-23 17:09:29.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"271c0415357f7b5ec56a18160ea550a1e3a5cb25","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-23 18:18:18.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/75/223675/4/gate/gate-python-glanceclient-python26/c04aebd/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/75/223675/4/gate/gate-python-glanceclient-docs/07ef3ed//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/75/223675/4/gate/gate-python-glanceclient-pep8/2bcc53f/ : SUCCESS in 59s\n- gate-python-glanceclient-python27 http://logs.openstack.org/75/223675/4/gate/gate-python-glanceclient-python27/828d084/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-python34 http://logs.openstack.org/75/223675/4/gate/gate-python-glanceclient-python34/8597b10/ : SUCCESS in 1m 46s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/75/223675/4/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/c66540b/ : SUCCESS in 1h 07m 24s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/75/223675/4/gate/gate-glanceclient-dsvm-functional/add7545/ : SUCCESS in 29m 28s","accounts_in_message":[],"_revision_number":4},{"id":"19fad28190a2299cdfec9b72a69c9fb8ccaab4bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-23 18:18:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b396e73e73fa1c351d0a8fd106fe4e8d50379658","revisions":{"90bfd55cd3e2370a63c03e43dcc87eaa65fb71e1":{"kind":"REWORK","_number":1,"created":"2015-09-15 16:21:39.000000000","uploader":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"ref":"refs/changes/75/223675/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/75/223675/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/1"}}},"commit":{"parents":[{"commit":"86635868c1eb3aec0c065c12cb9928c613940f36","subject":"Change next version in docs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/86635868c1eb3aec0c065c12cb9928c613940f36"}]}],"author":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-15 16:17:58.000000000","tz":0},"committer":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-15 16:20:31.000000000","tz":0},"subject":"Remove owner and self from image-create","message":"Remove owner and self from image-create\n\nThese two command are not ommited when the schema is gotten. Self is\nnot meant to exist as this to do withe underlying code. And owner will\nreturn a 403 every time as it is a read only property.\n\nCloses-bug: 1496024\nChange-Id: I28fd51a4cbef40fc7c90999fe8121611c7f89f21\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/90bfd55cd3e2370a63c03e43dcc87eaa65fb71e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/90bfd55cd3e2370a63c03e43dcc87eaa65fb71e1"}]},"branch":"refs/heads/master"},"f65bc4b13f7f363739176806ed5be6da4dd18811":{"kind":"REWORK","_number":2,"created":"2015-09-18 12:27:37.000000000","uploader":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"ref":"refs/changes/75/223675/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/75/223675/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/2"}}},"commit":{"parents":[{"commit":"86635868c1eb3aec0c065c12cb9928c613940f36","subject":"Change next version in docs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/86635868c1eb3aec0c065c12cb9928c613940f36"}]}],"author":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-15 16:17:58.000000000","tz":0},"committer":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-18 12:23:58.000000000","tz":0},"subject":"Remove owner and self from image-create","message":"Remove owner and self from image-create\n\nThese properties are not omitted when the schema is used. Self is not\nmeant to be used as this to do with the underlying code. And owner will\nreturn a 403 every time as it is a read-only property.\n\nCloses-bug: 1496024\nChange-Id: I28fd51a4cbef40fc7c90999fe8121611c7f89f21\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f65bc4b13f7f363739176806ed5be6da4dd18811"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f65bc4b13f7f363739176806ed5be6da4dd18811"}]},"branch":"refs/heads/master"},"dacb2ab84790e1ef8d796d1b047e3d0e6a3bc824":{"kind":"REWORK","_number":3,"created":"2015-09-29 09:50:31.000000000","uploader":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"ref":"refs/changes/75/223675/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/75/223675/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/3"}}},"commit":{"parents":[{"commit":"86635868c1eb3aec0c065c12cb9928c613940f36","subject":"Change next version in docs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/86635868c1eb3aec0c065c12cb9928c613940f36"}]}],"author":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-15 16:17:58.000000000","tz":0},"committer":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-29 09:48:28.000000000","tz":0},"subject":"Remove self from image-create/image-update","message":"Remove self from image-create/image-update\n\nSelf is not meant to exist as it is a READ ONLY property, that is not\nmeant to exist as something the user can change.\n\nCloses-bug: 1496024\nChange-Id: I28fd51a4cbef40fc7c90999fe8121611c7f89f21\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dacb2ab84790e1ef8d796d1b047e3d0e6a3bc824"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dacb2ab84790e1ef8d796d1b047e3d0e6a3bc824"}]},"branch":"refs/heads/master"},"b396e73e73fa1c351d0a8fd106fe4e8d50379658":{"kind":"REWORK","_number":4,"created":"2015-09-30 10:20:02.000000000","uploader":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"ref":"refs/changes/75/223675/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/75/223675/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/75/223675/4"}}},"commit":{"parents":[{"commit":"86635868c1eb3aec0c065c12cb9928c613940f36","subject":"Change next version in docs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/86635868c1eb3aec0c065c12cb9928c613940f36"}]}],"author":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-15 16:17:58.000000000","tz":0},"committer":{"name":"NiallBunting","email":"niall.bunting@hp.com","date":"2015-09-30 10:19:16.000000000","tz":0},"subject":"Remove self from image-create/image-update","message":"Remove self from image-create/image-update\n\nSelf is not meant to exist as it is a READ ONLY property, that is not\nmeant to exist as something the user can change.\n\nCloses-bug: 1496024\nChange-Id: I28fd51a4cbef40fc7c90999fe8121611c7f89f21\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b396e73e73fa1c351d0a8fd106fe4e8d50379658"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b396e73e73fa1c351d0a8fd106fe4e8d50379658"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}