)]}'
{"id":"openstack%2Fpython-glanceclient~227723","triplet_id":"openstack%2Fpython-glanceclient~master~I4c9c15ba526378970da5461511ed922d42c5a9f9","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1499540","hashtags":[],"change_id":"I4c9c15ba526378970da5461511ed922d42c5a9f9","subject":"No auth when token and endpoint are passed","status":"MERGED","created":"2015-09-25 09:02:19.000000000","updated":"2015-09-25 17:12:19.000000000","submitted":"2015-09-25 17:12:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dcf4ca6d240ca9a8c05a182143e81b4726321336","_number":227723,"virtual_id_number":227723,"owner":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2015-09-25 17:12:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"date":"2015-09-25 09:51:08.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":2,"date":"2015-09-25 15:52:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":2,"date":"2015-09-25 14:12:12.000000000","_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":1,"date":"2015-09-25 09:39:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":2,"date":"2015-09-25 15:59:46.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":1,"date":"2015-09-25 15:52:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-09-25 09:02:36.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-25 09:02:36.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2015-09-25 09:39:27.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2015-09-25 14:12:12.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2015-09-25 15:52:46.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2015-09-25 15:59:46.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2015-09-25 17:12:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"db6d6fdf4383c9c9b671fc7e60cac3ca9f14fddb","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-25 09:02:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b58b72a7023698f3837f0291428c6712c6082d4a","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2015-09-25 09:39:27.000000000","message":"Patch Set 1: Code-Review+1\n\nThe fix look well. Only one question,about  https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/utils.py#L248\nI found there is no code use it. So utils.is_authentication_required here will always return True IMO.\nSo what\u0027s the use case about it?","accounts_in_message":[],"_revision_number":1},{"id":"c1aa91d20a6bdd804c2ae233cdf667e9e34076ed","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2015-09-25 09:51:08.000000000","message":"Patch Set 1:\n\nWe can consider removing it in a follow-up patch but that requires a more detailed discussion. For example, are there operations that don\u0027t require authentication?\n\nThis change is meant to be backportable, which is why I limited to fixing the issue rather than removing the decorator.","accounts_in_message":[],"_revision_number":1},{"id":"03b8fdfdedd00c10c8359f3c8a4762faab03b5c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-25 09:54:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-python26/8ce6743/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-pep8/8d5e607/ : SUCCESS in 57s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/23/227723/1/check/gate-python-glanceclient-docs/e4005af//doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-glanceclient-python27 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-python27/aaa9de5/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-python34 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-python34/e5ef690/ : SUCCESS in 1m 27s\n- gate-python-glanceclient-pypy http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-pypy/a8b10e6/ : FAILURE in 1m 53s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/23/227723/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/5aaf950/ : FAILURE in 52m 07s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/23/227723/1/check/gate-glanceclient-dsvm-functional/8557aa8/ : SUCCESS in 20m 42s","accounts_in_message":[],"_revision_number":1},{"id":"7e884a6d8c26cb6f6aa9563573becac136cc7e6f","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2015-09-25 10:43:59.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"ae82d49483ed8f137b09c19d4f74079c2cc117f3","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2015-09-25 10:44:25.000000000","message":"Patch Set 1:\n\nThanks,Flavio.","accounts_in_message":[],"_revision_number":1},{"id":"8f20164020112d19fff77a79e55bfc71522ea252","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-25 11:54:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-python26/a1638e5/ : SUCCESS in 1m 10s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-pep8/24f0156/ : SUCCESS in 1m 06s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/23/227723/1/check/gate-python-glanceclient-docs/a3943ff//doc/build/html/ : SUCCESS in 59s\n- gate-python-glanceclient-python27 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-python27/bd5e5bb/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-python34 http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-python34/e8b81a3/ : SUCCESS in 1m 26s\n- gate-python-glanceclient-pypy http://logs.openstack.org/23/227723/1/check/gate-python-glanceclient-pypy/dc0abfa/ : FAILURE in 1m 58s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/23/227723/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/f26e312/ : SUCCESS in 1h 06m 59s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/23/227723/1/check/gate-glanceclient-dsvm-functional/ed9378c/ : SUCCESS in 20m 47s","accounts_in_message":[],"_revision_number":1},{"id":"b65ed69bfaf85fcd61e7629705890353cd76b2c7","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2015-09-25 14:12:12.000000000","message":"Patch Set 1: Code-Review+2\n\nAwesome! Thanks Flavio!!","accounts_in_message":[],"_revision_number":1},{"id":"7b58021ca70a53821a83a64bd883fa4b4cf014f8","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2015-09-25 15:52:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"048419909ce7828fe0f274a462d4eb90e17d3d77","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-25 15:52:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a0bfdd92701156454e9645da9ae5f12f31440419","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2015-09-25 15:59:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"de336f442381478970695ba773e91da1e9a34f66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-25 17:12:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/23/227723/1/gate/gate-python-glanceclient-python26/4cd130b/ : SUCCESS in 1m 25s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/23/227723/1/gate/gate-python-glanceclient-docs/1af5d09//doc/build/html/ : SUCCESS in 1m 25s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/23/227723/1/gate/gate-python-glanceclient-pep8/3fa43e3/ : SUCCESS in 57s\n- gate-python-glanceclient-python27 http://logs.openstack.org/23/227723/1/gate/gate-python-glanceclient-python27/e3a42e3/ : SUCCESS in 1m 17s\n- gate-python-glanceclient-python34 http://logs.openstack.org/23/227723/1/gate/gate-python-glanceclient-python34/69d2a09/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/23/227723/1/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/3947652/ : SUCCESS in 1h 18m 57s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/23/227723/1/gate/gate-glanceclient-dsvm-functional/e90f40a/ : SUCCESS in 20m 54s","accounts_in_message":[],"_revision_number":1},{"id":"996fbf14184edb2f3ccf56230d68b24686651333","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-25 17:12:19.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c31c1365573d10bd09afad47ca1974af3e50b5eb","revisions":{"c31c1365573d10bd09afad47ca1974af3e50b5eb":{"kind":"REWORK","_number":1,"created":"2015-09-25 09:02:19.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/23/227723/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/23/227723/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/23/227723/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/23/227723/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/23/227723/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/23/227723/1"}}},"commit":{"parents":[{"commit":"586d40131d0637f50ba214ef0d85ed9ddafca4f6","subject":"Change ignore-errors to ignore_errors","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/586d40131d0637f50ba214ef0d85ed9ddafca4f6"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2015-09-25 08:54:29.000000000","tz":120},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2015-09-25 08:59:54.000000000","tz":120},"subject":"No auth when token and endpoint are passed","message":"No auth when token and endpoint are passed\n\nThe latest change to the auth_required logic introduced a bug were even\nwhen the token and endpoint were passed, authentication was being\nrequired.\n\nThis patch fixes that issue and makes sure that authentication is not\nrequired when these 2 arguements are present.\n\nCloses-bug: #1499540\n\nChange-Id: I4c9c15ba526378970da5461511ed922d42c5a9f9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c31c1365573d10bd09afad47ca1974af3e50b5eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c31c1365573d10bd09afad47ca1974af3e50b5eb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}