)]}'
{"glanceclient/tests/unit/v2/test_client_requests.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"2fb5bc80916ebea9b81879668b6748ef2f8ba41a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        for image in images:"},{"line_number":41,"context_line":"            pass"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_show_bad_image_schema(self):"},{"line_number":44,"context_line":"        # if kernel_id or ramdisk_id are not uuids, verify we"},{"line_number":45,"context_line":"        # fail schema validation on \u0027show\u0027"},{"line_number":46,"context_line":"        self.requests \u003d self.useFixture(rm_fixture.Fixture())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_a46207d7","side":"PARENT","line":43,"updated":"2015-10-06 10:44:35.000000000","message":"Rather than deleting this test, could it be re-purposed?\n\nie ensure that rather than a failure, things work ok, even in the case of a non-matching schema.\n\nThis would be equivalent to \u0027test_list_bad_image_schema\u0027 above.","commit_id":"a98ed220916a0cae022b35dcdc212ba65eacafd2"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7589750f5893a5848dab58e03fa40faba99b521e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        for image in images:"},{"line_number":41,"context_line":"            pass"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_show_bad_image_schema(self):"},{"line_number":44,"context_line":"        # if kernel_id or ramdisk_id are not uuids, verify we"},{"line_number":45,"context_line":"        # fail schema validation on \u0027show\u0027"},{"line_number":46,"context_line":"        self.requests \u003d self.useFixture(rm_fixture.Fixture())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_57bac7e2","side":"PARENT","line":43,"in_reply_to":"7a2fa921_a46207d7","updated":"2015-10-06 11:13:27.000000000","message":"Actually, this is a great suggestion.","commit_id":"a98ed220916a0cae022b35dcdc212ba65eacafd2"}],"glanceclient/v2/images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b7b7292722068c98302107e6b4f7af2328460f65","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        :param \\*\\*kwargs: Image attribute names and their new values."},{"line_number":247,"context_line":"        \"\"\""},{"line_number":248,"context_line":"        unvalidated_image \u003d self.get(image_id)"},{"line_number":249,"context_line":"        image \u003d self.model(**unvalidated_image)"},{"line_number":250,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":251,"context_line":"            try:"},{"line_number":252,"context_line":"                setattr(image, key, value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_8eced481","line":249,"updated":"2015-10-04 12:08:18.000000000","message":"I actually don\u0027t think this is bad. Any reason why you think this should be changed? `self.get` does exactly what you\u0027re suggesting so, why not use it?","commit_id":"1c1dcd9c878cf9a72a4af5d0dd567f91c26c932b"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"53cd6f0b20bfdbec151a1f944237f1694d92a70f","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        :param \\*\\*kwargs: Image attribute names and their new values."},{"line_number":247,"context_line":"        \"\"\""},{"line_number":248,"context_line":"        unvalidated_image \u003d self.get(image_id)"},{"line_number":249,"context_line":"        image \u003d self.model(**unvalidated_image)"},{"line_number":250,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":251,"context_line":"            try:"},{"line_number":252,"context_line":"                setattr(image, key, value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_30a4f506","line":249,"updated":"2015-10-02 09:12:20.000000000","message":"I think that has better to do the following:\n1) define common utility function that requests image body:\nurl \u003d \u0027/v2/images/%s\u0027 % image_id\t180\nresp, body \u003d self.http_client.get(url)\nbody.pop(\u0027self\u0027, None)\n2) in get use self.unvalidated_model({body})\nwhere body is value returned by 1)\n3) in update use \nself.model({body})","commit_id":"1c1dcd9c878cf9a72a4af5d0dd567f91c26c932b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e0faa2d11673768424aaf9e26b3af01c2be8def0","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        :param \\*\\*kwargs: Image attribute names and their new values."},{"line_number":247,"context_line":"        \"\"\""},{"line_number":248,"context_line":"        unvalidated_image \u003d self.get(image_id)"},{"line_number":249,"context_line":"        image \u003d self.model(**unvalidated_image)"},{"line_number":250,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":251,"context_line":"            try:"},{"line_number":252,"context_line":"                setattr(image, key, value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_956d7806","line":249,"in_reply_to":"9a1a9d01_553b60d1","updated":"2015-10-05 08:40:20.000000000","message":"I guess, as you suggested, this could be done in a helper method function. I kinda feel it\u0027d be an over-optimization at this point.","commit_id":"1c1dcd9c878cf9a72a4af5d0dd567f91c26c932b"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"0bd1438894a6f0b2d87d5fec0f12afa3a949e310","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        :param \\*\\*kwargs: Image attribute names and their new values."},{"line_number":247,"context_line":"        \"\"\""},{"line_number":248,"context_line":"        unvalidated_image \u003d self.get(image_id)"},{"line_number":249,"context_line":"        image \u003d self.model(**unvalidated_image)"},{"line_number":250,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":251,"context_line":"            try:"},{"line_number":252,"context_line":"                setattr(image, key, value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_553b60d1","line":249,"in_reply_to":"9a1a9d01_8eced481","updated":"2015-10-05 08:09:03.000000000","message":"I think that building a model two times is not a good idea. The interesting thing that the first model is not needed at all. IMO we need to keep the code logical and clean. That\u0027s why I -1ed on this patch.","commit_id":"1c1dcd9c878cf9a72a4af5d0dd567f91c26c932b"}]}