)]}'
{"id":"openstack%2Fpython-glanceclient~23345","triplet_id":"openstack%2Fpython-glanceclient~master~Ic018a265a1676bb0a5638a55e70a527ce6b447fc","project":"openstack/python-glanceclient","branch":"master","topic":"bp/glance-api-v2-image-members","hashtags":[],"change_id":"Ic018a265a1676bb0a5638a55e70a527ce6b447fc","subject":"Image Members for glance v2 api","status":"MERGED","created":"2013-03-02 16:41:30.000000000","updated":"2013-05-10 17:07:43.000000000","submitted":"2013-05-10 17:07:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c5343899c44189d29c0ce83b8ac1d8d506d3be61","_number":23345,"virtual_id_number":23345,"owner":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":2,"date":"2013-05-10 17:07:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":2,"date":"2013-05-10 16:23:19.000000000","_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"date":"2013-05-09 10:55:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"value":2,"date":"2013-05-10 12:32:24.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":1,"date":"2013-05-10 16:23:19.000000000","_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"date":"2013-05-09 10:55:57.000000000","_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"value":0,"date":"2013-05-09 14:54:13.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-19 13:08:53.000000000","updated_by":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"reviewer":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"state":"REVIEWER"},{"updated":"2013-04-04 18:27:03.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2013-05-09 14:54:13.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2013-05-10 16:23:19.000000000","updated_by":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"reviewer":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"state":"REVIEWER"},{"updated":"2013-05-10 17:07:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"af6830d248ff9ee9a1e802e6a5f70c40ec3736c0","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-03-02 16:42:00.000000000","message":"Patch Set 1:\n\nDepends on https://review.openstack.org/#/c/23220/","accounts_in_message":[],"_revision_number":1},{"id":"c5b566da17ef2f21f97c395327166f70aa1926c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-02 17:17:42.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23345/1/check/gate-python-glanceclient-pep8/592 : SUCCESS\n- http://logs.openstack.org/23345/1/check/gate-python-glanceclient-docs/528 : SUCCESS\n- http://logs.openstack.org/23345/1/check/gate-python-glanceclient-python26/591 : SUCCESS\n- http://logs.openstack.org/23345/1/check/gate-python-glanceclient-python27/590 : SUCCESS\n- http://logs.openstack.org/23345/1/check/gate-tempest-devstack-vm-full/6699 : SUCCESS\n- http://logs.openstack.org/23345/1/check/gate-tempest-devstack-vm-postgres-full/6418 : SUCCESS\n- http://logs.openstack.org/23345/1/check/gate-tempest-devstack-vm-quantum/11571 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"9979a735df0369834556202c0cdec5aefa93e343","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-03-04 21:15:15.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nLooks really good, just a few things inline.","accounts_in_message":[],"_revision_number":1},{"id":"fc595b6dd811bae99cb3a55bd2f51bc25b3cbaea","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-03-12 06:03:04.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"d36829cd32b356f422bee4afc519db697dccac5f","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-03-12 06:03:04.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"ac9dc2f9841feca659afe0bf026e42b49dad0474","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-03-14 19:11:31.000000000","message":"Patch Set 1: Restored\n\nPushing up new changes","accounts_in_message":[],"_revision_number":1},{"id":"9869215857c1d5931db9adea791327de97a9573b","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-03-14 19:11:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d444a102ab9c9858c635c71c315e0630f8d7bc3f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-14 20:15:23.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23345/2/check/gate-python-glanceclient-pep8/619 : SUCCESS\n- http://logs.openstack.org/23345/2/check/gate-python-glanceclient-docs/554 : SUCCESS\n- http://logs.openstack.org/23345/2/check/gate-python-glanceclient-python26/617 : SUCCESS\n- http://logs.openstack.org/23345/2/check/gate-python-glanceclient-python27/616 : SUCCESS\n- http://logs.openstack.org/23345/2/check/gate-tempest-devstack-vm-full/8987 : SUCCESS\n- http://logs.openstack.org/23345/2/check/gate-tempest-devstack-vm-postgres-full/8703 : SUCCESS\n- http://logs.openstack.org/23345/2/check/gate-tempest-devstack-vm-quantum/14293 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"ca596a98bc7f460395311479e3851a55798d21e5","author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"date":"2013-03-15 21:12:45.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nThe image-list parameters for v1 and v2 are different.  Is this intentional or needed?\n\n$ glance --os-image-api-version 1 help member-list\nFailed to load keyring modules.\nusage: glance member-list [--image-id \u003cIMAGE_ID\u003e] [--tenant-id \u003cTENANT_ID\u003e]\n\nDescribe sharing permissions by image or tenant.\n\nOptional arguments:\n  --image-id \u003cIMAGE_ID\u003e\n                        Filter results by an image ID.\n  --tenant-id \u003cTENANT_ID\u003e\n                        Filter results by a tenant ID.\n\n$ glance --os-image-api-version 2 help member-list\nFailed to load keyring modules.\nusage: glance member-list \u003cIMAGE_ID\u003e\n\nDescribe sharing permissions by image\n\nPositional arguments:\n  \u003cIMAGE_ID\u003e  Image to display members of.","accounts_in_message":[],"_revision_number":2},{"id":"7621844745c6395d98d54a4a5da3efb440d97f59","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-03-15 23:31:01.000000000","message":"Patch Set 2:\n\nHey JOhn,\n\nTHanks for bringing that up. It is intentional, because in v2 of glance api we cannot view image members of specific tenant id. This is because a user should not be allowed to see image members of any other tenant.","accounts_in_message":[],"_revision_number":2},{"id":"38c5a9a2a0caab04622c495ccfcd8f5a285ae132","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-03-19 13:08:53.000000000","message":"Patch Set 2:\n\nA user can have access to multiple tenants so I don\u0027t see a problem filtering by tenant id. That being said I think I agree with John, I don\u0027t want to add an inconsistency because that could be frustrating to a user but I suppose we can only do this if the api allows. Have any thoughts on this?","accounts_in_message":[],"_revision_number":2},{"id":"c07ca87187be7e9139212dc304f36f95a0a630d6","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-03-25 00:12:06.000000000","message":"Patch Set 2:\n\nSay a user can have access to multiple tenants, but glance does not know which user has access to which tenant. Glance does not use keystone authentication to verify tenants. So basically when u are accessing image members as a particular tenant you are allowed to see only image members of the images owned by you. \nI hope that answers your question, feel free to ping me on irc if you want to discuss more or if I misunderstood you.","accounts_in_message":[],"_revision_number":2},{"id":"2bc5d17f20740354eccc72ea0893450a2f286245","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-01 06:03:03.000000000","message":"Patch Set 2:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"0aa9a962d0443cf8e1f59aa1e8bcc86c3bd22dd6","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-01 06:03:03.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"fbd3c13027e99d281ec1eba3255326c8671d84b4","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-04-03 21:00:48.000000000","message":"Patch Set 2: Restored","accounts_in_message":[],"_revision_number":2},{"id":"772c3a6c293917a66bda638575c34aba08a68621","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-04-03 21:01:55.000000000","message":"Patch Set 2:\n\nwe can add in additional tenant_id filter once its there in glance.","accounts_in_message":[],"_revision_number":2},{"id":"45231eda5b751db0d38dca35b7d0477ab4e73273","author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"date":"2013-04-04 18:37:40.000000000","message":"Patch Set 2: No score\n\nI would prefer to see it maintain interface compatibility as much as possible.  The v1 command takes --image-id instead of a positional argument.  However I will defer to others.","accounts_in_message":[],"_revision_number":2},{"id":"fa41fb150c9711486fecf326a36caa766513c524","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-19 06:03:02.000000000","message":"Patch Set 2:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"cedb83f610725b0e4163e801f5d58ef3f81e6b09","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-19 06:03:02.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"3b0d8d67aa487d83f8cfd33fcd86b56f18312211","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-04-23 01:10:06.000000000","message":"Patch Set 2: Restored\n\nFiled bug and added some comments in, let me know your thoughts - https://bugs.launchpad.net/glance/+bug/1171530","accounts_in_message":[],"_revision_number":2},{"id":"c0711b914624def00821aca0754be846b27a4fc7","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-04-29 22:54:36.000000000","message":"Patch Set 2:\n\nCould we support a positional parameter while maintaining backwards compatible support for an option (--image-id) ?\n\nFor now I\u0027d prefer to leave off --tenant-id. If someone finds they need it, we can look at adding it to member-list as a backwards compatibility feature, while actually making it a filter on image-list.\n\nDoes this plan sound okay?","accounts_in_message":[],"_revision_number":2},{"id":"71e96c4774d0c1468ea8256b27cfe9e0f24d0c9a","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-06 22:17:20.000000000","message":"Patch Set 2:\n\nHmm I am not sure if I get you, but image id is needed in the url for glance v2 api members https://github.com/openstack/glance/blob/master/glance/api/v2/router.py#L94 so it cannot be an optional parameter","accounts_in_message":[],"_revision_number":2},{"id":"eee1ce71095434bded20e7176590fd67d9efd7bd","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-08 19:21:31.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0576fe09d43ae6bca63bce022f8fedcb194ccea7","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-08 19:41:08.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"55b236b2056ade8cde67bdcbc56f0afec1753b72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-08 20:30:09.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23345/4/check/gate-python-glanceclient-pep8/729 : SUCCESS in 00:00:38\n- http://docs-draft.openstack.org/23345/4/check/gate-python-glanceclient-docs/661/doc/build/html/ : SUCCESS in 00:00:51\n- http://logs.openstack.org/23345/4/check/gate-python-glanceclient-python26/724 : SUCCESS in 00:01:05\n- http://logs.openstack.org/23345/4/check/gate-python-glanceclient-python26-centos6/13 : SUCCESS in 00:00:46 (non-voting)\n- http://logs.openstack.org/23345/4/check/gate-python-glanceclient-python27/722 : SUCCESS in 00:00:32\n- http://logs.openstack.org/23345/4/check/gate-tempest-devstack-vm-full/15097 : SUCCESS in 00:46:29\n- http://logs.openstack.org/23345/4/check/gate-tempest-devstack-vm-postgres-full/14812 : FAILURE in 00:45:12 (non-voting)\n- http://logs.openstack.org/23345/4/check/gate-tempest-devstack-vm-quantum/21346 : SUCCESS in 00:32:55\n- http://logs.openstack.org/23345/4/check/gate-grenade-devstack-vm/2845 : SUCCESS in 00:14:01 (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"8844a64eab21f10169ce8cffc04c29cfa1036bd2","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-09 10:53:49.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c1d67dc8e04c77b427ae3d3cde48739d7b9c4251","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-09 10:55:57.000000000","message":"Patch Set 5:\n\nBased on discussions in #openstack-glance this maintains backward comptability with --image-id but has made it a required param","accounts_in_message":[],"_revision_number":5},{"id":"5ce1102b7cce668ff52fcb5c1f791289a9ffad2a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-09 11:44:23.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23345/5/check/gate-python-glanceclient-pep8/730 : SUCCESS in 00:00:32\n- http://docs-draft.openstack.org/23345/5/check/gate-python-glanceclient-docs/662/doc/build/html/ : SUCCESS in 00:00:41\n- http://logs.openstack.org/23345/5/check/gate-python-glanceclient-python26/725 : SUCCESS in 00:00:58\n- http://logs.openstack.org/23345/5/check/gate-python-glanceclient-python26-centos6/14 : SUCCESS in 00:00:44 (non-voting)\n- http://logs.openstack.org/23345/5/check/gate-python-glanceclient-python27/723 : SUCCESS in 00:00:35\n- http://logs.openstack.org/23345/5/check/gate-tempest-devstack-vm-full/15198 : SUCCESS in 00:50:22\n- http://logs.openstack.org/23345/5/check/gate-tempest-devstack-vm-postgres-full/14913 : FAILURE in 00:43:28 (non-voting)\n- http://logs.openstack.org/23345/5/check/gate-tempest-devstack-vm-quantum/21455 : SUCCESS in 00:21:03\n- http://logs.openstack.org/23345/5/check/gate-grenade-devstack-vm/2939 : SUCCESS in 00:14:09 (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"a2fcff0fa3c0984ca80954ff3200383026f8f592","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-09 14:54:13.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nHi Iccha,\n\nIt looks good. I added some comments in-line (pls, ignore the one wrt positional against optional, I just wanted to add it there to keep track).\n\nHope those comments make sense.\nCheers,\nFF","accounts_in_message":[],"_revision_number":5},{"id":"0155448f26ec8e65da559f70605afd3c3c02f611","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-09 16:20:39.000000000","message":"Patch Set 5: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"47b680c10feeac4110fc6f275cd80d8f786ac548","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-10 12:32:24.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"4e65867e674e9f6f0da1b3f1aa2599779fa9c3ab","author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"date":"2013-05-10 16:23:19.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"483d87bb9abd187c206cce4d44cbcd4a604de738","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 16:23:22.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"60508a334c0781cdff085bfe60e0586186e1567c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 17:07:43.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/23345/5/gate/gate-python-glanceclient-docs/664/doc/build/html/ : SUCCESS in 00:00:43\n- http://logs.openstack.org/23345/5/gate/gate-python-glanceclient-pep8/732 : SUCCESS in 00:00:30\n- http://logs.openstack.org/23345/5/gate/gate-python-glanceclient-python26/727 : SUCCESS in 00:00:52\n- http://logs.openstack.org/23345/5/gate/gate-python-glanceclient-python27/725 : SUCCESS in 00:00:34\n- http://logs.openstack.org/23345/5/gate/gate-tempest-devstack-vm-full/15425 : SUCCESS in 00:42:12\n- http://logs.openstack.org/23345/5/gate/gate-tempest-devstack-vm-postgres-full/15141 : FAILURE in 00:44:11 (non-voting)\n- http://logs.openstack.org/23345/5/gate/gate-tempest-devstack-vm-quantum/21714 : SUCCESS in 00:20:51\n- http://logs.openstack.org/23345/5/gate/gate-grenade-devstack-vm/3147 : FAILURE in 00:09:50 (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"460c7874737ceaa23c5abafa5e725907fa8e890d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 17:07:43.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"18795f590ae3d63bb6c796ec9d69a2ceac61606e","revisions":{"9f85c2af2ff464099ece1d375ab08d6eec893f58":{"kind":"REWORK","_number":1,"created":"2013-03-02 16:41:30.000000000","uploader":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"ref":"refs/changes/45/23345/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/45/23345/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/1"}}},"commit":{"parents":[{"commit":"0ca43be6fd3eacc1f03b8376ac92ddb79992b2ff","subject":"Merge \"Use getattr properly in legacy shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0ca43be6fd3eacc1f03b8376ac92ddb79992b2ff"}]}],"author":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-03-02 03:12:04.000000000","tz":0},"committer":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-03-02 16:41:22.000000000","tz":0},"subject":"Image Members for glance v2 api","message":"Image Members for glance v2 api\n\nLists, creates, deletes, updates image members using glance\nv2 api.\n\nRelated to bp glance-api-v2-image-members\n\nChange-Id: Ic018a265a1676bb0a5638a55e70a527ce6b447fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9f85c2af2ff464099ece1d375ab08d6eec893f58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9f85c2af2ff464099ece1d375ab08d6eec893f58"}]},"branch":"refs/heads/master"},"68222b3e7e83e81fe578463ad1b81fd01c710589":{"kind":"REWORK","_number":2,"created":"2013-03-14 19:11:39.000000000","uploader":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"ref":"refs/changes/45/23345/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/45/23345/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/2"}}},"commit":{"parents":[{"commit":"0ca43be6fd3eacc1f03b8376ac92ddb79992b2ff","subject":"Merge \"Use getattr properly in legacy shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0ca43be6fd3eacc1f03b8376ac92ddb79992b2ff"}]}],"author":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-03-02 03:12:04.000000000","tz":0},"committer":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-03-14 19:01:08.000000000","tz":0},"subject":"Image Members for glance v2 api","message":"Image Members for glance v2 api\n\nLists, creates, deletes, updates image members using glance\nv2 api.\n\nRelated to bp glance-api-v2-image-members\n\nChange-Id: Ic018a265a1676bb0a5638a55e70a527ce6b447fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/68222b3e7e83e81fe578463ad1b81fd01c710589"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/68222b3e7e83e81fe578463ad1b81fd01c710589"}]},"branch":"refs/heads/master"},"35a5ef678da06c1101731b6fd5499f6aad44251c":{"kind":"REWORK","_number":3,"created":"2013-05-08 19:21:31.000000000","uploader":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"ref":"refs/changes/45/23345/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/45/23345/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/3"}}},"commit":{"parents":[{"commit":"a3223b99724eb04701b8d1d87d6f8d03bd581521","subject":"Fix inconsistent --debug messages on image-update","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3223b99724eb04701b8d1d87d6f8d03bd581521"}]}],"author":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-03-02 03:12:04.000000000","tz":0},"committer":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-05-08 19:22:00.000000000","tz":0},"subject":"Image Members for glance v2 api","message":"Image Members for glance v2 api\n\nLists, creates, deletes, updates image members using glance\nv2 api.\n\nRelated to bp glance-api-v2-image-members\n\nChange-Id: Ic018a265a1676bb0a5638a55e70a527ce6b447fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/35a5ef678da06c1101731b6fd5499f6aad44251c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/35a5ef678da06c1101731b6fd5499f6aad44251c"}]},"branch":"refs/heads/master"},"7f1452bb07af89759dfbedeb99f26f1fe2f9f7f2":{"kind":"REWORK","_number":4,"created":"2013-05-08 19:41:08.000000000","uploader":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"ref":"refs/changes/45/23345/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/45/23345/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/4"}}},"commit":{"parents":[{"commit":"a3223b99724eb04701b8d1d87d6f8d03bd581521","subject":"Fix inconsistent --debug messages on image-update","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3223b99724eb04701b8d1d87d6f8d03bd581521"}]}],"author":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-03-02 03:12:04.000000000","tz":0},"committer":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-05-08 19:39:24.000000000","tz":0},"subject":"Image Members for glance v2 api","message":"Image Members for glance v2 api\n\nLists, creates, deletes, updates image members using glance\nv2 api.\n\nRelated to bp glance-api-v2-image-members\n\nChange-Id: Ic018a265a1676bb0a5638a55e70a527ce6b447fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7f1452bb07af89759dfbedeb99f26f1fe2f9f7f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7f1452bb07af89759dfbedeb99f26f1fe2f9f7f2"}]},"branch":"refs/heads/master"},"18795f590ae3d63bb6c796ec9d69a2ceac61606e":{"kind":"REWORK","_number":5,"created":"2013-05-09 10:53:49.000000000","uploader":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"ref":"refs/changes/45/23345/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/45/23345/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/45/23345/5"}}},"commit":{"parents":[{"commit":"a3223b99724eb04701b8d1d87d6f8d03bd581521","subject":"Fix inconsistent --debug messages on image-update","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3223b99724eb04701b8d1d87d6f8d03bd581521"}]}],"author":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-03-02 03:12:04.000000000","tz":0},"committer":{"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","date":"2013-05-09 10:54:12.000000000","tz":0},"subject":"Image Members for glance v2 api","message":"Image Members for glance v2 api\n\nLists, creates, deletes, updates image members using glance\nv2 api.\n\nRelated to bp glance-api-v2-image-members\n\nChange-Id: Ic018a265a1676bb0a5638a55e70a527ce6b447fc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/18795f590ae3d63bb6c796ec9d69a2ceac61606e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/18795f590ae3d63bb6c796ec9d69a2ceac61606e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}