)]}'
{"glanceclient/shell.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5cc18b666420bcbc2760a59de70d4d5b269823cb","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":731,"context_line":"            print()"},{"line_number":732,"context_line":"            print(\"Run `glance --os-image-api-version 1 help COMMAND` \""},{"line_number":733,"context_line":"                  \"for v1 help\")"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_3705b079","line":732,"updated":"2015-10-14 14:13:24.000000000","message":"First, hardcoding COMMAND is not correct, you should check if \u0027command\u0027 var is None and change it to empty string like:\n\nif command is None:\n    \n    command \u003d \u0027\u0027","commit_id":"7457056bfd4107c294a2d6fcd27fae34214aa2cc"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5cc18b666420bcbc2760a59de70d4d5b269823cb","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":731,"context_line":"            print()"},{"line_number":732,"context_line":"            print(\"Run `glance --os-image-api-version 1 help COMMAND` \""},{"line_number":733,"context_line":"                  \"for v1 help\")"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def do_bash_completion(self, _args):"},{"line_number":736,"context_line":"        \"\"\"Prints arguments for bash_completion."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_572f0cf6","line":733,"updated":"2015-10-14 14:13:24.000000000","message":"Then, there must be second version in the strings, i.e \u0027--os-image-api-version 2\u0027 and \u0027for v2 help\u0027","commit_id":"7457056bfd4107c294a2d6fcd27fae34214aa2cc"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5e4f1349ffd853e2ebcbc707c5433ed5c3400ac0","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        else:"},{"line_number":728,"context_line":"            parser.print_help()"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        version \u003d 2 if (not args.os_image_api_version"},{"line_number":731,"context_line":"                        or args.os_image_api_version \u003d\u003d \u00272\u0027) else 1"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_3f190289","line":730,"updated":"2015-10-14 16:00:40.000000000","message":"version is better to be string  - \u00272\u0027 or \u00271\u0027","commit_id":"82e6dba4f8bef1b913b603af79d4d345fe351b6d"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"a4a5d82258207cf2343f9f98a10356d54ff4825d","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        else:"},{"line_number":728,"context_line":"            parser.print_help()"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        version \u003d 2 if (not args.os_image_api_version"},{"line_number":731,"context_line":"                        or args.os_image_api_version \u003d\u003d \u00272\u0027) else 1"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_f82ca903","line":730,"in_reply_to":"5a2ca52d_3f190289","updated":"2015-10-16 09:22:05.000000000","message":"Done","commit_id":"82e6dba4f8bef1b913b603af79d4d345fe351b6d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5e4f1349ffd853e2ebcbc707c5433ed5c3400ac0","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                        or args.os_image_api_version \u003d\u003d \u00272\u0027) else 1"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"},{"line_number":734,"context_line":"            print((\"\\nRun `glance --os-image-api-version %s help%s` \""},{"line_number":735,"context_line":"                  \"for v2 help\") % (version, command))"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_3a5b5030","line":734,"updated":"2015-10-14 16:00:40.000000000","message":"You did not fix the problem fix helpNone","commit_id":"82e6dba4f8bef1b913b603af79d4d345fe351b6d"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"a4a5d82258207cf2343f9f98a10356d54ff4825d","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                        or args.os_image_api_version \u003d\u003d \u00272\u0027) else 1"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"},{"line_number":734,"context_line":"            print((\"\\nRun `glance --os-image-api-version %s help%s` \""},{"line_number":735,"context_line":"                  \"for v2 help\") % (version, command))"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_38fa2144","line":734,"in_reply_to":"5a2ca52d_3a5b5030","updated":"2015-10-16 09:22:05.000000000","message":"if command is None, then this line will not print","commit_id":"82e6dba4f8bef1b913b603af79d4d345fe351b6d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5e4f1349ffd853e2ebcbc707c5433ed5c3400ac0","unresolved":false,"context_lines":[{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"},{"line_number":734,"context_line":"            print((\"\\nRun `glance --os-image-api-version %s help%s` \""},{"line_number":735,"context_line":"                  \"for v2 help\") % (version, command))"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def do_bash_completion(self, _args):"},{"line_number":738,"context_line":"        \"\"\"Prints arguments for bash_completion."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_ba30c0e9","line":735,"updated":"2015-10-14 16:00:40.000000000","message":"for v2 help - you hadcode the version here. Must be  \u0027for v%s help\u0027","commit_id":"82e6dba4f8bef1b913b603af79d4d345fe351b6d"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"a4a5d82258207cf2343f9f98a10356d54ff4825d","unresolved":false,"context_lines":[{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"},{"line_number":734,"context_line":"            print((\"\\nRun `glance --os-image-api-version %s help%s` \""},{"line_number":735,"context_line":"                  \"for v2 help\") % (version, command))"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def do_bash_completion(self, _args):"},{"line_number":738,"context_line":"        \"\"\"Prints arguments for bash_completion."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_1832c55f","line":735,"in_reply_to":"5a2ca52d_ba30c0e9","updated":"2015-10-16 09:22:05.000000000","message":"Done","commit_id":"82e6dba4f8bef1b913b603af79d4d345fe351b6d"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"227b6d36356a50bfc3d585e44bcdaca442a81ad6","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        else:"},{"line_number":728,"context_line":"            parser.print_help()"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        version \u003d \u00272\u0027 if (not args.os_image_api_version"},{"line_number":731,"context_line":"                          or args.os_image_api_version \u003d\u003d \u00272\u0027) else \u00271\u0027"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_017b298d","line":730,"updated":"2015-10-16 12:05:57.000000000","message":"Could it be transformed to \n\u00272\u0027 if args.os_image_api_version \u003d\u003d \u00272\u0027 else \u00271\u0027\nAlso it seems that condition is incorrect. It should be\n\u00272\u0027 if args.os_image_api_version !\u003d \u00271\u0027 else \u00271\u0027 because we are showing possibility how to show help from v2 for v1 and vice versa.","commit_id":"3331269469c007c847499925753f61abbbc611e0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"227b6d36356a50bfc3d585e44bcdaca442a81ad6","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        version \u003d \u00272\u0027 if (not args.os_image_api_version"},{"line_number":731,"context_line":"                          or args.os_image_api_version \u003d\u003d \u00272\u0027) else \u00271\u0027"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"},{"line_number":734,"context_line":"            print((\"\\nRun `glance --os-image-api-version %s help%s` \""},{"line_number":735,"context_line":"                   \"for %s help\") % (version, command, version))"},{"line_number":736,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_61fa1d77","line":733,"updated":"2015-10-16 12:05:57.000000000","message":"I think that the behavior is incorrect because you will see \u0027Run glance ... version 2 help for 2 help\u0027: need to change to \"v2 help\".","commit_id":"3331269469c007c847499925753f61abbbc611e0"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"227b6d36356a50bfc3d585e44bcdaca442a81ad6","unresolved":false,"context_lines":[{"line_number":732,"context_line":""},{"line_number":733,"context_line":"        if command:"},{"line_number":734,"context_line":"            print((\"\\nRun `glance --os-image-api-version %s help%s` \""},{"line_number":735,"context_line":"                   \"for %s help\") % (version, command, version))"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def do_bash_completion(self, _args):"},{"line_number":738,"context_line":"        \"\"\"Prints arguments for bash_completion."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_81cdf986","line":735,"updated":"2015-10-16 12:05:57.000000000","message":"you can use format to avoid duplication.","commit_id":"3331269469c007c847499925753f61abbbc611e0"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6b5969c5535905f78bf2ebef70d5dd0c6c50fc50","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":731,"context_line":"            print()"},{"line_number":732,"context_line":"            print((\"Run `glance --os-image-api-version 1 help%s` \""},{"line_number":733,"context_line":"                   \"for v1 help\") % command)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_1ea0f18f","side":"PARENT","line":732,"updated":"2015-10-26 02:08:54.000000000","message":"So why remove this line? If user just print \"glance help\" without command, this line should be printed IMO. \n\nWe only need to remove the \"command\" variable below.","commit_id":"eab2a9da93877d3c94d1f05f57a3a3d53df5e099"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"d2cccfd27564801fdb763baafc097cf232cbe6db","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":731,"context_line":"            print()"},{"line_number":732,"context_line":"            print((\"Run `glance --os-image-api-version 1 help%s` \""},{"line_number":733,"context_line":"                   \"for v1 help\") % command)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_dad79521","side":"PARENT","line":732,"in_reply_to":"3a29b11f_1ea0f18f","updated":"2015-11-10 10:52:37.000000000","message":"I believe that this line is not necessary to display, because it might confuse the user when using v2 default. Because it will display information about commands are not v1.","commit_id":"eab2a9da93877d3c94d1f05f57a3a3d53df5e099"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61d6180f193fed98b0bdf736db7b7b29e05a69fb","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":731,"context_line":"            print()"},{"line_number":732,"context_line":"            print((\"Run `glance --os-image-api-version 1 help%s` \""},{"line_number":733,"context_line":"                   \"for v1 help\") % command)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_f2f05893","side":"PARENT","line":732,"in_reply_to":"da85f559_dad79521","updated":"2015-11-11 02:12:51.000000000","message":"Sorry,I didn\u0027t say clearly before. I mean that L730-L733 should not be removed. \n\nWhen user use v2 default and print \"glance help\". These code could tell user that \"Run `glance --os-image-api-version 1 help for v1 help\". We only need to remove \"%s\" here.","commit_id":"eab2a9da93877d3c94d1f05f57a3a3d53df5e099"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"849fb70ce88dd152ba9fd064362dc3fd01974c36","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":731,"context_line":"            print()"},{"line_number":732,"context_line":"            print((\"Run `glance --os-image-api-version 1 help%s` \""},{"line_number":733,"context_line":"                   \"for v1 help\") % command)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_626809ba","side":"PARENT","line":732,"in_reply_to":"da85f559_f2f05893","updated":"2015-11-11 09:55:13.000000000","message":"Done","commit_id":"eab2a9da93877d3c94d1f05f57a3a3d53df5e099"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"e1409caa428d1cdd219e47710fdb95769b039821","unresolved":false,"context_lines":[{"line_number":725,"context_line":""},{"line_number":726,"context_line":"            if (not args.os_image_api_version"},{"line_number":727,"context_line":"                    or args.os_image_api_version \u003d\u003d \u00272\u0027):"},{"line_number":728,"context_line":"                self.get_subcommand_parser(\u00271\u0027)"},{"line_number":729,"context_line":"                if command in self.subcommands:"},{"line_number":730,"context_line":"                    print((\"\\nRun `glance --os-image-api-version 1 \""},{"line_number":731,"context_line":"                           \"help %s` for v1 help\") % command)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_3a8f19ce","line":728,"updated":"2015-10-23 14:29:17.000000000","message":"This modifies list of current client subcommands. So if smb will use the client the will receive v1 subcommands. Is it intended behavior?","commit_id":"efd91163cb438d57160a881e151d9da7c7f9bca6"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"7c4715ce21e831ea1bec419bfce09eecb6993596","unresolved":false,"context_lines":[{"line_number":725,"context_line":""},{"line_number":726,"context_line":"            if (not args.os_image_api_version"},{"line_number":727,"context_line":"                    or args.os_image_api_version \u003d\u003d \u00272\u0027):"},{"line_number":728,"context_line":"                self.get_subcommand_parser(\u00271\u0027)"},{"line_number":729,"context_line":"                if command in self.subcommands:"},{"line_number":730,"context_line":"                    print((\"\\nRun `glance --os-image-api-version 1 \""},{"line_number":731,"context_line":"                           \"help %s` for v1 help\") % command)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_6e12b35a","line":728,"in_reply_to":"3a29b11f_3a8f19ce","updated":"2015-10-23 15:48:09.000000000","message":"Yes, this is done to get a list of subcommands v1 in variable self.subcommands","commit_id":"efd91163cb438d57160a881e151d9da7c7f9bca6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f8e14afb493463aa671142a5046c22fb3c04d7aa","unresolved":false,"context_lines":[{"line_number":726,"context_line":"            command \u003d \u0027 \u0027 + command"},{"line_number":727,"context_line":"        else:"},{"line_number":728,"context_line":"            parser.print_help()"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":731,"context_line":"            print()"},{"line_number":732,"context_line":"            print((\"Run `glance --os-image-api-version 1 help%s` \""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_449dfe57","side":"PARENT","line":729,"updated":"2015-11-26 05:18:46.000000000","message":"can we simply add command \u003d \"\" here which will resolve the issue?","commit_id":"eab2a9da93877d3c94d1f05f57a3a3d53df5e099"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0f2f5cfd780b62935b74edb4c7be30ff2afe258c","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                    print((\"\\nRun `glance --os-image-api-version 1 \""},{"line_number":731,"context_line":"                           \"help %s` for v1 help\") % command)"},{"line_number":732,"context_line":"            else:"},{"line_number":733,"context_line":"                print((\"\\nRun `glance --os-image-api-version 2 help %s` \""},{"line_number":734,"context_line":"                       \"for v2 help\") % command)"},{"line_number":735,"context_line":"        else:"},{"line_number":736,"context_line":"            parser.print_help()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_4b8f64cc","line":733,"updated":"2015-11-17 18:38:53.000000000","message":"I don\u0027t think we need to add this for v2. We have it for v1 for a matter of compatibility and it\u0027ll be removed in the future.","commit_id":"1616216ad13c0df5151a54163015498157fd4499"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0972d35f8cc8a78a71adfd60e3b8993faa931f8c","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                or args.os_image_api_version \u003d\u003d \u00272\u0027):"},{"line_number":731,"context_line":"            print((\"\\nRun `glance --os-image-api-version 1 help%s`\""},{"line_number":732,"context_line":"                   \" for v1 help\") % (command or \u0027\u0027))"},{"line_number":733,"context_line":"        else:"},{"line_number":734,"context_line":"            print((\"\\nRun `glance --os-image-api-version 2 help%s`\""},{"line_number":735,"context_line":"                   \" for v2 help\") % (command or \u0027\u0027))"},{"line_number":736,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_447ab5be","line":733,"updated":"2015-11-26 17:35:02.000000000","message":"As I mentioned in one of my previous comments, I don\u0027t think we need to do this in v2. Did you take a look to the patch I had proposed?","commit_id":"76352a6f5d6e9429669d73636526096bbc6e8058"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1744a479d28b89d52106ee83f455f5fbb5227e77","unresolved":false,"context_lines":[{"line_number":716,"context_line":"    def do_help(self, args, parser):"},{"line_number":717,"context_line":"        \"\"\"Display help about this program or one of its subcommands.\"\"\""},{"line_number":718,"context_line":"        command \u003d getattr(args, \u0027command\u0027, \u0027\u0027)"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        if command:"},{"line_number":721,"context_line":"            if args.command in self.subcommands:"},{"line_number":722,"context_line":"                self.subcommands[args.command].print_help()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_c5e68314","side":"PARENT","line":719,"updated":"2015-11-27 12:51:01.000000000","message":"one nit: this change is unrelated. Mind putting this line back?","commit_id":"eab2a9da93877d3c94d1f05f57a3a3d53df5e099"}]}