)]}'
{"glanceclient/v1/shell.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"356c3024ede1c8a5dc3cb31b6c18abfb65e8de25","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    gc.image_members.delete(image_id, args.tenant_id)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"def do_version_list(gc, args):"},{"line_number":433,"context_line":"    \"\"\"List all API versions.\"\"\""},{"line_number":434,"context_line":"    versions \u003d gc.versions.list()"},{"line_number":435,"context_line":"    columns \u003d [\"Id\", \"Status\", \"Links\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_2c39a2f2","line":432,"updated":"2015-11-01 01:10:59.000000000","message":"Let\u0027s not add this to the CLI, I don\u0027t really think we need it there and we can agree on the arguments later.","commit_id":"5a30e0249b62d6201e7f66b752eb29b7a9f01bdc"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"149a63e62b693d5accce32eab9c501dca055d1a2","unresolved":false,"context_lines":[{"line_number":429,"context_line":"    gc.image_members.delete(image_id, args.tenant_id)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"def do_version_list(gc, args):"},{"line_number":433,"context_line":"    \"\"\"List all API versions.\"\"\""},{"line_number":434,"context_line":"    versions \u003d gc.versions.list()"},{"line_number":435,"context_line":"    columns \u003d [\"Id\", \"Status\", \"Links\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_56aee598","line":432,"in_reply_to":"1a26ad4f_2c39a2f2","updated":"2015-11-02 01:15:11.000000000","message":"I add it because that  I found nova has it: \"nova version-list\". Not sure this\u0027s redundant or not.","commit_id":"5a30e0249b62d6201e7f66b752eb29b7a9f01bdc"}],"glanceclient/v1/versions.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"356c3024ede1c8a5dc3cb31b6c18abfb65e8de25","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from glanceclient.openstack.common.apiclient import base"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class Version(base.Resource):"},{"line_number":21,"context_line":"    def __repr__(self):"},{"line_number":22,"context_line":"        return \"\u003cVersion %s\u003e\" % self._info"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_ec272ac8","line":20,"updated":"2015-11-01 01:10:59.000000000","message":"Kinda feel a plain dict would be more than enough for this case.","commit_id":"5a30e0249b62d6201e7f66b752eb29b7a9f01bdc"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"149a63e62b693d5accce32eab9c501dca055d1a2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from glanceclient.openstack.common.apiclient import base"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class Version(base.Resource):"},{"line_number":21,"context_line":"    def __repr__(self):"},{"line_number":22,"context_line":"        return \"\u003cVersion %s\u003e\" % self._info"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_56e025fa","line":20,"in_reply_to":"1a26ad4f_ec272ac8","updated":"2015-11-02 01:15:11.000000000","message":"Agree. If we don\u0027t add do_version_list function, dict is enough indeed.","commit_id":"5a30e0249b62d6201e7f66b752eb29b7a9f01bdc"}],"glanceclient/v2/client.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"87c199fae1d254179f531009a241d5f16f2d85d8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.metadefs_namespace \u003d ("},{"line_number":66,"context_line":"            metadefs.NamespaceController(self.http_client, self.schemas))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.versions \u003d versions.Controller(self.http_client)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_a7d3c737","line":68,"updated":"2015-11-09 15:37:05.000000000","message":"Why not VersionController?","commit_id":"bbba4ef334ab75d3c3f4f623999e466798756b40"}],"glanceclient/v2/versions.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"356c3024ede1c8a5dc3cb31b6c18abfb65e8de25","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.schema_client \u003d schema_client"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @utils.memoized_property"},{"line_number":29,"context_line":"    def model(self):"},{"line_number":30,"context_line":"        # TODO(wangxiyuan): Glance should support version schema. After Glance"},{"line_number":31,"context_line":"        # add it, we should get it from Glance here and then use schema.raw()."},{"line_number":32,"context_line":"        schema \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_4c3e5edb","line":29,"updated":"2015-11-01 01:10:59.000000000","message":"Do we really need a model here?\n\nI\u0027d prefer to return a plain python object and make the returned value consistent with the one from the v1 client.","commit_id":"5a30e0249b62d6201e7f66b752eb29b7a9f01bdc"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"149a63e62b693d5accce32eab9c501dca055d1a2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.schema_client \u003d schema_client"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @utils.memoized_property"},{"line_number":29,"context_line":"    def model(self):"},{"line_number":30,"context_line":"        # TODO(wangxiyuan): Glance should support version schema. After Glance"},{"line_number":31,"context_line":"        # add it, we should get it from Glance here and then use schema.raw()."},{"line_number":32,"context_line":"        schema \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_f6d05121","line":29,"in_reply_to":"1a26ad4f_4c3e5edb","updated":"2015-11-02 01:15:11.000000000","message":"The same reason as v1. The model here is used in shell.py. If  we don\u0027t want to add the client function to user, this could be removed.","commit_id":"5a30e0249b62d6201e7f66b752eb29b7a9f01bdc"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"471fba0af337a2582eca87bde6b5b6371944d6e4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.schema_client \u003d schema_client"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @utils.memoized_property"},{"line_number":29,"context_line":"    def model(self):"},{"line_number":30,"context_line":"        # TODO(wangxiyuan): Glance should support version schema. After Glance"},{"line_number":31,"context_line":"        # add it, we should get it from Glance here and then use schema.raw()."},{"line_number":32,"context_line":"        schema \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_50959e3c","line":29,"in_reply_to":"1a26ad4f_f6d05121","updated":"2015-11-06 09:18:01.000000000","message":"Agree with Flavio. This is redundant complexity.","commit_id":"5a30e0249b62d6201e7f66b752eb29b7a9f01bdc"}]}