)]}'
{"id":"openstack%2Fpython-glanceclient~248442","triplet_id":"openstack%2Fpython-glanceclient~master~I91bb41109d1b19705c5673be15c86046e53b80ed","project":"openstack/python-glanceclient","branch":"master","hashtags":[],"change_id":"I91bb41109d1b19705c5673be15c86046e53b80ed","subject":"Fixed handling of None values for limit, marker and is_public when listing images in client v1.","status":"ABANDONED","created":"2015-11-22 09:47:25.000000000","updated":"2016-02-02 12:37:01.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1fbfe6ff8e60af5214493df7ef948c69dd3e966a","_number":248442,"virtual_id_number":248442,"owner":{"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2015-11-22 10:39:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-11-22 09:47:30.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"date":"2015-11-24 13:20:15.000000000","_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":-1,"date":"2016-01-25 19:19:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":-1,"date":"2015-11-23 11:06:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-22 09:47:30.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2015-11-22 10:39:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-11-23 11:06:04.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2016-01-25 19:19:19.000000000","updated_by":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"reviewer":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"state":"REVIEWER"}],"messages":[{"id":"acd341a0c14ba34dbf94d15ec835bdcb14726e15","author":{"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"},"date":"2015-11-22 09:47:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0c91f88f17548b5212aff0f562b5985a56f89e7d","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2015-11-22 09:47:30.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"8fe9101322e31311e2b0906d0e800c8602df9b2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-22 10:39:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/42/248442/1/check/gate-python-glanceclient-python26/c933f2c/ : FAILURE in 1m 08s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/42/248442/1/check/gate-python-glanceclient-pep8/d6d00ec/ : SUCCESS in 54s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/42/248442/1/check/gate-python-glanceclient-docs/94322df//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-glanceclient-python27 http://logs.openstack.org/42/248442/1/check/gate-python-glanceclient-python27/a84cf60/ : FAILURE in 1m 14s\n- gate-python-glanceclient-python34 http://logs.openstack.org/42/248442/1/check/gate-python-glanceclient-python34/73a4bf7/ : FAILURE in 1m 28s\n- gate-python-glanceclient-pypy http://logs.openstack.org/42/248442/1/check/gate-python-glanceclient-pypy/aea53f3/ : FAILURE in 1m 41s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/42/248442/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/764cef6/ : SUCCESS in 51m 33s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/42/248442/1/check/gate-glanceclient-dsvm-functional/62bb6d8/ : SUCCESS in 23m 46s","accounts_in_message":[],"_revision_number":1},{"id":"0c3925e9093c8e0221ea7620ccb70f425697b8bb","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-11-23 11:06:04.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Nuwan,\n\nI think it would help reviewers if you could enter a bug for this in launchpad and link to it with a Closes-bug in the commit message.\n\nIn the bug an example of a user API call which triggers an error/unexpected response would again help clarify what the issue is.\n\nThanks!","accounts_in_message":[],"_revision_number":1},{"id":"3f4167444239c7bdd180420aee896ab6af21fff1","author":{"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"},"date":"2015-11-24 13:20:15.000000000","message":"Patch Set 1:\n\nHi Stuart,\n\nI\u0027m new here so that\u0027s very helpful info, thanks. Will do. I\u0027d also like to flag that the build appears to be broken in the main branch at present (independent of this patch).\n\ncheers!\n/Nuwan","accounts_in_message":[],"_revision_number":1},{"id":"e75536f0f240cc9b294ce0c84c6448e4091f4c32","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2016-01-25 19:19:19.000000000","message":"Patch Set 1: Code-Review-1\n\nThis patch has been -1ed because it has not been updated in\n\u003e\u003d2months. The patch also has either a -1/-2 from a core reviewer or a\n-1 from Jenkins.\n\nPlease, update/rebase the patch if the lack of updates was actually a\nlack of reviews or if you think the patch is still relevant.\n\n**NOTE: This will be abandoned if no update is done in 1 week.**\n\nIf this action does not seem accurate, please, ping flaper87 on IRC\nand he will gladly revert it. Sorry for the inconvenience and we look\nforward to have more contributions from you.","accounts_in_message":[],"_revision_number":1},{"id":"51c69f81484f8970a265b0d026e3b57b43d6c25e","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2016-02-02 12:37:00.000000000","message":"Patch Set 1:\n\nThis patch was marked to be abanadoned \u003e\u003d7days ago.\n\nIt is now being abandoned because there was no update, feedback nor rebase in the aforementioned period. If this is a mistake, please, contact members of the glance team[0] and they\u0027ll promptly correct the error.\n\nThanks for your contribution. The Glance team looks forward to new contributions from you.","accounts_in_message":[],"_revision_number":1},{"id":"1fbfe6ff8e60af5214493df7ef948c69dd3e966a","author":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"date":"2016-02-02 12:37:01.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"73f931cfd203dab832356179ce7ec8216eb7c86d","revisions":{"73f931cfd203dab832356179ce7ec8216eb7c86d":{"kind":"REWORK","_number":1,"created":"2015-11-22 09:47:25.000000000","uploader":{"_account_id":19405,"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","username":"nuwan_ag"},"ref":"refs/changes/42/248442/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/42/248442/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/42/248442/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/42/248442/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/42/248442/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/42/248442/1"}}},"commit":{"parents":[{"commit":"22e4e0a5db4a286bf88929e9d6963a37214263e1","subject":"Merge \"Fix \u0027test_help\u0027 for shell client.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/22e4e0a5db4a286bf88929e9d6963a37214263e1"}]}],"author":{"name":"nuwan_ag","email":"nuwan.ag@gmail.com","date":"2015-11-22 08:52:49.000000000","tz":660},"committer":{"name":"Nuwan Goonasekera","email":"nuwan.ag@gmail.com","date":"2015-11-22 09:31:53.000000000","tz":660},"subject":"Fixed handling of None values for limit, marker and is_public when listing images in client v1.","message":"Fixed handling of None values for limit, marker and is_public when\nlisting images in client v1.\n\nCurrently, when images.list() is called in the v1 client, specifying\nNone for limit, marker or is_public results in an invalid value being\nadded to the query string, which results in an Invalid parameter error\nfrom the server. This patch fixes this issue, making the behaviour\nsimilar to other clients.\n\nChange-Id: I91bb41109d1b19705c5673be15c86046e53b80ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/73f931cfd203dab832356179ce7ec8216eb7c86d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/73f931cfd203dab832356179ce7ec8216eb7c86d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}