)]}'
{"glanceclient/common/http.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0d896e9164a493408c693d6b034664fa8578ea0b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import struct"},{"line_number":23,"context_line":"import urlparse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from socket import socket as _socket"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    import json"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F7Bg%3D","line":25,"updated":"2013-03-20 21:20:28.000000000","message":"Hey,\n\nI guess this line should be right bellow import socket.","commit_id":"4c4e0f43563ee6099ab41f0b578eb5c6d075c428"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"04a8b37a8f2e9a74dc5a8ec3d6a214b1b41b4db5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import struct"},{"line_number":23,"context_line":"import urlparse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from socket import socket as _socket"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    import json"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6NA%3D","line":25,"in_reply_to":"AAAAOH%2F%2F7Bg%3D","updated":"2013-03-21 10:17:11.000000000","message":"Grazie Flavio. I seem to have a blind spot with import ordering. Let me push up another change.","commit_id":"4c4e0f43563ee6099ab41f0b578eb5c6d075c428"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a346e20f606cd68192e871554ddb362676a5e36c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from glanceclient.common import utils"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    from eventlet.green.httplib import HTTPSConnection"},{"line_number":42,"context_line":"    from eventlet.green.OpenSSL.SSL import GreenConnection as ConnectionType"},{"line_number":43,"context_line":"    from eventlet.greenio import GreenSocket"},{"line_number":44,"context_line":"    GreenSocket.getsockopt \u003d utils.getsockopt"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fv%2B4%3D","line":41,"updated":"2013-03-29 08:47:14.000000000","message":"Hey,\n\nCould you please add a NOTE here as a future reminder of why we need this code here and when can this be removed? Just like you did in common.utils or simple a one line not pointing the reader to utils.getsockopt docstring.\n\nThanks a lot!","commit_id":"276fe250516450746e0718952f95fe4cc35e8e4d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"261a343f27ba4bd4118df27d4241df843f9f73b4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from glanceclient.common import utils"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"try:"},{"line_number":41,"context_line":"    from eventlet.green.httplib import HTTPSConnection"},{"line_number":42,"context_line":"    from eventlet.green.OpenSSL.SSL import GreenConnection as ConnectionType"},{"line_number":43,"context_line":"    from eventlet.greenio import GreenSocket"},{"line_number":44,"context_line":"    GreenSocket.getsockopt \u003d utils.getsockopt"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FvqE%3D","line":41,"in_reply_to":"AAAAOH%2F%2Fv%2B4%3D","updated":"2013-03-29 16:58:03.000000000","message":"Sure, I can add a one liner.","commit_id":"276fe250516450746e0718952f95fe4cc35e8e4d"}],"glanceclient/common/utils.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a346e20f606cd68192e871554ddb362676a5e36c","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    return text"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"def getsockopt(self, *args, **kwargs):"},{"line_number":269,"context_line":"    \"\"\""},{"line_number":270,"context_line":"    A function which allows us to monkey patch eventlet\u0027s"},{"line_number":271,"context_line":"    GreenSocket, adding a required \u0027getsockopt\u0027 method."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fv%2Bo%3D","line":268,"updated":"2013-03-29 08:47:14.000000000","message":"Hey,\n\nJust an \"out loud thought\":\n\nSince this is a temporary change, wouldn\u0027t it be better to just create a lambda in the import block in order to keep the workaround isolated? \n\nYour implementation is definitely more explicit but just trying to figure out the right \"tradeoff\" between keeping workarounds as more isolated as possible and making the code more explicit and perhaps cleaner. \n\nWhat are your thoughts here?\n\nCheers.","commit_id":"276fe250516450746e0718952f95fe4cc35e8e4d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"261a343f27ba4bd4118df27d4241df843f9f73b4","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    return text"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"def getsockopt(self, *args, **kwargs):"},{"line_number":269,"context_line":"    \"\"\""},{"line_number":270,"context_line":"    A function which allows us to monkey patch eventlet\u0027s"},{"line_number":271,"context_line":"    GreenSocket, adding a required \u0027getsockopt\u0027 method."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FvqA%3D","line":268,"in_reply_to":"AAAAOH%2F%2Fv%2Bo%3D","updated":"2013-03-29 16:58:03.000000000","message":"Hey Flavio, I thought it was a bit distracting putting this in the main file. Hopefully we\u0027ll be able to remove it soon so the problem will go away in time.","commit_id":"276fe250516450746e0718952f95fe4cc35e8e4d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"89cf603dfc226f9abdca4805e1ecbec18eac1cfc","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    return text"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"def getsockopt(self, *args, **kwargs):"},{"line_number":269,"context_line":"    \"\"\""},{"line_number":270,"context_line":"    A function which allows us to monkey patch eventlet\u0027s"},{"line_number":271,"context_line":"    GreenSocket, adding a required \u0027getsockopt\u0027 method."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fvos%3D","line":268,"in_reply_to":"AAAAOH%2F%2FvqA%3D","updated":"2013-03-29 17:14:22.000000000","message":"Hey,\n\nFair enough! Thanks for the feedback! \n\nCheers","commit_id":"276fe250516450746e0718952f95fe4cc35e8e4d"}]}