)]}'
{"id":"openstack%2Fpython-glanceclient~251040","triplet_id":"openstack%2Fpython-glanceclient~master~I0cb7c2e5dabaa8ec4b06af4a5024580f1d0df990","project":"openstack/python-glanceclient","branch":"master","hashtags":[],"change_id":"I0cb7c2e5dabaa8ec4b06af4a5024580f1d0df990","subject":"Fix help for image-create","status":"ABANDONED","created":"2015-11-28 14:25:17.000000000","updated":"2015-11-30 15:38:28.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2d3be16e573381c2a0d7a50d731dfea45e0f7ab9","_number":251040,"virtual_id_number":251040,"owner":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"actions":{},"labels":{"Verified":{"all":[{"date":"2015-11-30 15:34:52.000000000","_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-11-30 15:15:00.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-28 15:24:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-11-30 04:15:08.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2015-11-30 15:15:00.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"}],"messages":[{"id":"6b19de3fce62abda44837f527f23ea411fcf8d3f","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-11-28 14:25:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5756141b8a56b873e05daf1f100a6b54cfbe0bb7","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-11-28 14:40:06.000000000","message":"Patch Set 1:\n\nPlease feel free comment on this change.\n\nI can see that the previous review that fixes this bug (https://review.openstack.org/#/c/221234/) has lots of discussion but was ultimately abandoned. It was quite disappointing, I for one (as an operator) would like to see this bug fix for good, and I don\u0027t mind taking it up as long as there is a clear direction.\n\nI understand that there is one use case for a blank image name or file, but not a case for blank name AND file. I am unsure if this is still required in v2? If so, let me know and I can adjust this patch accordingly.","accounts_in_message":[],"_revision_number":1},{"id":"da13d307972a44fc002415fb9bf6e3dfe8f48990","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-28 15:24:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-python26 http://logs.openstack.org/40/251040/1/check/gate-python-glanceclient-python26/79fc675/ : FAILURE in 1m 15s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/40/251040/1/check/gate-python-glanceclient-pep8/770e691/ : SUCCESS in 46s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/40/251040/1/check/gate-python-glanceclient-docs/782a631//doc/build/html/ : SUCCESS in 53s\n- gate-python-glanceclient-python27 http://logs.openstack.org/40/251040/1/check/gate-python-glanceclient-python27/e3a0233/ : FAILURE in 1m 12s\n- gate-python-glanceclient-python34 http://logs.openstack.org/40/251040/1/check/gate-python-glanceclient-python34/bb2f1fb/ : FAILURE in 1m 15s\n- gate-python-glanceclient-pypy http://logs.openstack.org/40/251040/1/check/gate-python-glanceclient-pypy/7b5dd59/ : FAILURE in 1m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/40/251040/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/55c184b/ : SUCCESS in 58m 41s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/40/251040/1/check/gate-glanceclient-dsvm-functional/7c486a2/ : SUCCESS in 20m 18s","accounts_in_message":[],"_revision_number":1},{"id":"4b2c111cbf6c806b82ed558a82e5762157e6564a","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-11-30 02:45:47.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"0515fd376e369cd22eb2ebc75ffa71e727a81143","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2015-11-30 04:15:08.000000000","message":"Patch Set 1:\n\nFor myself, I usually create image without parameter for quick test work. I think the behavior should be keep.","accounts_in_message":[],"_revision_number":1},{"id":"e8121ddb78dcc149e96452403129ab5d978757ec","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-11-30 11:56:12.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Jake,\n\nThanks for your patch.\n\nI think you\u0027re right that the help and the behaviour are out of sync.\n\nThat said, being able to create queued images is useful. (I actually did that this morning when reviewing https://review.openstack.org/#/c/199549.)\n\nWe haven\u0027t always done a good job of preserving backwards compatability with the CLI, but I do think that this change is problematic from a backwards compatability perspective. (I\u0027m really kind of -2 on this tbh, but let\u0027s see what others think.)\n\nHow would you feel about pushing up a change to fix the \u0027help\u0027 instead?","accounts_in_message":[],"_revision_number":1},{"id":"e7cbc788cc1b709f77f68c58eab8690c65ad3640","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-11-30 15:10:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"397dee4d0e2517b99c8a664b5a432070b1f9df1d","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2015-11-30 15:15:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"48607fcf3cc2ace6a7711695fbf646948c7dcd12","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-11-30 15:34:52.000000000","message":"Patch Set 2:\n\nHi Stuart,\n\nThanks for your kind comments. Yes, indeed the stdin message is very useful, and I will work on that.\n\nI hope you don\u0027t mind, but I am going to abandon this and create a new change because the previous patchset is not valid for what we are changing now. I think it\u0027ll be a good thing not to have it in history to reduce confusion.","accounts_in_message":[],"_revision_number":2},{"id":"1f1bcb427b13ae778e8920d216f052c1d716ae5b","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-11-30 15:38:10.000000000","message":"Topic image_create_help removed","accounts_in_message":[],"_revision_number":2},{"id":"2d3be16e573381c2a0d7a50d731dfea45e0f7ab9","author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"date":"2015-11-30 15:38:28.000000000","message":"Abandoned\n\nabandoning this change because it is the help that needs to be patched and not the function.\n\nThe new change to patch the help is in https://review.openstack.org/251436","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b7aa369911a1720201053a72f13fa3e0e578e0bf","revisions":{"4c4d82a2296c0bb7c7dcea1017b6768de2066b50":{"kind":"REWORK","_number":1,"created":"2015-11-28 14:25:17.000000000","uploader":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"ref":"refs/changes/40/251040/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/40/251040/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/1"}}},"commit":{"parents":[{"commit":"c4cb6a42ef3f8bc80ee534e514954a4df055583b","subject":"Merge \"Fix typo in \u0027help\u0027 in python-glanceclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c4cb6a42ef3f8bc80ee534e514954a4df055583b"}]}],"author":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-11-28 14:13:59.000000000","tz":660},"committer":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-11-28 14:24:22.000000000","tz":660},"subject":"Make image-create require --file param","message":"Make image-create require --file param\n\nThe help for image-create states that --file \u0027Must be present if images\nare not passed to the client via stdin.\u0027\n\nThis change enforces that behaviour.\n\nAs a bonus side effect, I think it also fixes one of the long standing\nbug #1184965.\n\nChange-Id: I0cb7c2e5dabaa8ec4b06af4a5024580f1d0df990\nCloses-bug: 1184965\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4c4d82a2296c0bb7c7dcea1017b6768de2066b50"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4c4d82a2296c0bb7c7dcea1017b6768de2066b50"}]},"branch":"refs/heads/master"},"b7aa369911a1720201053a72f13fa3e0e578e0bf":{"kind":"REWORK","_number":2,"created":"2015-11-30 15:10:14.000000000","uploader":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"ref":"refs/changes/40/251040/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/40/251040/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/40/251040/2"}}},"commit":{"parents":[{"commit":"c4cb6a42ef3f8bc80ee534e514954a4df055583b","subject":"Merge \"Fix typo in \u0027help\u0027 in python-glanceclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c4cb6a42ef3f8bc80ee534e514954a4df055583b"}]}],"author":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-11-28 14:13:59.000000000","tz":660},"committer":{"name":"Jake Yip","email":"jake.yip@unimelb.edu.au","date":"2015-11-30 15:03:25.000000000","tz":660},"subject":"Fix help for image-create","message":"Fix help for image-create\n\nThe help for image-create states that --file \u0027Must be present if images\nare not passed to the client via stdin.\u0027\n\nHowever, doing image-create without --file is a valid operation - it\nqueues a file to be created.\n\nChange-Id: I0cb7c2e5dabaa8ec4b06af4a5024580f1d0df990\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b7aa369911a1720201053a72f13fa3e0e578e0bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b7aa369911a1720201053a72f13fa3e0e578e0bf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}