)]}'
{"glanceclient/shell.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9896331fe8f736fd2bc0b3f9391cbf3a889c3488","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            # are one and two."},{"line_number":639,"context_line":"            try:"},{"line_number":640,"context_line":"                self.get_subcommand_parser(1)"},{"line_number":641,"context_line":"                if command in self.subcommands or command is None:"},{"line_number":642,"context_line":"                    if command is not None:"},{"line_number":643,"context_line":"                        command \u003d \u0027 \u0027 + command"},{"line_number":644,"context_line":"                    print((\"\\nRun `glance --os-image-api-version 1 help%s`\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_eb3fa284","line":641,"updated":"2015-12-09 03:21:44.000000000","message":"Can we check if command is None before we get the subcommand parser for v1?","commit_id":"19a01e34077647d94400660fd8a4f40def8d2117"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9896331fe8f736fd2bc0b3f9391cbf3a889c3488","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            try:"},{"line_number":640,"context_line":"                self.get_subcommand_parser(1)"},{"line_number":641,"context_line":"                if command in self.subcommands or command is None:"},{"line_number":642,"context_line":"                    if command is not None:"},{"line_number":643,"context_line":"                        command \u003d \u0027 \u0027 + command"},{"line_number":644,"context_line":"                    print((\"\\nRun `glance --os-image-api-version 1 help%s`\""},{"line_number":645,"context_line":"                           \" for v1 help\") % (command or \u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_0b430e14","line":642,"updated":"2015-12-09 03:21:44.000000000","message":"We would be checking for nullness for the second time here. If we check it before getting the subcommand, we won\u0027t need this check.","commit_id":"19a01e34077647d94400660fd8a4f40def8d2117"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9896331fe8f736fd2bc0b3f9391cbf3a889c3488","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                        command \u003d \u0027 \u0027 + command"},{"line_number":644,"context_line":"                    print((\"\\nRun `glance --os-image-api-version 1 help%s`\""},{"line_number":645,"context_line":"                           \" for v1 help\") % (command or \u0027\u0027))"},{"line_number":646,"context_line":"            except Exception:"},{"line_number":647,"context_line":"                pass"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_ab4e7a38","line":646,"updated":"2015-12-09 03:21:44.000000000","message":"What do we need to catch here? Can we catch a specific exception?","commit_id":"19a01e34077647d94400660fd8a4f40def8d2117"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"5e2ba6ba9ab38d29cd05aff8aea7b624b2a1237d","unresolved":false,"context_lines":[{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        if not args.os_image_api_version or args.os_image_api_version \u003d\u003d \u00272\u0027:"},{"line_number":637,"context_line":"            # NOTE(NiallBunting) This currently assumes that the only versions"},{"line_number":638,"context_line":"            # are one and two."},{"line_number":639,"context_line":"            try:"},{"line_number":640,"context_line":"                if command is None:"},{"line_number":641,"context_line":"                    print(\"\\nRun `glance --os-image-api-version 1 help`\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_f74c4b78","line":638,"updated":"2015-12-22 17:36:02.000000000","message":"Hopefully it stays that way!","commit_id":"bf67b80dbff7c8fdb7e4dcaa11bd1809f0cf7566"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0bf57aca36282b564e5ae63ee71aa41f29daab4c","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            # are one and two."},{"line_number":639,"context_line":"            try:"},{"line_number":640,"context_line":"                if command is None:"},{"line_number":641,"context_line":"                    print(\"\\nRun `glance --os-image-api-version 1 help`\""},{"line_number":642,"context_line":"                          \" for v1 help\")"},{"line_number":643,"context_line":"                else:"},{"line_number":644,"context_line":"                    self.get_subcommand_parser(1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_247371b3","line":641,"updated":"2015-12-15 02:39:58.000000000","message":"nit: we could put this message in a var and use it in both places","commit_id":"bf67b80dbff7c8fdb7e4dcaa11bd1809f0cf7566"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0bf57aca36282b564e5ae63ee71aa41f29daab4c","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                        command \u003d \u0027 \u0027 + command"},{"line_number":647,"context_line":"                        print((\"\\nRun `glance --os-image-api-version 1 help%s`\""},{"line_number":648,"context_line":"                               \" for v1 help\") % (command or \u0027\u0027))"},{"line_number":649,"context_line":"            except ImportError:"},{"line_number":650,"context_line":"                pass"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_c4686dbd","line":649,"updated":"2015-12-15 02:39:58.000000000","message":"what raises `ImportError`? Sounds... fun.","commit_id":"bf67b80dbff7c8fdb7e4dcaa11bd1809f0cf7566"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a110f6ebb26ddcab3d7a8a604d53595132a2e71b","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                        command \u003d \u0027 \u0027 + command"},{"line_number":647,"context_line":"                        print((\"\\nRun `glance --os-image-api-version 1 help%s`\""},{"line_number":648,"context_line":"                               \" for v1 help\") % (command or \u0027\u0027))"},{"line_number":649,"context_line":"            except ImportError:"},{"line_number":650,"context_line":"                pass"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_42dc56e4","line":649,"in_reply_to":"5a710552_440ea735","updated":"2015-12-15 12:42:44.000000000","message":"Ah-ha, right. Had forgotten about that!","commit_id":"bf67b80dbff7c8fdb7e4dcaa11bd1809f0cf7566"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"77150afe9f39f9dc14fa4f2eaf1b1cd78ac93d09","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                        command \u003d \u0027 \u0027 + command"},{"line_number":647,"context_line":"                        print((\"\\nRun `glance --os-image-api-version 1 help%s`\""},{"line_number":648,"context_line":"                               \" for v1 help\") % (command or \u0027\u0027))"},{"line_number":649,"context_line":"            except ImportError:"},{"line_number":650,"context_line":"                pass"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def do_bash_completion(self, _args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_440ea735","line":649,"in_reply_to":"5a710552_c4686dbd","updated":"2015-12-15 11:27:52.000000000","message":"self.get_subcommand_parser(1) can if it does not find the v1 module.","commit_id":"bf67b80dbff7c8fdb7e4dcaa11bd1809f0cf7566"}]}