)]}'
{"glanceclient/client.py":[{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"b70af945045aa3d4963223dc493955a5501d1377","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        endpoint, url_version \u003d utils.strip_version(endpoint)"},{"line_number":52,"context_line":"        version \u003d version if version is not None else url_version"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if version is None:"},{"line_number":55,"context_line":"            msg \u003d (\"Please provide either the version or an url with the form \""},{"line_number":56,"context_line":"                   \"http://$HOST:$PORT/v$VERSION_NUMBER\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_265c71ec","line":53,"updated":"2015-12-18 12:20:31.000000000","message":"Is this change related to glare refactoring?","commit_id":"a9872c68f2ca427ae9a8ea4ca3b9d7cfa5f9e5af"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"adfc43efbf92355d5b884ccdb87182b138d2b320","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        endpoint, url_version \u003d utils.strip_version(endpoint)"},{"line_number":52,"context_line":"        version \u003d version if version is not None else url_version"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if version is None:"},{"line_number":55,"context_line":"            msg \u003d (\"Please provide either the version or an url with the form \""},{"line_number":56,"context_line":"                   \"http://$HOST:$PORT/v$VERSION_NUMBER\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_c6780dc7","line":53,"in_reply_to":"3a7e1126_265c71ec","updated":"2015-12-18 12:29:51.000000000","message":"Yes, it\u0027s because name of version is 0.\n\"if not version\" return True, but we need False\n\"version or url_version\" always return url_version\nSo I\u0027m doing a comparison with None","commit_id":"a9872c68f2ca427ae9a8ea4ca3b9d7cfa5f9e5af"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"8bb5bc74c263a0b06831159f2fdd00f279671a6a","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        endpoint, url_version \u003d utils.strip_version(endpoint)"},{"line_number":52,"context_line":"        version \u003d version if version is not None else url_version"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if version is None:"},{"line_number":55,"context_line":"            msg \u003d (\"Please provide either the version or an url with the form \""},{"line_number":56,"context_line":"                   \"http://$HOST:$PORT/v$VERSION_NUMBER\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_3c71e1a8","line":53,"in_reply_to":"3a7e1126_c6780dc7","updated":"2015-12-21 13:46:16.000000000","message":"Ah, I see. Thanks!","commit_id":"a9872c68f2ca427ae9a8ea4ca3b9d7cfa5f9e5af"}],"glanceclient/glare/v0/artifacts.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"e453e058ae18810d1a8f7010120252da8018e254","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        :param artifact_id: ID of the artifact to modify."},{"line_number":60,"context_line":"        :param remove_props: List of property names to remove"},{"line_number":61,"context_line":"        :param \\*\\*kwargs: Artifact attribute names and their new values."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        type_name, type_version \u003d self._check_type_params(type_name,"},{"line_number":64,"context_line":"                                                          type_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_f48f1721","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":19},"updated":"2015-12-24 15:58:58.000000000","message":"Need to be deleted","commit_id":"a9872c68f2ca427ae9a8ea4ca3b9d7cfa5f9e5af"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"b392e6eb223021350ac75ce4f787979bccfbfecf","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        :param artifact_id: ID of the artifact to modify."},{"line_number":60,"context_line":"        :param remove_props: List of property names to remove"},{"line_number":61,"context_line":"        :param \\*\\*kwargs: Artifact attribute names and their new values."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        type_name, type_version \u003d self._check_type_params(type_name,"},{"line_number":64,"context_line":"                                                          type_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_f417cfeb","line":61,"range":{"start_line":61,"start_character":15,"end_line":61,"end_character":19},"in_reply_to":"1a7b0d38_f48f1721","updated":"2016-01-11 10:23:54.000000000","message":"Done","commit_id":"a9872c68f2ca427ae9a8ea4ca3b9d7cfa5f9e5af"}],"glanceclient/glare/v0/client.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"e453e058ae18810d1a8f7010120252da8018e254","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class Client(object):"},{"line_number":22,"context_line":"    \"\"\"Client for the OpenStack Glare API."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    :param string endpoint: A user-supplied endpoint URL for the glance"},{"line_number":25,"context_line":"                            service."},{"line_number":26,"context_line":"    :param string token: Token for authentication."},{"line_number":27,"context_line":"    :param integer timeout: Allows customization of the timeout for client"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_f4d39736","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":26},"updated":"2015-12-24 15:58:58.000000000","message":"i guess it should be under __init__ method  because it is method docstring.","commit_id":"a9872c68f2ca427ae9a8ea4ca3b9d7cfa5f9e5af"},{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"b392e6eb223021350ac75ce4f787979bccfbfecf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class Client(object):"},{"line_number":22,"context_line":"    \"\"\"Client for the OpenStack Glare API."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    :param string endpoint: A user-supplied endpoint URL for the glance"},{"line_number":25,"context_line":"                            service."},{"line_number":26,"context_line":"    :param string token: Token for authentication."},{"line_number":27,"context_line":"    :param integer timeout: Allows customization of the timeout for client"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_b4839755","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":26},"in_reply_to":"1a7b0d38_f4d39736","updated":"2016-01-11 10:23:54.000000000","message":"I think that docstring framed correctly, here are examples in v1 and v2\n\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/client.py#L29\n\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/client.py#L24","commit_id":"a9872c68f2ca427ae9a8ea4ca3b9d7cfa5f9e5af"}]}
