)]}'
{"glanceclient/v2/shell.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"236a505a1fc760c8727d91453848db0758d5eea3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                # if token expires during long image upload then we"},{"line_number":90,"context_line":"                # recreate a client and try to get image metainfo again."},{"line_number":91,"context_line":"                osis \u003d shell.OpenStackImagesShell()"},{"line_number":92,"context_line":"                gc \u003d osis._get_versioned_client(gc.version, args)"},{"line_number":93,"context_line":"                image \u003d gc.images.get(args.id)"},{"line_number":94,"context_line":"    finally:"},{"line_number":95,"context_line":"        utils.print_image(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_c6f25f6f","line":92,"updated":"2015-12-16 10:24:33.000000000","message":"If we used a SessionClient (glanceclient/common/http.py) would the re-auth happen automagically?","commit_id":"e236bb6008f45484fbb5faceb0a9173633fb1a00"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"ffefee2d7026e13c999ecb758c64ec6167131a84","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                # if token expires during long image upload then we"},{"line_number":90,"context_line":"                # recreate a client and try to get image metainfo again."},{"line_number":91,"context_line":"                osis \u003d shell.OpenStackImagesShell()"},{"line_number":92,"context_line":"                gc \u003d osis._get_versioned_client(gc.version, args)"},{"line_number":93,"context_line":"                image \u003d gc.images.get(args.id)"},{"line_number":94,"context_line":"    finally:"},{"line_number":95,"context_line":"        utils.print_image(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_97225500","line":92,"in_reply_to":"5a710552_c6f25f6f","updated":"2015-12-24 16:34:05.000000000","message":"So according to implementation, keystone sessions should re-authenticate requests by default. So I tend to agree that we don\u0027t need that for session client.","commit_id":"e236bb6008f45484fbb5faceb0a9173633fb1a00"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"8c1f84eb8a043081661958a6177af648735f7acf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                # if token expires during long image upload then we"},{"line_number":90,"context_line":"                # recreate a client and try to get image metainfo again."},{"line_number":91,"context_line":"                osis \u003d shell.OpenStackImagesShell()"},{"line_number":92,"context_line":"                gc \u003d osis._get_versioned_client(gc.version, args)"},{"line_number":93,"context_line":"                image \u003d gc.images.get(args.id)"},{"line_number":94,"context_line":"    finally:"},{"line_number":95,"context_line":"        utils.print_image(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_87b98c7b","line":92,"in_reply_to":"5a710552_c6f25f6f","updated":"2015-12-28 12:14:30.000000000","message":"Yes, you are right... The cause of this bug is that we pass a token to the client, but not a session. \n\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/shell.py#L431\n\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/shell.py#L447\n\nIf we do it with session, token should be updated \u0027automagically\u0027","commit_id":"e236bb6008f45484fbb5faceb0a9173633fb1a00"}]}