)]}'
{"glanceclient/v2/shell.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"cfd63583d28537efdfcc7e63c630a03850af9ef5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"           help\u003d_(\u0027Local file that contains disk image to be uploaded \u0027"},{"line_number":56,"context_line":"                  \u0027during creation. Alternatively, the image data can be \u0027"},{"line_number":57,"context_line":"                  \u0027passed to the client via stdin.\u0027))"},{"line_number":58,"context_line":"@utils.arg(\u0027--locations\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027,"},{"line_number":59,"context_line":"           help\u003d(\u0027URL where the data for this image already resides. For \u0027"},{"line_number":60,"context_line":"                 \u0027example, if the image data is stored in swift, you could \u0027"},{"line_number":61,"context_line":"                 \u0027specify \\\u0027swift+http://tenant%%3Aaccount:key@auth_url/\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_92239d05","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":23},"updated":"2016-01-12 02:55:38.000000000","message":"The arg is defined as \u0027--locations\u0027 but in unit test, you\u0027re using \u0027--location\u0027, which one is correct?","commit_id":"7d123a408ea19e2c78d0708f7b465729835b1b15"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"99dfeb01642d83bb6f65896b7b6bdc018a4e458c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"           help\u003d_(\u0027Local file that contains disk image to be uploaded \u0027"},{"line_number":56,"context_line":"                  \u0027during creation. Alternatively, the image data can be \u0027"},{"line_number":57,"context_line":"                  \u0027passed to the client via stdin.\u0027))"},{"line_number":58,"context_line":"@utils.arg(\u0027--locations\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027,"},{"line_number":59,"context_line":"           help\u003d(\u0027URL where the data for this image already resides. For \u0027"},{"line_number":60,"context_line":"                 \u0027example, if the image data is stored in swift, you could \u0027"},{"line_number":61,"context_line":"                 \u0027specify \\\u0027swift+http://tenant%%3Aaccount:key@auth_url/\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_c85ba22d","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":23},"in_reply_to":"da6ed579_92239d05","updated":"2016-01-12 03:40:36.000000000","message":"It should be \u0027location\u0027 here. Thanks.","commit_id":"7d123a408ea19e2c78d0708f7b465729835b1b15"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1622cefb40cbe3c666418b541aa489ecb2327a82","unresolved":false,"context_lines":[{"line_number":55,"context_line":"           help\u003d_(\u0027Local file that contains disk image to be uploaded \u0027"},{"line_number":56,"context_line":"                  \u0027during creation. Alternatively, the image data can be \u0027"},{"line_number":57,"context_line":"                  \u0027passed to the client via stdin.\u0027))"},{"line_number":58,"context_line":"@utils.arg(\u0027--locations\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027,"},{"line_number":59,"context_line":"           help\u003d(\u0027URL where the data for this image already resides. For \u0027"},{"line_number":60,"context_line":"                 \u0027example, if the image data is stored in swift, you could \u0027"},{"line_number":61,"context_line":"                 \u0027specify \\\u0027swift+http://tenant%%3Aaccount:key@auth_url/\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_c802c26f","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":23},"in_reply_to":"da6ed579_c85ba22d","updated":"2016-01-12 04:02:02.000000000","message":"Emm, sorry, we should use \u0027locations\u0027 here to suit schema check. :)","commit_id":"7d123a408ea19e2c78d0708f7b465729835b1b15"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"0f0e1ae64b97c4727acc4b38e91ded1bab02f0d1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"           help\u003d_(\u0027Local file that contains disk image to be uploaded \u0027"},{"line_number":56,"context_line":"                  \u0027during creation. Alternatively, the image data can be \u0027"},{"line_number":57,"context_line":"                  \u0027passed to the client via stdin.\u0027))"},{"line_number":58,"context_line":"@utils.arg(\u0027--locations\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027,"},{"line_number":59,"context_line":"           help\u003d(\u0027URL where the data for this image already resides. For \u0027"},{"line_number":60,"context_line":"                 \u0027example, if the image data is stored in swift, you could \u0027"},{"line_number":61,"context_line":"                 \u0027specify \\\u0027swift+http://tenant%%3Aaccount:key@auth_url/\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_17866965","line":58,"range":{"start_line":58,"start_character":14,"end_line":58,"end_character":23},"updated":"2016-01-13 11:01:15.000000000","message":"That confuse users if we are expecting only one location here.","commit_id":"b925cc756dc8966b203be83df3f242b4309a2c63"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"20b60ef29cdf6d4d516631fdbbde4efe5a732c00","unresolved":false,"context_lines":[{"line_number":55,"context_line":"           help\u003d_(\u0027Local file that contains disk image to be uploaded \u0027"},{"line_number":56,"context_line":"                  \u0027during creation. Alternatively, the image data can be \u0027"},{"line_number":57,"context_line":"                  \u0027passed to the client via stdin.\u0027))"},{"line_number":58,"context_line":"@utils.arg(\u0027--locations\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027,"},{"line_number":59,"context_line":"           help\u003d(\u0027URL where the data for this image already resides. For \u0027"},{"line_number":60,"context_line":"                 \u0027example, if the image data is stored in swift, you could \u0027"},{"line_number":61,"context_line":"                 \u0027specify \\\u0027swift+http://tenant%%3Aaccount:key@auth_url/\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_a51939d9","line":58,"range":{"start_line":58,"start_character":14,"end_line":58,"end_character":23},"in_reply_to":"da6ed579_17866965","updated":"2016-01-14 01:02:41.000000000","message":"good suggestion. I\u0027ll update a new one after the spec-lite be approved.","commit_id":"b925cc756dc8966b203be83df3f242b4309a2c63"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"0f0e1ae64b97c4727acc4b38e91ded1bab02f0d1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        key, value \u003d datum.split(\u0027\u003d\u0027, 1)"},{"line_number":79,"context_line":"        fields[key] \u003d value"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    location \u003d fields.pop(\u0027locations\u0027, None)"},{"line_number":82,"context_line":"    file_name \u003d fields.pop(\u0027file\u0027, None)"},{"line_number":83,"context_line":"    if location and file_name:"},{"line_number":84,"context_line":"        utils.exit(\"It\u0027s invalid to provide multiple image sources.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_374ccd6f","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":12},"updated":"2016-01-13 11:01:15.000000000","message":"Are we going to specify one location only? v2 provides a possibility to specify several locations. How about location metadata? Is it skipped intentionally?","commit_id":"b925cc756dc8966b203be83df3f242b4309a2c63"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"20b60ef29cdf6d4d516631fdbbde4efe5a732c00","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        key, value \u003d datum.split(\u0027\u003d\u0027, 1)"},{"line_number":79,"context_line":"        fields[key] \u003d value"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    location \u003d fields.pop(\u0027locations\u0027, None)"},{"line_number":82,"context_line":"    file_name \u003d fields.pop(\u0027file\u0027, None)"},{"line_number":83,"context_line":"    if location and file_name:"},{"line_number":84,"context_line":"        utils.exit(\"It\u0027s invalid to provide multiple image sources.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_851435a0","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":12},"in_reply_to":"da6ed579_374ccd6f","updated":"2016-01-14 01:02:41.000000000","message":"ditto","commit_id":"b925cc756dc8966b203be83df3f242b4309a2c63"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"0f0e1ae64b97c4727acc4b38e91ded1bab02f0d1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            args.metadata \u003d \u0027{}\u0027"},{"line_number":99,"context_line":"            do_location_add(gc, args)"},{"line_number":100,"context_line":"    finally:"},{"line_number":101,"context_line":"        if not location:"},{"line_number":102,"context_line":"            utils.print_image(image)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_3c59125b","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":24},"updated":"2016-01-13 11:01:15.000000000","message":"Why can\u0027t we print image at the end if location is specified?","commit_id":"b925cc756dc8966b203be83df3f242b4309a2c63"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"20b60ef29cdf6d4d516631fdbbde4efe5a732c00","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            args.metadata \u003d \u0027{}\u0027"},{"line_number":99,"context_line":"            do_location_add(gc, args)"},{"line_number":100,"context_line":"    finally:"},{"line_number":101,"context_line":"        if not location:"},{"line_number":102,"context_line":"            utils.print_image(image)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_45339d62","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":24},"in_reply_to":"da6ed579_3c59125b","updated":"2016-01-14 01:02:41.000000000","message":"because\ndef \u0027do_location_add return\u0027 has printed the image.","commit_id":"b925cc756dc8966b203be83df3f242b4309a2c63"}]}