)]}'
{"id":"openstack%2Fpython-glanceclient~264256","triplet_id":"openstack%2Fpython-glanceclient~master~I7135d3b7fe15b16c17b7581e553ce5d289b58f43","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"I7135d3b7fe15b16c17b7581e553ce5d289b58f43","subject":"Change assertTrue(isinstance()) by optimal assert","status":"MERGED","created":"2016-01-06 16:24:02.000000000","updated":"2016-01-07 00:50:26.000000000","submitted":"2016-01-07 00:50:26.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"77fef22f607249df9904f1966219709164300e54","_number":264256,"virtual_id_number":264256,"owner":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2016-01-07 00:50:26.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":2,"date":"2016-01-06 17:20:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-06 23:51:50.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-06 23:51:50.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-06 17:20:06.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2016-01-06 23:51:50.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2016-01-07 00:50:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d1f66aae43ff224049752dbb53fc64d01a7cd0f0","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-06 16:24:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"79d77fbb99e4aa35ed5bc3309cb096fab0e01118","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-01-06 17:04:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nHi Liu,\n\nI have nothing against the change itself (we should perhaps take this on our hacking tests to avoid these). But the bug reference should be corrected.","accounts_in_message":[],"_revision_number":1},{"id":"646a095d94aca5854bbd692310dc25a09c5814c1","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-06 17:07:45.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"ed5b17088f676f0a5043da18add21cebf09c2694","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-01-06 17:20:06.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks, LGTM","accounts_in_message":[],"_revision_number":2},{"id":"1e6e12bdc15e42e19390dd10ba02badd3a416788","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 20:49:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/56/264256/2/check/gate-python-glanceclient-pep8/b0085df/ : SUCCESS in 2m 08s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/56/264256/2/check/gate-python-glanceclient-docs/717f95b//doc/build/html/ : SUCCESS in 1m 35s\n- gate-python-glanceclient-python27 http://logs.openstack.org/56/264256/2/check/gate-python-glanceclient-python27/d822b0f/ : SUCCESS in 2m 50s\n- gate-python-glanceclient-python34 http://logs.openstack.org/56/264256/2/check/gate-python-glanceclient-python34/2d763af/ : SUCCESS in 3m 16s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/56/264256/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/4efb916/ : SUCCESS in 1h 13m 22s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/56/264256/2/check/gate-glanceclient-dsvm-functional/b8e063d/ : SUCCESS in 26m 37s","accounts_in_message":[],"_revision_number":2},{"id":"5b8003332a65913930f6e78f9e563d5c542aff5a","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2016-01-06 23:51:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ff56852445824e1c7b95c30be78ac180f381fe55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 23:51:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"788d59069921aaae0664e345e610cf34ff7c6c1c","date":"2016-01-07 00:50:26.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"5e3ee9f304cd131f4d5bd3998eb975a4b740c12c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 00:50:26.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/56/264256/2/gate/gate-python-glanceclient-docs/8252280//doc/build/html/ : SUCCESS in 52s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/56/264256/2/gate/gate-python-glanceclient-pep8/f5f23d9/ : SUCCESS in 58s\n- gate-python-glanceclient-python27 http://logs.openstack.org/56/264256/2/gate/gate-python-glanceclient-python27/406fa4c/ : SUCCESS in 1m 19s\n- gate-python-glanceclient-python34 http://logs.openstack.org/56/264256/2/gate/gate-python-glanceclient-python34/c1d2c1a/ : SUCCESS in 1m 23s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/56/264256/2/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/470b177/ : SUCCESS in 58m 28s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/56/264256/2/gate/gate-glanceclient-dsvm-functional/d413752/ : SUCCESS in 20m 01s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c7fc0d6b1d7d2691d28a7d5f6b8dc5dab7204368","revisions":{"80108dcd1aa10c3a6012680dcaabb49d2625309c":{"kind":"REWORK","_number":1,"created":"2016-01-06 16:24:02.000000000","uploader":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"ref":"refs/changes/56/264256/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/56/264256/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/1"}}},"commit":{"parents":[{"commit":"29734896220bf0b209618e3d711c97beaf05aadf","subject":"Merge \"remove python 2.6 trove classifier\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/29734896220bf0b209618e3d711c97beaf05aadf"}]}],"author":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-06 16:23:05.000000000","tz":480},"committer":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-06 16:23:05.000000000","tz":480},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nassertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests\nshould be replaced by assertIsInstance(A, B) provided by testtools.\n\nThere have one more place should be modified.\n\nChange-Id: I7135d3b7fe15b16c17b7581e553ce5d289b58f43\nCloses-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/80108dcd1aa10c3a6012680dcaabb49d2625309c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/80108dcd1aa10c3a6012680dcaabb49d2625309c"}]},"branch":"refs/heads/master"},"c7fc0d6b1d7d2691d28a7d5f6b8dc5dab7204368":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-01-06 17:07:45.000000000","uploader":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"ref":"refs/changes/56/264256/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/56/264256/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/56/264256/2"}}},"commit":{"parents":[{"commit":"29734896220bf0b209618e3d711c97beaf05aadf","subject":"Merge \"remove python 2.6 trove classifier\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/29734896220bf0b209618e3d711c97beaf05aadf"}]}],"author":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-06 16:23:05.000000000","tz":480},"committer":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-06 17:07:41.000000000","tz":0},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nassertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests\nshould be replaced by assertIsInstance(A, B) provided by testtools.\n\n\nChange-Id: I7135d3b7fe15b16c17b7581e553ce5d289b58f43\nRelated-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c7fc0d6b1d7d2691d28a7d5f6b8dc5dab7204368"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c7fc0d6b1d7d2691d28a7d5f6b8dc5dab7204368"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}