)]}'
{"id":"openstack%2Fpython-glanceclient~265118","triplet_id":"openstack%2Fpython-glanceclient~master~Ia11286978d81c85882b7a82f28eb5ab1fa860964","project":"openstack/python-glanceclient","branch":"master","topic":"use_oslo_reflection","hashtags":[],"change_id":"Ia11286978d81c85882b7a82f28eb5ab1fa860964","subject":"Use the oslo.utils.reflection to extract the class name","status":"ABANDONED","created":"2016-01-08 07:41:25.000000000","updated":"2016-01-25 15:41:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7e9ceb3081a20080fec86c26ed54dccdd2f0ae12","_number":265118,"virtual_id_number":265118,"owner":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-01-08 08:56:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-01-11 13:28:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-08 08:56:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-01-11 13:28:48.000000000","updated_by":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"reviewer":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"state":"REVIEWER"}],"messages":[{"id":"b7bdf8efea1a2a96c37d78f057bb710717dace41","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-08 07:41:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6dcb20db46d76ad89c3463319b013e888ca0be0d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 08:56:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/18/265118/1/check/gate-python-glanceclient-pep8/075627c/ : SUCCESS in 57s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/18/265118/1/check/gate-python-glanceclient-docs/5df239e//doc/build/html/ : SUCCESS in 1m 31s\n- gate-python-glanceclient-python27 http://logs.openstack.org/18/265118/1/check/gate-python-glanceclient-python27/1a78965/ : SUCCESS in 1m 47s\n- gate-python-glanceclient-python34 http://logs.openstack.org/18/265118/1/check/gate-python-glanceclient-python34/56fdaf8/ : SUCCESS in 1m 33s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/18/265118/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/3ac4f07/ : SUCCESS in 1h 06m 44s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/18/265118/1/check/gate-glanceclient-dsvm-functional/cdf1757/ : SUCCESS in 28m 54s","accounts_in_message":[],"_revision_number":1},{"id":"9663907fe9733887878304b36a3e2fb33ba1c19c","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-01-11 13:28:48.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks for patch.\nI am still wondering why do we need to use reflection here.\nself is always an instance of non-built-in object, so we can get class name in any case.\nI looked into implementation: https://github.com/openstack/oslo.utils/blob/master/oslo_utils/reflection.py#L67.\nIt seems that this method is useful when we don\u0027t know what is obj: function, object, class or built-in class. Could you please explain why do we need more complex solution here?","accounts_in_message":[],"_revision_number":1},{"id":"972f49d6cea14be749e904509b0a0487c7b2bced","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-01-25 15:41:33.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2969e73ee82b3ecd25dfe90724d4e79f5bc3211b","revisions":{"2969e73ee82b3ecd25dfe90724d4e79f5bc3211b":{"kind":"REWORK","_number":1,"created":"2016-01-08 07:41:25.000000000","uploader":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"ref":"refs/changes/18/265118/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/18/265118/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/18/265118/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/18/265118/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/18/265118/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/18/265118/1"}}},"commit":{"parents":[{"commit":"29734896220bf0b209618e3d711c97beaf05aadf","subject":"Merge \"remove python 2.6 trove classifier\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/29734896220bf0b209618e3d711c97beaf05aadf"}]}],"author":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-08 07:41:06.000000000","tz":480},"committer":{"name":"LiuNanke","email":"nanke.liu@easystack.cn","date":"2016-01-08 07:41:06.000000000","tz":480},"subject":"Use the oslo.utils.reflection to extract the class name","message":"Use the oslo.utils.reflection to extract the class name\n\nThe oslo.utils reflection module/code handles more variations\n of where a class name may come from (on python 2 and python 3)\nso its usage allows getting more accurate class names so we might\nas well use it.\n\nChange-Id: Ia11286978d81c85882b7a82f28eb5ab1fa860964\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2969e73ee82b3ecd25dfe90724d4e79f5bc3211b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2969e73ee82b3ecd25dfe90724d4e79f5bc3211b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
