)]}'
{"id":"openstack%2Fpython-glanceclient~26740","triplet_id":"openstack%2Fpython-glanceclient~master~I57fd85f7bb655bef69222d4fdf6b8274088ca827","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1167899","hashtags":[],"change_id":"I57fd85f7bb655bef69222d4fdf6b8274088ca827","subject":"Fix \"glance add\" parsing of \"copy_from\" option.","status":"MERGED","created":"2013-04-11 12:48:24.000000000","updated":"2013-04-22 00:05:29.000000000","submitted":"2013-04-22 00:05:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cc5a7c0d86b760b12ab1af8029c7267f42f5dbb7","_number":26740,"virtual_id_number":26740,"owner":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-04-22 00:05:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"recommended":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-04-12 21:03:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":2,"date":"2013-04-15 08:24:38.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":2,"date":"2013-04-21 23:21:19.000000000","_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"date":"2013-04-15 08:24:38.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":1,"date":"2013-04-21 23:21:19.000000000","_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-12 21:03:07.000000000","updated_by":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"reviewer":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"state":"REVIEWER"},{"updated":"2013-04-15 08:24:38.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2013-04-21 23:21:19.000000000","updated_by":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"reviewer":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"state":"REVIEWER"},{"updated":"2013-04-22 00:05:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fc5a2930c868ae5ec4cf2fc9cefcccb97bfbe60d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-11 13:29:17.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/26740/1/check/gate-python-glanceclient-pep8/674 : SUCCESS\n- http://docs-draft.openstack.org/26740/1/check/gate-python-glanceclient-docs/606/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/26740/1/check/gate-python-glanceclient-python26/669 : SUCCESS\n- http://logs.openstack.org/26740/1/check/gate-python-glanceclient-python26-rhel6/27 : SUCCESS (non-voting)\n- http://logs.openstack.org/26740/1/check/gate-python-glanceclient-python27/667 : SUCCESS\n- http://logs.openstack.org/26740/1/check/gate-tempest-devstack-vm-full/12343 : SUCCESS\n- http://logs.openstack.org/26740/1/check/gate-tempest-devstack-vm-postgres-full/12058 : SUCCESS\n- http://logs.openstack.org/26740/1/check/gate-tempest-devstack-vm-quantum/18167 : SUCCESS\n- http://logs.openstack.org/26740/1/check/gate-grenade-devstack-vm/307 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"9b9e024835f1e0a43b0d8ac23825edfe6b189f2c","author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"date":"2013-04-12 19:48:09.000000000","message":"Patch Set 1:\n\nI did some testing here and a small side effect occurs with this patch.  If location and copy_from are both used, copy_from is not removed from the fields and this it ends up as a property on the image, ex: \n\n$ glance show \u003cID\u003e\n.....\nProperty \u0027copy_from\u0027: http://berrange.fedorapeople.org/images/2012-02-29/f16-x86_64-openstack-sda.qcow2\n\nwithout this patch this does not occur.  This should probably be a separate bug.  \n\nHowever I would like to see some test added with this bug fix if possible.","accounts_in_message":[],"_revision_number":1},{"id":"a8b2799b0596981ae1bb790af433a4a523fccbc5","author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"date":"2013-04-12 21:03:07.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nI added a test for it here:\n\nhttps://review.openstack.org/#/c/26889/","accounts_in_message":[],"_revision_number":1},{"id":"9da119336db2e981eb15e78bd7b1581a332b1410","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-04-15 08:24:38.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"945a9063ae2f2d80baa15a3968565266148973c5","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-04-21 23:21:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nlgtm\n\nhave u filed the bug mentioned john?","accounts_in_message":[],"_revision_number":1},{"id":"215b67974c99ada3fce19d3d1b8c21e914ec8433","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-21 23:21:21.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2e0d1200696cc852e147cd0a3be8cc0d343e981b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-22 00:05:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"a166a9df501ae5b1a1e4b1f7f8e06f54bbbbfc69","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-22 00:05:29.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/26740/1/gate/gate-python-glanceclient-docs/622/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/26740/1/gate/gate-python-glanceclient-pep8/690 : SUCCESS\n- http://logs.openstack.org/26740/1/gate/gate-python-glanceclient-python26/685 : SUCCESS\n- http://logs.openstack.org/26740/1/gate/gate-python-glanceclient-python27/683 : SUCCESS\n- http://logs.openstack.org/26740/1/gate/gate-tempest-devstack-vm-full/13106 : SUCCESS\n- http://logs.openstack.org/26740/1/gate/gate-tempest-devstack-vm-postgres-full/12821 : SUCCESS\n- http://logs.openstack.org/26740/1/gate/gate-tempest-devstack-vm-quantum/19004 : SUCCESS\n- http://logs.openstack.org/26740/1/gate/gate-grenade-devstack-vm/1003 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c98432a6d4d13f44eb00720a67153715d81a5d78","revisions":{"c98432a6d4d13f44eb00720a67153715d81a5d78":{"kind":"REWORK","_number":1,"created":"2013-04-11 12:48:24.000000000","uploader":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"ref":"refs/changes/40/26740/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/40/26740/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/26740/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/26740/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/40/26740/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/40/26740/1"}}},"commit":{"parents":[{"commit":"0995045f2a6c6179b9d3daf7e8c994e30e4e2d8c","subject":"Improve unit tests for python-glanceclient.glanceclient.common.http","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0995045f2a6c6179b9d3daf7e8c994e30e4e2d8c"}]}],"author":{"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","date":"2013-04-11 12:38:35.000000000","tz":120},"committer":{"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","date":"2013-04-11 12:43:19.000000000","tz":120},"subject":"Fix \"glance add\" parsing of \"copy_from\" option.","message":"Fix \"glance add\" parsing of \"copy_from\" option.\n\ncopy_from was ignored which resulted in \"glance add\" attempting to read from\nstdout.\n\nFixes bug 1167899\n\nChange-Id: I57fd85f7bb655bef69222d4fdf6b8274088ca827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c98432a6d4d13f44eb00720a67153715d81a5d78"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c98432a6d4d13f44eb00720a67153715d81a5d78"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}