)]}'
{"id":"openstack%2Fpython-glanceclient~268013","triplet_id":"openstack%2Fpython-glanceclient~master~I55829d106c9d25374df6538b3071104ee5f215f2","project":"openstack/python-glanceclient","branch":"master","topic":"fix_image_create_help","hashtags":[],"change_id":"I55829d106c9d25374df6538b3071104ee5f215f2","subject":"Enhance description of instance-uuid option for image-create","status":"MERGED","created":"2016-01-15 08:53:45.000000000","updated":"2016-01-18 12:55:21.000000000","submitted":"2016-01-18 12:55:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fb4ae92782fd7695897212bad3741647125b49b2","_number":268013,"virtual_id_number":268013,"owner":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-01-18 12:55:21.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":2,"date":"2016-01-18 11:16:27.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":2,"date":"2016-01-18 11:21:32.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":1,"date":"2016-01-18 11:21:32.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-15 09:34:20.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2016-01-18 11:16:27.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2016-01-18 11:21:32.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2016-01-18 12:55:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9fb44240add91069f99fa7e48efad2c5beec4ad2","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-01-15 08:53:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf9e8b5a708cd1d6a2c49ddceb4ac3290914ccfa","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2016-01-15 09:34:20.000000000","message":"Patch Set 1:\n\nKairat, first of all, I agree with you. It\u0027s better to enhance the description rather than remove it. Romove an api parameter directly\nseems bad. Or set it to \u0027deprecated\u0027?\n\nAnd not only instance-uuid but also other properties should be fixed. \nSuch as architecture, os-distro and so on.\n\nLet\u0027s wait what will core reviewers say.","accounts_in_message":[],"_revision_number":1},{"id":"9c4bb6a12a6091dbaf7bdd8a2598d8f17a74c3f5","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-01-15 09:43:01.000000000","message":"Patch Set 1:\n\nThanks for review.\nI am not sure we need the fix for other field because IMO it is clear that they are just metadata field so let\u0027s wait for the others contributors)","accounts_in_message":[],"_revision_number":1},{"id":"008d3237c0bc2b60da664a2b361a5191f5e3ae38","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-15 10:42:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/13/268013/1/check/gate-python-glanceclient-pep8/8fae55f/ : SUCCESS in 1m 04s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/13/268013/1/check/gate-python-glanceclient-docs/86ddbfe//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-glanceclient-python27 http://logs.openstack.org/13/268013/1/check/gate-python-glanceclient-python27/c4f3f40/ : SUCCESS in 1m 15s\n- gate-python-glanceclient-python34 http://logs.openstack.org/13/268013/1/check/gate-python-glanceclient-python34/501354d/ : SUCCESS in 1m 37s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/13/268013/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/2fd1db2/ : SUCCESS in 1h 34m 55s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/13/268013/1/check/gate-glanceclient-dsvm-functional/d3d959f/ : SUCCESS in 22m 23s","accounts_in_message":[],"_revision_number":1},{"id":"4a364acc2b49f13631aef2d6473a6e1f2365d93d","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2016-01-15 10:55:53.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nYes, I see how someone who is familiar with \u0027nova image-create\u0027 could expect this to snapshot the instance.\n\nTweaked working a bit -- is that ok?","accounts_in_message":[],"_revision_number":1},{"id":"850a0ed5f055307358f3549f30c65908738feff1","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-01-18 09:41:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7d363317294c6731bba870a175b8e29875060dbb","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-01-18 09:41:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"79151c5e14d62e9b5b8c616e2ae1892ee6c34bca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-18 11:06:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/13/268013/2/check/gate-python-glanceclient-pep8/1c1ecbb/ : SUCCESS in 54s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/13/268013/2/check/gate-python-glanceclient-docs/609f8dc//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-glanceclient-python27 http://logs.openstack.org/13/268013/2/check/gate-python-glanceclient-python27/bc5373a/ : SUCCESS in 1m 15s\n- gate-python-glanceclient-python34 http://logs.openstack.org/13/268013/2/check/gate-python-glanceclient-python34/ae4a6ed/ : SUCCESS in 1m 21s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/13/268013/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/944c7fa/ : SUCCESS in 1h 18m 53s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/13/268013/2/check/gate-glanceclient-dsvm-functional/b1ba2f7/ : SUCCESS in 27m 29s","accounts_in_message":[],"_revision_number":2},{"id":"9b146a531c11010342b8c3884cb2e9990b6538d4","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2016-01-18 11:16:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"56a8c0e7188ded2ba441a4271fb172e85ec44f47","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2016-01-18 11:19:30.000000000","message":"Patch Set 2:\n\nDo we need to make the same change in the server code?\n\n\n ./etc/schema-image.json:    \"instance_uuid\": {\n ./etc/schema-image.json-        \"type\": \"string\",\n ./etc/schema-image.json-        \"description\": \"ID of instance used to create this image.\"\n ./etc/schema-image.json-    },","accounts_in_message":[],"_revision_number":2},{"id":"149de5932fe807bfc7cbb3711b844856549b71ea","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2016-01-18 11:21:32.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6b1e0e77d7402b9d4188c4ea16b4d19565438799","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-01-18 11:21:35.000000000","message":"Patch Set 2:\n\nYes, we do. Thanks for raising this question.\nI will update the bug and upload the patch.","accounts_in_message":[],"_revision_number":2},{"id":"9a6c699f0624944db43b95fb152a3d4a8901a6e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-18 11:21:37.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"6cb7cbc528ff16d6f8a720b4316a51b087adbb12","date":"2016-01-18 12:55:21.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"beecc8974264dca4f3b337e4016195a0c565a5e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-18 12:55:21.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/13/268013/2/gate/gate-python-glanceclient-docs/9502c5b//doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/13/268013/2/gate/gate-python-glanceclient-pep8/3c9ea43/ : SUCCESS in 1m 12s\n- gate-python-glanceclient-python27 http://logs.openstack.org/13/268013/2/gate/gate-python-glanceclient-python27/64703b2/ : SUCCESS in 1m 13s\n- gate-python-glanceclient-python34 http://logs.openstack.org/13/268013/2/gate/gate-python-glanceclient-python34/28b8658/ : SUCCESS in 1m 38s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/13/268013/2/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/a7f5598/ : SUCCESS in 1h 33m 38s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/13/268013/2/gate/gate-glanceclient-dsvm-functional/d02c7e1/ : SUCCESS in 30m 01s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a8d7ded8fb4f5cf1e84c185d13c6fac1b607696c","revisions":{"e2fede9910c57e45bcef79f4e5437c6e5ca7a5dd":{"kind":"REWORK","_number":1,"created":"2016-01-15 08:53:45.000000000","uploader":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"ref":"refs/changes/13/268013/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/13/268013/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/1"}}},"commit":{"parents":[{"commit":"0b7a6d2379981c1c0e08797ab44aa7272590d340","subject":"Merge \"Remove location check from V2 client\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0b7a6d2379981c1c0e08797ab44aa7272590d340"}]}],"author":{"name":"kairat_kushaev","email":"kkushaev@mirantis.com","date":"2016-01-15 08:50:43.000000000","tz":180},"committer":{"name":"kairat_kushaev","email":"kkushaev@mirantis.com","date":"2016-01-15 08:50:43.000000000","tz":180},"subject":"Enhance description of instance-uuid option for image-create","message":"Enhance description of instance-uuid option for image-create\n\nCurrent description of instance-uuid may confuse users because\nthey may think that instance-uuid can serve as basis for image\nbut it just stores instance-uuid as image-metadata.\nSo we need to enhance the description in glanceclient.\n\nChange-Id: I55829d106c9d25374df6538b3071104ee5f215f2\nCloses-Bug: #1496822\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e2fede9910c57e45bcef79f4e5437c6e5ca7a5dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e2fede9910c57e45bcef79f4e5437c6e5ca7a5dd"}]},"branch":"refs/heads/master"},"a8d7ded8fb4f5cf1e84c185d13c6fac1b607696c":{"kind":"REWORK","_number":2,"created":"2016-01-18 09:41:30.000000000","uploader":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"ref":"refs/changes/13/268013/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/13/268013/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/13/268013/2"}}},"commit":{"parents":[{"commit":"0b7a6d2379981c1c0e08797ab44aa7272590d340","subject":"Merge \"Remove location check from V2 client\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0b7a6d2379981c1c0e08797ab44aa7272590d340"}]}],"author":{"name":"kairat_kushaev","email":"kkushaev@mirantis.com","date":"2016-01-15 08:50:43.000000000","tz":180},"committer":{"name":"kairat_kushaev","email":"kkushaev@mirantis.com","date":"2016-01-18 09:41:17.000000000","tz":180},"subject":"Enhance description of instance-uuid option for image-create","message":"Enhance description of instance-uuid option for image-create\n\nCurrent description of instance-uuid may confuse users because\nthey may think that instance-uuid can serve as basis for image\nbut it just stores instance-uuid as image-metadata.\nSo we need to enhance the description in glanceclient.\n\nChange-Id: I55829d106c9d25374df6538b3071104ee5f215f2\nCloses-Bug: #1496822\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a8d7ded8fb4f5cf1e84c185d13c6fac1b607696c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a8d7ded8fb4f5cf1e84c185d13c6fac1b607696c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}